Commits · 77b7687e4837223f820e1e98c369d36696f3f2b3 · Linshizhi / Chromium_Depot_tools

06 Oct, 2017 2 commits

gclient conditionals are supposed to allow '!=', but don't currently. · 77b7687e

Dirk Pranke authored Oct 06, 2017

R=smut@chromium.org
TBR=phajdan.jr@chromium.org
BUG=570091

Change-Id: I9e0cce71105e9b819019d64c8857c2e86796a16f
Reviewed-on: https://chromium-review.googlesource.com/704224
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: smut <smut@google.com>

77b7687e

Roll recipe dependencies (trivial). · a5b7d73e

recipe-roller authored Oct 06, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce Update source_manifest to e8149bf in luci-go (hinoka@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibb352c4c937bd213567fa93820f13379e3f28790
Reviewed-on: https://chromium-review.googlesource.com/704134Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

a5b7d73e

05 Oct, 2017 1 commit

Use HTTPS links in CheckAuthorizedAuthor · b5807979

Xiaoyin Liu authored Oct 05, 2017

For security and privacy, change http://www.chromium.org/developers/contributing-code
link to use HTTPS.

R=dpranke@chromium.org

Bug:
Change-Id: I12d0658631d7704de1b3072f6eb840814cc6bed0
Reviewed-on: https://chromium-review.googlesource.com/702034Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

b5807979

04 Oct, 2017 6 commits

[vpython] Roll CIPD version. · a58f1dac

Dan Jacques authored Oct 04, 2017

Roll CIPD version to:
bbb30ff0932ace4c6bed7ca1ba14e8a1ccc819cb

TBR=iannucci@chromium.org
BUG=chromium:771277
TEST=canary

Change-Id: I4fb064dcad7072a6a4f728f6c6384a8a65ad56a3
Reviewed-on: https://chromium-review.googlesource.com/701434Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

a58f1dac

gclient config: add support for custom vars · 3ba2a7cf

Paweł Hajdan, Jr authored Oct 04, 2017

Bug: 570091
Change-Id: I44da3366fe4aa91240f4b3076f53e27aa4a81806
Reviewed-on: https://chromium-review.googlesource.com/700498Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

3ba2a7cf

gclient: make predefined variables native · d325eb34

Paweł Hajdan, Jr authored Oct 03, 2017

See https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/687496

Bug: 570091
Change-Id: Ifb2c8473e1b1e8ae0c73365bc806a995ddbd7b74
Reviewed-on: https://chromium-review.googlesource.com/698066Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

d325eb34

Allow gclient solution URLs to be |None|. · c634ba57

Michael Moss authored Oct 03, 2017

This is supported by gclient and has the effect of treating the solution
as a purely local, standalone DEPS (i.e. not as a source repo to
checkout or process in any way). It also prevents the solution from
being added to the output of 'gclient flatten'.

R=agable@chromium.org, phajdan.jr@chromium.org

Change-Id: Ie11246ec7a74097b96ea6a26983a63b3fb3123a5
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/698271
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

c634ba57

Roll recipe dependencies (trivial). · df963185

recipe-roller authored Oct 04, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4d872b88fb06006ec917c6d2a3324e26c0124319 Add 'service_account' recipe module. (vadimsh@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id3e9d6203bb5baf4ea26d9cdb1c42ccd356c223d
Reviewed-on: https://chromium-review.googlesource.com/699814Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

df963185

Simplify git-cl-diff for Gerrit · a718c3eb

Aaron Gable authored Aug 29, 2017

Previously, git-cl-diff went through a dance where it would create
a new branch, download the uploaded patch onto that branch, and
then diff against that. This had all sorts of problems: if you
aborted the command, it might leave you on that branch; if you have
local changes, they might get clobbered or the command would refuse
to run.

Now that we're in a Gerrit-only world, and patchsets are by definition
equivalent to commits, we can simply diff against whatever local commit
was last uploaded or, in a pinch, fetch the uploaded commit and diff
against that.

Bug: 759893
Change-Id: Ia4b93dcfb9b8aba85817e62731f68d6450026e75
Reviewed-on: https://chromium-review.googlesource.com/639915Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

a718c3eb

03 Oct, 2017 1 commit

gclient flatten: properly quote conditionals · 78ce24e3

Paweł Hajdan, Jr authored Oct 03, 2017

Bug: 661382
Change-Id: Id50b2541132002452bc5d86bb013758e8be0f4b0
Reviewed-on: https://chromium-review.googlesource.com/697813Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

78ce24e3

02 Oct, 2017 3 commits

gclient: add support for native boolean variables · e0214743

Paweł Hajdan, Jr authored Sep 28, 2017

Bug: 570091
Change-Id: I195f5f798d9869f385437db4e0bc5f4c5d4853ae
Reviewed-on: https://chromium-review.googlesource.com/687496
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

e0214743

gclient flatten: emit conditions for hooks · ecf53fec

Paweł Hajdan, Jr authored Sep 29, 2017

Bug: 661382
Change-Id: I0e74273a5e00b4f3cf1d5c22ce0944dc2fa6f31e
Reviewed-on: https://chromium-review.googlesource.com/692934Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

ecf53fec

Update fetch config with new Syzygy location. · 355b7041

Sigurdur Asgeirsson authored Sep 29, 2017

Change-Id: Iacc2efd6974f1a161da6e33a0d25d6329fcaaf4f
Reviewed-on: https://chromium-review.googlesource.com/692697
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>

355b7041

30 Sep, 2017 2 commits

Remove rietveld commit queue command line client · e632e544

Aaron Gable authored Sep 29, 2017

This code appears unused, and if it is used, it isn't useful anymore.

R=tandrii@chromium.org

Bug: 770408
Change-Id: I8b96a119be8ed20132e0b7439e466ad90f3757c2
Reviewed-on: https://chromium-review.googlesource.com/693337Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

e632e544

Remove rietveld git cherry-pick-upload command · 7659f4ff

Aaron Gable authored Sep 29, 2017

The command only supports rietveld; we use git drover for Gerrit.

R=tandrii@chromium.org

Bug: 770408
Change-Id: I63a32e6e355ab361a77fb1328c21934613602a27
Reviewed-on: https://chromium-review.googlesource.com/693339Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

7659f4ff

29 Sep, 2017 5 commits

roll-dep: Add comments indicating that --no-log needs to keep working · 3be96a83

Eric Boren authored Sep 29, 2017

Bug:
Change-Id: Id5efd1e84318b95297c6d83f77e58f617d7db8de
Reviewed-on: https://chromium-review.googlesource.com/690242
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

3be96a83

Expose new gclient.sync() arg in gclient.checkout(). · 210ed0eb

Michael Moss authored Sep 29, 2017

R=phajdan.jr@chromium.org

Change-Id: I7313b8a26a5f2934e26491fc4b9403ba6cea0cee
Reviewed-on: https://chromium-review.googlesource.com/691017Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

210ed0eb

Fix autoninja to allow compiling one source file · f3b4f060

Bruce Dawson authored Sep 08, 2017

This is the second attempt at fixing autoninja to allow passing '^^' to
it to specify that ninja should build the outputs of the specified file
instead of building that file itself. The problem is that '^' is a
special character and when extra layers of indirection are added the
number of '^' characters needed grows exponentially in some poorly
understood way. The first fix attempt just quoted the arguments that
autoninja.bat passed to autoninja.py, but that meant they came in as
one argument. This fix expands on that by modifying autoninja.py to
understand how to deal with the monolithic argument. With this change
this once again works:

    autoninja -C out\debug_component ..\..\base\win\enum_variant.cc^^

It can be convenient to have a ninja.bat file which starts goma and lets
users keep typing the same build commands. However even with this fix
the previously recommended ninja.bat file must be invoked with four
'^' characters. If that is too much then the new recommended ninja.bat
is to copy autoninja.bat and modify as needed, perhaps like this:

    @echo off
    call python c:\goma\goma-win64\goma_ctl.py ensure_start >nul
    FOR /f "usebackq tokens=*" %%a in (`python c:\src\depot_tools\autoninja.py "%*"`) do echo %%a & %%a

BUG: 758725
Change-Id: Ieee9cf343ee5f22e9988a1969cb7a7a90687666b
Reviewed-on: https://chromium-review.googlesource.com/656478Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

f3b4f060

Remove defunct Rietveld end-to-end tests · 0a1f3f6a

Aaron Gable authored Sep 29, 2017

R=tandrii@chromium.org

Bug: 770019
Change-Id: I55d74d67281bd3f79cfd5ba9f57eea082359573e
Reviewed-on: https://chromium-review.googlesource.com/693034
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

0a1f3f6a

[depot_tools] Add "ensure_bootstrap" script. · 35c5b9ad

Dan Jacques authored Sep 29, 2017

Add a "ensure_bootstrap" script, which syncs the bootstrapped state of
"depot_tools" so that remaining operations become read-only.

BUG=chromium:769369
TEST=local

Change-Id: I2dab36112b378a926d8201d2ab31a7daa9f5da29
Reviewed-on: https://chromium-review.googlesource.com/691318
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

35c5b9ad

28 Sep, 2017 3 commits

bot_update: use patch repo instead of project if it is mapped · a16ccaf1

Aaron Gable authored Sep 28, 2017

This is a step away from patch_project, which was a holdover
from Rietveld. Instead of mapping "projects" (which are
poorly-defined and not guaranteed to be unique) to subpaths,
instead map repository urls (which are at least unique).

Eventually we may be able to compute this directly from DEPS
instead of hardcoding the mapping here, but at least this is
a step in the right direction.

Bug: 765633
Change-Id: Idd65984fc6edefcbedb0438d38c2338b10b7e8e5
Reviewed-on: https://chromium-review.googlesource.com/690776
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

a16ccaf1

Add ability to pass extra flags to gclient.sync(). · 2da7cbd7

Michael Moss authored Sep 27, 2017

R=agable@chromium.org, phajdan.jr@chromium.org

Change-Id: Id883945d61aabf90e11368fbf603196e62ff0f52
Reviewed-on: https://chromium-review.googlesource.com/688675Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

2da7cbd7

Roll "vpython". · 41450825

Dan Jacques authored Sep 28, 2017

Roll "vpython" to git_revision:0577e51184b2da24260cbb01763eba51915b9755

TBR=iannucci@chromium.org
BUG=chromium:764087
TEST=None

Change-Id: I117a0c2d368303805abb6426e3b9e4cbb8997b91
Reviewed-on: https://chromium-review.googlesource.com/688584Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

41450825

27 Sep, 2017 1 commit

Fix CheckPatchFormatted() when using inherit-review-settings-ok · d86c8037

Andrew Grieve authored Sep 26, 2017

Adding inherit-review-settings-ok to a subrepository causes the
PRESUBMIT.py of the parent repository to be run. In this case, the
CheckPatchFormatted() check needs to run "git cl format" with
CWD=repository root.

Bug: 768962

Change-Id: I44c642185efa78ba3a1bd752f94c3c09feff9cf1
Reviewed-on: https://chromium-review.googlesource.com/685355Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>

d86c8037

26 Sep, 2017 4 commits

Remove unused gclient.sync() 'with_branch_heads' arg. · ced744fa

Michael Moss authored Sep 26, 2017

This arg used to be used in a 'sync' call that was removed in
crrev.com/7090f652, but it was never
applied to the remaining 'sync' call. This removes the arg and leaves
"--with_branch_heads" (and adds "--with_tags") as default sync flags.

Change-Id: Ice5a592d95a0b09dafddab24769f5edd8835a1c9
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: build
Reviewed-on: https://chromium-review.googlesource.com/677754Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

ced744fa

gclient: evaluate variables before passing them to GN · b495bf50

Paweł Hajdan, Jr authored Sep 25, 2017

This helps make sure they have proper types (e.g. True
instead of "True" for booleans).

Also see https://chromium-review.googlesource.com/c/chromium/src/+/681854
for context.

Bug: 756688, 570091
Change-Id: I1e4d26df724e8e94cc3daba361191856f80a1b2c
Reviewed-on: https://chromium-review.googlesource.com/681705Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

b495bf50

gclient: expose target_os · df64ee13

Paweł Hajdan, Jr authored Sep 26, 2017

Bug: 570091
Change-Id: I7513f3360662975ef6ef1d9019726dcef730a586
Reviewed-on: https://chromium-review.googlesource.com/681700
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

df64ee13

git-cl upload: adjust code-review score on TBR. · 81e3ff52

Yoshisato Yanagisawa authored Sep 26, 2017

Since git-cl TBR always sets +1, it does not allow auto-submit where
using +2 score as approval.  Let me make git-cl automatically adjust
to proper score.

Bug: 762425
Change-Id: I71fe1af1b8bf5e68d2509c60e8bf05024b6bdbb7
Reviewed-on: https://chromium-review.googlesource.com/680717Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

81e3ff52

25 Sep, 2017 1 commit

Adds progress argument option to fetch for git checkout · 0f09f971

Emma authored Sep 25, 2017

Bug:768229
Change-Id: If6988e3a75e66beb2900360b10d63560b4c0b345
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/681194
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

0f09f971

22 Sep, 2017 2 commits

Roll recipe dependencies (trivial). · 2fceee8f

recipe-roller authored Sep 22, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a22165922f0da807ad5f27d82c9e953b9c4672c3 Fixup quotes in test. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I06dad9bf00651e98ad257fc85f7a5f93b2b6d3a3
Reviewed-on: https://chromium-review.googlesource.com/679795Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

2fceee8f

Roll recipe dependencies (trivial). · 1bf03403

recipe-roller authored Sep 22, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/54df660706538e94951f101607491e659e5e3ed1 [package] Fix deep overrides doing extra fetches. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48e5ebb3d59f3537a9f1eadb2160660ae42351be
Reviewed-on: https://chromium-review.googlesource.com/679394Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

1bf03403

19 Sep, 2017 1 commit

Add support for PDFium to my_activity.py · 897602ab

Ryan Harrison authored Sep 18, 2017

Change-Id: I0febf1c3442511b8c82129c82cf9c68f7c37329c
Reviewed-on: https://chromium-review.googlesource.com/671548Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

897602ab

18 Sep, 2017 1 commit

Add skia_buildbot config · e09fe917

Ravi Mistry authored Sep 18, 2017

Goal is to eventually add a presubmit trybot for skia_buildbot
repository.
Similar to one that was added in
https://codereview.chromium.org/1141583002

Bug: skia:7049
Change-Id: I95a8e2b452a44a50dc177d520af4ce95129db6da
Reviewed-on: https://chromium-review.googlesource.com/671410Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

e09fe917

15 Sep, 2017 2 commits

Add some differentiating details to gerrit step names. · 7d7c4840

Michael Moss authored Sep 14, 2017

R=phajdan.jr@chromium.org

Recipe-Manual-Change: release_scripts
Recipe-Nontrivial-Roll: release_scripts
Change-Id: I4c3ca01bad7e5158565a8abc8d7fc5b4b77b0d4f
Reviewed-on: https://chromium-review.googlesource.com/666977
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

7d7c4840

WebRTC: Remove hack in bot_update.py. · 410907fe

Edward Lemur authored Sep 15, 2017

Bug: 765633
Change-Id: I8f2a9ba807fbe176695a7d44467f3948eea07fda
Reviewed-on: https://chromium-review.googlesource.com/668446Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

410907fe

13 Sep, 2017 5 commits

git-cl: Parse new change urls containing project paths · 289b4318

Aaron Gable authored Sep 13, 2017

Bug: 764848
Change-Id: I639451ad54eb50a405fe44b9a83b00d84ec76578
Reviewed-on: https://chromium-review.googlesource.com/665998Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

289b4318

WebRTC: Update source-of-truth on 'fetch webrtc' · 832e0bdf

Edward Lemur authored Sep 11, 2017

Bug: 751635
Change-Id: I0eaac306d394662d966e416b649414e9adbea048
Reviewed-on: https://chromium-review.googlesource.com/660258Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

832e0bdf

Roll vpython. · 2b619cc7

Robert Iannucci authored Sep 13, 2017

This picks up luci-go @ 0b4a49dd79cb1e7ef737a7ebea37c63c50f21ced
which adds awareness of the "linux-aarch64" platform/architecture
to vpython.

TBR=dnj@chromium.org, vadimsh@chromium.org

Bug: 764710
Change-Id: Ib2098c89c64d042879ddb8d281513616d49087ef
Reviewed-on: https://chromium-review.googlesource.com/665305Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

2b619cc7

Add gsutil.vpython spec to recipe bundles · 915b8122

Alexander Thomas authored Sep 13, 2017

Bug: 764673
Change-Id: I8cb5c95cccfa0afbea441a85b062de48c185af19
Reviewed-on: https://chromium-review.googlesource.com/665121
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

915b8122

Revert "Fix checkout.py issues when p.patchlevel > 1." · f8792079

Edward Lesmes authored Sep 13, 2017

This reverts commit 5908f990.

Reason for revert:
Introduces bugs when deleting files.
The reason is that 
  patchlevel = patchlevel or self.patchlevel
will evaluate to self.patchlevel also when patchlevel is 0, which is wrong.

Original change's description:
> Fix checkout.py issues when p.patchlevel > 1.
> 
> When p.patchlevel > 1, p.filename does not correspond to the files that
> git-apply would modify.
> 
> See bug for details
> 
> Bug: 764294
> Change-Id: Icdb803056e306edb25238b2d9cdabd3ff175d8ed
> Reviewed-on: https://chromium-review.googlesource.com/663357
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=kjellander@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: Ifa1f94602a023228cb32e5fe3fa07586b466981a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 764294
Reviewed-on: https://chromium-review.googlesource.com/663266Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f8792079