- 12 Jun, 2015 1 commit
-
-
iannucci@chromium.org authored
R=maruel@chromium.org BUG=479837,499650 Review URL: https://codereview.chromium.org/1181103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295664 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Apr, 2015 1 commit
-
-
agable@chromium.org authored
R=maruel@chromium.org BUG=475714 Review URL: https://codereview.chromium.org/1092313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294925 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Apr, 2015 1 commit
-
-
rmistry@google.com authored
The CQ dry run feature was announced in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/G5-X0_tfmok The primary complain is that the presubmit builders fail because of OWNERS checks or because of "Missing LGTM from someone other than...". This change skips those checks for dry runs. BUG=chromium:477190 Review URL: https://codereview.chromium.org/1090943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294853 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Mar, 2015 1 commit
-
-
dtu@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/1033363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294600 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Mar, 2015 1 commit
-
-
dominik.rottsches@intel.com authored
Blink CL https://codereview.chromium.org/879533003/ defines own casts to convert between bridged types. The cast helpers in base cannot be used in Blink. Fine tune the presubmit check to allow for those by adding a negative look behind for reinterpret_cast. BUG= Review URL: https://codereview.chromium.org/1034523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294560 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2015 1 commit
-
-
enne@chromium.org authored
Thanks to tfarina for the code suggestion. BUG=443718 Review URL: https://codereview.chromium.org/990403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294436 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Feb, 2015 1 commit
-
-
tfarina@chromium.org authored
This came in this CL review https://codereview.chromium.org/947983003/ BUG=None R=dpranke@chromium.org Review URL: https://codereview.chromium.org/955713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294207 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Feb, 2015 1 commit
-
-
erg@chromium.org authored
If the repository has third_party/dart-sdk/ unpacked, use that to format dart files modified in the current patch. BUG=459376 R=maruel@chromium.org, zra@google.com Review URL: https://codereview.chromium.org/933383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294179 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Feb, 2015 1 commit
-
-
glider@chromium.org authored
This check is specific to Chromium codebase, there's no point in having it in depot_tools. BUG=None R=maruel@chromium.org Review URL: https://codereview.chromium.org/924863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294124 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2015 1 commit
-
-
dpranke@chromium.org authored
Way back in r185294 I added the ability to request that, when checking owners, the patch author *should not* count (normally it does count). We did this in order to be able to mimic the review processes of WebKit in the Blink repo. However, we ended up never using this feature, so I'm finally getting around to deleting it. R=maruel@chromium.org BUG=none Review URL: https://codereview.chromium.org/851103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293685 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Dec, 2014 1 commit
-
-
tfarina@chromium.org authored
The idea here is that when one of the filters are cleaned up in Chromium, they should not be filtered out, otherwise we won't catch them in the presubmit step. See for example -> https://codereview.chromium.org/788493002/ BUG=None R=agable@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/779033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293357 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2014 1 commit
-
-
scottmg@chromium.org authored
Requires https://codereview.chromium.org/779883002/ to be landed/rolled before it's useful. R=dpranke@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/779513005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293269 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2014 1 commit
-
-
enne@chromium.org authored
input_api.basename is a function, so printing it out yields: "The <function basename at 0x7fccd3735410> directory requires..>" Instead, use it to resolve the local presubmit path that has requested clang formatting. R=dpranke@chromium.org BUG=422332 Review URL: https://codereview.chromium.org/665493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Oct, 2014 1 commit
-
-
jkarlin@chromium.org authored
If presubmit.py for a directory (such as net/) fails due to not being clang formatted, then 'git cl format' needs to be run for that directory, not the entire patch. BUG=422332 Review URL: https://codereview.chromium.org/648713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292407 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Oct, 2014 1 commit
-
-
dcheng@chromium.org authored
This check never triggered before, since cpplint.py was looking for override not OVERRIDE. Since Chromium prefers override now, the linter is now (correctly) warning. However, the old Chromium convention (and the one implemented by the clang plugin) is to explicitly annotate all overrides with both virtual and override. The clang plugin code has been updated, but new binaries have not yet been built. Until clang rolls, suppress the warning. BUG=417463 TBR=stip@chromium.org Review URL: https://codereview.chromium.org/627163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292319 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Sep, 2014 1 commit
-
-
dbeam@chromium.org authored
R=dpranke@chromium.org BUG=none TEST=no whining about <include src="long/path/name.js"> Review URL: https://codereview.chromium.org/579383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292080 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jul, 2014 1 commit
-
-
treib@chromium.org authored
BUG=397508 Review URL: https://codereview.chromium.org/424733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285901 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2014 1 commit
-
-
pgervais@chromium.org authored
'Add a description' is not enough to know what the test is about. Added some more info. BUG= Review URL: https://codereview.chromium.org/313523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274393 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2014 1 commit
-
-
agable@chromium.org authored
This method is necessary to allow good code organization (i.e., unittests live adjacent to the source files they test) in the new infra.git repository. R=maruel@chromium.org Review URL: https://codereview.chromium.org/281013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270564 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2014 1 commit
-
-
smut@google.com authored
I want to run Python unit tests as part of my presubmit, and those unit tests require PYTHONPATH to be set the way it would be set when the modules they test are running. Review URL: https://codereview.chromium.org/250693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@265998 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Apr, 2014 1 commit
-
-
nednguyen@google.com authored
BUG= Review URL: https://codereview.chromium.org/234293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263142 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2014 1 commit
-
-
isherman@chromium.org authored
BUG=none R=agable@chromium.org Review URL: https://codereview.chromium.org/215153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262641 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Mar, 2014 1 commit
-
-
isherman@chromium.org authored
R=agable@chromium.org BUG=none Review URL: https://codereview.chromium.org/195793021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259250 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Mar, 2014 1 commit
-
-
rvargas@chromium.org authored
2006-2009/10 was a valid copyright date format before 2011 (when we decided to use only one year, not a range). The current directive with copyright is in fact to not change old copyright dates, so there is no plan to go back and "fix" old files. As such, the presubmit checks should not be complaining about old files. BUG=none Review URL: https://codereview.chromium.org/200643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257181 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jan, 2014 1 commit
-
-
enne@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/143903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247723 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Jan, 2014 1 commit
-
-
enne@chromium.org authored
For simplicity, the canned presubmit check just calls git cl format directly with a new option --dry-run which does not change the files on disk. Because some users may not have git or clang-format might somehow have errors, this canned check is a warning. Additionally, if git cl format fails with an error then the presubmit check will silently report success to avoid spamming misconfigured users during upload. BUG=none Review URL: https://codereview.chromium.org/141493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246066 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2013 2 commits
-
-
maruel@chromium.org authored
This is useful to diagnose slow tests. Make this multiprocessing aware. Stop printing when the commands are added but use the proper message system instead. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/99453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238388 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@google.com authored
I've unified the checks for language specific exceptions to line length. There is a behavior change where cpp compiler directives no longer have a maximum line length (previously they were restricted to 150% of max line length). This change was made to match the behavior for java files. BUG=NONE Review URL: https://codereview.chromium.org/100163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238268 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Oct, 2013 1 commit
-
-
scheib@chromium.org authored
Review URL: https://codereview.chromium.org/27269002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228565 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Sep, 2013 1 commit
-
-
dpranke@chromium.org authored
Previously we would suggest owners for the whole CL, rather than just the files currently missing owner approval. R=maruel@chromium.org BUG=130978 Review URL: https://chromiumcodereview.appspot.com/23591064 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224183 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Aug, 2013 1 commit
-
-
danakj@chromium.org authored
Currently the output is: Found line ending with white spaces in: cc/trees/layer_tree_host_impl_unittest.cc, line 379 This format is extremely annoying because you must combine the file and line number together by hand. A more standard format for expressing a position in a file is filename:lineno. This changes the format to match: Found line ending with white spaces in: cc/trees/layer_tree_host_impl_unittest.cc:379 R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/22837004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@217405 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jun, 2013 1 commit
-
-
nick@chromium.org authored
presubmit_support: Call git once per change, to get a diff for all files. Parse this result to generate per-file diffs, which go into a cache that's shared between the AffectedFile instances. Greatly improves presubmit performance on Blink where there may be rule violations (my test case went from 50s to 5s). BUG=236206 TEST=new test in presubmit_unittest.py; manual performance test on Mac and Windows after touching hundreds of files in webkit; testing included add/move/edit/delete on both binary and text files. Review URL: https://chromiumcodereview.appspot.com/15898005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205275 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2013 1 commit
-
-
ilevy@chromium.org authored
Enable parallel tests on depot_tools. On Z620 presubmit times: 3m -> 35s. Review URL: https://codereview.chromium.org/14247012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@195377 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2013 1 commit
-
-
bauerb@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/13852011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194983 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Apr, 2013 1 commit
-
-
enne@chromium.org authored
This will let clients that don't use the heavily filtered canned cpplint check and want to behave more strictly (aka cc/) reuse any common settings applied to the cpplint module. R=maruel@chromium.org BUG=none Review URL: https://codereview.chromium.org/13866044 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194264 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Apr, 2013 1 commit
-
-
danakj@chromium.org authored
For hash_map and hash_set, we should include "base/hashtables.h", not the <hash_set> or <hash_map> standard headers. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194047 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2013 1 commit
-
-
jamesr@chromium.org authored
Blink wants to override the maxlen which is currently configurable in CheckLongLines but not in PanProjectChecks. This exposes the parameter on PanProjectChecks. Review URL: https://chromiumcodereview.appspot.com/13403004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192394 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Mar, 2013 1 commit
-
-
dpranke@chromium.org authored
If we uploaded a CL w/o any reviewers specified, and then ran the owners check on it (so that we had a Rietveld issue number) we would crash in a Python assertion. This wasn't caught in unit testing because of a limitation in the unit test scaffolding. TBR=maruel@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/12546003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186454 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Mar, 2013 1 commit
-
-
dpranke@chromium.org authored
Until an issue is uploaded to Rietveld, we don't know the official email address to use for an owners check. There are three ways to fix this: we could attempt to log in to rietveld prior to doing the check and extract the address to use, or we could use ~/.last_codereview_email_address, or we can use the email address we can determine from the checkout. All three options have flaws; the first is particularly awkward since there doesn't seem to be a good way to fetch the email without posting an issue. The second is flawed if we use different addresses for different repos, and the third is flawed if the checkout's email address is different from the rietveld address, or if it is anonymous. However, since this is only being used for owners checks (in this case), anonymous checkouts probably don't matter, and hopefully the cases where the email addresses differ are rare. R=maruel@chromium.org BUG=118388, 150049 Review URL: https://chromiumcodereview.appspot.com/12377023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Feb, 2013 1 commit
-
-
dpranke@chromium.org authored
Right now we require approval from someone, and we require an owner approval, but we don't require an approval from an owner *other than the patch other*. It's conceivable that we might want this, so I am making this a configurable argument to the presubmit check. This will also be needed to ensure that we don't suggest you as an owner for your own patches, when we actually know who you are. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/12326151 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@185294 0039d316-1c4b-4281-b951-d872f2087c98
-