Commit b3b5201b authored by bauerb@chromium.org's avatar bauerb@chromium.org

Sort list of files that are missing OWNERS LGTM in presubmit check.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/13852011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194983 0039d316-1c4b-4281-b951-d872f2087c98
parent c4209085
......@@ -804,7 +804,7 @@ def CheckOwners(input_api, output_api, source_file_filter=None,
if missing_files:
output_list = [
output('Missing %s for these files:\n %s' %
(needed, '\n '.join(missing_files)))]
(needed, '\n '.join(sorted(missing_files))))]
if not input_api.is_committing:
suggested_owners = owners_db.reviewers_for(affected_files, owner_email)
output_list.append(output('Suggested OWNERS:\n %s' %
......
......@@ -2419,9 +2419,11 @@ class CannedChecksUnittest(PresubmitTestsBase):
'brett@example.com']),
reviewers=set(['john@example.com',
'ben@example.com']),
uncovered_files=set(['foo/xyz.cc']),
uncovered_files=set(['foo/xyz.cc', 'foo/bar.cc']),
expected_output='Missing LGTM from an OWNER '
'for these files:\n foo/xyz.cc\n',
'for these files:\n'
' foo/bar.cc\n'
' foo/xyz.cc\n',
author_counts_as_owner=False)
def testCannedCheckOwners_TBR(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment