Add exception for long url(..) lines in css files in presubmit_canned_checks.CheckLongLines

BUG=397508

Review URL: https://codereview.chromium.org/424733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285901 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_canned_checks.py

@@ -358,10 +358,14 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):
     if line_len > extra_maxlen:
       return False
 
-    return (
-      any((url in line) for url in ('file://', 'http://', 'https://')) or
-        input_api.re.match(
-          r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))
+    if any((url in line) for url in ('file://', 'http://', 'https://')):
+      return True
+
+    if 'url(' in line and file_extension == 'css':
+      return True
+
+    return input_api.re.match(
+        r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line)
 
   def format_error(filename, line_num, line):
     return '%s, line %s, %s chars' % (filename, line_num, len(line))

tests/presubmit_unittest.py

@@ -2253,6 +2253,16 @@ class CannedChecksUnittest(PresubmitTestsBase):
         None,
         presubmit.OutputApi.PresubmitPromptWarning)
 
+  def testCannedCheckLongLinesCssUrl(self):
+    check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+    self.ContentTest(
+        check,
+        ' url(some.png)',
+        'foo.css',
+        ' url(some.png)',
+        'foo.cc',
+        presubmit.OutputApi.PresubmitPromptWarning)
+
 
   def testCannedCheckLongLinesLongSymbol(self):
     check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)