• Bill Budge's avatar
    Revert "[torque] Port builtins-number-gen to Torque" · f920ad11
    Bill Budge authored
    This reverts commit 4482f988.
    
    Reason for revert: Causes Torque to break UBSAN
    
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11235?
    
    [764/2199] ACTION //:run_torque(//build/toolchain/linux:clang_x64)
    FAILED: gen/torque-generated/bit-fields-tq.h gen/torque-generated/builtin-definitions-tq.h gen/torqu...(too long)
    python ../../tools/run.py ./torque -o gen/torque-generated -v8-root ../.. src/builtins/array-copywit...(too long)
    ../../src/torque/implementation-visitor.cc:778:36: runtime error: 2.14748e+09 is outside the range of representable values of type 'int'
    
    Original change's description:
    > [torque] Port builtins-number-gen to Torque
    > 
    > - Ports everything except Add.
    > 
    > Builtins generated from this CL are slightly larger, e.g. Subtract
    > is 424 bytes on x64, as opposed to 400 bytes for the CSA version.
    > See https://crbug.com/v8/10521
    > 
    > Bug: v8:9891
    > 
    > Change-Id: Id85779eb26d8e51643d8a04f0a75090bc50ef5b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191644
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67910}
    
    TBR=bbudge@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Change-Id: Ib124c893753973243563e32c25bc727a5df2ca53
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9891
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209264Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67911}
    f920ad11
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...