• Bill Budge's avatar
    Revert "[torque] Port builtins-number-gen to Torque" · f920ad11
    Bill Budge authored
    This reverts commit 4482f988.
    
    Reason for revert: Causes Torque to break UBSAN
    
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11235?
    
    [764/2199] ACTION //:run_torque(//build/toolchain/linux:clang_x64)
    FAILED: gen/torque-generated/bit-fields-tq.h gen/torque-generated/builtin-definitions-tq.h gen/torqu...(too long)
    python ../../tools/run.py ./torque -o gen/torque-generated -v8-root ../.. src/builtins/array-copywit...(too long)
    ../../src/torque/implementation-visitor.cc:778:36: runtime error: 2.14748e+09 is outside the range of representable values of type 'int'
    
    Original change's description:
    > [torque] Port builtins-number-gen to Torque
    > 
    > - Ports everything except Add.
    > 
    > Builtins generated from this CL are slightly larger, e.g. Subtract
    > is 424 bytes on x64, as opposed to 400 bytes for the CSA version.
    > See https://crbug.com/v8/10521
    > 
    > Bug: v8:9891
    > 
    > Change-Id: Id85779eb26d8e51643d8a04f0a75090bc50ef5b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191644
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67910}
    
    TBR=bbudge@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Change-Id: Ib124c893753973243563e32c25bc727a5df2ca53
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9891
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209264Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67911}
    f920ad11
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...