- 19 May, 2020 34 commits
-
-
Bill Budge authored
This reverts commit 4482f988. Reason for revert: Causes Torque to break UBSAN https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11235? [764/2199] ACTION //:run_torque(//build/toolchain/linux:clang_x64) FAILED: gen/torque-generated/bit-fields-tq.h gen/torque-generated/builtin-definitions-tq.h gen/torqu...(too long) python ../../tools/run.py ./torque -o gen/torque-generated -v8-root ../.. src/builtins/array-copywit...(too long) ../../src/torque/implementation-visitor.cc:778:36: runtime error: 2.14748e+09 is outside the range of representable values of type 'int' Original change's description: > [torque] Port builtins-number-gen to Torque > > - Ports everything except Add. > > Builtins generated from this CL are slightly larger, e.g. Subtract > is 424 bytes on x64, as opposed to 400 bytes for the CSA version. > See https://crbug.com/v8/10521 > > Bug: v8:9891 > > Change-Id: Id85779eb26d8e51643d8a04f0a75090bc50ef5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191644 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67910} TBR=bbudge@chromium.org,jgruber@chromium.org,tebbi@chromium.org Change-Id: Ib124c893753973243563e32c25bc727a5df2ca53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209264Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#67911}
-
Bill Budge authored
- Ports everything except Add. Builtins generated from this CL are slightly larger, e.g. Subtract is 424 bytes on x64, as opposed to 400 bytes for the CSA version. See https://crbug.com/v8/10521 Bug: v8:9891 Change-Id: Id85779eb26d8e51643d8a04f0a75090bc50ef5b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191644 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67910}
-
Deepti Gandluri authored
Bug: v8:10506 Change-Id: I3fccaf640e23b5fcc7722164e2437b247684f824 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207919Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67909}
-
Ng Zhi An authored
Convert wasm-value into internal::WasmValue, then to debug::WasmValue. This is then copied into a CDP protocol object via a new class, WasmValueMirror. Bug: v8:10347 Change-Id: I5778d2cc5701caf82e4a97ac329303e510695b74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151130Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67908}
-
Seth Brenith authored
This change updates some Torque-defined classes to include more precise field types where possible. It also updates those classes to use @generateCppClass. One field was removed because it's unused (PrototypeInfo::validity_cell), and two fields in StackFrameInfo actually became less precise because they're based on Script::name, which is an embedder-provided untyped Local<Value>. (Automatically generated accessors pointed out this bug easily.) This change also includes a couple of minor fixes in Torque. Change-Id: Ib2bc6c7165bb3612b6d344c0686a94165a568277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199640 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 18ac08d0 Original Commit Message: This is a reland of 3cc981cb with a fix for data race detected by TSan. Original change's description: > [wasm][debug] Fix tier down during streaming compilation > > If the debugger is enabled while streaming compilation is happening, we > won't correctly tier down to Liftoff. This is because during streaming > compilation, we always compile for no debugging. Fixing that is a bit > tricky, since when the debugger is enabled, functions can either already > have finished compiling, or they are currently being compiled, or their > wire bytes are not received yet. > Instead of handling this correctly while streaming compilation is > running, we just recompile the whole module with Liftoff after streaming > compilation finished. > > For testing this, we use the existing tests for async compilation, and > enable --wasm-test-streaming, which compiles via the streaming decoder > even in the async compilation case. > > R=thibaudm@chromium.org > > Bug: v8:10531 > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67882} R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I778a10eaba0016a9e897c8f71ac822c6b421350f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208901 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Marja Hölttä authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/ttUq_6Bq_FM Bug: v8:10372 Change-Id: I32dc3d35a7afd2d1ea0af81fcada870837a2a3c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207185 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67905}
-
Thibaud Michaud authored
Registers cannot be used as a merge destination if they have more than one use, otherwise the merge will unexpectedly affect other uses of that register. R=ahaas@chromium.org,clemensb@chromium.org Bug: chromium:1084151 Change-Id: I0d6ad97c585920357a37d95361e0320d32c71f4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208851Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67904}
-
Bill Budge authored
- Ports all conversions that Torque can handle (without weird linkage.) - Moves NumberToString to number:: namespace. - Moves ToStringImpl to string:: namespace. Bug: v8:9891 Change-Id: I5190c545952e1d9810ca71ae7ff4a807d2d98781 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2205192 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Lookups and updates to the executable_memory_ unordered_map need to be protected with mutex. Bug: v8:10315, v8:10546 Change-Id: Ic17e19d1e4fda18b99103a96052940e68e970586 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208867Reviewed-by:
-
Bill Budge authored
Bug: v8:9891 Change-Id: I9fda15122fc4f24e237af6bfc00eb529ae37cb01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2177512 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Emanuel Ziegler authored
The typed function references proposal allows an optional second parameter to Table.grow containing the initialization value for the newly added entries for tables that do not support null defaults. This CL adds this functionality but hides it behind a newly added experimental flag --experimental-wasm-typed-funcref. R=ahaas@chromium.org CC=jkummerow@chromium.org CC=manoskouk@chromium.org Bug: v8:9495 Change-Id: Ia156aeacf95bc36a9fc182990f315c42075cbb7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207184 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Richard Stotz authored
Bug: v8:10520 Change-Id: I765201107b6cee20ad8591db57ac88fef5b3dbbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207534 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Do not lock mutex for the full duration of the slow path of allocation on background threads. For example sweeping and allocation of a new page is now performed outside of the lock. Bug: v8:10315 Change-Id: Ifee9bc1569d1ec53fdced965bd222dd1eab11b24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207131Reviewed-by:
-
Richard Stotz authored
Bug: v8:10520 Change-Id: I40b94705e638fa6491cef7ca7f8c6287657af06f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202909 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 3cc981cb with a fix for data race detected by TSan. Original change's description: > [wasm][debug] Fix tier down during streaming compilation > > If the debugger is enabled while streaming compilation is happening, we > won't correctly tier down to Liftoff. This is because during streaming > compilation, we always compile for no debugging. Fixing that is a bit > tricky, since when the debugger is enabled, functions can either already > have finished compiling, or they are currently being compiled, or their > wire bytes are not received yet. > Instead of handling this correctly while streaming compilation is > running, we just recompile the whole module with Liftoff after streaming > compilation finished. > > For testing this, we use the existing tests for async compilation, and > enable --wasm-test-streaming, which compiles via the streaming decoder > even in the async compilation case. > > R=thibaudm@chromium.org > > Bug: v8:10531 > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67882} Bug: v8:10531, v8:10544 Change-Id: I884922b6ac55543e6ff9b1046438f6b3abab6f64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207187Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67896}
-
Thibaud Michaud authored
Fix underflow when the break type list is empty, and do not try to reuse the first value to generate the wanted type. Bug: chromium:1084452 Change-Id: Ia9855a267730bb9f427518c27157f449475fb6ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208858Reviewed-by:
-
Clemens Backes authored
For single-threaded, we can not tier up in the background. Hence we can either tier up in foreground (which is pointless), or not tier up. This CL disables Liftoff, so will compile TurboFan code right away. R=ahaas@chromium.org Bug: v8:10530 Change-Id: Icfdc26643ab219d617f844c2ea8e149870168dbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208853Reviewed-by:
-
Richard Stotz authored
Bug: v8:10520 Change-Id: Ifc99782682c7b1597357211d72a11c44703965b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202907Reviewed-by:
-
Clemens Backes authored
TSan handles SIGPROF incorrectly, hence we don't get the samples we expect on that test, and it quite frequently times out on TSan bots. Skip it for now, until the TSan issue is fixed. R=petermarshall@chromium.org Bug: v8:9869 Change-Id: I27c65cdd10c53b441faad216e00d6c60b42229e6 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208857Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67892}
-
Ulan Degenbaev authored
Allocation observers are not thread-safe, so the allocation steps should be invoked only on the main thread. Bug: v8:10536 Change-Id: I90e809fa230d18cce135f4bea67b62ef616ca593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207189Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67891}
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:10506, v8:6949 Change-Id: I701ad51273e14db8a5185ff130e8d8593dce1ba4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202911Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67890}
-
Dominik Inführ authored
Locking the space mutex isn't required in PagedSpace::Expand. Bug: v8:10315 Change-Id: I6fac74e3c4fc6f4f2228af37729839b6ff23bc64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207183 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Call_WithFeedback CallWithArrayLike_WithFeedback CallWithSpread_WithFeedback ConstructWithArrayLike_WithFeedback ConstructWithSpread_WithFeedback These are used in generic lowering if --turbo-nci is passed. Bug: v8:8888 Change-Id: I78b56a1f358fa7c213e375eeb2feaa65432adfdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199352Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67888}
-
Santiago Aboy Solanes authored
Return type still needs TNodification. It can be Object or Float64T. Bug: v8:10506, v8:6949 Change-Id: I71e7ae28f3039b2e1c5c2a5c2e383c335cdec38a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204281Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67887}
-
Santiago Aboy Solanes authored
Used to be named FastFixedArrayForEachBody. Rename to remove the 'fixed' part since it can also be a PropertyArray (i.e not a FixedArray). Rename BuildFastFixedArrayForEach to also remove the 'fixed'. Bug: v8:10506, v8:6949 Change-Id: I840edf802d334b9ca930f3022553c476e2dca34a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202910Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67886}
-
Clemens Backes authored
This reverts commit 3cc981cb. Reason for revert: TSan failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/31572 Original change's description: > [wasm][debug] Fix tier down during streaming compilation > > If the debugger is enabled while streaming compilation is happening, we > won't correctly tier down to Liftoff. This is because during streaming > compilation, we always compile for no debugging. Fixing that is a bit > tricky, since when the debugger is enabled, functions can either already > have finished compiling, or they are currently being compiled, or their > wire bytes are not received yet. > Instead of handling this correctly while streaming compilation is > running, we just recompile the whole module with Liftoff after streaming > compilation finished. > > For testing this, we use the existing tests for async compilation, and > enable --wasm-test-streaming, which compiles via the streaming decoder > even in the async compilation case. > > R=thibaudm@chromium.org > > Bug: v8:10531 > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67882} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: I26e750c6c6d0783b5e4a0f19a5462a5fbe99a742 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207186Reviewed-by:
-
Marja Hölttä authored
In this case, we'll already have values in "errors" in PerformPromiseAny step 8.d. Bug: v8:9808 Change-Id: I5bb0cba41887f4bbdab3bb15e8f52dd94acec9c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204277 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Richard Stotz authored
We implement the conversions via C functions (external references) because 64-bit conversions are difficult to implement on ia32 and would not be significantly faster. Bug: v8:10520 Change-Id: I3573d30bf6b3d558f708c7e0273f027c30a1a771 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202988 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Clemens Backes authored
If the debugger is enabled while streaming compilation is happening, we won't correctly tier down to Liftoff. This is because during streaming compilation, we always compile for no debugging. Fixing that is a bit tricky, since when the debugger is enabled, functions can either already have finished compiling, or they are currently being compiled, or their wire bytes are not received yet. Instead of handling this correctly while streaming compilation is running, we just recompile the whole module with Liftoff after streaming compilation finished. For testing this, we use the existing tests for async compilation, and enable --wasm-test-streaming, which compiles via the streaming decoder even in the async compilation case. R=thibaudm@chromium.org Bug: v8:10531 Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133Reviewed-by:
-
Shu-yu Guo authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/raep1X9R_SE/m/V8ofHrBdAgAJ Bug: v8:9801 Change-Id: I55e71b37f23ec91a01771f5584d11bc4e5939da4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207920 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67881}
-
Jakob Gruber authored
So far this is mainly a readability improvement to specify expectations on the packed argument. In the future we should also check signedness during bytecode generation. Drive-by: Update DCHECK to allow signed args to CHECK_CURRENT_POSITION. Bug: chromium:1083450 Change-Id: I9376ec691b51eb251c972309ad65dd6c04eec3ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207137 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67880}
-
Jakob Gruber authored
Verify that `current` always points inside, or just past the end of the subject string. Bug: chromium:1083450 Change-Id: I27ba49cbfd0aa93cd2e305efafc23b155c98a49b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207136Reviewed-by:
-
Ng Zhi An authored
The lowering for anytrue was assuming that the input nodes are all integers. The regression test added in https://crrev.com/c/2194471 calls anytrue with float operands, this was causing the lowering to generate cmpl instructions with a float register and an immediate, which is wrong. The fix is to use GetReplacementsWithType on the input nodes, but only if the input were floats, since we use Word32Equal. Drive-by clean up of comments in the aforementioned regression test. Bug: v8:10535 Change-Id: I4de89516c178e9003a4c745808d831be87918381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203400 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 18 May, 2020 6 commits
-
-
Ng Zhi An authored
Bug: v8:9886 Change-Id: I22af3c19ef6371d31f0f95c58730ceb3e7effafa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207653Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67877}
-
Hannes Payer authored
Change-Id: I70328a944b78591d106d752197b096cb86c32573 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206735 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Ng Zhi An authored
The codegen uses a bunch of vpmax to try and keep set bits around. The datatype for vpmax does not need to change for each instruction, since vpmax U32 will persist set bits just as well. This simplifies the instruction sequences for S1x8 and S1x16 anytrue. I added a test to check a special case when a f64x2 contains -0.0 (top bit set). A previous attempt to optimize codegen used floating point compare, which does not distinguish between 0.0 and -0.0. So -0.0 will compare equals to 0.0, and incorrect return 0 for anytrue. Change-Id: I66013796af08a666009e6b2d774ea7ee7bdfe1ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203113 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 99e4ef48 Original Commit Message: Only for arm and arm64 now. The ia32 and x64 ones are more complicated and will be included in subsequent changes. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3bcdae0d47d2e024cfb6e80ba460306ec5e2d434 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2205884Reviewed-by:
-
Ng Zhi An authored
This is a reland of edf90ee8 The fix here is to call GetUnusedRegister with {}, in liftoff-assembler-ia32.h emit_i8x16_shri_u. Original change's description: > [wasm-simd][liftoff][ia32][x64] Implement i8x16 shr > > The code sequence is the same as TurboFan, only wrapped in a template to > share the implementation. > > Bug: v8:9909 > Change-Id: I9c1b37bbfafe91d1bd8edd7f9dafd86ff1c07623 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202723 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67842} Bug: v8:9909 Change-Id: Id56a612cd6580c68a5129e71d7a0e7b29d64b368 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204080Reviewed-by:
-
Ng Zhi An authored
Making them private was a way to hide the constructor, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I8a116637608fcc6a93d6fc4f5ee014d2db863669 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204156Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67872}
-
