• Clemens Backes's avatar
    [wasm][debug] Fix tier down during streaming compilation · 3cc981cb
    Clemens Backes authored
    If the debugger is enabled while streaming compilation is happening, we
    won't correctly tier down to Liftoff. This is because during streaming
    compilation, we always compile for no debugging. Fixing that is a bit
    tricky, since when the debugger is enabled, functions can either already
    have finished compiling, or they are currently being compiled, or their
    wire bytes are not received yet.
    Instead of handling this correctly while streaming compilation is
    running, we just recompile the whole module with Liftoff after streaming
    compilation finished.
    
    For testing this, we use the existing tests for async compilation, and
    enable --wasm-test-streaming, which compiles via the streaming decoder
    even in the async compilation case.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10531
    Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67882}
    3cc981cb
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...