• Clemens Backes's avatar
    [wasm][debug] Store "for debugging" flag on compilation unit · e0433f7d
    Clemens Backes authored
    Before the "debug" flag was stored on the {CompilationEnv}. But each
    background compilation task only gets the {CompilationEnv} once when
    starting compilation, so by the time it picks up the "Liftoff for
    debugging" compilation jobs, it might still compile them without the
    debug flag being set. This leads to flakes in the "debug-step-into-wasm"
    test, because we won't stop in the function prologue when stepping in
    (because the function prologue does not check the "hook on function
    call" flag if debug mode was not enabled).
    
    This CL does not increase the size of a compilation unit, since both the
    tier and the debug flag only need a single byte each.
    
    As a nice side effect, this change allows us to remove the lock in
    {CreateCompilationEnv}, because no modifyable flag is read any more.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10410
    Change-Id: Ic296ea0c4dd1d4dedde119f0536e87e5d301b5a1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144116Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67115}
    e0433f7d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...