- 14 Apr, 2020 11 commits
-
-
Clemens Backes authored
Before the "debug" flag was stored on the {CompilationEnv}. But each background compilation task only gets the {CompilationEnv} once when starting compilation, so by the time it picks up the "Liftoff for debugging" compilation jobs, it might still compile them without the debug flag being set. This leads to flakes in the "debug-step-into-wasm" test, because we won't stop in the function prologue when stepping in (because the function prologue does not check the "hook on function call" flag if debug mode was not enabled). This CL does not increase the size of a compilation unit, since both the tier and the debug flag only need a single byte each. As a nice side effect, this change allows us to remove the lock in {CreateCompilationEnv}, because no modifyable flag is read any more. R=thibaudm@chromium.org Bug: v8:10410 Change-Id: Ic296ea0c4dd1d4dedde119f0536e87e5d301b5a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144116Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67115}
-
Anna Henningsen authored
ArrayBuffer instances are serialized by first re-assigning a index to the backing store field, then serializing the object, and then storing the actual backing store address again (and the same for the ArrayBufferExtension). If serialization of the object itself is deferred, the real backing store address is written into the snapshot, which cannot be processed when deserializing, leading to a crash. This fixes this by not deferring ArrayBuffer serialization and adding a DCHECK for the crash that previously occurred. Change-Id: Id9bea8268061bd0770cde7bfeb6695248978f994 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144123 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67114}
-
Milad Farazmand authored
Port 4558c1df Original Commit Message: As a drive-by, the order of rounding_average_u is adjusted according to src/wasm/wasm-opcodes.h. R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib5c72c9187ee3803c5c04b4fb62422be67382bf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148649Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67113}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: Idbbab7af430e3bc2791eba630b331a75a67e35a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142262Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67112}
-
Anna Henningsen authored
- Minor improvements to the documentation for snapshotting. - Add newlines to printed errors where necessary. Change-Id: I822e7e850adb67eae73b51c23cf34e40ba3106f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144954Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67111}
-
Leszek Swirski authored
Change the unittests Isolate mixin to create one Isolate per test, rather than one per test suite. We usually run these tests independently in separate processes anyway, so this shouldn't affect normal test execution, but it will avoid Isolate state leaking across tests when running the unittests binary directly. Take this opportunity to also clean up the mixins, changing counter initialization and forcing pointer compression into template traits. Bug: v8:10142 Change-Id: If92046f9c6f2056252d099faed04d97844ef7319 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143818Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67110}
-
Michael Lippautz authored
Provides the infrastructure to register weak callbacks for WeakMember<T> through visitor. The WeakCallbackInfo broker is used to query objects for liveness. In a future CL the same broker object is passed to custom weak callbacks. Change-Id: I8b5a66354e0e457521989d40ae64a9558c339503 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142265 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:10371, v8:10396 Change-Id: I55359ac5d96369962d472f8a7e5d01303b823be0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2145240 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67108}
-
Michael Lippautz authored
Introduce LivenessBroker which is a temporary broker object to expose liveness during specific garbage collection phases. This broker can be used to handle: - PreFinalizer - Custom weak callbacks - Internal weak callbacks used for WeakMember Change-Id: I3870c2b89b2538f04feabf2eb7a4676ce2fe7d61 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144059Reviewed-by:
-
Omer Katz authored
This adds ownership of tests. Bug: chromium:1056170 Change-Id: Ibed6ee0024d34c886817d273660922d5cc6865ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141734Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67106}
-
Zhao Jiazhong authored
Port c054847d https://crrev.com/c/2131323 Change-Id: I21e534399eed573affd3bf65004b3e570c549ff4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2147573Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#67105}
-
- 13 Apr, 2020 6 commits
-
-
Zhou, Zhiguo authored
As a drive-by, the order of rounding_average_u is adjusted according to src/wasm/wasm-opcodes.h. Bug: v8:9909 Change-Id: Ia3a2ed5869f8df8a2191afa034e0b9438de98bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141654Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Cr-Commit-Position: refs/heads/master@{#67104}
-
Clemens Backes authored
v8.1 has a stability issue where we free code too early. Thus disable for now, such that we can merge this back to v8.1. v8.2 does not have this problem, since https://crrev.com/c/2078583 fixed it. This CL is not easily backmergable though. R=tebbi@chromium.org Bug: chromium:1070199, chromium:1070182 Change-Id: I4bf468b3e7b5b1e66b314907f844d4195b3ff029 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144966 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67103}
-
Zhao Jiazhong authored
Port 445f9ef1 https://crrev.com/c/2107511 Change-Id: Ib3517c186da6e49574b873ac568afd0e8e4336c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143980Reviewed-by:
-
Milad Farazmand authored
Port 445f9ef1 R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3b383071ea26286e9d1d5121565020a0c6f31a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2147030Reviewed-by:
-
Milad Farazmand authored
Port bd04ee08 R=fanchen.kong@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3b8e2625816a8517a0557882d6acdb6d6f28766b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2147029Reviewed-by:
-
Kong, Fanchen authored
Bug: v8:9909 Change-Id: I13d7ae7b304fe55645ef7bcc9ac404782bb55d4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2131323Reviewed-by:
-
- 11 Apr, 2020 1 commit
-
-
Zhao Jiazhong authored
Port bd04ee08 https://crrev.com/c/2143386 Change-Id: I547c9b5b341abe76d6983a07633129299c32e017 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143978Reviewed-by:
-
- 10 Apr, 2020 4 commits
-
-
Milad Farazmand authored
Change-Id: Iaa39a9fd8ee0a80b04c5664328931383545e074b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144747Reviewed-by:
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: I21980ee97e0d2483c064e40cae181297b4d563a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2107511 Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Reviewed-by:
-
Kong, Fanchen authored
Bug: v8:9909 Change-Id: I5dd3e88ab6f7508a07b2a8e5adb033fff7e28fe2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143386Reviewed-by:
-
Zhao Jiazhong authored
Port 04b6e0de https://crrev.com/c/2135074 Original Commit Message: This reorders the SIMD opcodes together with their implementations on x64, ia32 according to src/wasm/wasm-opcodes.h. Change-Id: I82c8b678eb65b616d02d20333d479ee4ae0564d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143974Reviewed-by:
-
- 09 Apr, 2020 18 commits
-
-
Milad Farazmand authored
Port 1a7f5689 R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4db697c6a0fab9bd3c9dda4761c3af3ade509ffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144691 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
-
Milad Farazmand authored
Port da409929 Original Commit Message: Adds: - GetStackStart - GetCurrentStackPosition - GetStackSlot which translates a stack slot through ASAN if needed R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Icdf50db1c4d0b6ce3c9819cda4663dc640ec6f43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144292Reviewed-by:
-
Ng Zhi An authored
This relands commit df204288 with the addtional fix to Haddps to enable SSE3 scope. There are a couple more left in some i64x2 ops, but those are not in the proposal, so I've left them as it is. Bug: v8:9561 Change-Id: I88fd5f88809e629f53a65d67ea5b11562111b44a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136067Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67091}
-
Clemens Backes authored
In production, the debug side tables will always be produced with Liftoff in debug mode ({CompilationEnv::debug} being set). Thus, this CL switches the tests to also test this configuration. R=thibaudm@chromium.org Bug: v8:10410 Change-Id: I3fa16f099d2bb612c7abf8c3ef518e1446564306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144119Reviewed-by: -
Richard Townsend authored
Bug: v8:10407 Change-Id: I4fb6544ca575e115ed84c1e15911794f3fb4a627 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144112Reviewed-by:
-
Camillo Bruni authored
- Fix property name table with very long names - List all keyboard shortcuts Change-Id: I4eba14143a0cf71f4e8c02159a1f16113aa2600a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142267Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67088}
-
Thibaud Michaud authored
This is a reland of f902ef32 Original change's description: > [wasm] Cleanup wasm script creation > > - Do not expose CreateWasmScript since we should now use > WasmEngine:GetOrCreateScript instead, > - Initialize all Script fields in CreateWasmScript, not in > WasmModuleObject::New, > - Do not pass code size estimate argument, since we can always use the > actual native module's committed code space. > > R=clemensb@chromium.org > > Bug: v8:10349 > Change-Id: If9250d62ffc271ab6efc3b9c45958a305c9d1827 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135633 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67083} Bug: v8:10349 Change-Id: I38c8b6beb07a1e5d565c6a5fd749daea147817bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144064Reviewed-by:
-
Mathias Bynens authored
Per the spec [1], a resolved promise may be “pending, fulfilled, or rejected”, but previously V8 incorrectly used the term “resolved” instead of “fulfilled”. This change is user-observable through the `d8` REPL and the DevTools Console. Corresponding DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2141673 Corresponding Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2144095 [1]: https://tc39.es/ecma262/#sec-properties-of-promise-instances Bug: v8:6751, v8:5416 Change-Id: I6c5302c280d01cf681c6358add3d2e88fbffa36f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144011 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#67086}
-
Clemens Backes authored
This reverts commit f902ef32. Reason for revert: Makes gc-stress unhappy: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/27404 Original change's description: > [wasm] Cleanup wasm script creation > > - Do not expose CreateWasmScript since we should now use > WasmEngine:GetOrCreateScript instead, > - Initialize all Script fields in CreateWasmScript, not in > WasmModuleObject::New, > - Do not pass code size estimate argument, since we can always use the > actual native module's committed code space. > > R=clemensb@chromium.org > > Bug: v8:10349 > Change-Id: If9250d62ffc271ab6efc3b9c45958a305c9d1827 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135633 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67083} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: Iac2978af1a300ec079baebab0feb8c9598711738 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10349 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144058Reviewed-by:
-
Nico Hartmann authored
This reverts commit 3e1c7040. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/12665 Original change's description: > Reland "cppgc: Add page memory allocation backend" > > This is a port of src/components/gc that was added recently. > > Differences: > - Added back bucketing to the page pool, as that guarantees that > arenas used for specific types do not have their pages used by other > arenas. > - Replaced base::flat_map with std::map. This may cause performance > regressions when using PageMemoryRegionTree in hot paths. A > vector-like representation may be used to fix such a regression > > This reverts commit 656c68a7. > > Bug: chromium:1056170 > Change-Id: I638183c944255ebcaab47d2b94b1980d54479746 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143814 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67080} TBR=mlippautz@chromium.org,mslekova@chromium.org Change-Id: I04b048dd979c32e9275c972307796d5f75865037 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144114Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67084}
-
Thibaud Michaud authored
- Do not expose CreateWasmScript since we should now use WasmEngine:GetOrCreateScript instead, - Initialize all Script fields in CreateWasmScript, not in WasmModuleObject::New, - Do not pass code size estimate argument, since we can always use the actual native module's committed code space. R=clemensb@chromium.org Bug: v8:10349 Change-Id: If9250d62ffc271ab6efc3b9c45958a305c9d1827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135633Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10408 Change-Id: I6a4a1d82333cf31520526c766357c78d3d8dd206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140941 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67082}
-
Clemens Backes authored
Templates provide better error messages and make debugging easier. R=zhin@chromium.org Bug: v8:10364 Change-Id: Ia3581c4458e8edb3b24371605000b0b00bb5069d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140936 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This is a port of src/components/gc that was added recently. Differences: - Added back bucketing to the page pool, as that guarantees that arenas used for specific types do not have their pages used by other arenas. - Replaced base::flat_map with std::map. This may cause performance regressions when using PageMemoryRegionTree in hot paths. A vector-like representation may be used to fix such a regression This reverts commit 656c68a7. Bug: chromium:1056170 Change-Id: I638183c944255ebcaab47d2b94b1980d54479746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143814Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67080}
-
Omer Katz authored
GetHeapFromPayload returned the page header address instead of the value of the first field of the header. Bug: chromium:1056170 Change-Id: I4de5be975accced32460d6fab91543e6a5b07ba0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143825 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Clemens Backes authored
This increases source code size, but the code is simple and repetitive. Complexity is reduced by removing the macros. R=zhin@chromium.org Bug: v8:10364 Change-Id: I989c4d78aaebe00c7fbb525d88a6670cd0fe3b92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141732Reviewed-by:
-
Leszek Swirski authored
Fix off-thread space merging unit tests, by a) Doing a GC on each test teardown (avoiding leaking GC state between tests), and b) Removing the AllocationStep when merging, which could cause a deadlock if incremental marking triggered a free-list refill. Bug: v8:10142 Change-Id: Id2670115f96ab3b13613ea357bd44a639d0151e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142260 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Michael Lippautz authored
This CL provides a basic allocator that allocates normal-sized objects on pages without ever reusing them. This allows for already using the backref from page to heap which is used in some critical places (pre-finalizers, write barrier, Persistent). Bug: chromium:1056170 Change-Id: Ifada9b7e984827906c267d1a3a521576587feaeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141736 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
