• Clemens Backes's avatar
    [wasm][debug] Store "for debugging" flag on compilation unit · e0433f7d
    Clemens Backes authored
    Before the "debug" flag was stored on the {CompilationEnv}. But each
    background compilation task only gets the {CompilationEnv} once when
    starting compilation, so by the time it picks up the "Liftoff for
    debugging" compilation jobs, it might still compile them without the
    debug flag being set. This leads to flakes in the "debug-step-into-wasm"
    test, because we won't stop in the function prologue when stepping in
    (because the function prologue does not check the "hook on function
    call" flag if debug mode was not enabled).
    
    This CL does not increase the size of a compilation unit, since both the
    tier and the debug flag only need a single byte each.
    
    As a nice side effect, this change allows us to remove the lock in
    {CreateCompilationEnv}, because no modifyable flag is read any more.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10410
    Change-Id: Ic296ea0c4dd1d4dedde119f0536e87e5d301b5a1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144116Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67115}
    e0433f7d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...