• Benedikt Meurer's avatar
    [wasm][inspector] Don't use `Script::source_url` to store URL. · c0ee8f90
    Benedikt Meurer authored
    The `Script::source_url` field holds the value of the magic
    `//# sourceURL` comment if found, and the `Script::name` field is
    supposed to hold the actual name of the resource (as provided by
    the embedder ideally), in case of Chromium that's supposed to be
    the URL (in case of Node.js it's often the local path).
    
    Using `source_url` worked by chance so far, but for loading DWARF
    symbol files correctly we need the initiator (which we pick from
    the embedderName of the Script as reported to DevTools). More
    importantly, the partial handling of `//# sourceURL` in V8 is a
    layering violation and causes trouble in DevTools, i.e. when users
    put relative paths here. So as part of refactoring and correctifying
    the handling of `//# sourceURL`, we need to make sure that the embedder
    provided name (the URL in case of Chromium) is always stored in the
    `Script::name` field.
    
    Bug: chromium:1183990, chromium:974543, chromium:1174507
    Change-Id: I32e11def2b9b52be11bd2e0e64a2ab6bdcf5e52d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773584
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73536}
    c0ee8f90
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...