• Seth Brenith's avatar
    Revert "[regalloc] Run SpillPlacer on any value defined in a loop" · 3017f895
    Seth Brenith authored
    This reverts commit 7f054679.
    
    Reason for revert: regressions on Emscripten/Fannkuch and
    JetStream/richards
    
    Original change's description:
    > [regalloc] Run SpillPlacer on any value defined in a loop
    > 
    > I previously wrote a comment that said "We haven't seen any indication
    > of performance improvements from seeking optimal spilling positions
    > except on loop-top phi values". That statement is no longer true, now
    > that I've looked a little harder. In the latest version of the Mono
    > interpreter, we can improve performance by 2.5% by enabling SpillPlacer
    > for any value defined within a loop.
    > 
    > Bug: v8:10606
    > Change-Id: I25e06458c87ad4ffcefe52be3042032e05a47b35
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2381557
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#69646}
    
    TBR=rmcilroy@chromium.org,seth.brenith@microsoft.com,thibaudm@chromium.org
    
    Change-Id: Ic3e74485f42bafedfe1890c0be32a29c3455afe5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10606, chromium:1124028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2388745Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#69658}
    3017f895
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
live-range-separator.cc Loading commit data...
live-range-separator.h Loading commit data...
mid-tier-register-allocator.cc Loading commit data...
mid-tier-register-allocator.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
register-allocation.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
spill-placer.cc Loading commit data...
spill-placer.h Loading commit data...
unwinding-info-writer.h Loading commit data...