• Seth Brenith's avatar
    Revert "[regalloc] Run SpillPlacer on any value defined in a loop" · 3017f895
    Seth Brenith authored
    This reverts commit 7f054679.
    
    Reason for revert: regressions on Emscripten/Fannkuch and
    JetStream/richards
    
    Original change's description:
    > [regalloc] Run SpillPlacer on any value defined in a loop
    > 
    > I previously wrote a comment that said "We haven't seen any indication
    > of performance improvements from seeking optimal spilling positions
    > except on loop-top phi values". That statement is no longer true, now
    > that I've looked a little harder. In the latest version of the Mono
    > interpreter, we can improve performance by 2.5% by enabling SpillPlacer
    > for any value defined within a loop.
    > 
    > Bug: v8:10606
    > Change-Id: I25e06458c87ad4ffcefe52be3042032e05a47b35
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2381557
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#69646}
    
    TBR=rmcilroy@chromium.org,seth.brenith@microsoft.com,thibaudm@chromium.org
    
    Change-Id: Ic3e74485f42bafedfe1890c0be32a29c3455afe5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10606, chromium:1124028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2388745Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#69658}
    3017f895
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...