• Seth Brenith's avatar
    Revert "[regalloc] Run SpillPlacer on any value defined in a loop" · 3017f895
    Seth Brenith authored
    This reverts commit 7f054679.
    
    Reason for revert: regressions on Emscripten/Fannkuch and
    JetStream/richards
    
    Original change's description:
    > [regalloc] Run SpillPlacer on any value defined in a loop
    > 
    > I previously wrote a comment that said "We haven't seen any indication
    > of performance improvements from seeking optimal spilling positions
    > except on loop-top phi values". That statement is no longer true, now
    > that I've looked a little harder. In the latest version of the Mono
    > interpreter, we can improve performance by 2.5% by enabling SpillPlacer
    > for any value defined within a loop.
    > 
    > Bug: v8:10606
    > Change-Id: I25e06458c87ad4ffcefe52be3042032e05a47b35
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2381557
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#69646}
    
    TBR=rmcilroy@chromium.org,seth.brenith@microsoft.com,thibaudm@chromium.org
    
    Change-Id: Ic3e74485f42bafedfe1890c0be32a29c3455afe5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10606, chromium:1124028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2388745Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#69658}
    3017f895
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...