- 04 May, 2016 7 commits
-
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:608630 LOG=Y Review-Url: https://codereview.chromium.org/1943313002 Cr-Commit-Position: refs/heads/master@{#36008}
-
mstarzinger authored
The predicate in question was a workaround for when the compilation pipeline still kept bytecode and baseline code on the same shared function info. It is not longer needed. In the long run we want a predicate which can determine the exact tier for each function. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/1940913002 Cr-Commit-Position: refs/heads/master@{#36007}
-
bmeurer authored
The inline allocation sequence in the optimizing compilers cannot deal well with funky types like JSRegExp, which have some magic fields in addition to the inobject properties. In Crankshaft we already use the FastNewObjectStub for %_NewObject in general, so fix TurboFan to the same. Hopefully one day we can kill %_NewObject completely. R=jarin@chromium.org BUG=chromium:609029 LOG=n Review-Url: https://codereview.chromium.org/1943403004 Cr-Commit-Position: refs/heads/master@{#36006}
-
jarin authored
Review-Url: https://codereview.chromium.org/1946883003 Cr-Commit-Position: refs/heads/master@{#36005}
-
bjaideep authored
Port 81cb8411 R=binji@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4614 LOG=N Review-Url: https://codereview.chromium.org/1951643002 Cr-Commit-Position: refs/heads/master@{#36004}
-
bjaideep authored
Port d2efbf25 R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/1952503002 Cr-Commit-Position: refs/heads/master@{#36003}
-
v8-autoroll authored
Rolling v8/build to bbe88f49be848cde9fcf4e1f470506cd560ec5f6 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1944243002 Cr-Commit-Position: refs/heads/master@{#36002}
-
- 03 May, 2016 33 commits
-
-
adamk authored
Compiler backends get their language mode from the current function, but should instead be deriving it from the current scope. This allows proper handling of the always-strictness of class declarations and expressions, and in particular the treatment of 'eval' calls in an extends clause as a strict eval. Also fix the parser's RecordEvalCall logic to only reach out to the DeclarationScope in sloppy mode, which fixes the strange case of a sloppy function thinking it contains a sloppy eval when in fact it contains only a strict eval. BUG=v8:4970 LOG=n Review-Url: https://codereview.chromium.org/1931003003 Cr-Commit-Position: refs/heads/master@{#36001}
-
danno authored
BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/1948433002 Cr-Commit-Position: refs/heads/master@{#36000}
-
mbrandy authored
TEST=cctest/test-api/Regress470113 --ignition R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1946733002 Cr-Commit-Position: refs/heads/master@{#35999}
-
binji authored
https://codereview.chromium.org/1938213002 added xchg_b and xchg_w, but didn't add it to the disassembler, and there were no tests that caught it. BUG=v8:4614 TBR=bmeurer@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1947673002 Cr-Commit-Position: refs/heads/master@{#35998}
-
cornacch authored
Typing icount at the sim debug prompt will print the current icount. si <mnemonic> steps through instructions until an instruction with that mnemonic is seen. E.g. si brc will stop at the next brc instruction before executing it. R=jyan@ca.ibm.com, joransiu@ca.ibm.com Review-Url: https://codereview.chromium.org/1944913002 Cr-Commit-Position: refs/heads/master@{#35997}
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1943733003 Cr-Commit-Position: refs/heads/master@{#35996}
-
Adam Klein authored
R=rmcilroy@chromium.org BUG=v8:4899 LOG=n Review URL: https://codereview.chromium.org/1938673002 . Cr-Commit-Position: refs/heads/master@{#35995}
-
bjaideep authored
Port fa570e55 R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/1950443002 Cr-Commit-Position: refs/heads/master@{#35994}
-
binji authored
BUG=v8:4614 R=bmeurer@chromium.org,jarin@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1938213002 Cr-Commit-Position: refs/heads/master@{#35993}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:592352 LOG=Y Review-Url: https://codereview.chromium.org/1943373002 Cr-Commit-Position: refs/heads/master@{#35992}
-
cbruni authored
The Great Keys Migration: This is part of a bigger effort to centralize optimizations for key collections in a central place. This necessary to avoid the penalty that would be introduced by fixing shadowed property iteration. BUG=v8:4758, v8:705 LOG=N Review-Url: https://codereview.chromium.org/1938413002 Cr-Commit-Position: refs/heads/master@{#35991}
-
martyn.capewell authored
Disable ASM_LOCATION inline debug messages in release builds. This makes code size measurements more representative when using the simulator. BUG= Review-Url: https://codereview.chromium.org/1919013005 Cr-Commit-Position: refs/heads/master@{#35990}
-
jkummerow authored
Omitting the initializer will give zero-initialization which is equivalent to kNoWriteBarrier. Review-Url: https://codereview.chromium.org/1942293002 Cr-Commit-Position: refs/heads/master@{#35989}
-
bjaideep authored
native_handle_ on AIX64 is of type int, and therefore fails on an operation with a pointer type. Use kSemaphoreAlignmentMask as sizeof(int) on AIX and sizeof(pointer) otherwise. R=jochen@chromium.org, mbrandy@us.ibm.com BUG=v8:4767 LOG=N Review-Url: https://codereview.chromium.org/1936003002 Cr-Commit-Position: refs/heads/master@{#35988}
-
mstarzinger authored
This moves all implementation internals of the Pipeline class into the corresponding cc-file. Only the public API remains in the header and is made up of static functions only. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1948443002 Cr-Commit-Position: refs/heads/master@{#35987}
-
mlippautz authored
Reland of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1947473002/ ) Reason for revert: Unrelated to waterfall failures. Original issue's description: > Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) > > Reason for revert: > GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin > > Original issue's description: > > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > > > BUG=chromium:598319 > > LOG=N > > > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > > Cr-Commit-Position: refs/heads/master@{#35970} > > TBR=ulan@chromium.org,mlippautz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:598319 > > Committed: https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b > Cr-Commit-Position: refs/heads/master@{#35979} TBR=ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947503002 Cr-Commit-Position: refs/heads/master@{#35986}
-
jarin authored
The problem is actually not related to try-catch, so here is a test without try-catch. BUG=chromium:607493 LOG=n Review-Url: https://codereview.chromium.org/1943883002 Cr-Commit-Position: refs/heads/master@{#35985}
-
mlippautz authored
Reland of [turbofan] Restore basic write barrier elimination. (patchset #1 id:1 of https://codereview.chromium.org/1943743003/ ) Reason for revert: Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination. Original issue's description: > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) > > Reason for revert: > Breaks WBs that should be there ;) > > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 > > Will open repro bug asap. > > Original issue's description: > > [turbofan] Restore basic write barrier elimination. > > > > Restore the basic write barrier elimination that we used to run as part > > of the simplified lowering phase (in ChangeLowering actually) before, by > > moving the write barrier computation to SimplifiedLowering where we can > > still look at types and consider the heap/isolate, and just update the > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > > lowering to a machine Load/Store. > > > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > R=mstarzinger@chromium.org > > BUG=v8:4969,chromium:608636 > > LOG=n > > > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > > Cr-Commit-Position: refs/heads/master@{#35969} > > TBR=mstarzinger@chromium.org,bmeurer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4969,chromium:608636 > > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 > Cr-Commit-Position: refs/heads/master@{#35983} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943323002 Cr-Commit-Position: refs/heads/master@{#35984}
-
mlippautz authored
Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) Reason for revert: Breaks WBs that should be there ;) https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 Will open repro bug asap. Original issue's description: > [turbofan] Restore basic write barrier elimination. > > Restore the basic write barrier elimination that we used to run as part > of the simplified lowering phase (in ChangeLowering actually) before, by > moving the write barrier computation to SimplifiedLowering where we can > still look at types and consider the heap/isolate, and just update the > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > lowering to a machine Load/Store. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > R=mstarzinger@chromium.org > BUG=v8:4969,chromium:608636 > LOG=n > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > Cr-Commit-Position: refs/heads/master@{#35969} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943743003 Cr-Commit-Position: refs/heads/master@{#35983}
-
jarin authored
BUG=chromium:607493 LOG=n Review-Url: https://codereview.chromium.org/1949433002 Cr-Commit-Position: refs/heads/master@{#35982}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1947463002 Cr-Commit-Position: refs/heads/master@{#35981}
-
yangguo authored
Some uninitialized ICs used to be implemented as builtins. This is apparently no longer the case. R=bmeurer@chromium.org, mvstanton@chromium.org Review-Url: https://codereview.chromium.org/1940283002 Cr-Commit-Position: refs/heads/master@{#35980}
-
yangguo authored
Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) Reason for revert: GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin Original issue's description: > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > BUG=chromium:598319 > LOG=N > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > Cr-Commit-Position: refs/heads/master@{#35970} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947473002 Cr-Commit-Position: refs/heads/master@{#35979}
-
mstarzinger authored
By now the Pipeline class can no longer be used to construct instances from the outside. The constructor and all non-exposed helpers can be made private. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1943243003 Cr-Commit-Position: refs/heads/master@{#35978}
-
yangguo authored
v8::Object::{Set,Get,Delete}HiddenValue have long been deprecated. Please use v8::Object::{Set,Has,Get}Private instead. R=jochen@chromium.org LOG=Y Review-Url: https://codereview.chromium.org/1942233002 Cr-Commit-Position: refs/heads/master@{#35977}
-
ahaas authored
Additionally I removed some stale comments. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/1941323002 Cr-Commit-Position: refs/heads/master@{#35976}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1946523002 Cr-Commit-Position: refs/heads/master@{#35975}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:605488 LOG=Y Review-Url: https://codereview.chromium.org/1940243002 Cr-Commit-Position: refs/heads/master@{#35974}
-
ahaas authored
Graph construction, graph scheduling, instruction selection, and register allocation has been moved to ExecuteCompilation, which will eventually be executed on the background threads. Code generation remains in FinishCompilation because it has to be executed by the main thread. Additionally, WasmCompilationUnits are finished more eagerly in wasm-module.cc to save memory. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/1942773002 Cr-Commit-Position: refs/heads/master@{#35973}
-
ishell authored
Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler. BUG=v8:2743 LOG=Y Review-Url: https://codereview.chromium.org/1894953004 Cr-Commit-Position: refs/heads/master@{#35972}
-
bmeurer authored
R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1941373002 Cr-Commit-Position: refs/heads/master@{#35971}
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1943263002 Cr-Commit-Position: refs/heads/master@{#35970}
-
bmeurer authored
Restore the basic write barrier elimination that we used to run as part of the simplified lowering phase (in ChangeLowering actually) before, by moving the write barrier computation to SimplifiedLowering where we can still look at types and consider the heap/isolate, and just update the WriteBarrierKind in the FieldAccess/ElementAccess that we later use when lowering to a machine Load/Store. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel R=mstarzinger@chromium.org BUG=v8:4969,chromium:608636 LOG=n Review-Url: https://codereview.chromium.org/1938993002 Cr-Commit-Position: refs/heads/master@{#35969}
-