• mlippautz's avatar
    Reland of [turbofan] Restore basic write barrier elimination. (patchset #1... · 95b8f3b0
    mlippautz authored
    Reland of [turbofan] Restore basic write barrier elimination. (patchset #1 id:1 of https://codereview.chromium.org/1943743003/ )
    
    Reason for revert:
    Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination.
    
    Original issue's description:
    > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ )
    >
    > Reason for revert:
    > Breaks WBs that should be there ;)
    >
    > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305
    >
    > Will open repro bug asap.
    >
    > Original issue's description:
    > > [turbofan] Restore basic write barrier elimination.
    > >
    > > Restore the basic write barrier elimination that we used to run as part
    > > of the simplified lowering phase (in ChangeLowering actually) before, by
    > > moving the write barrier computation to SimplifiedLowering where we can
    > > still look at types and consider the heap/isolate, and just update the
    > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when
    > > lowering to a machine Load/Store.
    > >
    > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
    > > R=mstarzinger@chromium.org
    > > BUG=v8:4969,chromium:608636
    > > LOG=n
    > >
    > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62
    > > Cr-Commit-Position: refs/heads/master@{#35969}
    >
    > TBR=mstarzinger@chromium.org,bmeurer@chromium.org
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=v8:4969,chromium:608636
    >
    > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7
    > Cr-Commit-Position: refs/heads/master@{#35983}
    
    TBR=mstarzinger@chromium.org,bmeurer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4969,chromium:608636
    
    Review-Url: https://codereview.chromium.org/1943323002
    Cr-Commit-Position: refs/heads/master@{#35984}
    95b8f3b0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...