- 28 Apr, 2021 6 commits
-
-
Jakob Gruber authored
.. which traces various stats (time, memory) related to the snapshot. Due to various flag shuffles, it was broken as of Oct 2020, with some line items reporting constant 0. This also refactors --profile-deserialization and --serialization-statistics s.t. the former only reports deserialization times and the latter reports memory. Memory.json now passes both flags. Change-Id: I7dacbbbe9f7a667e0802d0f7a44703dc34524a4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854742 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74241}
-
Ross McIlroy authored
Rather than pushing each root seperately, then emptying the queue and pushing the next, instead push all roots together then work through the queue. This reduces the number of node visits by around 6x compared to pushing roots seperately. BUG=v8:9684 Change-Id: I481fc177731f9d2b12e00c2a6d1be06a93429ff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854298 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74240}
-
Leszek Swirski authored
Add a special builtin performing a ToBoolean operation for jumps in baseline code, which a) returns the original value as the first return value, to avoid needing to save it in the caller, and b) returns the true/false value as a Smi, to make the baseline-side comparison a cheap comparison against zero. This reduces JumpIfToBoolean (on x64) from ~40 to ~30 bytes. Bug: v8:11420 Change-Id: Idee51405b1e450cdd11ccb45ed82ddbc9119ae74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854654 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74239}
-
Shu-yu Guo authored
With top-level await enabled by default, the behavior of v8::Module::Evaluate is changed to always return a Promise, and should be documented. No-try: true Change-Id: I8bf41a18d8d98befecd62d6423ab37fdbaac3aad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854874Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74238}
-
Dominik Inführ authored
A NativeContext is initialized in two steps: First the map is allocated, only afterwards the NativeContext. It could happen that there is a GC happening when allocating the NativeContext. In such a case the native_context for the Map is still set to null. Fix this by also allowing null in Map::MapVerify. Bug: v8:11695 Change-Id: Id8dcd6aef83aff4cbfff45a1e993e555cff8e7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853587Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6273d81..94367a1 Rolling v8/third_party/aemu-linux-x64: CMJyNq6nZ3RoBUYmon01iRJ7MYYfVl4ds1kgbGFcNRMC..KmvDYKZZ-xQz7ZzzSKBh3HrWPpQv89vfFY9mBp6RDq4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/00b0b51..ca2c407 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c91f5f6..ae1b2b1 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/86da5ec..835951a Rolling v8/tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289 Rolling v8/tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289 Rolling v8/tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia1b0769152c8b3e11691c452d8f0e338ede4b3af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74236}
-
- 27 Apr, 2021 34 commits
-
-
Milad Fa authored
MatcherBase::buffer_ defined under "gtest/gtest-matchers.h" is a union of sizes that may be too large for Config object currently being passed to it. This might result in `buffer_` to remain uninitialized. More information about the error can be found in the comment section of this CL: https://crrev.com/c/2228887 Change-Id: Ibeef1189a7db8056f00cc85dbccec506d345a7eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854278Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74235}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: chromium:1202736 Change-Id: Id4056ba60fdaa5d5fbe2099ef0823da70a28e6ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853601 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74234}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I41ebc2e507d1662588364396f1129c75a0f0841d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851890 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74233}
-
Nico Weber authored
Bug: v8:11699 Change-Id: I286ea7d3a6455528c66eee3f479455bfc49f190c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2852039 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Changes: - Add WasmInitExpr class which knows how to create initializer expressions as pairs of {type, value}. Also define a default for every type. Emit such pairs to a byte array with emit_init_expr(). - Add an initializer expression to every global (addGlobal() uses the default if the argument is absent). - Introduce wasmI64Const(); - Update tests as needed. Change-Id: I75ffe96604891506ad78bd3677ce1efe5e0cee07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851892 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Georg Neis authored
The kInt64, kUint64, and kIntPtr type definitions made no sense. This CL removes kIntPtr and fixes+renames k(I|Ui)nt64. It also adds some DCHECKs to avoid similar bugs in the future. Bug: chromium:1202609 Change-Id: Ibe2e9c7501c22959b850d2b1076e819455440450 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851895Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74230}
-
Junliang Yan authored
Change-Id: Ib492a0165d8aed748d8ece406bc51931ee577391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849179Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74229}
-
Maya Lekova authored
Bug: v8:11695 Change-Id: I3b558260a23b4fb7d16bc8f1e9c57b94bce03838 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854299Reviewed-by:
-
Leszek Swirski authored
Remove a couple of cases where builtins called by the baseline code needed a context parameter, either because the interface descriptor accidentally included the context, or by adding a trivial context load from the frame where appropriate. Bug: v8:11420 Change-Id: I3f34cd452f42dd876255375ae357feb245c78cdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848464 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Jakob Gruber authored
FixedDoubleArrays are a special case: 1 The reads are 64-bit and unaligned, thus use memcpy underneath. 2 The compiler only reads FDArray values for (constant) boilerplate elements. 1) makes proper atomic reads tricky-to-impossible without a lock. Luckily, 2) means we know that the array values are immutable after initialization, thus we can simply do a non-atomic read from the compiler thread. Bug: v8:7790 Change-Id: I39698d867543ce2214a2148511c5d90ced6364b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848410 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74226}
-
Michael Lippautz authored
- Move ASAN and MSAN support to base/ - Eval arguments for builds without sanitizer to preserve same semantics - IWYU fixes Bug: chromium:1056170 Change-Id: I212becf205e03b155c188ffd13cf5629df6f2cb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851887Reviewed-by:
-
Maya Lekova authored
Bug: v8:11700 Change-Id: Ibed6e02fdf17cef267135620a2ceab735be2ee9f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853593 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The previously added perf-context Promise-hooks take a v8::Function as arguments. However, the builtin code was only accepting JSFunctions which causes cast errors. Drive-by-fix: Directly pass nativeContext in more places. Bug: chromium:1201465 Change-Id: Ic8bed11253a1f18a84e71eb9ea809b1ec1c3f428 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850162Reviewed-by:
-
Michael Achenbach authored
The config was mistakenly switched to Bionic already. We keep it unspecified now to prepare reimaging the bots. No-Try: true Bug: chromium:1199430 Change-Id: Ib09d9abbe890fc891af69b6630bf21be85328196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853586 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74222}
-
Jakob Gruber authored
This is another step towards improving TSAN and test coverage of concurrent paths. By purging reconstructible (background-serialized or never-serialized) ObjectData instances from the cache after serialization, we increase ObjectData-construction activity on the background thread. Note that this means ObjectData is no longer canonicalized - two instances can point at the same underlying object. Losing this property is unfortunate, but we can revert back to it once work on the concurrency project is further advanced. Bug: v8:7790 Change-Id: I44b1366f61dc9087cddc76939512abed17e28d61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844661 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74221}
-
Maya Lekova authored
This CL makes the object passed as argument to IsLeafTemplateForApiObject be received as a handle instead of a raw C++ pointer. From the codegen point of view, the memory representation is the same, so this doesn't change its semantics. Bug: chromium:1052746 Change-Id: Ibc116aa4d577ba95f30d1014f15f34ef3fbb1a35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851884Reviewed-by:
-
Wenyu Zhao authored
This CL ensures that the TPH object iterator is reset correctly before iteration. Bug: v8:11641 Change-Id: I041890f8a1999f5d0d75af017744a5618550f28c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849818Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74219}
-
Patrick Thier authored
With --stress-scavenge it is possible that we don't have a memento for the object we are interested in anymore, making the test useless. Bug: v8:11701 Change-Id: I05984de33dc0c21d01023ebaa4ceebacfb63cc84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851889 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74218}
-
Dan Elphick authored
Expose third_party/google_benchmark:google_benchmark as a public dep from third_party/google_benchmark:benchmark_main and a v8_libbase dependency to empty_benchmark to expose base/macros.h. Bug: v8:7330 Change-Id: I5205af365da2ac7c35647acff90ed65d831cfa07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851888 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Wenyu Zhao authored
Bug: v8:11641 Change-Id: I2b7fb85fa4e2890787981af1559f535b76ec8b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849815Reviewed-by:
-
Maya Lekova authored
Bug: v8:11702 Change-Id: Ie6b03cce08b0c9c617ce58050ae4d066ba1f592a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851891Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#74215}
-
Dan Elphick authored
Removes references to previously deleted headers: src/sanitizer/lsan-page-allocator.h src/base/atomicops_internals_portable.h src/base/atomicops_internals_std.h Bug: v8:7330 Change-Id: I8834d8041f50d4cd9402fc57490e8a6e0e7d5c76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851885 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Wenyu Zhao authored
TPH doesn't support multiple mutators at the moment, so concurrent_inlining is disabled. Thus we don't need to support `PublishPendingAllocations` for now. Bug: v8:11641 Change-Id: I26f63f4093027878563c15de594a0a6bbef31c0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849819 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
-
Wenyu Zhao authored
* Failed tests that also trigger GCs are not filtered out. They are expected to be fixed when TPH supports real garbage collection. Bug: v8:11641 Change-Id: I30b8bcf48d5e3f32439eeffb39d28ee45db2a21c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849822Reviewed-by:
-
Wenyu Zhao authored
Place DCHECKs in per-space allocation functions and concurrent allocation functions to assert TPH is not enabled. For per-space allocation function, they should be redirected to TPH. For concurrent allocations, TPH doesn't support it at the moment. Bug: v8:11641 Change-Id: Ib7292bc03132353b0555d9cbd5b49936f4a6de76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849817 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
-
Wenyu Zhao authored
Bug: v8:11641 Change-Id: I76226e98a298e7868ec4fda75cb1bb75b8d42b7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849820Reviewed-by:
-
Daniel Dromboski authored
Update the way urllib is imported. As of Python 3, the old `urllib2` was split into several smaller modules under `urllib`. This commit unifies the resulting imported names across Python 2 and Python 3, for forward/backward compatibility. Bug: v8:9871 Change-Id: I81310ea83536269ae0cdf1406fd69285928c9357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848488Reviewed-by:
-
QiuJi authored
1. add saving for s9, s10, s11 2. remove saving for gp. 3. fix maintain of fp (which alias to s0). Reference of calling convention source: https://riscv.org/wp-content/uploads/2015/01/riscv-calling.pdf. Change-Id: I7898f52e55df3976dccd736b72249f4fe28dd359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848476Reviewed-by:
-
Leszek Swirski authored
Change-Id: I983d3c0a14238aeaa017f083b5df30668f6670e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848472 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#74207}
-
Wenyu Zhao authored
Bug: v8:11641 Change-Id: I82434a2134862a2de9b878c564141168c844132d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849821Reviewed-by:
-
Georg Neis authored
Bug: v8:11692 Change-Id: I89cdb3d7102123f63fc66106c35962d0578222c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851878 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#74205}
-
Michael Achenbach authored
Bug: chromium:1199430 Change-Id: I7bdbb6ecdf08e71b13825401ae0523a82386c48b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851882 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/84e217e..6273d81 Rolling v8/third_party/aemu-linux-x64: GCNw2-mtXN7PnLi5hLQH5ab_ViULLYtqr5C1KX36CYQC..CMJyNq6nZ3RoBUYmon01iRJ7MYYfVl4ds1kgbGFcNRMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1727be6..00b0b51 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/90aee2a..c91f5f6 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/f16d43c..23ef295 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I755a92fbcb724c599fc0e848ad8edb4e7461d23b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2852896Reviewed-by:
-
Santiago Aboy Solanes authored
This is a reland as-is of https://chromium-review.googlesource.com/c/v8/v8/+/2831488, which got lost in the js-heap-broker.cc to heap-refs.cc transition. Bug: v8:7790 Change-Id: I9dd9e77a665e70feb90457a906a221926a3c0b94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848411 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
