Commit e3d63e96 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[build] Fix gn check errors in test/benchmarks/cpp

Expose third_party/google_benchmark:google_benchmark as a public dep
from third_party/google_benchmark:benchmark_main and a v8_libbase
dependency to empty_benchmark to expose base/macros.h.

Bug: v8:7330
Change-Id: I5205af365da2ac7c35647acff90ed65d831cfa07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851888
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74217}
parent 2be84120
......@@ -25,6 +25,9 @@ if (v8_enable_google_benchmark) {
sources = [ "empty.cc" ]
deps = [ "//third_party/google_benchmark:benchmark_main" ]
deps = [
"//:v8_libbase",
"//third_party/google_benchmark:benchmark_main",
]
}
}
......@@ -69,6 +69,6 @@ if (v8_enable_google_benchmark) {
source_set("benchmark_main") {
testonly = true
sources = [ "src/src/benchmark_main.cc" ]
deps = [ ":google_benchmark" ]
public_deps = [ ":google_benchmark" ]
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment