- 31 May, 2022 38 commits
-
-
Leszek Swirski authored
This is a reland of commit 3b251deb Annotates the perfetto proto include with nogncheck, because gn's header checker doesn't understand preprocessor directives. See https://gn.googlesource.com/gn/+/main/docs/reference.md#advice-on-fixing-problems Original change's description: > Reland "[test] Move tracing cctest to unittests" > > This is a reland of a7d6bf96 > > Added perfetto to unittests include_rules. > > Bug: v8:12781 > Change-Id: Iabf0e62abb1de879de21ba06fbd38f5432ee4f76 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652295 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80847} Bug: v8:12781 Change-Id: I886df9254d8fecd56f64110f04b1447937605b58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3680299 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80866}
-
Clemens Backes authored
The macro list makes it difficult to impossible to deprecate individual methods (like the one receiving a {WasmModuleTieredUp} struct). Hence avoid the macro list and instead call the macro explicitly for each definition. R=cbruni@chromium.org Bug: v8:12899 Change-Id: I4139de7721c4a1450920c5be312e91e7478e6fa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667076Reviewed-by: -
Danil Somsikov authored
Bug: chromium:1240663 Change-Id: I133e3de012b08666c767478b8ad6fd7bf7c0fa35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679098Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Danil Somsikov <dsv@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#80864}
-
Clark DuVall authored
This will be useful for implementing crbug.com/1328448. Bug: v8:12916 Change-Id: Id22ae96f6c1f9b72ab09508dd1f6dc2d70f8b5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677654 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80863}
-
Patrick Thier authored
Add a new late escape analysis pass to JS late optimizations. The new pass simply removes allocations that are not used (besides initializing stores to the object). Bug: v8:12200 Change-Id: I01fc6233cca2f369c77ff2116ed7c4da1a232d95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677298 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80862}
-
Junliang Yan authored
Change-Id: Ia6f542104887624d80eebd309f16b7da94159fc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679978Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80861}
-
Dominik Inführ authored
After AssertNoTypedSlotsInFreeMemory being a CHECK for some time now to get more test coverage, turn this into a DCHECK again. This CL also renames the methods used by the sweeper to clear typed slots in free memory. It was previously called "invalid slots" but IMHO that could be a bit misleading, since this isn't about object slot invalidation (where we also filter slots) but only really about slots in free memory. Bug: v8:12760 Change-Id: I8f414be06207460531fa54189b9ef1be85f4ecb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679578Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80860}
-
Clemens Backes authored
The method is already misleading, as with dynamic tiering the "top tier" is defined to be the same as the "baseline tier" (i.e. Liftoff). Hence the method does not do what you would expect it to do. Fixing it to wait for all functions to be compiled with TurboFan would result in a deadlock, if we do not also trigger tier-up of all functions. Hence remove the method. R=ahaas@chromium.org Bug: v8:12899 Change-Id: I4ba76febd796f6a9ad1252e6d73a72e569fd648c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657436 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80859}
-
jameslahm authored
This CL adds the serialization and deserialization for properties in function. And we only support fast properties in property array now. Bug: v8:11525 Change-Id: If0bb3fee400ca957009d046ed74b92d8192c2514 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650675 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80858}
-
Leszek Swirski authored
This reverts commit 3b251deb. Reason for revert: Chrome build is still unhappy Original change's description: > Reland "[test] Move tracing cctest to unittests" > > This is a reland of a7d6bf96 > > Added perfetto to unittests include_rules. > > Bug: v8:12781 > Change-Id: Iabf0e62abb1de879de21ba06fbd38f5432ee4f76 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652295 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80847} Bug: v8:12781 Change-Id: I54d64a10e24bc913be9d2bd66c1908664665f484 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679519 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80857}
-
Andreas Haas authored
Bug: v8:12926 Change-Id: I16d4b7d3e2af638ceb4f635fb114762c2f352616 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678209 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80856}
-
Leszek Swirski authored
Add support for LoadHandlers with the kConstantFromPrototype kind. With some dependency checks, this becomes a map check and constant load. Bug: v8:7700 Change-Id: I865eee7be4df9bd0ba56943814f601e3e950ed80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675101Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80855}
-
Manos Koukoutos authored
This CL fixes all spots where wasm Turbofan code did not satisfy the invariant that all nodes with effect outputs are connected to another node. Also, it enables the related verification for wasm code. Drive-by: - Simplify how stack checks are removed during loop unrolling. - Fix a test declaration in test-gc.cc. Change-Id: Id32af8584ba0ec281f4bf7757bd2915e6d8bf443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676862 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:12781 Change-Id: Icf3233b48718e117cc39289c511f9fd4d99c874d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679079Reviewed-by:
-
Marja Hölttä authored
This makes the following use cases produce a visible error: - deserializing invalid data w/ d8 [previously broken] - error in the script embedded in the web snapshot - d8 can't read web snapshot files Bug: v8:11525,v8:12820 Change-Id: I40a993194f9992a40c877261ebf9882e018b669b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672415Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11525 NoTry: True Change-Id: Idee38e400aec4aed1ebf9a25e0416002a05a7a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679258Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80851}
-
Maya Lekova authored
Bug: chromium:1329234 Change-Id: I59f171d3e2ab0c07f79f631971b1695b9f706600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677294Reviewed-by:
-
Clemens Backes authored
Some tests disabled dynamic tiering in order to actually serialize TurboFan code. This makes the tests a bit simpler, but does not reflect real-world usage. This CL enables dynamic tiering in those tests and when needed executes the code until tier-up was observed. R=ahaas@chromium.org Bug: v8:12899 Change-Id: I34cb8cedbc5908d9e6ca09d56c51609d0c8b2d6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660262 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11525,v8:12820 Change-Id: I282ab058b6062513113059db171644466ef37870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667078Reviewed-by:
-
Leszek Swirski authored
This is a reland of a7d6bf96 Added perfetto to unittests include_rules. Bug: v8:12781 Change-Id: Iabf0e62abb1de879de21ba06fbd38f5432ee4f76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652295Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80847}
-
Omer Katz authored
The abstractions in this CL include: 1) Using EvacuatePrologue to handle age mark updating in SemiSpaceNewSpace. 2) Using IsPromotionCandidate to check if a page contains the current age mark. 3) EnsureCurrentCapacity instead of Rebalance. 4) Delegate page promotions in mark-compact.cc to the NewSpace implementation. Bug: v8:12612 Change-Id: Ied83261d661a8e61a11bf33b1d7a2103ac99a853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644966 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80846}
-
Marja Hölttä authored
This reverts commit ff84cd04. Reason for revert: This CL had a commit from another branch which was supposed to land as a part of that CL ( https://chromium-review.googlesource.com/c/v8/v8/+/3672415/1 ), not this one. Going to reland a cleaned up version. Original change's description: > [rab/gsab] Fix ObjectSerializer > > Without this fix, the byte length for GSABs is probably serialized > wrong. A failing test is omitted since it would be pretty involved > (currently this code path is only hit with --stress-snapshot). > > Bug: v8:11111 > Change-Id: If7df98263cec9f82766c2fa6ba095b98b53a6fde > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657431 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80780} Bug: v8:11111 Change-Id: I5fc3384484f6a8d2d6e40a404da0bf04167abc1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678838 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
JialuZhang-intel authored
To eliminate unnecessary move instructions from register to fixed register. We check the fixed register hint for operands in move gaps when building LiveRanges. If a to_operand has a hint_operand (with fixed register), then set the hint_operand for from_operand too. This can avoid the register allocator ignore hint information about fixed register. Bug: v8:12909 Change-Id: I17f9afa484ee08de8ac1ab42945caba2c362fc9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669019Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jialu Zhang <jialu.zhang@intel.com> Cr-Commit-Position: refs/heads/main@{#80844}
-
Igor Sheludko authored
Fixes b/3074796. Change-Id: Ib8343702a7f9f8c912bcb5660ff9d0378b90d1f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676856 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
The fuzzer runs the same wire bytes through the streaming decoder and through synchronous compilation, and compares the result. In particular, if one fails, then also the other should fail. More checks for the result of both pipelines can be added later. R=ahaas@chromium.org Bug: v8:12922 Change-Id: I905adf740e581c4b7d0f4ab7c0d5d0e48d96fc4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675100Reviewed-by:
-
Dominik Inführ authored
WorkerThreads access the queue to get new tasks, that's why all of them need to stop before we can destroy the queue. This hopefully fixes the linked race/crash since I can't reproduce this locally. Bug: v8:12914 Change-Id: Icbfd462f106a4a1f0bbd525f0b7f342e9857a539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672421Reviewed-by:
-
Darius M authored
This is a reland of commit ab76ffc8. Original change's description: > [builtins] use SIMD IndexOf/includes on large arrays > > Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Darius Mercadier <dmercadier@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80771} Change-Id: I81dcf3c97a15b95fd42927ff8e91602f109db315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672418Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Replace all usages of UPDATE_WEAK_WRITE_BARRIER with UPDATE_WRITE_BARRIER. The barrier wasn't hot, so the additional branch for the marking barrier shouldn't be a problem. Performing the marking barrier could in theory cause more floating garbage. However in this case the write barrier is only run once directly after e.g. allocating a Code or NativeContext object. Since UPDATE_WEAK_WRITE_BARRIER only skips the marking barrier, we should only observe different behavior when marking is on. But since we already have black allocation for objects in old space, we will not cause additional floating garbage. In case of performance regression, we should also be able to replace those usages with SKIP_WRITE_BARRIER, since NativeContext and Code objects are never allocated in the young generation, so running the generational barrier shouldn't be necessary. It's just hard to DCHECK that SKIP_WRITE_BARRIER is valid here. Bug: v8:11708 Change-Id: I25d760a46d1d7ec973cc589f51ddf80ca3b5419d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663080Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I0196169d5bfe80df23179414f37c418db775cefb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663341 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Print polymorphic feedback, and include instance type in printed maps. Change-Id: I34b71fbd5c94a1b615b17646dcd7a729a4ff4eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677299Reviewed-by:
-
jameslahm authored
... disasm-loong64-unittest. Bug: v8:12781 Change-Id: I81b5ff789d8e5d7eb0ce8e4c6fa1531f52199918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676638Reviewed-by:
-
jameslahm authored
... disasm-pcc-unittest. Bug: v8:12781 Change-Id: I239c5101a0b978b0b824bac8e31a6e62b3e7e836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676639Reviewed-by:
-
jameslahm authored
... disasm-mips64-unittest. Bug: v8:12781 Change-Id: I5c4e2b95d4d30962c671c1f2a625f6e97fecad15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676640 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-riscv64-unittest. Bug: v8:12781 Change-Id: I0d4c0ffbda5757db6a6b906e9f51ce28bc5f6f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676641 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-arm-unittest. Bug: v8:12781 Change-Id: Ice4bafdf89e2eb9ddbef7b613eef1e6ceb56133b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676637Reviewed-by:
-
jameslahm authored
... diy-fp-unittest. Bug: v8:12781 Change-Id: I7cb996c095ec0c946ed2db311dfd815e1cbd459b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676643Reviewed-by:
-
jameslahm authored
... decls-unittest. Bug: v8:12781 Change-Id: I0c2915bade2b5a6f6eeeba3db81542d3220bcd66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676644 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-s390-unittest. Bug: v8:12781 Change-Id: I52155e0f6667202ce2f3c7bd59cb0031694edbc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676642 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
- 30 May, 2022 2 commits
-
-
Junliang Yan authored
Change-Id: I3bf465381df92dc2ec3181f1082463a2d7903854 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677332Reviewed-by:
-
Clark DuVall authored
Bug: chromium:1328448 Change-Id: If0c3d02070071b5bb25df5bca51cf8c4cfc424d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673420Reviewed-by:
-
