Commit 806748ac authored by Clark DuVall's avatar Clark DuVall Committed by V8 LUCI CQ

Allow BackgroundCompileTask to be created from a background thead

This will be useful for implementing crbug.com/1328448.

Bug: v8:12916
Change-Id: Id22ae96f6c1f9b72ab09508dd1f6dc2d70f8b5d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677654
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80863}
parent f22c7eb6
......@@ -2715,7 +2715,6 @@ ScriptCompiler::ScriptStreamingTask* ScriptCompiler::StartStreaming(
"Invalid CompileOptions");
if (!i::FLAG_script_streaming) return nullptr;
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
DCHECK_NO_SCRIPT_NO_EXCEPTION(i_isolate);
i::ScriptStreamingData* data = source->impl();
std::unique_ptr<i::BackgroundCompileTask> task =
std::make_unique<i::BackgroundCompileTask>(data, i_isolate, type,
......
......@@ -1545,12 +1545,7 @@ BackgroundCompileTask::BackgroundCompileTask(
timer_(isolate->counters()->compile_script_on_background()),
start_position_(0),
end_position_(0),
function_literal_id_(kFunctionLiteralIdTopLevel) {
VMState<PARSER> state(isolate);
LOG(isolate, ScriptEvent(V8FileLogger::ScriptEventType::kStreamingCompile,
flags_.script_id()));
}
function_literal_id_(kFunctionLiteralIdTopLevel) {}
BackgroundCompileTask::BackgroundCompileTask(
Isolate* isolate, Handle<SharedFunctionInfo> shared_info,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment