- 08 Feb, 2019 28 commits
-
-
Igor Sheludko authored
... in favor of [Full]MaybeObjectSlot and finally make deserializer pointer compression friendly. Bug: v8:8794 Change-Id: I23e5b119ccfe7d0c12c15a857978d89813e0522f Reviewed-on: https://chromium-review.googlesource.com/c/1460460 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59472}
-
Igor Sheludko authored
... and update the list of unused bytecodes. This CL also drops kInternalReferenceEncoded as all necessary details are already encoded in RelocInfo. Bug: v8:8794, v8:8562 Change-Id: Ia8aec1f4bcf9802fe15322bd6bb273218d8959fa Reviewed-on: https://chromium-review.googlesource.com/c/1460459 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Seth Brenith authored
When creating the results object for an exec call, V8 is calling into a runtime helper once per named capture group. It can instead create that object without any runtime calls, using existing CSA helpers. The only additional cost of this approach is that it internalizes the capture group names at regex compilation time, even if the script never calls exec on that regex. Bug: v8:6914 Change-Id: I58975b8d7aea05f8c67ae087608715099f62fc48 Reviewed-on: https://chromium-review.googlesource.com/c/1454268Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#59470}
-
Toon Verwaest authored
--parse-only only invokes the parser but does not compile / run the scripts --max-lazy ignores eager compilation hints from IIFE. Change-Id: Icd156cab16d796b9f676b95bb1542ad07c67546d Reviewed-on: https://chromium-review.googlesource.com/c/1460939 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59469}
-
Igor Sheludko authored
... and also loads of off-heap tagged values. Bug: v8:7703 Change-Id: I0dd15ecda76cc35fe5f2f51a7103937a7ac238dc Reviewed-on: https://chromium-review.googlesource.com/c/1459639 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59468}
-
Jaroslav Sevcik authored
Instead of eliminating bounds checks based on types, we introduce an aborting bounds check that crashes rather than deopts. Bug: v8:8806 Change-Id: Icbd9c4554b6ad20fe4135b8622590093679dac3f Reviewed-on: https://chromium-review.googlesource.com/c/1460461 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59467}
-
Georg Neis authored
Change-Id: Ie996f5da3f2f4a45b5664e33833362b8d13c476c Reviewed-on: https://chromium-review.googlesource.com/c/1460943Reviewed-by:
-
Ulan Degenbaev authored
This patch ensures that the serializer does not read the field of the DescriptorArray that can be changed concurrently by GC. Bug: v8:8803 Change-Id: I849fd2278abd228a46351ab18efb8bfd201ceafc Reviewed-on: https://chromium-review.googlesource.com/c/1458239 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Iad53e1a3b6ef0148dc5aa9c5c04c25c446dcdfa2 Reviewed-on: https://chromium-review.googlesource.com/c/1460468Reviewed-by:
-
Igor Sheludko authored
... as it's no longer needed. Bug: v8:8794, v8:8562 Change-Id: Ia5149bab33af219e5cdc6909af4688e53f1409fa Reviewed-on: https://chromium-review.googlesource.com/c/1460458 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This CL also stops using checked decompression for tagged values in TurboFan backend. Bug: v8:7703 Change-Id: I4ab7670301924a365a10bb78f43bce0bbf785862 Reviewed-on: https://chromium-review.googlesource.com/c/1459638Reviewed-by:
-
Igor Sheludko authored
... as it's no longer needed. Bug: v8:8794, v8:8562 Change-Id: Ifbc4f5f5d34f24ff4ba8f32309e8a032268c12c0 Reviewed-on: https://chromium-review.googlesource.com/c/1460457 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL renames field offsets from *Index to *Offset in the StackFrameInfo class for consistency. R=mstarzinger@chromium.org Bug: v8:8562 Change-Id: I9ccec3e6f924a4040d26dc677fdd1ec620cf0463 Reviewed-on: https://chromium-review.googlesource.com/c/1460937Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59460}
-
Georg Neis authored
It unnecessarily allowed for transitions in the presence of multiple receiver maps. Bug: v8:7790 Change-Id: I226f499f626ffb7c1b084aa5a45684e7782d1760 Reviewed-on: https://chromium-review.googlesource.com/c/1456088Reviewed-by:
-
Matheus Marchini authored
This is a reland of 97628eee. Original change's description: > [error] extend error stack w/ function parameters > > Extend FrameArray to hold weak references to parameters forfunctions in > the call stack. The goal here is to provide more metadata for postmortem > tools (such as llnode), especially in cases of rethrowing (this will be > particularly useful when using postmortem with promises on Node.js). > > Besides postmortem, these changes allow us to print a more detailed > stack trace for errors with parameters types (or even values), which can > be useful since JavaScript functions can receive any number of > parameters of any type, and having a function behave differently > according to the number of parameters received as well as their types is > a common pattern on JS libraries and frameworks. > > R=<U+200B>bmeurer@google.com, yangguo@google.com > > Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61 > Reviewed-on: https://chromium-review.googlesource.com/c/1289489 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58468} R=bmeurer@google.com, jkummerow@chromium.org, yangguo@google.com Change-Id: I53d90bb862d9c5e9541116b375fa4de70e3e76dd Reviewed-on: https://chromium-review.googlesource.com/c/1405568 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... as they are no longer needed. Bug: v8:8794, v8:8562 Change-Id: Ib5d87fce9834839410b0dffce95b4a8ae4f946cc Reviewed-on: https://chromium-review.googlesource.com/c/1460456Reviewed-by:
-
Benedikt Meurer authored
This adds a new %ClearMegamorphicStubCache() runtime function, which can be used to easily wipe the megamorphic stub cache. This is useful when investigating performance issues that are related to high contention on the megamorphic stub cache. Change-Id: I7abb496bf1dd658298a90065241dd317f2fb6624 Reviewed-on: https://chromium-review.googlesource.com/c/1459637 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
This allows the embedder to use a shared library build even if they use this method. R=ulan@chromium.org Change-Id: I613a6e5eb82b494128fb95dc89a0b73639ac5ca2 Reviewed-on: https://chromium-review.googlesource.com/c/1456042Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59455}
-
Gus Caplan authored
This is a reland of d7def900 Original change's description: > Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation" > > This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Original change's description: > > [builtins] [turbofan] Refactor Float64Pow to use single implementation > > > > Remove platform-specific Float64Pow implementations and utils Pow in > > favor of a base::ieee754::pow implementation. > > > > This unifies the implementation of pow for the compiler, wasm, and > > runtime. > > > > Bug: v8:5848, v8:5086 > > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403018 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59229} > > Bug: v8:5848, v8:5086 > Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e > Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1447854 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59411} Tbr: neis@chromium.org, bmeurer@chromium.org, jkummerow@chromium.org Bug: v8:5848, v8:5086 Change-Id: I42972b29b8830ed47a00b2b1d408d3005a810c0e Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1456302Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59454}
-
Tamer Tas authored
Presubmit script complains when an unformatted Torque file is submitted. This CL automates the formatting process of the Torque files. Presubmit script is run before every 'git cl upload', the workflow will make sure that the upload is canceled, but the files are formatted. Bug: chromium:898436, v8:8805 Change-Id: I821ce36907c62e222451e883c5e3e18a9359f20e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1458222Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59453}
-
Dan Elphick authored
Mark Context version of BooleanValue as V8_DEPRECATED. Bug: v8:7279, v8:8562 Change-Id: I152f5080d92a940dadea9e8f2ed3f25338e6f099 Reviewed-on: https://chromium-review.googlesource.com/c/1458245Reviewed-by:
-
Clemens Hammacher authored
The new API receives a unique_ptr to avoid leaking the Extension object. All chromium uses were refactored in https://crrev.com/c/1447652. R=adamk@chromium.org Bug: v8:8725 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I46a931a73e941fe7b78f5390fec74663677e13e4 Reviewed-on: https://chromium-review.googlesource.com/c/1454723Reviewed-by:
-
Mythri authored
This cl: https://chromium-review.googlesource.com/c/v8/v8/+/1421077 changed the implementation of SetProperty to infer the language mode. Language mode is only required when there is an error to decide if we have to throw an error or not. However we used to compute language mode eagerly for PropertyCallbackInfo. This causes regressions in some benchmarks. This cl changes it by deferring it further by computing it only when it is actually required. BUG: v8:8580, chromium:925289 Change-Id: Iba70ec5f9bb3deec16414a1ec418b3963f2144f9 Reviewed-on: https://chromium-review.googlesource.com/c/1454608Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Toon Verwaest authored
As requested in https://chromium-review.googlesource.com/c/v8/v8/+/1448313 Change-Id: I89e84600aa4cd3feef3dbf4f5acdaf377e3446f8 Reviewed-on: https://chromium-review.googlesource.com/c/1460463Reviewed-by:
-
Yang Guo authored
This reverts commit 734a6575. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/29872 Original change's description: > Do not enqueue or run a microtask on detached contexts > > This CL disables EnqueueMicrotask and RunMicrotasks on detached > contexts. That is, if an embedder call DetachGlobal() on a v8::Context, > EnqueueMicrotask on that context will not take effect, and all Microtask > that is enqueued before DetachGlobal will be cancelled. > > On Blink, this implies that a frame will no longer run a microtask after > it's navigated away. OTOH, detached frames in Blink are not affected. > > Bug: v8:8124 > Change-Id: I5b00ceef5ea2afb87cf067a65eb95c29bf91176d > Reviewed-on: https://chromium-review.googlesource.com/c/1416071 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59445} TBR=yukishiino@chromium.org,adamk@chromium.org,yangguo@chromium.org,bmeurer@chromium.org,verwaest@chromium.org,tzik@chromium.org Change-Id: I9f5b703e7101aa3c251fe03ed4b52e9d71ae605a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8124 Reviewed-on: https://chromium-review.googlesource.com/c/1460466Reviewed-by:
-
Tamer Tas authored
chromium/buildtools repo was moved and broke the V8 auto-roller. This CL corrects the old-path. Failed-Roll: https://chromium-review.googlesource.com/c/v8/v8/+/1459743 R=machenbach@chromium.org,sergiyb@chromium.org CC=yangguo@chromium.org Bug: chromium:930050 Change-Id: I969c73c13bfa996b1010971c37d9325c22048c0a Reviewed-on: https://chromium-review.googlesource.com/c/1460464 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59447}
-
Frank Tang authored
Cache up to 8 Calendar Cache up to 8 SimpleDateFormat Improve another ~12% (x1.12) $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json ... NewIntlDateTimeFormat-Intl(Score): 104 ... Compare to baseline in https://chromium-review.googlesource.com/c/v8/v8/+/1457603 Bug: chromium:928098 Change-Id: Ib3d2d3af1a84c4a856b9e0a40dc06a34aa5d9c71 Reviewed-on: https://chromium-review.googlesource.com/c/1459476 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
tzik authored
This CL disables EnqueueMicrotask and RunMicrotasks on detached contexts. That is, if an embedder call DetachGlobal() on a v8::Context, EnqueueMicrotask on that context will not take effect, and all Microtask that is enqueued before DetachGlobal will be cancelled. On Blink, this implies that a frame will no longer run a microtask after it's navigated away. OTOH, detached frames in Blink are not affected. Bug: v8:8124 Change-Id: I5b00ceef5ea2afb87cf067a65eb95c29bf91176d Reviewed-on: https://chromium-review.googlesource.com/c/1416071Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 07 Feb, 2019 12 commits
-
-
Frank Tang authored
$ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json ... NewIntlDateTimeFormat-Intl(Score): 92.9 Compare to baseline in https://chromium-review.googlesource.com/c/v8/v8/+/1455727 improve another x3.5 Bug: chromium:928098 Change-Id: Iab6b9e2d58231832c54bc626d01b25a3813537fa Reviewed-on: https://chromium-review.googlesource.com/c/1457603Reviewed-by:
-
Igor Sheludko authored
... and use RelocInfo iteration instead of skip-and-unaligned-write sequences. This is a step towards avoiding unaligned stores via UnalignedSlot. Various cleanup CLs will follow. Bug: v8:8794 Change-Id: I62faedfa1c1ababe4b185fa8d7f2c6c1baa5cf79 Reviewed-on: https://chromium-review.googlesource.com/c/1456579 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This makes the existing error message tests also test the error produced by asynchronous compilation and instantiation. It also slightly tweaks the error message to contain the name of the API function invoked instead of "WebAssembly Instantiation". R=titzer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Bug: chromium:926311 Change-Id: If4ab963cee8267d43b289169d21b31637c471d6d Reviewed-on: https://chromium-review.googlesource.com/c/1456085 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59442}
-
Ujjwal Sharma authored
Port String.prototype.endsWith from a CPP builtin to a Torque builtin. Spec: https://tc39.github.io/ecma262/#sec-string.prototype.endswith Bug: v8:8400 Change-Id: I4ac8cb92acb68389db844deaecc9ae1c6e7d6bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1454677 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59441}
-
Jaroslav Sevcik authored
This is a reland of 78ed0e3f The breakage was unrelated to constant field tracking (see the linked bugs). Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} Bug: v8:8361, v8:8799, v8:8801 Change-Id: I318768b925f3efd285cb27aa93e6de35fdcced42 Reviewed-on: https://chromium-review.googlesource.com/c/1458238Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59440}
-
Andreas Haas authored
R=titzer@chromium.org Bug: v8:7581 Change-Id: I857a40a0f955b3506d7958d2128a1b4560cff0bc Reviewed-on: https://chromium-review.googlesource.com/c/1458236 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The Size() includes the page header. Bug: chromium:852420 Change-Id: I1f2da2309ff38f2222c82b5758937bdaf5036f12 Reviewed-on: https://chromium-review.googlesource.com/c/1458242Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59438}
-
Tamer Tas authored
The test name alone isn't informative alone. This CL prints the variant name during the progress reporting. tested by running test262 with all variants R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I3d7d1fc6eacef3712d87404c7276fd5523bb445a Reviewed-on: https://chromium-review.googlesource.com/c/1458156 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Junliang Yan authored
the DCHECK in set_constant_pool_offset fails due to the InstructionSize() needs builtin_index() Change-Id: Ic3f2a72d4f481ba9d5413c1bcfdd95b8bb107782 Reviewed-on: https://chromium-review.googlesource.com/c/1456309Reviewed-by:
-
Sigurd Schneider authored
Drive-by: Refactor FlushInstructionCache to its own header. This removes dependencies of objects.cc and code.cc Bug: v8:8562 Change-Id: If23f3b9d4f2068e08c61c0f4b070ecfe1b9a6cc0 Reviewed-on: https://chromium-review.googlesource.com/c/1456081Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59435}
-
Michael Starzinger authored
This unifies how continuations after a control transfer are handled within the interpreter loop. To avoid bumping the {pc} we can either reset the opcode length to zero or just "continue" the loop. This just unifies the approach for the entire {Execute} method. R=clemensh@chromium.org Change-Id: Ifc33c3a87cff69d417f61fa0bc234260c7fa502a Reviewed-on: https://chromium-review.googlesource.com/c/1458216 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Ulan Degenbaev authored
The new scheduling reduces the main thread marking performed in tasks and on allocation. It is based on two counters: - bytes_marked, - scheduled_bytes_to_mark. The bytes_marked accounts marking done both the main thread and the concurrent threads. The scheduled_bytes_to_mark increases based on allocated bytes and also based on time passed since the start of marking. The main thread steps are allowed to mark the minimal amount if bytes_marked is greater than scheduled_bytes_to_mark. This also changes tasks posted for marking. Before only normal tasks were posted. Now delayed tasks are posted if the marker is ahead of schedule. Bug: 926189 Change-Id: I5bc9c33a5ecfc9f8d09f78d08ae277d16a2779ca Reviewed-on: https://chromium-review.googlesource.com/c/1443056 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
