• Yang Guo's avatar
    Revert "Do not enqueue or run a microtask on detached contexts" · df5c72b0
    Yang Guo authored
    This reverts commit 734a6575.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/29872
    
    Original change's description:
    > Do not enqueue or run a microtask on detached contexts
    > 
    > This CL disables EnqueueMicrotask and RunMicrotasks on detached
    > contexts. That is, if an embedder call DetachGlobal() on a v8::Context,
    > EnqueueMicrotask on that context will not take effect, and all Microtask
    > that is enqueued before DetachGlobal will be cancelled.
    > 
    > On Blink, this implies that a frame will no longer run a microtask after
    > it's navigated away. OTOH, detached frames in Blink are not affected.
    > 
    > Bug: v8:8124
    > Change-Id: I5b00ceef5ea2afb87cf067a65eb95c29bf91176d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1416071
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59445}
    
    TBR=yukishiino@chromium.org,adamk@chromium.org,yangguo@chromium.org,bmeurer@chromium.org,verwaest@chromium.org,tzik@chromium.org
    
    Change-Id: I9f5b703e7101aa3c251fe03ed4b52e9d71ae605a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8124
    Reviewed-on: https://chromium-review.googlesource.com/c/1460466Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59448}
    df5c72b0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...