- 18 Jan, 2021 14 commits
-
-
Seth Brenith authored
Heap-profiler changes: Currently, a whole lot of types are all reported as just "system" in heap snapshots. With this change, we can use Torque-generated macro lists to easily report type names such as "system / BytecodeArray". Those objects still show up in a single category named "(system)" in the dev tools UI, so they don't clutter the output. For V8 developers or anybody who is interested in an extra-detailed view, this change also includes a runtime flag that instructs V8 to upgrade nodes of type kHidden to type kNative. After a snapshot is collected with this flag enabled, the dev tools UI then shows each internal object type separately. Torque changes: Currently, Torque emits several macro lists containing pairs of (ClassName, CLASS_NAME_TYPE) which can be used to associate instance types with Torque class names. However, some Torque classes are not included in any of these three lists. In cases like the heap profiler, it would be nice to easily generate a complete list including every instance type, so this CL includes two changes: - Include classes in TORQUE_INSTANCE_CHECKERS_MULTIPLE_FULLY_DEFINED even if they're not marked `extern`. I'm not sure what exactly we were hoping to accomplish in filtering by extern-ness, but it's simpler not to and slightly reduces clutter in a couple of files that use that macro list. - Add a fourth macro list for the previously-ignored category: classes which have their own instance type (are not `abstract`), and have subtypes, but do not have their fields defined in Torque. This list contains just a single item (HashTable), but I like the consistency of generating the full set of lists. Change-Id: Ib24953e12ed13ce353206bbec23a52d8f684dfcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610172 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72138}
-
Marja Hölttä authored
This saves memory (the home object doesn't need to be stored for each method, but only once per class) and hopefully makes the home object a constant in the optimized code. Detailed documentation of the changes: https://docs.google.com/document/d/1ZVXcoQdf9IdMsnRI9iyUjyq9NDoEyx9nA3XqMgwflMs/edit?usp=sharing Bug: v8:9237 Change-Id: Ia0925bdc8bfe54cbefcba6d10f64746d63a530c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563275 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72137}
-
Thibaud Michaud authored
R=ahaas@chromium.org,mark@chromium.org,mseaborn@chromium.org Bug: v8:11098 Change-Id: Ic4eb02a96805e49da71f301269567a6e0ac1b843 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519555 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#72136}
-
Junliang Yan authored
Change-Id: Ia8e8600cabb7e317befca480e734915239e10f69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2634828Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72135}
-
Nico Hartmann authored
This reverts commit ff606a06. This fix makes a handle persistent that was missing in the original CL. Bug: v8:7790, chromium:1158322 Change-Id: I53079f5c32523313cff76130d2a40c3de5bb0638 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629270 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72134}
-
Victor Gomes authored
Removes: - v8_disable_arguments_adaptor GN flag - ArgumentsAdaptorTrampoline - ArgumentsAdaptorFrame class Change-Id: I382ebe6c25c3c172bee5df3e86e762fca10fa392 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622911Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Backes authored
memory.size returns in i64 if memory64 is enabled. This CL fixes typing and adds a decoder test. Execution will be tested and fixed in a follow-up CL. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: I15818a6273b579d0faacec7f77dc813ae9ba218f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632593Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72132}
-
Clemens Backes authored
For memory64, the init expressions for data segments provide a 64-bit value. This CL adds a new {EvalUint64InitExpr} function alongside {EvalUint32InitExpr}. It supports i64.const and global.get operations. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: I58acbb28acb8771a0947f9d5df1c14e6ca0f79cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632589Reviewed-by: -
Sami Kyostila authored
If V8 is running in a context where Perfetto hasn't been initialized (e.g., as part of mksnapshot), don't try to initialize track events either. Since perfetto::Tracing::IsInitialized() was only added recently, we also roll Perfetto to the latest revision. This also requires updating the proto_library GN template together with the underlying libprotobuf dependency. Bug: chromium:1006541 Change-Id: Icec626b7ed78264a81f1a80d73d60be3bde0d908 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632590 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
The feedback_vector/cell and code fields of a JSFunctionRef are only used when generating code for the function (e.g., for the function being optimized or inlined functions). This CL explicitly serializes these fields only when the function will be used for codegen, otherwise avoiding their serialization. BUG=v8:7790,v8:9684 Change-Id: If76bc0b77e51aa10517699e0a9198358fe77f009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2617083Reviewed-by:
-
Mythri A authored
This cl: https://chromium-review.googlesource.com/c/v8/v8/+/2632588 introduced a bug by bailing out early if we have top tier code early. However, we still need to check if the frame is still interpreted so that we could OSR. The early bailout isn't correct and also the DCHECK isn't correct. This cl removes both. Bug: chromium:1167638, v8:9684 Change-Id: I5a4aa406b05b6cbb5f98b63e015298c5b45160eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632696Reviewed-by:
-
Clemens Backes authored
We are working on getting Liftoff feature complete. Eventually, bailout should only happen if experimental features are enabled. Until we are there, we also need to allow some more bailouts, which should be removed in the near future. This CL adds a check for expected bailout reasons. The new function serves as a burndown list of issues to be fixed. Drive-by: Make some methods constexpr such that they can be used in static assertions. R=ahaas@chromium.org Change-Id: I5d3cd8f49a30d01f89ac6cf5321e1314b63eba40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629513 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Jakob Gruber authored
FrameState parameters must not be iterated directly since parameters can be encoded into StateValues (i.e. parameter i is not necessarily InputAt(i)). Instead, they should be accessed through the StateValuesAccess helper class. One example: 82: StateValues[sparse:^^^^^^](81, 31, 32, 33, 34, 35) 81: StateValues[sparse:^^^^^^^^](110, 24, 25, 26, 27, 28, 29, 30) 31: NumberConstant[8] 32: NumberConstant[9] 33: NumberConstant[10] 34: NumberConstant[11] 35: NumberConstant[13] Here, node 81 holds multiple parameters. These are properly iterated by the StateValuesAccess class. Bug: chromium:1166136 Change-Id: I12725f83994e1c05571bcba153ff45154b16d93f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625879 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3ecdb5e..43dd249 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f46e9e7..cf567b6 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22b2eb5734c9578289d1700b1fae88f2c338d3e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2635361Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72125}
-
- 16 Jan, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/670a905..3ecdb5e Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/235cfe4..c38b5ab Rolling v8/buildtools/linux64: git_revision:595e3be7c8381d4eeefce62a63ec12bae9ce5140..git_revision:d62642c920e6a0d1756316d225a90fd6faa9e21e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b2af2da..f46e9e7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/091f5ac..dabd965 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib0c53b119f960f4d8d41d7bd1b4355ea82b0b009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632878Reviewed-by:
-
- 15 Jan, 2021 18 commits
-
-
Santiago Aboy Solanes authored
This reverts commit 3a6f75ac. Reason for revert: performance regressions https://bugs.chromium.org/p/chromium/issues/detail?id=1163063 Original change's description: > [objects] Remove MakeExternal case for uncached internal strings > > Concurrently accessing internal external uncached strings is not > thread-safe. We are removing a case where we can make such a string > through MakeExternal. > > Bug: v8:7790 > Change-Id: I958062c15cf40ccc330600bb572de98620866e54 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565511 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71573} TBR=leszeks@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: I5dcc734869c3c921eacd89426309141127a85f47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633547Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72123}
-
Santiago Aboy Solanes authored
This reverts commit b3d09001. Reason for revert: https://chromium-review.googlesource.com/c/v8/v8/+/2565511 has to be reverted, and this was a follow-up to that Original change's description: > [objects] Remove uncached internal external string type > > We shouldn't be creating those anymore since they are not thread-safe. > > Bug: v8:7790 > Change-Id: I4546d995fa32eb076c8dfe9d95301fad719c9e07 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615347 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72006} TBR=rmcilroy@chromium.org,leszeks@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: I4eb1a6b8446fa602eeb5bf29fbf1fe57182cdbf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2627605Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72122}
-
Andreas Haas authored
R=thibaudm@chromium.org Bug: v8:7581 Change-Id: I717466f045473015c8d99d1e640492486d05a832 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625886 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72121}
-
Michael Lippautz authored
Context objects are allocated on the heap and thus should be Data objects. This allows handling them through tracing in the GC through the API. Bug: chromium:1013149 Change-Id: Id3a7bfd57fab19a5669062ccf61c2f8588faf0bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2627307Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72120}
-
Andreas Haas authored
There is an implication from --predictable => --single-threaded => --no-wasm-tier-up. This implication introduces conflicting flags for all tests that set --wasm-tier-up. This CL disables all these tests. R=machenbach@chromium.org Bug: v8:11319 Change-Id: I32452d74ae33fc0e081971c5c0ed840334f274d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632598 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72119}
-
Thibaud Michaud authored
Replace 0x16 with 0x18 for the delegate opcode, to avoid a conflict with the function reference proposal. See https://github.com/WebAssembly/exception-handling/issues/145 R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ib012f8680dfece200973e18fdf6c82877f10d5de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632604Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72118}
-
Sathya Gunasekaran authored
I haven't done any test262 rolls in forever and won't be doing any for the foreseeable future, there's no need for me to be an OWNER. Change-Id: I51d5915f5704d0c15c0735c95cfbff9464a0e929 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632592 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72117}
-
Thibaud Michaud authored
Exception ref is not part of the latest exception handling proposal. Remove the corresponding value type, the type opcode and some obsolete tests. R=clemensb@chromium.org Bug: v8:8091 Change-Id: I5e068ba3426f4b56b90ef056193acdd8cc8fe7d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632599Reviewed-by:
-
Bill Budge authored
This is a reland of 2f3cda58 GetFirstUnusedStackSlot is restored, and used for finding the padding slot location, if any. Original change's description: > [compiler] Rework calculation to start of return slots > > - Changes GetOffsetToReturns to take into account return slot padding > and argument padding. > - Changes GetStackParameterDelta to use GetOffsetToReturns for the SP > delta calculation. > - Removes GetFirstUnusedStackSlot. > > Change-Id: I13df72e86750c62798bae262f0560cf1d7f981db > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593306 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72078} Change-Id: I954d7e7487728dbd6a545a6c84efb8f8f65d894d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626979Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 37c3e05e. Reason for revert: https://chromium-review.googlesource.com/c/v8/v8/+/2565511 has to be reverted, and this was a follow-up to that Original change's description: > [test] Update MakeExternal tests > > They weren't initializing the VM at the start of the test. Also updated > the test description. > > Bug: v8:7790 > Change-Id: I7b9df9e3aebb43fc526e16ec260aa071c0fdeb92 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615019 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71978} TBR=leszeks@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: I35bc0090c3beed4ef11a458f0e26c44b22f7b654 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2627606Reviewed-by:
-
Andreas Haas authored
Liftoff is not fully feature complete yet. To test that Liftoff can bailout to TurboFan also for debugging, this CL adds * an opcode that is only implemented in TurboFan * a flag that allows that opcode to be compiled with TurboFan * a bailout for this opcode to Liftoff. R=clemensb@chromium.org Bug: v8:7581 Change-Id: Ie4b4654d0d36ab937a7dfe9b1bb6a187b17615fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629284 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Alex Kodat authored
76217f57 fixed the profiler so it would only sample a thread if it had the Isolate lock. Unfortunately, this fix missed a timing window where a thread might have the Isolate lock but might not have restored the thread-specific data such as thread_local_top_ for the locked thread yet, so the sampler might end up using data from a different thread. This doesn't cause any seg faults or the like because the thread we *meant* to sample has the Isolate lock so the thread we're accidentally sampling can't mess with any Isolate data but we can still get incorrect sample data which can be especially obvious if the accidentally sampled thread is inside code that would never run on the thread we meant to sample. Fortunately, we can tell when all thread-specific data has been restored to the Isolate because thread_state_ in the PerIsolateThreadData for a thread is set to a non-null value until everything has been restored, at which point it gets set to null. So the fix adds a check after the test for the Isolate lock to check if thread_state_ is null for the thread we mean to sample. If so, we know all the data in the Isolate is good to go for sampling. Bug: v8:11316 Change-Id: I02d6361d8cbd6ec809ad8fb7ef07f5e9c94c7d1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2628133Reviewed-by:
-
Andreas Haas authored
R=zhin@chromium.org Change-Id: Ibf94191615d0081f089065e59c78b685e68f5bae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629507 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Mythri A authored
This is a reland of e38cb757. This was reverted as a potential culprit for a wasm failure. The actual revert that fixed the bots is here: https://chromium-review.googlesource.com/c/v8/v8/+/2630736. This should be safe to reland. I verified locally that the test is failing with or without this change. Original change's description: > [turboprop] Enable tierup to TurboFan with FLAG_turboprop > > FLAG_turboprop was used to test the turboprop compiler without any > further tierup to TurboFan. This cl changes: > - FLAG_turboprop to also tier up to TurboFan. > - Introduces FLAG_turboprop_as_toptier to continue running the > configuration without tierup. > - Removes FLAG_turboprop_as_midtier which is same as FLAG_turboprop. > > Bug: v8:9684 > Change-Id: I487bda13d226434837770ecc43b3ced7c31ccf19 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622214 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72101} Bug: v8:9684 Change-Id: I8b61fd8e562190c3c7bf5a003273f2a058542dad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632588 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Liu Yu authored
Implement i64x2 widen i32x4, and saturating rounding multiply high. Port: 9cb7e571 Port: 39f2e3de Change-Id: Ib88aca3e3f66eb4a12be4d2cf4e51ac930849cc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632353Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72109}
-
Liu Yu authored
Port: 646bdbf8 Bug: v8:10972 Change-Id: I9b199dc75d0e759a768da55298af383ebeb30e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632351 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d64e599..670a905 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/178c01b..b2af2da Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/64d94de..091f5ac Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b12d1c8..ba4ee03 Rolling v8/tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 Rolling v8/tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 Rolling v8/tools/luci-go: git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9..git_revision:77944aa535e42e29faadf6cfa81aee252807d468 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4615747dd11f2ce6c969dfa7f4cf661198d4c5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2631788Reviewed-by:
-
Zhi An Ng authored
Prototype load lane instructions on ARM Liftoff. We had a helper function for load lane that was living in instruction-selector. Move it out to assembler-arm so we can reuse that in Liftoff. Bug: v8:10975 Change-Id: Ic6e15c23eb778fb94a882609be622d2ca1f61ddb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614225 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72106}
-
- 14 Jan, 2021 7 commits
-
-
Ben Noordhuis authored
Remove the ambient dependency on the currently entered isolate, let the embedder pass it in explicitly. Bug: v8:11287 Change-Id: I03690390a308a59e2c6ea5c6ae268780d836b717 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2608209Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#72105}
-
Milad Fa authored
Port f9e76d6d Original Commit Message: - Modify InstructionSelectors to track both padding and multiple slot values to correctly adjust stack pointers when pushing arguments. Pass stack offset as an immediate operand. - Modify CodeGenerators to handle alignment padding. R=bbudge@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I639b6394f33e5e694882cb98c43b58edf5d93775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629947Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72104}
-
Francis McCabe authored
This reverts commit 7fc1351b. Reason for revert: creating new flakiness? See https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/13052 Original change's description: > [wasm] Unskip a test > > Debugging with multiple isolates involved is fixed now, thus unskip the > test. > > R=thibaudm@chromium.org > > Bug: v8:10359, v8:10099 > Change-Id: I0134fe9da21c86dd40a559dbd4cf8c998a70be20 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629512 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72099} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: Ie328a3af76ba2070cbd0971395d6414d48f4d973 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10359 Bug: v8:10099 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2630736Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72103}
-
Francis McCabe authored
This reverts commit e38cb757. Reason for revert: Test failing: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8858103866497469056/+/steps/Check/0/logs/tier-down-to-liftoff/0 Original change's description: > [turboprop] Enable tierup to TurboFan with FLAG_turboprop > > FLAG_turboprop was used to test the turboprop compiler without any > further tierup to TurboFan. This cl changes: > - FLAG_turboprop to also tier up to TurboFan. > - Introduces FLAG_turboprop_as_toptier to continue running the > configuration without tierup. > - Removes FLAG_turboprop_as_midtier which is same as FLAG_turboprop. > > Bug: v8:9684 > Change-Id: I487bda13d226434837770ecc43b3ced7c31ccf19 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622214 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72101} TBR=rmcilroy@chromium.org,mythria@chromium.org,jgruber@chromium.org Change-Id: Ic3e87c311fba001460e4f1561a2e5f74391a06a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2630526Reviewed-by:
-
Mythri A authored
FLAG_turboprop was used to test the turboprop compiler without any further tierup to TurboFan. This cl changes: - FLAG_turboprop to also tier up to TurboFan. - Introduces FLAG_turboprop_as_toptier to continue running the configuration without tierup. - Removes FLAG_turboprop_as_midtier which is same as FLAG_turboprop. Bug: v8:9684 Change-Id: I487bda13d226434837770ecc43b3ced7c31ccf19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622214 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 16e5dca3. Reason for revert: https://chromium-review.googlesource.com/c/v8/v8/+/2565511 has to be reverted, and this was a follow-up to that Original change's description: > [compiler] Mark String as kNeverSerialized > > Bug: v8:7790 > Change-Id: I2deb462c3467f7239d55b0f295feed1de5ca1c2f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616198 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72010} TBR=neis@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: Ie8b628fc5d0b0d90637515d7d3a2f1a9f64a0a09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629747Reviewed-by:
-
Clemens Backes authored
Debugging with multiple isolates involved is fixed now, thus unskip the test. R=thibaudm@chromium.org Bug: v8:10359, v8:10099 Change-Id: I0134fe9da21c86dd40a559dbd4cf8c998a70be20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2629512Reviewed-by:
-
