• Jakob Gruber's avatar
    [compiler] Use StateValuesAccess to access frame state parameters · 0ef84f99
    Jakob Gruber authored
    FrameState parameters must not be iterated directly since parameters
    can be encoded into StateValues (i.e. parameter i is not necessarily
    InputAt(i)). Instead, they should be accessed through the
    StateValuesAccess helper class.
    
    One example:
    
     82: StateValues[sparse:^^^^^^](81, 31, 32, 33, 34, 35)
      81: StateValues[sparse:^^^^^^^^](110, 24, 25, 26, 27, 28, 29, 30)
      31: NumberConstant[8]
      32: NumberConstant[9]
      33: NumberConstant[10]
      34: NumberConstant[11]
      35: NumberConstant[13]
    
    Here, node 81 holds multiple parameters. These are properly iterated
    by the StateValuesAccess class.
    
    Bug: chromium:1166136
    Change-Id: I12725f83994e1c05571bcba153ff45154b16d93f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625879
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72126}
    0ef84f99
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...