- 13 Jun, 2022 2 commits
-
-
Clemens Backes authored
Add a new --wasm-max-module-size flag to replace the unused and more specific --experimental-wasm-allow-huge-modules flag. The new flag can be used in fuzzers to reduce the maximum allowed module size, avoiding OOM on some systems (like 32-bit ASan builds). R=ahaas@chromium.org Bug: chromium:1334577 Change-Id: I2830d407c5b01be21a47b21392c1210061c40b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695267Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81102}
-
Simon Zünd authored
This CL extends the live edit mechanism to allow editing the function that is currently on top of the stack, as long as that call frame is the only activation of that function. The CL changes how we look for functions on the current JS stack: Instead of starting at thread_local_top we start at the frame we are currently paused in. This is possible since there can not be any JavaScript frames above the current "break frame", only C++ frames which are not relevant for live edit. If the edited script modifes the top-most function, the inspector will trigger a restart of that call frame. That is why we check if we can actually restart the function and only allow the live edit to go through if that is the case. Note that this CL also adds a kill switch in the form of a runtime flag for this feature, in case we need to pull the plug and disable this feature again via back-merge. R=jarin@chromium.org Bug: chromium:1334484 Change-Id: I711913df96c8acc786ad4de28de804d2f90e1847 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695353Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#81097}
-
- 09 Jun, 2022 2 commits
-
-
Clemens Backes authored
After flags are frozen, this will not work any more. It's also not required, as flags cannot be accessed after teardown anyway. This CL changes that to only release the memory of dynamically allocated string flags, which is something we still need to do after write-protecting the flags anyway. R=tebbi@chromium.org Bug: v8:12887 Change-Id: Iff0e3845cbd91fb59878b2ed36a44d6df00572f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695379Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81030}
-
Clemens Backes authored
The getters and setters were not using the correct types for the casts of {valptr_} and {defptr_}. It was mostly fine though, because {FlagValue<T>} just wraps a {T}, so accessing a {FlagValue<T>*} as a {T*} just works. This CL fixes the casts of {valptr_} to use proper {FlagValue<T>*}, and changes the definition of the default values to use plain {T} instead of {FlagValue<T>}. R=tebbi@chromium.org Bug: v8:12887 Change-Id: I3a38ba466df95a4c7b45e83fbd5d37c9a4785a13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695558Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81029}
-
- 08 Jun, 2022 4 commits
-
-
Clemens Backes authored
This is a reland of commit abcb6bb8. The data race is fixed by using atomic operations. Original change's description: > [heap] Avoid dynamic updates of FLAG_gc_interval > > Flags will be protected from updates after V8 initialization (in the > future). This CL avoids any updates of the --gc-interval flag during > runtime, and instead updates a static field on the HeapAllocator > directly. > > R=mlippautz@chromium.org > > Bug: v8:12887 > Change-Id: I17a495cae50a46d59a8159c6ece1558d4d61b949 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687691 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80998} Bug: v8:12887 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: Ib5b537500413a627d9b2509354d20906e0474d8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695380Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81008}
-
Manos Koukoutos authored
This reverts commit abcb6bb8. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/20029/overview Original change's description: > [heap] Avoid dynamic updates of FLAG_gc_interval > > Flags will be protected from updates after V8 initialization (in the > future). This CL avoids any updates of the --gc-interval flag during > runtime, and instead updates a static field on the HeapAllocator > directly. > > R=mlippautz@chromium.org > > Bug: v8:12887 > Change-Id: I17a495cae50a46d59a8159c6ece1558d4d61b949 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687691 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80998} Bug: v8:12887 Change-Id: I18310a3f515506d617f42be7a208013957625eaf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695559Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Owners-Override: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81002}
-
Clemens Backes authored
Flags will be protected from updates after V8 initialization (in the future). This CL avoids any updates of the --gc-interval flag during runtime, and instead updates a static field on the HeapAllocator directly. R=mlippautz@chromium.org Bug: v8:12887 Change-Id: I17a495cae50a46d59a8159c6ece1558d4d61b949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687691 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80998}
-
Igor Sheludko authored
... by default when fast W^X is enabled. Bug: v8:12054 Change-Id: I242567a07aa323127e5f7cdcbf3a1a7d5708b923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688518 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80995}
-
- 07 Jun, 2022 1 commit
-
-
Dominik Inführ authored
https://crrev.com/c/3471854 already disabled the RecordWrite builtin specifically for incremental marking. Since this didn't regress performance as expected, we can now remove those versions of the builtin. This will simplify the barrier implementation a bit, but is also required for the shared heap write barrier. Unlike the generational barrier, the shared heap barrier can't be elided for map values. Bug: v8:11708 Change-Id: I44bc6ee79006a5be8c1b593dee7fc30c3b9cfa85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683341Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80966}
-
- 03 Jun, 2022 1 commit
-
-
Clemens Backes authored
Extend the effect of --freeze-flags-after-init to also protect updates of individual flags instead of only the API. For this, we wrap each flag in a {FlagValue} class which implicitly converts to the value of the flag. Some cases still require the explicit {value()} accessor though. That accessor is {constexpr}, in contrast to the implicit conversion, because otherwise clang emits a lot of warnings about dead code within "if (FLAG...)" scopes. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I87d3457e49ceb317d34d6a21cf09c520d4171eb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683321Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80938}
-
- 02 Jun, 2022 3 commits
-
-
Clemens Backes authored
Use the existing {base::Optional} instead of the extra {MaybeBoolFlag} struct. This makes writing to a maybe-flag simpler because you just write a boolean value and that automatically initializes the optional. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I940d20286d65ba4355dc04b4b6068a306706f295 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686412Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80915}
-
Clemens Backes authored
This adds a new flag to freeze all flag values after initializing V8. For now, the only effect is that future calls to {SetFlagsFromString}, {SetFlagsFromCommandLine} or {EnforceFlagImplications} will fail. In the future (once tests and embedders are fixed to not change flags after initialization) we plan to actually protect flag values via memory protection. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I7974bb9b86715694122f788e08952f7dcc3acdbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679099 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80914}
-
Manos Koukoutos authored
We introduce a typing phase into the Turbofan compilation pipeline for wasm-gc. It has two functionalities: (1) to type nodes that were not typed during code generation (mainly phi nodes) and (2) to narrow types as much as possible. The following nodes are handled, which should be enough for our purposes: TypeGuard, WasmTypeCast, AssertNotNull, Phi, LoadFromObject, and LoadImmutableFromObject. Loop phi types are computed by first assigning the type of the non-recursive input, and updating once we have the type of the recursive inputs, and repeating this process to a fixed point. Drive-by: Remove the narrowing of function signatures during wasm inlining, as it created some issues and should not be needed after this series of changes. Bug: v8:7748 Change-Id: I8a72488d5c221c4ae8257fc5abf6f0368cf10e96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678208 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80912}
-
- 01 Jun, 2022 2 commits
-
-
Omer Katz authored
MinorMC only used a single color (grey) while the full MC used 2 colors (grey and black). Update MinorMC to use black as well. This aligns and brings full MC and MinorMC closer, and allows to reuse more of the existing sweeping infrastructure for the non-moving MinorMC. Bug: v8:12612 Change-Id: Ifa740537c4587dc197196e41829ea74a312b79d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683320Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80894}
-
Marja Hölttä authored
This reverts commit df73fd60. Reason for revert: Reverting before branch Original change's description: > Reland "[rab/gsab] Temporarily stage --harmony-rab-gsab to enable fuzzing" > > This reverts commit 24286b8e. > > Reason for revert: Re-staging the experimental flag for fuzzing > > Original change's description: > > Revert "[rab/gsab] Temporarily stage --harmony-rab-gsab to enable fuzzing" > > > > This reverts commit b8f88be0. > > > > Reason: disabling an experimental feature in release branch > > > > Bug: v8:11111,v8:12870 > > Change-Id: I6fbd6bdb318c0d25e69c04db208a0d5f2b9ebbd7 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647357 > > Auto-Submit: Marja Hölttä <marja@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80520} > > Bug: v8:11111,v8:12870 > Change-Id: I0a45ed5ce53010196949dda23773d152aa605846 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647836 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#80576} Bug: v8:11111,v8:12870 Change-Id: Ib32c1ba464dde7a5c8cc16f32680bad144bb4304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683358Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80888}
-
- 30 May, 2022 1 commit
-
-
Dominik Inführ authored
Get some test coverage before restarting the map space compaction finch again. This should test whether slots in invalidated objects are now properly ignored when the invalidated object is dead. Bug: v8:12578 Change-Id: I5b6f30b97c2db895183216ae5d5dbd4e5fa9d0c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676855Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80814}
-
- 25 May, 2022 1 commit
-
-
Seth Brenith authored
This change reverts the following: 400b2cc2 Don't rescue old top-level SharedFunctionInfos Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3657472 16a7150b Reland "Disable recompilation of existing Scripts from Isolate compilation cache" Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3655011 2df4d58a Fix rehashing of script compilation cache Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3654413 c8848cf4 Refactor CompilationSubCache Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3629603 25072178 Improve Script reuse in isolate compilation cache, part 1 Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3597106 Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601, chromium:1328671, chromium:1328672, chromium:1328678, chromium:1328811, chromium:1328810 Change-Id: I1d318dc172e5214166d3b15f19903186f4fe6024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664023Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80744}
-
- 24 May, 2022 2 commits
-
-
Patrick Thier authored
Disable --always-use-string-forwarding-table when --shared-string-table is set. With --shared-string-table we can have parallel GCs in multiple client isolates. With --always-use-string-forwarding-table we can have young generation strings in the forwarding table, requiring table updates when the string gets promoted. This is not supported for parallel GCs. This CL also reverts the incorrect try to fix an issue with these flag combination introduced in https://crrev.com/c/3650719 Bug: v8:12877, v8:12007 Change-Id: I49a2aa300af36b82007a7d215afe9a70ac1ce39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660258 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80710}
-
Shu-yu Guo authored
Bug: v8:12764 Change-Id: I7e76647be838749b723400914b144b9ec2a27cd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3656520 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80703}
-
- 23 May, 2022 1 commit
-
-
Manos Koukoutos authored
Not peeling very large loops gives speedups on some benchmarks. Change-Id: Ifbdf08ddaee0e9c638238a6bcf4a3a5ea319b817 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660243 Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80699}
-
- 20 May, 2022 5 commits
-
-
Tobias Tebbi authored
This reverts commit 74c68e2a. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/21353/overview Original change's description: > [heap] Disable map space with --future > > Original CL got reverted, this time the failing test should be fixed. > > Bug: v8:12578 > Change-Id: Id2d8801f07742e8b00884fefec8200e4270f4250 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657434 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80668} Bug: v8:12578 Change-Id: I2ee20c79ec09ff4f7bece6ddcc1c3a5cd9351223 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647692 Owners-Override: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80669}
-
Dominik Inführ authored
Original CL got reverted, this time the failing test should be fixed. Bug: v8:12578 Change-Id: Id2d8801f07742e8b00884fefec8200e4270f4250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657434 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80668}
-
Tobias Tebbi authored
This reverts commit 4ba3b515. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/8900/overview Original change's description: > [heap] Disable map space with --future > > Bug: v8:12578 > Change-Id: If0253a2feb383d6ef313729bf99b489eb9436303 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652794 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80660} Bug: v8:12578 Change-Id: I9ccfc2641b29539a29258a6517824cdd5a5709d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657432 Owners-Override: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80664}
-
Dominik Inführ authored
Bug: v8:12578 Change-Id: If0253a2feb383d6ef313729bf99b489eb9436303 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652794Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80660}
-
Shu-yu Guo authored
Error.cause has shipped since M93. Bug: chromium:1192162 Change-Id: Ib6019f5796cc41447af70c325c90136bcbd774ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624981 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80649}
-
- 19 May, 2022 1 commit
-
-
Seth Brenith authored
This is a reland of commit a7607221 The bug exposed by landing this change the first time has been fixed separately in https://crrev.com/c/3654413 . Original change's description: > Disable recompilation of existing Scripts from Isolate compilation cache > > My previous change https://crrev.com/c/3597106 led to some performance > regressions in time spent on parsing and compilation. This change > disables the ability to recompile an existing uncompiled Script, as an > attempt to both fix the regressions and isolate which part of the > previous change was the cause of those problems. > > Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 > Change-Id: Ifa086bf27070da8f4b3c0e4415af5ca7b6706b0a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652252 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#80616} Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 Change-Id: Ib31864bef90ff3340d1dfd4e25e21bef121f2d49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3655011Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80645}
-
- 18 May, 2022 3 commits
-
-
Tobias Tebbi authored
Bug: v8:12783 Change-Id: I15cf16bd66a97c33170ca4f1f5e3acc6ff9bf956 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576129 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80618}
-
Adam Klein authored
This reverts commit a7607221. Reason for revert: fails on GC Stress bot: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/38512/overview Original change's description: > Disable recompilation of existing Scripts from Isolate compilation cache > > My previous change https://crrev.com/c/3597106 led to some performance > regressions in time spent on parsing and compilation. This change > disables the ability to recompile an existing uncompiled Script, as an > attempt to both fix the regressions and isolate which part of the > previous change was the cause of those problems. > > Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 > Change-Id: Ifa086bf27070da8f4b3c0e4415af5ca7b6706b0a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652252 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#80616} Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 Change-Id: I0f56163856d04ff49da96b0fb344fb59b5501a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3653273 Auto-Submit: Adam Klein <adamk@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80617}
-
Seth Brenith authored
My previous change https://crrev.com/c/3597106 led to some performance regressions in time spent on parsing and compilation. This change disables the ability to recompile an existing uncompiled Script, as an attempt to both fix the regressions and isolate which part of the previous change was the cause of those problems. Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 Change-Id: Ifa086bf27070da8f4b3c0e4415af5ca7b6706b0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652252Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80616}
-
- 17 May, 2022 3 commits
-
-
Jakob Kummerow authored
When call_ref has seen more than one call target, we now support inlining all of them (constrained by budget/heuristics). Bug: v8:7748,v8:12166 Change-Id: Iae16e74da1bad5e7a117f70efb6c61b3f39f832c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650607Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80602}
-
Michael Achenbach authored
NumFuzz passes various flags to V8 testing randomly, which can lead to various flag contradictions with existing flags. Up to now the system ignored the check for contradictions and kept running the test cases, leading to false positives. This change adds a new v8 flag --exit-on-contradictory-flags that exists gracefully when a contradiction is detected. On the numfuzz side we now filter simple contradictions beforehand. Measurements showed that ~2% of all numfuzz tests ran into contradictions. Around half of them are simple contradictions (repetitions and inversions), which are now filtered beforehand. The remaining ones (redundant or contradictory implications) are now ignored. Bug: v8:11826 Change-Id: I9942e203ba9668a097fabe1343dd1365c9da94c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650746 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#80589}
-
Marja Hölttä authored
This reverts commit 24286b8e. Reason for revert: Re-staging the experimental flag for fuzzing Original change's description: > Revert "[rab/gsab] Temporarily stage --harmony-rab-gsab to enable fuzzing" > > This reverts commit b8f88be0. > > Reason: disabling an experimental feature in release branch > > Bug: v8:11111,v8:12870 > Change-Id: I6fbd6bdb318c0d25e69c04db208a0d5f2b9ebbd7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647357 > Auto-Submit: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80520} Bug: v8:11111,v8:12870 Change-Id: I0a45ed5ce53010196949dda23773d152aa605846 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647836 Commit-Queue: Marja Hölttä <marja@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80576}
-
- 13 May, 2022 3 commits
-
-
Samuel Groß authored
This is more consistent with similar features, for example V8_ENABLE_WEBASSEMBLY or V8_ENABLE_MAGLEV. Drive-by: remove V8_SANDBOX_IS_AVAILABLE as it's no longer needed. Bug: v8:10391 Change-Id: I8658c5b0c331a4c73892737083b2c2f9b8f84056 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647355 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Samuel Groß <saelo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80530}
-
Marja Hölttä authored
This reverts commit b8f88be0. Reason: disabling an experimental feature in release branch Bug: v8:11111,v8:12870 Change-Id: I6fbd6bdb318c0d25e69c04db208a0d5f2b9ebbd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647357 Auto-Submit: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80520}
-
Patrick Thier authored
We temporarily enable the StringForwardingTable for all ThinString transitions behind --future to get coverage and performance numbers from future bots. Bug: v8:12007 Change-Id: Ia59bd6c40df2fd413867f6fc2aa7f69d099b5377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637799Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#80516}
-
- 10 May, 2022 1 commit
-
-
Shu-yu Guo authored
Private brand checks have shipped since M91. Bug: v8:11374 Change-Id: Ifd2f8e9904cdb25b45b2e4019da13b3cfc9efdc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622266Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80455}
-
- 09 May, 2022 1 commit
-
-
Camillo Bruni authored
There are currently several flags to tune V8's optimisation level: --sparkplug, --maglev, --opt This CL tries to make this simpler by introducing yet another flag. --max-opt limits the maximum optimisation tier and avoids the common error to mistake --no-opt with no dynamic optimisations. Settings: --max-opt=999 Allow all optimisations, default configuration. Any number > 3 will do, as long as no other tier will be added. --max-opt=0 Allow only ignition --max-opt=1 Allow up to sparkplug --max-opt=2 Allow up to maglev --max-opt=3 Allow up to turbofan Bug: v8:12825 Change-Id: Iff9a0fcccdf05e9770168053a1430303613a7299 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605816 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80418}
-
- 05 May, 2022 1 commit
-
-
Andreas Haas authored
The write protection of code memory with mprotect is too expensive for lazy compilation. As the usefulness of this memory protection is limited anyways, this CL disables the memory protection in case lazy compilation is enabled. Bug: v8:12852 Change-Id: I4c56d4021a7b594e24a4d3d28a130a309c56de38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627596Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80377}
-
- 04 May, 2022 1 commit
-
-
Leszek Swirski authored
This is temporary until we update our infra to always use --turbofan Change-Id: Ie1ca8ce2cae6744515d9810ae4f57f00c8670e36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625977 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80355}
-
- 03 May, 2022 1 commit
-
-
Shu-yu Guo authored
Relative indexing methods have shipped since M92. Bug: v8:10961 Change-Id: I4346a3bed443c9cc48924e5ef23ec012eeeecab1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622134Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80345}
-