Skip to content

V
V8
Commit 075778cb authored by Shu-yu Guo's avatar Shu-yu Guo Committed by V8 LUCI CQ
Browse files
Options

Remove --harmony-relative-indexing-methods 

Relative indexing methods have shipped since M92.

Bug: v8:10961
Change-Id: I4346a3bed443c9cc48924e5ef23ec012eeeecab1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622134Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80345}
parent 2b79eefe
Hide whitespace changes
Inline Side-by-side
Showing with 75 additions and 109 deletions
src/flags/flag-definitions.h
View file @ 075778cb
......@@ -323,14 +323,13 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
#endif
// Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_private_brand_checks, "harmony private brand checks") \
V(harmony_relative_indexing_methods, "harmony relative indexing methods") \
V(harmony_error_cause, "harmony error cause property") \
V(harmony_object_has_own, "harmony Object.hasOwn") \
V(harmony_class_static_blocks, "harmony static initializer blocks") \
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_private_brand_checks, "harmony private brand checks") \
V(harmony_error_cause, "harmony error cause property") \
V(harmony_object_has_own, "harmony Object.hasOwn") \
V(harmony_class_static_blocks, "harmony static initializer blocks") \
V(harmony_array_find_last, "harmony array find last helpers")
#ifdef V8_INTL_SUPPORT
......
src/init/bootstrapper.cc
View file @ 075778cb
......@@ -1759,6 +1759,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
JSObject::AddProperty(isolate_, proto, factory->constructor_string(),
array_function, DONT_ENUM);
SimpleInstallFunction(isolate_, proto, "at", Builtin::kArrayPrototypeAt, 1,
true);
SimpleInstallFunction(isolate_, proto, "concat",
Builtin::kArrayPrototypeConcat, 1, false);
SimpleInstallFunction(isolate_, proto, "copyWithin",
......@@ -1835,6 +1837,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Builtin::kArrayPrototypeToString, 0, false);
Handle<JSObject> unscopables = factory->NewJSObjectWithNullProto();
InstallTrueValuedProperty(isolate_, unscopables, "at");
InstallTrueValuedProperty(isolate_, unscopables, "copyWithin");
InstallTrueValuedProperty(isolate_, unscopables, "entries");
InstallTrueValuedProperty(isolate_, unscopables, "fill");
......@@ -2047,6 +2050,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
// Install the String.prototype methods.
SimpleInstallFunction(isolate_, prototype, "anchor",
Builtin::kStringPrototypeAnchor, 1, false);
SimpleInstallFunction(isolate_, prototype, "at",
Builtin::kStringPrototypeAt, 1, true);
SimpleInstallFunction(isolate_, prototype, "big",
Builtin::kStringPrototypeBig, 0, false);
SimpleInstallFunction(isolate_, prototype, "blink",
......@@ -3347,6 +3352,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
values, DONT_ENUM);
// TODO(caitp): alphasort accessors/methods
SimpleInstallFunction(isolate_, prototype, "at",
Builtin::kTypedArrayPrototypeAt, 1, true);
SimpleInstallFunction(isolate_, prototype, "copyWithin",
Builtin::kTypedArrayPrototypeCopyWithin, 2, false);
SimpleInstallFunction(isolate_, prototype, "every",
......@@ -4686,46 +4693,6 @@ void Genesis::InitializeGlobal_regexp_linear_flag() {
native_context()->set_regexp_prototype_map(regexp_prototype->map());
}
void Genesis::InitializeGlobal_harmony_relative_indexing_methods() {
if (!FLAG_harmony_relative_indexing_methods) return;
{
Handle<JSFunction> array_function(native_context()->array_function(),
isolate());
Handle<JSObject> array_prototype(
JSObject::cast(array_function->instance_prototype()), isolate());
SimpleInstallFunction(isolate(), array_prototype, "at",
Builtin::kArrayPrototypeAt, 1, true);
Handle<JSObject> unscopables = Handle<JSObject>::cast(
JSReceiver::GetProperty(isolate(), array_prototype,
factory()->unscopables_symbol())
.ToHandleChecked());
InstallTrueValuedProperty(isolate(), unscopables, "at");
}
{
Handle<JSFunction> string_function(native_context()->string_function(),
isolate());
Handle<JSObject> string_prototype(
JSObject::cast(string_function->instance_prototype()), isolate());
SimpleInstallFunction(isolate(), string_prototype, "at",
Builtin::kStringPrototypeAt, 1, true);
}
{
Handle<JSFunction> typed_array_function(
native_context()->typed_array_function(), isolate());
Handle<JSObject> typed_array_prototype(
JSObject::cast(typed_array_function->instance_prototype()), isolate());
SimpleInstallFunction(isolate(), typed_array_prototype, "at",
Builtin::kTypedArrayPrototypeAt, 1, true);
}
}
void Genesis::InitializeGlobal_harmony_rab_gsab() {
if (!FLAG_harmony_rab_gsab) return;
Handle<JSObject> array_buffer_prototype(
......
tools/v8heapconst.py
View file @ 075778cb
......@@ -501,67 +501,67 @@ KNOWN_OBJECTS = {
("read_only_space", 0x0368d): "EmptyFunctionScopeInfo",
("read_only_space", 0x036b1): "NativeScopeInfo",
("read_only_space", 0x036c9): "HashSeed",
("old_space", 0x04231): "ArgumentsIteratorAccessor",
("old_space", 0x04275): "ArrayLengthAccessor",
("old_space", 0x042b9): "BoundFunctionLengthAccessor",
("old_space", 0x042fd): "BoundFunctionNameAccessor",
("old_space", 0x04341): "ErrorStackAccessor",
("old_space", 0x04385): "FunctionArgumentsAccessor",
("old_space", 0x043c9): "FunctionCallerAccessor",
("old_space", 0x0440d): "FunctionNameAccessor",
("old_space", 0x04451): "FunctionLengthAccessor",
("old_space", 0x04495): "FunctionPrototypeAccessor",
("old_space", 0x044d9): "StringLengthAccessor",
("old_space", 0x0451d): "WrappedFunctionLengthAccessor",
("old_space", 0x04561): "WrappedFunctionNameAccessor",
("old_space", 0x045a5): "InvalidPrototypeValidityCell",
("old_space", 0x045ad): "EmptyScript",
("old_space", 0x045f1): "ManyClosuresCell",
("old_space", 0x045fd): "ArrayConstructorProtector",
("old_space", 0x04611): "NoElementsProtector",
("old_space", 0x04625): "MegaDOMProtector",
("old_space", 0x04639): "IsConcatSpreadableProtector",
("old_space", 0x0464d): "ArraySpeciesProtector",
("old_space", 0x04661): "TypedArraySpeciesProtector",
("old_space", 0x04675): "PromiseSpeciesProtector",
("old_space", 0x04689): "RegExpSpeciesProtector",
("old_space", 0x0469d): "StringLengthProtector",
("old_space", 0x046b1): "ArrayIteratorProtector",
("old_space", 0x046c5): "ArrayBufferDetachingProtector",
("old_space", 0x046d9): "PromiseHookProtector",
("old_space", 0x046ed): "PromiseResolveProtector",
("old_space", 0x04701): "MapIteratorProtector",
("old_space", 0x04715): "PromiseThenProtector",
("old_space", 0x04729): "SetIteratorProtector",
("old_space", 0x0473d): "StringIteratorProtector",
("old_space", 0x04751): "SingleCharacterStringCache",
("old_space", 0x04b59): "StringSplitCache",
("old_space", 0x04f61): "RegExpMultipleCache",
("old_space", 0x05369): "BuiltinsConstantsTable",
("old_space", 0x0579d): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x057c1): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x057e5): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x05809): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x0582d): "AsyncGeneratorYieldResolveSharedFun",
("old_space", 0x05851): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x05875): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x05899): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x058bd): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x058e1): "PromiseAllResolveElementSharedFun",
("old_space", 0x05905): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x05929): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x0594d): "PromiseAnyRejectElementSharedFun",
("old_space", 0x05971): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x05995): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x059b9): "PromiseCatchFinallySharedFun",
("old_space", 0x059dd): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x05a01): "PromiseThenFinallySharedFun",
("old_space", 0x05a25): "PromiseThrowerFinallySharedFun",
("old_space", 0x05a49): "PromiseValueThunkFinallySharedFun",
("old_space", 0x05a6d): "ProxyRevokeSharedFun",
("old_space", 0x05a91): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x05ab5): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x05ad9): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
("old_space", 0x04241): "ArgumentsIteratorAccessor",
("old_space", 0x04285): "ArrayLengthAccessor",
("old_space", 0x042c9): "BoundFunctionLengthAccessor",
("old_space", 0x0430d): "BoundFunctionNameAccessor",
("old_space", 0x04351): "ErrorStackAccessor",
("old_space", 0x04395): "FunctionArgumentsAccessor",
("old_space", 0x043d9): "FunctionCallerAccessor",
("old_space", 0x0441d): "FunctionNameAccessor",
("old_space", 0x04461): "FunctionLengthAccessor",
("old_space", 0x044a5): "FunctionPrototypeAccessor",
("old_space", 0x044e9): "StringLengthAccessor",
("old_space", 0x0452d): "WrappedFunctionLengthAccessor",
("old_space", 0x04571): "WrappedFunctionNameAccessor",
("old_space", 0x045b5): "InvalidPrototypeValidityCell",
("old_space", 0x045bd): "EmptyScript",
("old_space", 0x04601): "ManyClosuresCell",
("old_space", 0x0460d): "ArrayConstructorProtector",
("old_space", 0x04621): "NoElementsProtector",
("old_space", 0x04635): "MegaDOMProtector",
("old_space", 0x04649): "IsConcatSpreadableProtector",
("old_space", 0x0465d): "ArraySpeciesProtector",
("old_space", 0x04671): "TypedArraySpeciesProtector",
("old_space", 0x04685): "PromiseSpeciesProtector",
("old_space", 0x04699): "RegExpSpeciesProtector",
("old_space", 0x046ad): "StringLengthProtector",
("old_space", 0x046c1): "ArrayIteratorProtector",
("old_space", 0x046d5): "ArrayBufferDetachingProtector",
("old_space", 0x046e9): "PromiseHookProtector",
("old_space", 0x046fd): "PromiseResolveProtector",
("old_space", 0x04711): "MapIteratorProtector",
("old_space", 0x04725): "PromiseThenProtector",
("old_space", 0x04739): "SetIteratorProtector",
("old_space", 0x0474d): "StringIteratorProtector",
("old_space", 0x04761): "SingleCharacterStringCache",
("old_space", 0x04b69): "StringSplitCache",
("old_space", 0x04f71): "RegExpMultipleCache",
("old_space", 0x05379): "BuiltinsConstantsTable",
("old_space", 0x057ad): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x057d1): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x057f5): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x05819): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x0583d): "AsyncGeneratorYieldResolveSharedFun",
("old_space", 0x05861): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x05885): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x058a9): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x058cd): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x058f1): "PromiseAllResolveElementSharedFun",
("old_space", 0x05915): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x05939): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x0595d): "PromiseAnyRejectElementSharedFun",
("old_space", 0x05981): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x059a5): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x059c9): "PromiseCatchFinallySharedFun",
("old_space", 0x059ed): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x05a11): "PromiseThenFinallySharedFun",
("old_space", 0x05a35): "PromiseThrowerFinallySharedFun",
("old_space", 0x05a59): "PromiseValueThunkFinallySharedFun",
("old_space", 0x05a7d): "ProxyRevokeSharedFun",
("old_space", 0x05aa1): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x05ac5): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x05ae9): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
}
# Lower 32 bits of first page addresses for various heap spaces.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment