- 17 Feb, 2021 2 commits
-
-
Chris Mumford authored
This missing include was undetected because trace_perf.cc is only built if the checkout_google_benchmark custom gclient variable is defined. Bug: none Change-Id: If2016edad4df382f14903593ea18066f7759c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698387Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#72825}
-
Paolo Severini authored
The csuite.py script does not work correctly on Windows. It runs correctly in baseline mode, but there are two problems when running in compare mode: 1. In compare mode the output of benchmark.py is piped to the compare-baseline.py script, but Windows only execute python files if python.exe is the default program to open '.py' files, and this is not the case, by default, when python is installed as part of the depot_tools. Fix: explicitly add the 'python' command before compare-baseline.py. 2. By default CSuite prints the results to stdout using escapes codes that add color highlights. But this does not work on Windows when compare-baseline.py is launched with a pipe: python test/benchmarks/csuite/benchmark.py <...> | python test/benchmarks/csuite/compare-baseline.py <baseline_results> Fix: Do not use a pipe. Write the benchmark numbers for the compare-run into a separate file, and pass the path to this file to compare-baseline.py Change-Id: Ic22d5bd4b47901f0ba0f35bc2496441346d21c6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656855Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72807}
-
- 27 Jan, 2021 1 commit
-
-
Michael Lippautz authored
Add reporting of C++ memory to V8's heap growing strategy via existing EmbedderHeapTracer interface. In addition, introduce API-level NoGarbageCollectionScope which allows to temporarily avoid scheduling GC finalizations. Replace internal NoGCScope with NoGarbageCollectionScope and remove NoGCScope. Bug: chromium:1056170 Change-Id: I0ad3dfd67eb81f09f48e2ab87f9bbece7491ed71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72345}
-
- 03 Dec, 2020 3 commits
-
-
Sathya Gunasekaran authored
No-Try: true Bug: v8:11222 Change-Id: I64e30e95101d0c8a318c7081b8c94f97fdb8538c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2571127Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71601}
-
Dominik Inführ authored
These tests are pretty slow with both TSAN and --stress-incremental-marking enabled. * Skip octane/raytrace for the variant stress when TSAN is enabled. * Test wasm/shared-memory-worker-stress is slow with TSAN. Change-Id: Ia4b8ce2986d04e6ef2fc7d28991cd5ce7faf31e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2571129Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#71598}
-
Sathya Gunasekaran authored
Bug: v8:11222 Change-Id: I18a5c58315e37443de1a328ff4d254116c67fcfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569772Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71590}
-
- 24 Nov, 2020 1 commit
-
-
Omer Katz authored
The CPPGC_BUILD_IN_V8 define (used for tracing) isn't propagated from v8_base_without_compiler to cppgc_base, which breaks build with perfetto. Instead use a gn args to specify standalone builds (defaulted to false) and use that to choose the right tracing implementation. Bug: chromium:1056170 Change-Id: I70bce819d45fb133b6f932a50a5d027e39f3e5b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555007 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71356}
-
- 14 Sep, 2020 1 commit
-
-
Michael Achenbach authored
This skips the top outliers in debug mode and marks other tests as slow that frequently flakily time out, see bug. No=Try: true Bug: v8:10909 Change-Id: I26b22cceba4a93496f340fe25af0685391fa762b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407897 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69865}
-
- 24 Jul, 2020 1 commit
-
-
Z Nguyen-Huu authored
csuite.py compare command currently throws exception "_csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)" This should fix it. Change-Id: I69c0ec43575a8c3627dac81dc99e47ba6adf6f61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316833Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#69050}
-
- 10 Jul, 2020 1 commit
-
-
Omer Katz authored
This CL removes the GetTraceDescriptor virtual call from garbage collected mixins and replaces it with querying the object start bitmap. The CL also removes the mixin macros which are now no longer needed. Bug: chromium:1056170 Change-Id: I27ed299f93025d09a3bb3f0d17b14bed3c200565 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287508Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68787}
-
- 03 Jul, 2020 2 commits
-
-
Michael Lippautz authored
The benchmarks cover static vs dynamic tracing of an object where the header is computed statically vs using the object start bitmap, respectively. $ out/x64.release/cppgc_basic_benchmarks --benchmark_filter=Trace/* Running out/x64.release/cppgc_basic_benchmarks Run on (56 X 3500 MHz CPU s) CPU Caches: L1 Data 32 KiB (x28) L1 Instruction 32 KiB (x28) L2 Unified 256 KiB (x28) L3 Unified 35840 KiB (x2) Load Average: 0.24, 0.26, 0.26 -------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------- Trace/Static 1.78 ns 1.78 ns 393324147 Trace/Dynamic 3.27 ns 3.27 ns 215078276 2020-07-03T15: 21:25+02:00 Change-Id: I8bf5a8ed71a8991873160353e26f96214c038730 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280099 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68675}
-
Michael Lippautz authored
Output: $ out/x64.release/cppgc_allocation_benchmark --benchmark_repetitions=3 Running out/x64.release/cppgc_allocation_benchmark Run on (56 X 3500 MHz CPU s) CPU Caches: L1 Data 32 KiB (x28) L1 Instruction 32 KiB (x28) L2 Unified 256 KiB (x28) L3 Unified 35840 KiB (x2) Load Average: 0.23, 0.27, 0.27 -------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... -------------------------------------------------------------------------------- Allocate/Tiny 17.0 ns 17.0 ns 40348381 bytes_per_second=55.9692M/s Allocate/Tiny 17.1 ns 17.1 ns 40348381 bytes_per_second=55.8961M/s Allocate/Tiny 17.2 ns 17.2 ns 40348381 bytes_per_second=55.3108M/s Allocate/Tiny_mean 17.1 ns 17.1 ns 3 bytes_per_second=55.7254M/s Allocate/Tiny_median 17.1 ns 17.1 ns 3 bytes_per_second=55.8961M/s Allocate/Tiny_stddev 0.112 ns 0.111 ns 3 bytes_per_second=369.571k/s Allocate/Large 40339 ns 40334 ns 17707 bytes_per_second=1.51326G/s Allocate/Large 40350 ns 40343 ns 17707 bytes_per_second=1.51292G/s Allocate/Large 40205 ns 40192 ns 17707 bytes_per_second=1.51861G/s Allocate/Large_mean 40298 ns 40290 ns 3 bytes_per_second=1.51493G/s Allocate/Large_median 40339 ns 40334 ns 3 bytes_per_second=1.51326G/s Allocate/Large_stddev 81.2 ns 84.7 ns 3 bytes_per_second=3.26614M/s 2020-07-03T09: 14:23+02:00 Change-Id: I25a55beb5ea1718af76e638b752bf7d67cfe373e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280086Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68672}
-
- 02 Jul, 2020 1 commit
-
-
Michael Lippautz authored
This adds Google benchmark for microbenchmarking C++ code as an optional dependency. To enable, add the following to the .gclient before syncing "custom_vars": { "checkout_google_benchmark": True } Change-Id: Id0eab772dd71558906658ef4bb60e31acd665948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275964Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68663}
-
- 06 May, 2020 1 commit
-
-
Jakob Gruber authored
The serializer currently cannot handle a heap state containing arbitrary compiled Code objects. As a quick fix for the --stress-snapshot d8 flag, we clear compiled data from the isolate prior to the serialize-deserialize-verify pass. With this change, mjsunit tests pass on x64. The %SerializeDeserializeNow() runtime function would require more work, since it is not possible to mutate the heap to this extent while still preserving a runnable host context and isolate. We will need another solution there. Drive-by: Skip the stress_snapshot variant except for the mjsunit suite. Tbr: machenbach@chromium.org Bug: v8:10493,v8:10416 Change-Id: Ie110da8b51613fcd69c7f391d3cf8589d6b04dd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182429Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67585}
-
- 26 Feb, 2020 1 commit
-
-
Marcin Wiącek authored
Before: running different suites is removing non-related master data After: different suites have separate master data files Change-Id: Iab46d663fdf2a1d709aeb7da77a443c2ed1bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071870Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#66453}
-
- 22 Oct, 2019 1 commit
-
-
Simon Zünd authored
Embedded builtins are now unconditionally enabled, which removes the need to differentiate between enabled/disabled embedded builtins. This Cl removes the 'embedded_builtins' variant and related *.status entries. R=machenbach@chromium.org Bug: v8:8519 Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64464}
-
- 14 Oct, 2019 1 commit
-
-
Michael Achenbach authored
TBR=gsathya@chromium.org NOTRY=true Change-Id: I6ddb04fe4aec3596bfc70170310745924909de52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1857222Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64268}
-
- 02 Oct, 2019 1 commit
-
-
Mythri A authored
This is a reland of 9efe315e after marking box2d slow. Original change's description: > Mark functions for optimization only on bytecode budget interrupts > > We used to mark functions for optimization on any interrupt. This sometimes > causes functions to OSR when not needed. The implementation was such because > we didn't have a different runtime function to distinguish bytecode budget > interrupts from other interrupts. For lazy feedback allocation we added a > new runtime function for bytecode budget interrupts so it makes it easier > to actually mark functions only when needed. > > This also includes a fix to reduce the stack limits for interrupts when > entering a scope that allows interrupts from a postponed interrupt scope. > > Bug: chromium:993061 > Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64048} Bug: chromium:993061 Change-Id: I24dae03357d6c368e4173db3f071e8ab09e9d6dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832173Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#64082}
-
- 07 May, 2019 1 commit
-
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: v8:8537 Change-Id: I0230916b533ddd7fa8d40ef531a475f1245366f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598762Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61285}
-
- 26 Apr, 2019 2 commits
-
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Bug: v8:9145 Change-Id: I01829358bc2729d39d06ee40af108b3218e7339d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585841Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61043}
-
Michael Achenbach authored
NOTRY=true Bug: v8:9145 Change-Id: I0751ad840bb5a93ae0d0988e1b69dd9b1b215f6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585727 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61032}
-
- 23 Apr, 2019 1 commit
-
-
Michael Achenbach authored
NOTRY=true TBR=sigurds@chromium.org Bug: v8:8963 Change-Id: Idf19be92f7f039a14838c87695666d5f6963e6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575585Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60938}
-
- 20 Mar, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
This is a reland of f8962ae1 Original change's description: > Preparing v8 to use with python3 /test > > There are now less that 400 days until the end of life > of Python 2(aka _legacy_ Python) https://pythonclock.org/ . > The code compatibility check for python2 and python3 > used the following tools: futurize, flake8 > You can see the reports here: https://travis-ci.com/bmsdave/v8/builds > > This CL was uploaded by git cl split. > > Bug: v8:8594 > Change-Id: Idbf467daf629a4e808345a6a88036c2a3f259138 > Reviewed-on: https://chromium-review.googlesource.com/c/1470121 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59679} Bug: v8:8594 Change-Id: I8c1a8d6593a4a927d56d37dada2c704062e842cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484300Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#60354}
-
- 26 Feb, 2019 1 commit
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:8889 Change-Id: I1faf4bcb8f573485915a8b79d551fbb4985a02a0 Reviewed-on: https://chromium-review.googlesource.com/c/1489075Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59872}
-
- 20 Feb, 2019 1 commit
-
-
Sergiy Belozorov authored
This reverts commit f8962ae1. Reason for revert: breaks Arm bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/9655, task: https://chromium-swarm.appspot.com/task?d=true&id=431dfa503db16d10 Original change's description: > Preparing v8 to use with python3 /test > > There are now less that 400 days until the end of life > of Python 2(aka _legacy_ Python) https://pythonclock.org/ . > The code compatibility check for python2 and python3 > used the following tools: futurize, flake8 > You can see the reports here: https://travis-ci.com/bmsdave/v8/builds > > This CL was uploaded by git cl split. > > Bug: v8:8594 > Change-Id: Idbf467daf629a4e808345a6a88036c2a3f259138 > Reviewed-on: https://chromium-review.googlesource.com/c/1470121 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59679} TBR=machenbach@chromium.org,sergiyb@chromium.org,herhut@chromium.org,bmsdave@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8594 Change-Id: I17a0a7b203fa2c0ab0f965240ee1415b7513e1cf Reviewed-on: https://chromium-review.googlesource.com/c/1478692Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59725}
-
- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: Idbf467daf629a4e808345a6a88036c2a3f259138 Reviewed-on: https://chromium-review.googlesource.com/c/1470121 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59679}
-
- 06 Feb, 2019 2 commits
-
-
Tamer Tas authored
This is a reland of 81eec150 Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} Bug: v8:8174, v8:8790 Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857 Reviewed-on: https://chromium-review.googlesource.com/c/1454724 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59387}
-
Michael Achenbach authored
TBR=jgruber@chromium.org NOTRY=true Bug: v8:8789 Change-Id: I4058cf0ad32b0dfac313fce41f2ee58f65331f9a Reviewed-on: https://chromium-review.googlesource.com/c/1454610Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59386}
-
- 05 Feb, 2019 4 commits
-
-
Tamer Tas authored
This reverts commit 81eec150. Reason for revert: windows mozilla test failures Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59370}
-
Tamer Tas authored
This is a reland of 7f92ad0a Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} Bug: v8:8174, v8:8769 Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59369}
-
Tamer Tas authored
This reverts commit 7f92ad0a. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148 Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454599 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59362}
-
Tamer Tas authored
Every testsuite configuration consist of at least 30% code duplication. The code age ranges from 10 years old to 5 years old. Implementing anything that touches the testsuite code becomes a technical fight to the death. This CL removes all the duplication by refactoring the common functionality. This CL contains structural changes without any logical changes % small bug fixes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8769 Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 Reviewed-on: https://chromium-review.googlesource.com/c/1445881 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59361}
-
- 21 Dec, 2018 1 commit
-
-
Mike Stanton authored
It's nice to have a quick way to get stable results on the local machine for the classic d8 benchmarks. CSuite revitalizes an old tool called BSuite which offers multiple averaged runs, and a nice ascii display of results. Sample usage: ./csuite.py octane baseline ~/src/v8/out/d8 ./csuite.py octane compare ~/src/v8/out-mine/d8 benchmark: score | master | % | ===================================================+==========+========+ Richards: 26201.0 | 26568.0 | -1.4 | DeltaBlue: 55744.0 | 58309.0 | -4.4 | Crypto: 31831.0 | 31815.0 | | RayTrace: 73481.0 | 73185.0 | 0.4 | ............<snip>............................ Octane: 36388.0 | 35741.0 | 1.8 | ---------------------------------------------------+----------+--------+ See README.md for more documentation. Change-Id: I182490506ca07fab1240bd485bd1d7a8920db893 Reviewed-on: https://chromium-review.googlesource.com/c/1387487 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58434}
-
- 29 Aug, 2018 1 commit
-
-
Michael Achenbach authored
This shares logic for finding additional resources in JS source code. Previously the logic was implemented for mjsunit, now it will be used across all d8-based test cases. This'll enable adding those test suites for Android testing. Bug: chromium:866862 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7c89ba141483aaf692a03c0e168edb61bbb7b010 Reviewed-on: https://chromium-review.googlesource.com/1193873 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55503}
-
- 28 Mar, 2018 3 commits
-
-
Michael Achenbach authored
This is a reland of 712b66da Breakage is fixed on infra side by: https://crrev.com/c/983417 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} Bug: chromium:669910 Change-Id: I6c06a1fe9587206aa4e983befb105327bfec4154 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983573Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52273}
-
Michael Achenbach authored
This reverts commit 712b66da. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/builds/32049 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,jgruber@chromium.org Change-Id: I1955325b0b419b38d793ab205131de8de08cb50a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983418Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52268}
-
Michael Achenbach authored
Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c Reviewed-on: https://chromium-review.googlesource.com/982630Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52267}
-
- 26 Mar, 2018 1 commit
-
-
Michael Achenbach authored
Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifb8719a989a4fda48241967271ebe39037643e39 Reviewed-on: https://chromium-review.googlesource.com/980032 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52223}
-
- 08 Feb, 2018 1 commit
-
-
Michael Achenbach authored
Timeouts on num-fuzzer only lead to false positives, as tests might take unpredictably longer. This CL forgives timeouts through a global override mechanism of the expected outcomes. This allows to remove already existing scattered code that allowed timeouts in some test suites only. Bug: v8:6917 Change-Id: Ib131765d360e335789c1952bc6793ed051e016ea Reviewed-on: https://chromium-review.googlesource.com/908454 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51188}
-
- 01 Feb, 2018 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a7b41502dfd4be43496b1edb958522a8eb0c31 Reviewed-on: https://chromium-review.googlesource.com/895588 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51023}
-