1. 17 Feb, 2021 2 commits
    • Chris Mumford's avatar
      IWYU: Added missing include: include/cppgc/persistent.h · 84d2527b
      Chris Mumford authored
      This missing include was undetected because trace_perf.cc is only
      built if the checkout_google_benchmark custom gclient variable is
      defined.
      
      Bug: none
      Change-Id: If2016edad4df382f14903593ea18066f7759c4d5
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698387Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Chris Mumford <cmumford@google.com>
      Cr-Commit-Position: refs/heads/master@{#72825}
      84d2527b
    • Paolo Severini's avatar
      [Test] Make CSuite benchmark runner work better on Windows · a974dd7e
      Paolo Severini authored
      The csuite.py script does not work correctly on Windows. It runs
      correctly in baseline mode, but there are two problems when running in
      compare mode:
      
      1. In compare mode the output of benchmark.py is piped to the
         compare-baseline.py script, but Windows only execute python files if
         python.exe is the default program to open '.py' files, and this is
         not the case, by default, when python is installed as part of the
         depot_tools.
      
         Fix: explicitly add the 'python' command before compare-baseline.py.
      
      2. By default CSuite prints the results to stdout using escapes codes
         that add color highlights. But this does not work on Windows when
         compare-baseline.py is launched with a pipe:
      
         python test/benchmarks/csuite/benchmark.py <...> |
             python test/benchmarks/csuite/compare-baseline.py <baseline_results>
      
         Fix: Do not use a pipe. Write the benchmark numbers for the
         compare-run into a separate file, and pass the path to this file to
         compare-baseline.py
      
      Change-Id: Ic22d5bd4b47901f0ba0f35bc2496441346d21c6a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656855Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Commit-Queue: Paolo Severini <paolosev@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#72807}
      a974dd7e
  2. 27 Jan, 2021 1 commit
  3. 03 Dec, 2020 3 commits
  4. 24 Nov, 2020 1 commit
  5. 14 Sep, 2020 1 commit
  6. 24 Jul, 2020 1 commit
  7. 10 Jul, 2020 1 commit
  8. 03 Jul, 2020 2 commits
    • Michael Lippautz's avatar
      cppgc: Add micro benchmark for tracing objects · 5ab27690
      Michael Lippautz authored
      The benchmarks cover static vs dynamic tracing of an object where the
      header is computed statically vs using the object start bitmap,
      respectively.
      
      $ out/x64.release/cppgc_basic_benchmarks --benchmark_filter=Trace/*
      
      Running out/x64.release/cppgc_basic_benchmarks
      Run on (56 X 3500 MHz CPU s)
      CPU Caches:
        L1 Data 32 KiB (x28)
        L1 Instruction 32 KiB (x28)
        L2 Unified 256 KiB (x28)
        L3 Unified 35840 KiB (x2)
      Load Average: 0.24, 0.26, 0.26
      --------------------------------------------------------
      Benchmark              Time             CPU   Iterations
      --------------------------------------------------------
      Trace/Static        1.78 ns         1.78 ns    393324147
      Trace/Dynamic       3.27 ns         3.27 ns    215078276
      
      2020-07-03T15: 21:25+02:00
      Change-Id: I8bf5a8ed71a8991873160353e26f96214c038730
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280099
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
      Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68675}
      5ab27690
    • Michael Lippautz's avatar
      cppgc: Add allocation benchmark · 66fc9431
      Michael Lippautz authored
      Output:
      
      $ out/x64.release/cppgc_allocation_benchmark --benchmark_repetitions=3
      
      Running out/x64.release/cppgc_allocation_benchmark
      Run on (56 X 3500 MHz CPU s)
      CPU Caches:
        L1 Data 32 KiB (x28)
        L1 Instruction 32 KiB (x28)
        L2 Unified 256 KiB (x28)
        L3 Unified 35840 KiB (x2)
      Load Average: 0.23, 0.27, 0.27
      --------------------------------------------------------------------------------
      Benchmark                      Time             CPU   Iterations UserCounters...
      --------------------------------------------------------------------------------
      Allocate/Tiny               17.0 ns         17.0 ns     40348381 bytes_per_second=55.9692M/s
      Allocate/Tiny               17.1 ns         17.1 ns     40348381 bytes_per_second=55.8961M/s
      Allocate/Tiny               17.2 ns         17.2 ns     40348381 bytes_per_second=55.3108M/s
      Allocate/Tiny_mean          17.1 ns         17.1 ns            3 bytes_per_second=55.7254M/s
      Allocate/Tiny_median        17.1 ns         17.1 ns            3 bytes_per_second=55.8961M/s
      Allocate/Tiny_stddev       0.112 ns        0.111 ns            3 bytes_per_second=369.571k/s
      Allocate/Large             40339 ns        40334 ns        17707 bytes_per_second=1.51326G/s
      Allocate/Large             40350 ns        40343 ns        17707 bytes_per_second=1.51292G/s
      Allocate/Large             40205 ns        40192 ns        17707 bytes_per_second=1.51861G/s
      Allocate/Large_mean        40298 ns        40290 ns            3 bytes_per_second=1.51493G/s
      Allocate/Large_median      40339 ns        40334 ns            3 bytes_per_second=1.51326G/s
      Allocate/Large_stddev       81.2 ns         84.7 ns            3 bytes_per_second=3.26614M/s
      
      2020-07-03T09: 14:23+02:00
      Change-Id: I25a55beb5ea1718af76e638b752bf7d67cfe373e
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280086Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
      Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68672}
      66fc9431
  9. 02 Jul, 2020 1 commit
  10. 06 May, 2020 1 commit
    • Jakob Gruber's avatar
      [snapshot] Clear reconstructable data prior to d8 stress_snapshot run · 3c422d1c
      Jakob Gruber authored
      The serializer currently cannot handle a heap state containing
      arbitrary compiled Code objects. As a quick fix for the
      --stress-snapshot d8 flag, we clear compiled data from the isolate
      prior to the serialize-deserialize-verify pass.
      
      With this change, mjsunit tests pass on x64.
      
      The %SerializeDeserializeNow() runtime function would require more
      work, since it is not possible to mutate the heap to this extent while
      still preserving a runnable host context and isolate. We will need
      another solution there.
      
      Drive-by: Skip the stress_snapshot variant except for the mjsunit
      suite.
      
      Tbr: machenbach@chromium.org
      Bug: v8:10493,v8:10416
      Change-Id: Ie110da8b51613fcd69c7f391d3cf8589d6b04dd8
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182429Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67585}
      3c422d1c
  11. 26 Feb, 2020 1 commit
  12. 22 Oct, 2019 1 commit
  13. 14 Oct, 2019 1 commit
  14. 02 Oct, 2019 1 commit
    • Mythri A's avatar
      Reland "Mark functions for optimization only on bytecode budget interrupts" · 483a5e94
      Mythri A authored
      This is a reland of 9efe315e after marking
      box2d slow.
      
      Original change's description:
      > Mark functions for optimization only on bytecode budget interrupts
      >
      > We used to mark functions for optimization on any interrupt. This sometimes
      > causes functions to OSR when not needed. The implementation was such because
      > we didn't have a different runtime function to distinguish bytecode budget
      > interrupts from other interrupts. For lazy feedback allocation we added a
      > new runtime function for bytecode budget interrupts so it makes it easier
      > to actually mark functions only when needed.
      >
      > This also includes a fix to reduce the stack limits for interrupts when
      > entering a scope that allows interrupts from a postponed interrupt scope.
      >
      > Bug: chromium:993061
      > Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Commit-Queue: Mythri Alle <mythria@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#64048}
      
      Bug: chromium:993061
      Change-Id: I24dae03357d6c368e4173db3f071e8ab09e9d6dc
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832173Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64082}
      483a5e94
  15. 07 May, 2019 1 commit
  16. 26 Apr, 2019 2 commits
  17. 23 Apr, 2019 1 commit
  18. 20 Mar, 2019 1 commit
  19. 26 Feb, 2019 1 commit
  20. 20 Feb, 2019 1 commit
  21. 19 Feb, 2019 1 commit
  22. 06 Feb, 2019 2 commits
    • Tamer Tas's avatar
      Reland "Reland "[test] refactor testsuite configuration"" · df630e67
      Tamer Tas authored
      This is a reland of 81eec150
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      >
      > This is a reland of 7f92ad0a
      >
      > Original change's description:
      > > [test] refactor testsuite configuration
      > >
      > > Every testsuite configuration consist of at least 30% code duplication.
      > >
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > >
      > > This CL removes all the duplication by refactoring the common functionality.
      > >
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > >
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > >
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      Bug: v8:8174, v8:8790
      Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857
      Reviewed-on: https://chromium-review.googlesource.com/c/1454724
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59387}
      df630e67
    • Michael Achenbach's avatar
      [test] Skip slow test · b60906f3
      Michael Achenbach authored
      TBR=jgruber@chromium.org
      NOTRY=true
      
      Bug: v8:8789
      Change-Id: I4058cf0ad32b0dfac313fce41f2ee58f65331f9a
      Reviewed-on: https://chromium-review.googlesource.com/c/1454610Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59386}
      b60906f3
  23. 05 Feb, 2019 4 commits
    • Tamer Tas's avatar
      Revert "Reland "[test] refactor testsuite configuration"" · ea4412ad
      Tamer Tas authored
      This reverts commit 81eec150.
      
      Reason for revert: windows mozilla test failures
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      > 
      > This is a reland of 7f92ad0a
      > 
      > Original change's description:
      > > [test] refactor testsuite configuration
      > > 
      > > Every testsuite configuration consist of at least 30% code duplication.
      > > 
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > > 
      > > This CL removes all the duplication by refactoring the common functionality.
      > > 
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > > 
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > > 
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org
      
      Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59370}
      ea4412ad
    • Tamer Tas's avatar
      Reland "[test] refactor testsuite configuration" · 81eec150
      Tamer Tas authored
      This is a reland of 7f92ad0a
      
      Original change's description:
      > [test] refactor testsuite configuration
      > 
      > Every testsuite configuration consist of at least 30% code duplication.
      > 
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      > 
      > This CL removes all the duplication by refactoring the common functionality.
      > 
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      > 
      > R=machenbach@chromium.org
      > CC=yangguo@chromium.org,sergiyb@chromium.org
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      Bug: v8:8174, v8:8769
      Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59369}
      81eec150
    • Tamer Tas's avatar
      Revert "[test] refactor testsuite configuration" · 97068800
      Tamer Tas authored
      This reverts commit 7f92ad0a.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148
      
      Original change's description:
      > [test] refactor testsuite configuration
      >
      > Every testsuite configuration consist of at least 30% code duplication.
      >
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      >
      > This CL removes all the duplication by refactoring the common functionality.
      >
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      >
      > R=​machenbach@chromium.org
      > CC=​yangguo@chromium.org,sergiyb@chromium.org
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org
      
      Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454599
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59362}
      97068800
    • Tamer Tas's avatar
      [test] refactor testsuite configuration · 7f92ad0a
      Tamer Tas authored
      Every testsuite configuration consist of at least 30% code duplication.
      
      The code age ranges from 10 years old to 5 years old. Implementing anything that
      touches the testsuite code becomes a technical fight to the death.
      
      This CL removes all the duplication by refactoring the common functionality.
      
      This CL contains structural changes without any logical changes % small bug
      fixes.
      
      R=machenbach@chromium.org
      CC=yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8769
      Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59361}
      7f92ad0a
  24. 21 Dec, 2018 1 commit
    • Mike Stanton's avatar
      [Test] CSuite benchmark runner · 98b47ebb
      Mike Stanton authored
      It's nice to have a quick way to get stable results on the local
      machine for the classic d8 benchmarks. CSuite revitalizes an
      old tool called BSuite which offers multiple averaged runs,
      and a nice ascii display of results.
      
      Sample usage:
      
      ./csuite.py octane baseline ~/src/v8/out/d8
      ./csuite.py octane compare ~/src/v8/out-mine/d8
      
                                    benchmark:    score |   master |      % |
      ===================================================+==========+========+
                                      Richards:  26201.0 |  26568.0 |   -1.4 |
                                     DeltaBlue:  55744.0 |  58309.0 |   -4.4 |
                                        Crypto:  31831.0 |  31815.0 |        |
                                      RayTrace:  73481.0 |  73185.0 |    0.4 |
                    ............<snip>............................
                                        Octane:  36388.0 |  35741.0 |    1.8 |
      ---------------------------------------------------+----------+--------+
      
      
      See README.md for more documentation.
      
      Change-Id: I182490506ca07fab1240bd485bd1d7a8920db893
      Reviewed-on: https://chromium-review.googlesource.com/c/1387487
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58434}
      98b47ebb
  25. 29 Aug, 2018 1 commit
  26. 28 Mar, 2018 3 commits
  27. 26 Mar, 2018 1 commit
  28. 08 Feb, 2018 1 commit
  29. 01 Feb, 2018 1 commit