Reland "Mark functions for optimization only on bytecode budget interrupts"

This is a reland of 9efe315e after marking
box2d slow.

Original change's description:
> Mark functions for optimization only on bytecode budget interrupts
>
> We used to mark functions for optimization on any interrupt. This sometimes
> causes functions to OSR when not needed. The implementation was such because
> we didn't have a different runtime function to distinguish bytecode budget
> interrupts from other interrupts. For lazy feedback allocation we added a
> new runtime function for bytecode budget interrupts so it makes it easier
> to actually mark functions only when needed.
>
> This also includes a fix to reduce the stack limits for interrupts when
> entering a scope that allows interrupts from a postponed interrupt scope.
>
> Bug: chromium:993061
> Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#64048}

Bug: chromium:993061
Change-Id: I24dae03357d6c368e4173db3f071e8ab09e9d6dc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832173Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64082}

src/execution/stack-guard.cc

@@ -87,6 +87,8 @@ void StackGuard::PushInterruptsScope(InterruptsScope* scope) {
       current->intercepted_flags_ &= ~scope->intercept_mask_;
     }
     thread_local_.interrupt_flags_ |= restored_flags;
+
+    if (has_pending_interrupts(access)) set_interrupt_limits(access);
   }
   if (!has_pending_interrupts(access)) reset_limits(access);
   // Add scope to the chain.
@@ -305,8 +307,6 @@ Object StackGuard::HandleInterrupts() {
   }
 
   isolate_->counters()->stack_interrupts()->Increment();
-  isolate_->counters()->runtime_profiler_ticks()->Increment();
-  isolate_->runtime_profiler()->MarkCandidatesForOptimization();
 
   return ReadOnlyRoots(isolate_).undefined_value();
 }

src/runtime/runtime-internal.cc

@@ -14,6 +14,7 @@
 #include "src/execution/frames-inl.h"
 #include "src/execution/isolate-inl.h"
 #include "src/execution/messages.h"
+#include "src/execution/runtime-profiler.h"
 #include "src/handles/maybe-handles.h"
 #include "src/init/bootstrapper.h"
 #include "src/logging/counters.h"
@@ -296,10 +297,11 @@ RUNTIME_FUNCTION(Runtime_BytecodeBudgetInterrupt) {
     function->feedback_vector().set_invocation_count(1);
     return ReadOnlyRoots(isolate).undefined_value();
   }
-  // Handle interrupts.
   {
     SealHandleScope shs(isolate);
-    return isolate->stack_guard()->HandleInterrupts();
+    isolate->counters()->runtime_profiler_ticks()->Increment();
+    isolate->runtime_profiler()->MarkCandidatesForOptimization();
+    return ReadOnlyRoots(isolate).undefined_value();
   }
 }
 

test/benchmarks/benchmarks.status

@@ -35,6 +35,7 @@
   # Slow tests.
   'kraken/imaging-gaussian-blur': [PASS, SLOW],
   'octane/typescript': [PASS, SLOW],
+  'octane/box2d': [PASS, SLOW],
 }],  # ALWAYS
 
 # Slow variants.
@@ -42,7 +43,6 @@
   # Slow tests.
   'kraken/ai-astar': [PASS, SLOW],
   'kraken/imaging-desaturate': [PASS, SLOW],
-  'octane/box2d': [PASS, SLOW],
   'octane/code-load': [PASS, SLOW],
   'octane/crypto': [PASS, SLOW],
   'octane/gbemu-part1': [PASS, SLOW],