Remove 'embedded_builtins' variant

Embedded builtins are now unconditionally enabled, which removes the
need to differentiate between enabled/disabled embedded builtins.

This Cl removes the 'embedded_builtins' variant and related
*.status entries.

R=machenbach@chromium.org

Bug: v8:8519
Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64464}

test/benchmarks/benchmarks.status

@@ -82,8 +82,4 @@
   'octane/typescript': [SKIP],
 }],  # 'predictable'
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
 ]

test/cctest/cctest.status

@@ -590,11 +590,6 @@
   'test-macro-assembler-arm/ReplaceLane': [PASS, ['arch == arm and not simulator_run', SKIP]],
 }], # variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ##############################################################################
 ['variant == turboprop', {
   # Require inlining.

test/debugger/debugger.status

@@ -134,11 +134,6 @@
   'wasm-*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ##############################################################################
 ['variant == turboprop', {
   # Deopts differently than TurboFan.

test/fuzzer/fuzzer.status

@@ -13,9 +13,4 @@
   'wasm_compile/*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/inspector/inspector.status

@@ -12,9 +12,6 @@
   'cpu-profiler/coverage-block': [PASS, ['lite_mode == True', SKIP]],
   'cpu-profiler/coverage': [PASS, ['lite_mode == True', SKIP]],
 
-  # Bad OOM timing on noembed builds (https://crbug.com/v8/8494).
-  'debugger/pause-on-oom': [PASS, ['embedded_builtins == False', SKIP]],
-
   # https://crbug.com/v8/9029
   'debugger/script-on-after-compile-snapshot': [SKIP],
 }],  # ALWAYS
@@ -77,8 +74,5 @@
 }],  # 'arch == s390 or arch == s390x'
 
 ##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
 
 ]

test/intl/intl.status

@@ -73,8 +73,4 @@
   'relative-time-format/resolved-options-nu-extended': [FAIL],
 }],  # 'system == android'
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
 ]

test/message/message.status

@@ -64,9 +64,4 @@
   'asm-*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/mjsunit/mjsunit.status

@@ -1096,16 +1096,6 @@
   'regress/regress-913844': [SKIP],
 }],
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
-['not embedded_builtins', {
-  # Explicitly sets jitless flag.
-  'regress/regress-992389': [SKIP],
-}], # not embedded_builtins
-
 ##############################################################################
 ['variant == turboprop', {
   # Deopts differently than TurboFan.

test/mkgrokdump/mkgrokdump.status

@@ -9,9 +9,4 @@
   '*': [SKIP],
 }],  # variant != default or arch != x64 or lite_mode
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/mozilla/mozilla.status

@@ -1069,9 +1069,4 @@
   '*': [SKIP],
 }],  # variant == no_wasm_traps
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/preparser/preparser.status

@@ -29,8 +29,4 @@
 [ALWAYS, {
 }],  # ALWAYS
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
 ]

test/test262/test262.status

@@ -750,9 +750,4 @@
   'intl402/DateTimeFormat/prototype/resolvedOptions/basic': [SKIP],
 }],  # system == windows
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/unittests/unittests.status

@@ -24,10 +24,6 @@
 }], # lite_mode or variant == jitless
 
 ##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ['system == windows and asan', {
   # BUG(893437).
   'Torque*': [SKIP],

test/wasm-api-tests/wasm-api-tests.status

@@ -8,9 +8,4 @@
   '*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/wasm-js/wasm-js.status

@@ -24,9 +24,4 @@
   '*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ]

test/wasm-spec-tests/wasm-spec-tests.status

@@ -79,10 +79,5 @@
   '*': [SKIP],
 }], # lite_mode or variant == jitless
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 
 ]

test/webkit/webkit.status

@@ -136,10 +136,5 @@
   'fast/js/string-capitalization': [FAIL],
 }],  # variant == no_wasm_traps
 
-##############################################################################
-['variant == jitless and not embedded_builtins', {
-  '*': [SKIP],
-}], # variant == jitless and not embedded_builtins
-
 ##############################################################################
 ]

tools/testrunner/base_runner.py

@@ -198,10 +198,6 @@ class BuildConfig(object):
     self.tsan = build_config['is_tsan']
     # TODO(machenbach): We only have ubsan not ubsan_vptr.
     self.ubsan_vptr = build_config['is_ubsan_vptr']
-    # TODO(https://crbug.com/v8/8519)
-    # 'v8_enable_embedded_builtins' was removed, 'embedded_builtins' can be
-    # removed as well.
-    self.embedded_builtins = True
     self.verify_csa = build_config['v8_enable_verify_csa']
     self.lite_mode = build_config['v8_enable_lite_mode']
     self.pointer_compression = build_config['v8_enable_pointer_compression']
@@ -236,8 +232,6 @@ class BuildConfig(object):
       detected_options.append('tsan')
     if self.ubsan_vptr:
       detected_options.append('ubsan_vptr')
-    if self.embedded_builtins:
-      detected_options.append('embedded_builtins')
     if self.verify_csa:
       detected_options.append('verify_csa')
     if self.lite_mode:
@@ -704,7 +698,6 @@ class BaseTestRunner(object):
       "system": self.target_os,
       "tsan": self.build_config.tsan,
       "ubsan_vptr": self.build_config.ubsan_vptr,
-      "embedded_builtins": self.build_config.embedded_builtins,
       "verify_csa": self.build_config.verify_csa,
       "lite_mode": self.build_config.lite_mode,
       "pointer_compression": self.build_config.pointer_compression,

tools/unittests/run_tests_test.py

@@ -356,7 +356,6 @@ class SystemTest(unittest.TestCase):
           'no_i18n\n'
           'tsan\n'
           'ubsan_vptr\n'
-          'embedded_builtins\n'
           '>>> Running tests for ia32.release')
       self.assertIn(expect_text, result.stdout, result)
       self.assertEqual(0, result.returncode, result)