- 24 Apr, 2018 13 commits
-
-
Andrew Grieve authored
NOTRY=true NOTREECHECKS=true Change-Id: I6a9f671a9c3db4fb2eb346ccdf80a10d3e7a5040 Reviewed-on: https://chromium-review.googlesource.com/1025952Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#52760}
-
Kim-Anh Tran authored
Wasm tier-up first compiles the whole module using Liftoff, and then using Turbofan. The idea is to achieve fast start-up times by first running Liftoff-compiled code. In the meantime we finish compilation with Turbofan, and replace the Liftoff-compiled code as soon as Turbofan finished compilation, thus achieving high performance. Tier-up is enabled through the flag FLAG_wasm_tier_up. Bug: v8:6600 Change-Id: I70552969c53d909a591666a1e7ce1ee1419b2f34 Reviewed-on: https://chromium-review.googlesource.com/1010422 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52759}
-
Andreas Haas authored
This CL splits the definition of ValueType and its helper functions into its own header file. R=clemensh@chromium.org Bug: v8:7570 Change-Id: I3aa776edb45839d7d38836e131df45732c685310 Reviewed-on: https://chromium-review.googlesource.com/1021810 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL introduces a JSOperator for Array.isArray and moves the corresponding lowering to JSCallReducer and JSTypedLowering. Bug: v8:7340, v8:7250 Change-Id: Iaa7ced2ad34bec8cccc9da1041007261168cf4b3 Reviewed-on: https://chromium-review.googlesource.com/1025092 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52757}
-
Sigurd Schneider authored
Bug: v8:7679 Change-Id: If8b6d9ad4f93eb2b98878c916625b7a344e5900c Reviewed-on: https://chromium-review.googlesource.com/1021532Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52756}
-
Andreas Haas authored
WebAssembly.instantiate is polymorphic, it can either take a module object as parameter, or a buffer source which should be compiled first. To share code between the two implementations, the module object was first passed to a promise (i.e. which is the result of compilation). However, passing the module object to a promise has a side effect if the module object has a then function. To avoid this side effect I remove this code sharing and call AsyncInstantiate directly in case the parameter is a module object. R=mstarzinger@chromium.org Bug: chromium:836141 Change-Id: I67b76d0d7761c5aeb2cf1deda45b6842e494eed4 Reviewed-on: https://chromium-review.googlesource.com/1025774Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52755}
-
Clemens Hammacher authored
Passing a pointer of the needed type, and then reading using ReadUnalignedValue is pointless, since the compiler can assume alignment of the pointer value. This CL fixes the remaining external refs of wasm to take an Address to a single buffer. R=ahaas@chromium.org Bug: v8:7570, v8:3770 Change-Id: If8a7324a4703e1e900cb3c5644baef207e6a371d Reviewed-on: https://chromium-review.googlesource.com/1023406 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Kenton Varda authored
For use cases with a large number of threads or a large number of isolates (or both), ThreadDataTable can be a major performance bottleneck due to O(n) lookup time of the linked list. Switching to a hash map reduces this to O(1). Example 1: Sandstorm.io, a Node.js app that utilizes "fibers", was observed spending the majority of CPU time iterating over the ThreadDataTable. See: https://sandstorm.io/news/2016-09-30-fiber-bomb-debugging-story Example 2: Cloudflare's Workers engine, a high-multi-tenancy web server framework built on V8 (but not Node), creates large numbers of threads and isolates per-process. It saw a 34x improvement in throughput when we applied this patch. Cloudflare has been using a patch in production since the Workers launch which replaces the linked list with a hash map -- but still global. This commit builds on that but goes further and creates a separate hash map and mutex for each isolate, with the table being a member of the Isolate class. This avoids any globals and should reduce lock contention. Bug: v8:5338 Change-Id: If0d11509afb2e043b888c376e36d3463db931b47 Reviewed-on: https://chromium-review.googlesource.com/1014407Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52753}
-
Marja Hölttä authored
BUG=v8:7490 Change-Id: I03421657d4abc3cd6e27ffafa6b922ea0e83b2b4 Reviewed-on: https://chromium-review.googlesource.com/1016381 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#52752}
-
Daniel Clifford authored
Bug: v8:7666 Change-Id: Ida9b6f964261bad75a4eb5d567ad37ec82569bcc Reviewed-on: https://chromium-review.googlesource.com/1023061 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#52751}
-
Marja Hölttä authored
LoadMaybeWeakField returns a TNode<MaybeObject>, and the only way to extract values from it is through explicit functions. Previous version: https://chromium-review.googlesource.com/1014106 BUG=v8:7308 Change-Id: I73bf3a007733ed84937e45336ac142011adc5151 Reviewed-on: https://chromium-review.googlesource.com/1023935Reviewed-by:
-
Ingvar Stepanyan authored
NewFunctionFromSharedFunctionInfo is not called with `undefined` anymore, and so can be changed to just accept `Handle<Context>`. Additionally, reporting script compilation to the debugger can now be moved into `Compiler::PostInstantiation`. R=yangguo@chromium.org Change-Id: I0a9b3fa51f87f41b4fc97a29f79c110c6246f273 Reviewed-on: https://chromium-review.googlesource.com/1024832Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52749}
-
Benedikt Meurer authored
Bug: chromium:830565 Change-Id: I1adab76e790a81f51f7b03165962992f5afecc99 Reviewed-on: https://chromium-review.googlesource.com/1023400 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52748}
-
- 23 Apr, 2018 27 commits
-
-
Erik Luo authored
This CL whitelists Console Command Line API callbacks on the V8 side. Bug: chromium:810176 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7afdd6bd4263cb4cb18bdf02b37ab3e822ae5c96 Reviewed-on: https://chromium-review.googlesource.com/1016094 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52747}
-
Vincent Belliard authored
On AArch64, we can't push arguments one by one because sp must always be 16 byte aligned. This patch adds a LiftoffStackSlots class which holds everything which has to be pushed. This way, on AArch64, we will be able to reserve the needed space and eventually add some padding. Then, all pushes will be converted to stores into this reserved space. Bug: v8:6600 Change-Id: I17480fb841f16e07356b35326c59e3c7f03ed012 Reviewed-on: https://chromium-review.googlesource.com/1023977 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
This function can be used to set breakpoint on any function call, including native functions without source code, for them new method is only one way to set breakpoint. R=dgozman@chromium.org Bug: chromium:828076 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iae8f4805b6e860a7ca008041fdfbe75e43a1959c Reviewed-on: https://chromium-review.googlesource.com/1023128 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52745}
-
Eric Holk authored
Bug: chromium:834693, chromium:834955 Change-Id: I243521f45c2b7e2457a37d34ab3629670d8fa39b Reviewed-on: https://chromium-review.googlesource.com/1020361 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
This CL introduced SafeForInterruptsScope. This scope overrides outer PostponeInterruptsScopes: - reschedule postponed interrupts if needed, - allow requesting new interrupts. As soon as scope removed interrupts are posponed if needed. This scope will be: - used to allow inspector to interrupt and terminate DebugeEvaluate::Local, - exposed with new flag on Isolate to implement SafeForTerminationScope in blink. R=yangguo@chromium.org Bug: chromium:820640 Change-Id: I15befc10c2cee393d1e3be48cecb31ee14dae638 Reviewed-on: https://chromium-review.googlesource.com/1022969 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 5728b3fb Original change's description: > [builtins] Separate species protectors for Array, TypedArray, Promise > > Previously, there was one species protector for Array, TypedArray and > Promise. This CL splits the protector in three separate ones. This means > that invalidating one of them does not have negative performance > implications for the other ones. > > Bug: chromium:835347, v8:7340 > Change-Id: Id84aa0071f17096192965264eb60ddadd1e8e73f > Reviewed-on: https://chromium-review.googlesource.com/1023408 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52733} Bug: chromium:835347, v8:7340 Change-Id: I0c0188a0723e206ddb362834bcf872b23cd7666d Reviewed-on: https://chromium-review.googlesource.com/1023811 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Embedder may implement any non trivial logic using embedder fields, e.g. creates wrappers lazily and store native pointer to native object inside embedder fields. R=yangguo@chromium.org Bug: v8:7588 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id14eb6e686f8945cb350cfe77e8a4b3c52c5ec5b Reviewed-on: https://chromium-review.googlesource.com/1013404Reviewed-by:
-
Aleksey Kozyatinskiy authored
This reverts commit bd7f5cf0. Reason for revert: does not work well. Original change's description: > Roll third_party/inspector_protocol to 59ca26e > > This roll includes: > - [inspector_protocol] first class citizien .pdl support > - [inspector_protocol] node uses script names inside own repository > > + removed .json file > > R=pfeldman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Idd87e80a3ce42198858ade4bcf6e6fec4b2f0731 > Reviewed-on: https://chromium-review.googlesource.com/804635 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52734} TBR=pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I64cfa2740c03a2c15db1eb483212adec8f5f6a76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1024350Reviewed-by:
-
Sigurd Schneider authored
This manages input_index directly in TranslatedFrame::iterator. I think the overhead is low enough, expecially since all uses of the iterator, except one, compute input_index anyway. Bug: v8:7679 Change-Id: I7e5fc08ff23a49415265afd617248c55f4d95e19 Reviewed-on: https://chromium-review.googlesource.com/1021711 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Pierre Langlois authored
The movw/movt instructions are only available since Armv7. One of the disassembly tests was expecting these instructions when, on Armv6, we generate a load literal. Change-Id: I2b11894b5de748fc185f341b0cd49fa518d005e5 Reviewed-on: https://chromium-review.googlesource.com/978143 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
-
Clemens Hammacher authored
This adds support for i32.div_u and i32.div_s, implemented on ia32 and x64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I920fb0613ecba0021dab0936690415be88d666e9 Reviewed-on: https://chromium-review.googlesource.com/1021890 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 5728b3fb. Reason for revert: Breaks noi18n build Original change's description: > [builtins] Separate species protectors for Array, TypedArray, Promise > > Previously, there was one species protector for Array, TypedArray and > Promise. This CL splits the protector in three separate ones. This means > that invalidating one of them does not have negative performance > implications for the other ones. > > Bug: chromium:835347, v8:7340 > Change-Id: Id84aa0071f17096192965264eb60ddadd1e8e73f > Reviewed-on: https://chromium-review.googlesource.com/1023408 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52733} TBR=sigurds@chromium.org,bmeurer@chromium.org Change-Id: Ied8b436e7991c759eb3b98702c142aa127a7e63c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:835347, v8:7340 Reviewed-on: https://chromium-review.googlesource.com/1024151Reviewed-by:
-
Marja Hölttä authored
This reverts commit c823ca95. Reason for revert: test failures Original change's description: > [csa] Add TNode<MaybeObject>. > > LoadMaybeWeakField returns a TNode<MaybeObject>, and the only way to extract > values from it is through explicit functions. > > BUG=v8:7308 > > Change-Id: I98da6b715527bb9976b4c78ed9caaa39fbcb3ed5 > Reviewed-on: https://chromium-review.googlesource.com/1014106 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52732} TBR=marja@chromium.org,petermarshall@chromium.org,tebbi@chromium.org Change-Id: Ie7ff36d39db1fedf668c21ed56532e364e93eca1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1024150Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52735}
-
Alexey Kozyatinskiy authored
This roll includes: - [inspector_protocol] first class citizien .pdl support - [inspector_protocol] node uses script names inside own repository + removed .json file R=pfeldman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idd87e80a3ce42198858ade4bcf6e6fec4b2f0731 Reviewed-on: https://chromium-review.googlesource.com/804635 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52734}
-
Sigurd Schneider authored
Previously, there was one species protector for Array, TypedArray and Promise. This CL splits the protector in three separate ones. This means that invalidating one of them does not have negative performance implications for the other ones. Bug: chromium:835347, v8:7340 Change-Id: Id84aa0071f17096192965264eb60ddadd1e8e73f Reviewed-on: https://chromium-review.googlesource.com/1023408 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Marja Hölttä authored
LoadMaybeWeakField returns a TNode<MaybeObject>, and the only way to extract values from it is through explicit functions. BUG=v8:7308 Change-Id: I98da6b715527bb9976b4c78ed9caaa39fbcb3ed5 Reviewed-on: https://chromium-review.googlesource.com/1014106 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Andreas Haas authored
At the moment, the isolate is allocated and initialized in a single step. This has the downside that the platform cannot register the isolate before the isolate gets initialized, and therefore the platform is not available for the isolate during initialization. With this CL we register the uninitialized isolate on the platform and initialize the isolate after that. This change is needed to allow the creation of task runners already during the initialization of the isolate. The related chromium CL: https://crrev.com/c/1015020 R=yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I52e89388a757f2693d1a800e7aa7701aa0080795 Reviewed-on: https://chromium-review.googlesource.com/1014044Reviewed-by:
-
Sigurd Schneider authored
This CL applies the previously introduced stack abstraction for constructing output frames to constructor stub frames. Bug: v8:7679 Change-Id: I707b3d11c033b29873317f5798e1ee89c13e9907 Reviewed-on: https://chromium-review.googlesource.com/1021410 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: I9684997c59664792fa69e5147fbf82e7931dbba1 Reviewed-on: https://chromium-review.googlesource.com/1023405Reviewed-by:
-
Ulan Degenbaev authored
This reverts commit 2998a176. Reason for revert: perf regressions crbug.com/835472 Original change's description: > [heap] Removing marking step size ramp-up interval heuristic. > > The heuristic is no longer needed now that we have concurrent marking. > > Bug: chromium:834371 > Change-Id: I8ca3eaacdab618f690d8007aff66713260ace19f > Reviewed-on: https://chromium-review.googlesource.com/1017123 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52693} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:834371 Change-Id: I574abd75e77ae9ff443419f01750a3f01072adaf Reviewed-on: https://chromium-review.googlesource.com/1023890Reviewed-by:
-
Sigurd Schneider authored
This CL applies the previously introduced stack abstraction for constructing output frames to argument adaptor frames. Bug: v8:7679 Change-Id: I07cb4447a8af510b24a8489d8abd047845a23e62 Reviewed-on: https://chromium-review.googlesource.com/1019148 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL also adds the simplified operator NumberIsNaN. Bug: v8:7340, v8:7250 Change-Id: Ifa44cf59b30ee700f7df61f8d58782a43fd0f3c5 Reviewed-on: https://chromium-review.googlesource.com/1023391Reviewed-by:
-
jgruber authored
Bug: v8:7382,v8:7682 Change-Id: I57aa1658e8136334e18390c422eded3713066728 Reviewed-on: https://chromium-review.googlesource.com/1023394 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52725}
-
Peter Marshall authored
There doesn't seem to be any reason to use our custom hashmap here, which has a more complicated interface. Change-Id: Ib08c2e400a3cb402a5984b925034aac29750c2ec Reviewed-on: https://chromium-review.googlesource.com/1019445Reviewed-by:
-
jgruber authored
When attributing ticks to a function, we first check if the current pc matches a section within the dynamic library. If we find a match here, then we don't continue looking within dynamically generated range information, e.g. for JS functions and builtins. This logic breaks when embedded builtins come into play. They live within the libv8.so shared library, and are found when looking up statics. But what we really want is to look up the dynamically generated code-range, which contains more precise information. In this CL, this case is detected by matching the found symbol name. If it's the embedded blob, then we continue to dynamic lookup. Bug: v8:6666 Change-Id: I7cea2cd4898f5a08381a071bdbc2f862b9c80880 Reviewed-on: https://chromium-review.googlesource.com/1023422 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL fixes the new {CodeReference} class to comply to the style guide. It makes it a proper class, renames private fields to end in an underscore and simplifies the union declaration. R=ahaas@chromium.org CC=herhut@chromium.org Bug: v8:7570 Change-Id: I329bbc6fca1ba3c0cb34fb4e1179eb4fa9044e76 Reviewed-on: https://chromium-review.googlesource.com/1023414Reviewed-by: -
Clemens Hammacher authored
For on-heap code, there is the nice feature of highlighting the current pc on the "jco" gdb macro (calling {Code->Print}, {Code->Disassemble} or {WasmCode::Disassemble}). For wasm code, this feature was missing so far. This CL adds it. R=ahaas@chromium.org Change-Id: I0ee86d3c5cf9f42581f03c2ba4ec16b4c992e016 Reviewed-on: https://chromium-review.googlesource.com/1021517Reviewed-by:
-
