• jgruber's avatar
    [prof] Attribute ticks in embedded builtins correctly · 384a51da
    jgruber authored
    When attributing ticks to a function, we first check if the current pc
    matches a section within the dynamic library. If we find a match here,
    then we don't continue looking within dynamically generated range
    information, e.g. for JS functions and builtins.
    
    This logic breaks when embedded builtins come into play. They live
    within the libv8.so shared library, and are found when looking up
    statics. But what we really want is to look up the dynamically
    generated code-range, which contains more precise information.
    
    In this CL, this case is detected by matching the found symbol name.
    If it's the embedded blob, then we continue to dynamic lookup.
    
    Bug: v8:6666
    Change-Id: I7cea2cd4898f5a08381a071bdbc2f862b9c80880
    Reviewed-on: https://chromium-review.googlesource.com/1023422
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52723}
    384a51da
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...