1. 09 Jan, 2017 1 commit
  2. 03 Jan, 2017 1 commit
  3. 19 Dec, 2016 3 commits
  4. 15 Dec, 2016 1 commit
  5. 12 Dec, 2016 2 commits
    • bradnelson's avatar
      [wasm] [asmjs] Route asm.js warnings to the dev console. · aabbbec6
      bradnelson authored
      Generalize Messages to include an error level.
      Add a parameter to AddMessageHandler to select which error levels to receive, using a mask (default being just errors, i.e. the current behavior).
      
      BUG=v8:4203
      R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chromium.org,jochen@chromium.org
      
      Review-Url: https://codereview.chromium.org/2526703002
      Cr-Commit-Position: refs/heads/master@{#41648}
      aabbbec6
    • clemensh's avatar
      [wasm] Generate correct locations for error messages · 222541df
      clemensh authored
      The current logic in Isolate::GetLocationFromStackTrace just ignores
      wasm frames, making the computed location point to the first javascript
      frame, like this:
      
      test.js:17: RuntimeError: divide by zero
      module.exports.main();
                     ^
      RuntimeError: divide by zero
          at main (<WASM>[1]+5)
          at test.js:17:16
      
      This CL not only fixes the location to point to the top-most wasm
      frame, but also exposes to the embedder that the script of that location
      is a wasm script, allowing for custom printing of wasm locations.
      The Shell::ReportException method now checks for this flag, and prints
      wasm locations like this:
      
      <WASM>[0]+5: RuntimeError: divide by zero
      RuntimeError: divide by zero
          at main (<WASM>[0]+5)
          at test/message/wasm-trap.js:15:16
      
      R=titzer@chromium.org, yangguo@chromium.org
      BUG=chromium:613110
      
      Review-Url: https://codereview.chromium.org/2563673002
      Cr-Commit-Position: refs/heads/master@{#41640}
      222541df
  6. 29 Nov, 2016 1 commit
  7. 22 Nov, 2016 1 commit
  8. 21 Nov, 2016 2 commits
  9. 09 Nov, 2016 1 commit
    • lpy's avatar
      [Tracing] Fix crash of --enable-tracing. · bc37b518
      lpy authored
      When we use unique_ptr on tracing controller and release it to platform,
      unique_ptr will crash when we try to start tracing with trace config, this patch
      replaces it with raw pointer and delete it explicitly at the end when needed.
      
      TBR=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2488003002
      Cr-Commit-Position: refs/heads/master@{#40871}
      bc37b518
  10. 08 Nov, 2016 1 commit
    • lpy's avatar
      [Tracing] Use TracingCategoryObserver in gc statistics · 7d28301d
      lpy authored
      This patch is a follow-up patch to enable gc statistics to use
      TracingCategoryObserver.
      
      Previously we need to pass --track_gc_object_stats to v8 if we want to enable
      gc statistics in tracing. In this patch, we introducce an integer flag
      FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
      will set it to 0x01, tracing will set it to 0x10 when we start tracing and
      reset the bit when we stop tracing.
      
      BUG=v8:5590
      
      Review-Url: https://codereview.chromium.org/2459903003
      Cr-Commit-Position: refs/heads/master@{#40817}
      7d28301d
  11. 07 Nov, 2016 1 commit
  12. 05 Nov, 2016 1 commit
  13. 04 Nov, 2016 2 commits
  14. 03 Nov, 2016 3 commits
  15. 31 Oct, 2016 3 commits
  16. 28 Oct, 2016 1 commit
    • lpy's avatar
      [Tracing] Implement TracingCategoryObserver. · 6df8096a
      lpy authored
      This patch implements TracingCategoryObserver to set global flag when a V8
      specific category is enabled. Previously, we set a global flag each time when we
      encounter a top level trace event, and use it as a global check. With this
      patch, we can set a group of flags when tracing is enabled; besides, we make
      V8 tracing feature use V8 flags instead of defining its own flag in a messy way.
      
      With this patch, whatever V8 flag we want to imply in tracing, we define another
      integer flag, and the original V8 flag will set it to 0x01 when passing by
      commandline, tracing will set it to 0x10 when we start tracing and reset the bit
      when we stop tracing.
      
      Review-Url: https://codereview.chromium.org/2436273002
      Cr-Commit-Position: refs/heads/master@{#40659}
      6df8096a
  17. 27 Oct, 2016 1 commit
  18. 25 Oct, 2016 1 commit
    • kozyatinskiy's avatar
      [inspector] enable inspector by default · d7a18896
      kozyatinskiy authored
      To achieve this:
      - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else.
      - fixed asan for d8 - unique_ptr on array has single element type.
      - force Debugger.disable at the end of test.
      
      BUG=chromium:635948
      R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
      
      Review-Url: https://codereview.chromium.org/2450653002
      Cr-Commit-Position: refs/heads/master@{#40546}
      d7a18896
  19. 24 Oct, 2016 1 commit
  20. 21 Oct, 2016 2 commits
  21. 20 Oct, 2016 2 commits
  22. 12 Oct, 2016 1 commit
  23. 11 Oct, 2016 3 commits
    • adamk's avatar
      [modules] Store Module metadata in per-Context EmbedderData · 9d2051fc
      adamk authored
      This is a re-land of https://codereview.chromium.org/2393303002/ with
      an additional call to DisposeModuleEmbedderData() added to fix lsan failures.
      
      Unifies the approaches used for storing the specifier -> module mapping
      and the module -> directory mapping, using std::unordered_maps for both
      and storing them per-Context.
      
      This requires adding a method to the v8::Module API to get a hash code
      for a Module, but allows slimming down the API in return: gone are
      SetEmbedderData/GetEmbedderData, along with the fourth argument
      to ResolveModuleCallback.
      
      Besides a simpler API, this allows d8 to get closer to the HTML loader,
      which requires each Realm to have a persistent module map (though this
      capability is not yet exercised by any tests).
      
      BUG=v8:1569
      TBR=neis@chromium.org,jochen@chromium.org
      
      Review-Url: https://codereview.chromium.org/2405313002
      Cr-Commit-Position: refs/heads/master@{#40186}
      9d2051fc
    • adamk's avatar
      Revert of [modules] Store Module metadata in per-Context EmbedderData... · 12779889
      adamk authored
      Revert of [modules] Store Module metadata in per-Context EmbedderData (patchset #7 id:120001 of https://codereview.chromium.org/2393303002/ )
      
      Reason for revert:
      Fails under LeakSanitizer on auto-roll fyi bot:
      
      https://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20release%20process/builds/49447
      
      Original issue's description:
      > [modules] Store Module metadata in per-Context EmbedderData
      >
      > Unifies the approaches used for storing the specifier -> module mapping
      > and the module -> directory mapping, using std::unordered_maps for both
      > and storing them per-Context.
      >
      > This requires adding a method to the v8::Module API to get a hash code
      > for a Module, but allows slimming down the API in return: gone are
      > SetEmbedderData/GetEmbedderData, along with the fourth argument
      > to ResolveModuleCallback.
      >
      > Besides a simpler API, this allows d8 to get closer to the HTML loader,
      > which requires each Realm to have a persistent module map (though this
      > capability is not yet exercised by any tests).
      >
      > BUG=v8:1569
      >
      > Committed: https://crrev.com/9cf8fce74cf6e7afd6aea3f3545f6bb61572f277
      > Cr-Commit-Position: refs/heads/master@{#40133}
      
      TBR=jochen@chromium.org,neis@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:1569
      
      Review-Url: https://codereview.chromium.org/2406973003
      Cr-Commit-Position: refs/heads/master@{#40145}
      12779889
    • adamk's avatar
      Revert of [d8] Fix LeakSanitizer failures on the bots due to... · 9da6f120
      adamk authored
      Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (patchset #2 id:20001 of https://codereview.chromium.org/2403303002/ )
      
      Reason for revert:
      Still failing on auto-roll fyi bot
      
      Original issue's description:
      > [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData
      >
      > BUG=v8:1569
      > TBR=jochen@chromium.org
      >
      > Committed: https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918
      > Cr-Commit-Position: refs/heads/master@{#40143}
      
      TBR=jochen@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:1569
      
      Review-Url: https://codereview.chromium.org/2403103004
      Cr-Commit-Position: refs/heads/master@{#40144}
      9da6f120
  24. 10 Oct, 2016 2 commits
  25. 06 Oct, 2016 1 commit
  26. 28 Sep, 2016 1 commit
    • zhengxing.li's avatar
      [tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in... · 990a8e39
      zhengxing.li authored
      [tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Platform Class.
      
        The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc compilation fail for v8 debug mode.
        The error message was:
        In file included from .././include/libplatform/v8-tracing.h:13:0,
                         from .././src/libplatform/default-platform.h:14,
                         from ../src/libplatform/default-platform.cc:5:
        .././include/v8-platform.h:169:20: error: ‘virtual uint64_t v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, unsigned int)’ was hidden [-Werror=overloaded-virtual]
           virtual uint64_t AddTraceEvent(
                            ^
        In file included from ../src/libplatform/default-platform.cc:5:0:
        .././src/libplatform/default-platform.h:55:12: error:   by ‘virtual uint64_t v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’ [-Werror=overloaded-virtual]
           uint64_t AddTraceEvent(
                    ^
      
        This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all declarations of AddTraceEvent functions in Classes derived from Platform Class.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2380583002
      Cr-Commit-Position: refs/heads/master@{#39810}
      990a8e39