- 09 Jan, 2017 1 commit
-
-
marja authored
Downside: this adds all kinds of weird includes in the .cc files. (See design doc linked in the bug.) BUG=v8:5402 Review-Url: https://codereview.chromium.org/2622503002 Cr-Commit-Position: refs/heads/master@{#42140}
-
- 03 Jan, 2017 1 commit
-
-
jochen authored
BUG= Review-Url: https://codereview.chromium.org/2609833003 Cr-Commit-Position: refs/heads/master@{#42022}
-
- 19 Dec, 2016 3 commits
-
-
yangguo authored
Hopefully we can avoid going through JS at all, so we can avoid this issue. R=jgruber@chromium.org, kozyatinskiy@chromium.org BUG=v8:5654 Review-Url: https://codereview.chromium.org/2510093002 Cr-Original-Commit-Position: refs/heads/master@{#41802} Committed: https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc914961735b1e Review-Url: https://codereview.chromium.org/2510093002 Cr-Commit-Position: refs/heads/master@{#41807}
-
yangguo authored
Revert of [inspector] gracefully handle stack overflows in the inspector. (patchset #13 id:240001 of https://codereview.chromium.org/2510093002/ ) Reason for revert: asan failure: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/10047/steps/Ignition%20-%20turbofan/logs/regress-2318 Original issue's description: > [inspector] gracefully handle stack overflows in the inspector. > > Hopefully we can avoid going through JS at all, so we can avoid this issue. > > R=jgruber@chromium.org, kozyatinskiy@chromium.org > BUG=v8:5654 > > Review-Url: https://codereview.chromium.org/2510093002 > Cr-Commit-Position: refs/heads/master@{#41802} > Committed: https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc914961735b1e TBR=jgruber@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5654 Review-Url: https://codereview.chromium.org/2583173002 Cr-Commit-Position: refs/heads/master@{#41805}
-
yangguo authored
Hopefully we can avoid going through JS at all, so we can avoid this issue. R=jgruber@chromium.org, kozyatinskiy@chromium.org BUG=v8:5654 Review-Url: https://codereview.chromium.org/2510093002 Cr-Commit-Position: refs/heads/master@{#41802}
-
- 15 Dec, 2016 1 commit
-
-
titzer authored
R=jochen@chromium.org, hpayer@chromium.org, verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2584563002 Cr-Commit-Position: refs/heads/master@{#41729}
-
- 12 Dec, 2016 2 commits
-
-
bradnelson authored
Generalize Messages to include an error level. Add a parameter to AddMessageHandler to select which error levels to receive, using a mask (default being just errors, i.e. the current behavior). BUG=v8:4203 R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2526703002 Cr-Commit-Position: refs/heads/master@{#41648}
-
clemensh authored
The current logic in Isolate::GetLocationFromStackTrace just ignores wasm frames, making the computed location point to the first javascript frame, like this: test.js:17: RuntimeError: divide by zero module.exports.main(); ^ RuntimeError: divide by zero at main (<WASM>[1]+5) at test.js:17:16 This CL not only fixes the location to point to the top-most wasm frame, but also exposes to the embedder that the script of that location is a wasm script, allowing for custom printing of wasm locations. The Shell::ReportException method now checks for this flag, and prints wasm locations like this: <WASM>[0]+5: RuntimeError: divide by zero RuntimeError: divide by zero at main (<WASM>[0]+5) at test/message/wasm-trap.js:15:16 R=titzer@chromium.org, yangguo@chromium.org BUG=chromium:613110 Review-Url: https://codereview.chromium.org/2563673002 Cr-Commit-Position: refs/heads/master@{#41640}
-
- 29 Nov, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:350797 R=dgozman@chromium.org TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2527473004 Cr-Commit-Position: refs/heads/master@{#41371}
-
- 22 Nov, 2016 1 commit
-
-
titzer authored
BUG=chromium:667603 R=clemensh@chromium.org Review-Url: https://codereview.chromium.org/2519363002 Cr-Commit-Position: refs/heads/master@{#41174}
-
- 21 Nov, 2016 2 commits
-
-
titzer authored
R=mstarzinger@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2520963002 Cr-Commit-Position: refs/heads/master@{#41154}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5654 Review-Url: https://codereview.chromium.org/2511733002 Cr-Commit-Position: refs/heads/master@{#41139}
-
- 09 Nov, 2016 1 commit
-
-
lpy authored
When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2488003002 Cr-Commit-Position: refs/heads/master@{#40871}
-
- 08 Nov, 2016 1 commit
-
-
lpy authored
This patch is a follow-up patch to enable gc statistics to use TracingCategoryObserver. Previously we need to pass --track_gc_object_stats to v8 if we want to enable gc statistics in tracing. In this patch, we introducce an integer flag FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats will set it to 0x01, tracing will set it to 0x10 when we start tracing and reset the bit when we stop tracing. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2459903003 Cr-Commit-Position: refs/heads/master@{#40817}
-
- 07 Nov, 2016 1 commit
-
-
yangguo authored
Using _exit on windows may cause race conditions in threads. BUG=chromium:603131 Review-Url: https://codereview.chromium.org/2478473003 Cr-Commit-Position: refs/heads/master@{#40789}
-
- 05 Nov, 2016 1 commit
-
-
machenbach authored
Revert of [Tracing] Use TracingCategoryObserver in gc statistics (patchset #5 id:100001 of https://codereview.chromium.org/2459903003/ ) Reason for revert: Speculative revert for blocking roll: https://codereview.chromium.org/2473003006/ E.g.: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331898 Original issue's description: > [Tracing] Use TracingCategoryObserver in gc statistics > > This patch is a follow-up patch to enable gc statistics to use > TracingCategoryObserver. > > Previously we need to pass --track_gc_object_stats to v8 if we want to enable > gc statistics in tracing. In this patch, we introducce an integer flag > FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats > will set it to 0x01, tracing will set it to 0x10 when we start tracing and > reset the bit when we stop tracing. > > BUG=v8:5590 TBR=fmeawad@chromium.org,mlippautz@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Review-Url: https://codereview.chromium.org/2477143002 Cr-Commit-Position: refs/heads/master@{#40785}
-
- 04 Nov, 2016 2 commits
-
-
lpy authored
This patch is a follow-up patch to enable gc statistics to use TracingCategoryObserver. Previously we need to pass --track_gc_object_stats to v8 if we want to enable gc statistics in tracing. In this patch, we introducce an integer flag FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats will set it to 0x01, tracing will set it to 0x10 when we start tracing and reset the bit when we stop tracing. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2459903003 Cr-Commit-Position: refs/heads/master@{#40777}
-
lpy authored
This patch is a follow-up patch to enable runtime statistics to use TracingCategoryObserver. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2460973003 Cr-Commit-Position: refs/heads/master@{#40745}
-
- 03 Nov, 2016 3 commits
-
-
lpy authored
Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (patchset #6 id:140001 of https://codereview.chromium.org/2460973003/ ) Reason for revert: Static-Initializers failed on Ubuntu-12.04 Original issue's description: > [Tracing] Use TracingCategoryObserver in runtime statistics > > This patch is a follow-up patch to enable runtime statistics to use > TracingCategoryObserver. > > BUG=v8:5590 TBR=cbruni@chromium.org,fmeawad@chromium.org,alph@chromium.org,bmeurer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Review-Url: https://codereview.chromium.org/2469403005 Cr-Commit-Position: refs/heads/master@{#40743}
-
lpy authored
This patch is a follow-up patch to enable runtime statistics to use TracingCategoryObserver. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2460973003 Cr-Commit-Position: refs/heads/master@{#40742}
-
lpy authored
This patch removes TracingCategoryObserver API and moves the creation of observer inside platform initialization, by assuming that either Platform::AddTraceStateObserver is implemented correctly to add observer to tracing controller that implemented by embedders, or default tracing controller has already been set up and attached to platform before v8::V8::InitializePlatform is called. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2471583004 Cr-Commit-Position: refs/heads/master@{#40739}
-
- 31 Oct, 2016 3 commits
-
-
lpy authored
We only need included categories list, excluded categories list will only work if we use regular expression in categories list, which is not supported in V8. TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2462143002 Cr-Commit-Position: refs/heads/master@{#40681}
-
jgravelle authored
This function is implemented in other JavaScript shells BUG=None R=titzer Review-Url: https://codereview.chromium.org/2458963003 Cr-Commit-Position: refs/heads/master@{#40677}
-
jgruber authored
This exposes a couple of broken tests that used to silently throw within the listener. Mark these as failing for now BUG=v8:5330, v8:5581 Review-Url: https://codereview.chromium.org/2460833002 Cr-Commit-Position: refs/heads/master@{#40672}
-
- 28 Oct, 2016 1 commit
-
-
lpy authored
This patch implements TracingCategoryObserver to set global flag when a V8 specific category is enabled. Previously, we set a global flag each time when we encounter a top level trace event, and use it as a global check. With this patch, we can set a group of flags when tracing is enabled; besides, we make V8 tracing feature use V8 flags instead of defining its own flag in a messy way. With this patch, whatever V8 flag we want to imply in tracing, we define another integer flag, and the original V8 flag will set it to 0x01 when passing by commandline, tracing will set it to 0x10 when we start tracing and reset the bit when we stop tracing. Review-Url: https://codereview.chromium.org/2436273002 Cr-Commit-Position: refs/heads/master@{#40659}
-
- 27 Oct, 2016 1 commit
-
-
mstarzinger authored
This prepares the code-base so that Ignition can be enabled on a certain subset of compilations without setting the {FLAG_ignition} flag (which enables Ignition on all compilations). We should not check the flag in question explicitly anywhere outside of the compiler heuristics. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2443573002 Cr-Commit-Position: refs/heads/master@{#40617}
-
- 25 Oct, 2016 1 commit
-
-
kozyatinskiy authored
To achieve this: - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else. - fixed asan for d8 - unique_ptr on array has single element type. - force Debugger.disable at the end of test. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2450653002 Cr-Commit-Position: refs/heads/master@{#40546}
-
- 24 Oct, 2016 1 commit
-
-
mstarzinger authored
Revert of [compiler] Prepare for partially shipping Ignition. (patchset #1 id:1 of https://codereview.chromium.org/2443573002/ ) Reason for revert: Causes regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=658711 Original issue's description: > [compiler] Prepare for partially shipping Ignition. > > This prepares the code-base so that Ignition can be enabled on a certain > subset of compilations without setting the {FLAG_ignition} flag (which > enables Ignition on all compilations). We should not check the flag in > question explicitly anywhere outside of the compiler heuristics. > > R=mvstanton@chromium.org BUG=chromium:658711 TBR=mvstanton@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2448443002 Cr-Commit-Position: refs/heads/master@{#40534}
-
- 21 Oct, 2016 2 commits
-
-
mstarzinger authored
This prepares the code-base so that Ignition can be enabled on a certain subset of compilations without setting the {FLAG_ignition} flag (which enables Ignition on all compilations). We should not check the flag in question explicitly anywhere outside of the compiler heuristics. R=mvstanton@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2443573002 Cr-Commit-Position: refs/heads/master@{#40507}
-
yangguo authored
This introduces: - a way in d8 to send messages to the inspector and receive responses. - a new test suite where existing debugger tests should migrate to. R=jgruber@chromium.org, kozyatinskiy@chromium.org, machenbach@chromium.org BUG=v8:5530 Review-Url: https://chromiumcodereview.appspot.com/2425973002 Cr-Commit-Position: refs/heads/master@{#40487}
-
- 20 Oct, 2016 2 commits
-
-
mstarzinger authored
Breaks layout tests on Blink builders. TBR=machenbach@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428413004 Cr-Commit-Position: refs/heads/master@{#40471}
-
mstarzinger authored
This enables Ignition unconditionally for all code that is destined for optimization with TurboFan. This ensures all optimization attempts will go through the BytecodeGraphBuilder and that the AstGraphBuilder pipe is dried out in practice. R=mvstanton@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2427953002 Cr-Commit-Position: refs/heads/master@{#40462}
-
- 12 Oct, 2016 1 commit
-
-
fmeawad authored
The state sampling was implemented in chrome, we had an interface for it V8 but it was not implemented yet. The chrome version version has been removed in https://codereview.chromium.org/2406703002/ Therefore following up with its removal in V8 as well. This CL can land independent of the Chromium related CL. R=primiano@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2410523002 Cr-Commit-Position: refs/heads/master@{#40232}
-
- 11 Oct, 2016 3 commits
-
-
adamk authored
This is a re-land of https://codereview.chromium.org/2393303002/ with an additional call to DisposeModuleEmbedderData() added to fix lsan failures. Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 TBR=neis@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2405313002 Cr-Commit-Position: refs/heads/master@{#40186}
-
adamk authored
Revert of [modules] Store Module metadata in per-Context EmbedderData (patchset #7 id:120001 of https://codereview.chromium.org/2393303002/ ) Reason for revert: Fails under LeakSanitizer on auto-roll fyi bot: https://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20release%20process/builds/49447 Original issue's description: > [modules] Store Module metadata in per-Context EmbedderData > > Unifies the approaches used for storing the specifier -> module mapping > and the module -> directory mapping, using std::unordered_maps for both > and storing them per-Context. > > This requires adding a method to the v8::Module API to get a hash code > for a Module, but allows slimming down the API in return: gone are > SetEmbedderData/GetEmbedderData, along with the fourth argument > to ResolveModuleCallback. > > Besides a simpler API, this allows d8 to get closer to the HTML loader, > which requires each Realm to have a persistent module map (though this > capability is not yet exercised by any tests). > > BUG=v8:1569 > > Committed: https://crrev.com/9cf8fce74cf6e7afd6aea3f3545f6bb61572f277 > Cr-Commit-Position: refs/heads/master@{#40133} TBR=jochen@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2406973003 Cr-Commit-Position: refs/heads/master@{#40145}
-
adamk authored
Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (patchset #2 id:20001 of https://codereview.chromium.org/2403303002/ ) Reason for revert: Still failing on auto-roll fyi bot Original issue's description: > [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData > > BUG=v8:1569 > TBR=jochen@chromium.org > > Committed: https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918 > Cr-Commit-Position: refs/heads/master@{#40143} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2403103004 Cr-Commit-Position: refs/heads/master@{#40144}
-
- 10 Oct, 2016 2 commits
-
-
adamk authored
BUG=v8:1569 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2403303002 Cr-Commit-Position: refs/heads/master@{#40143}
-
adamk authored
Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 Review-Url: https://codereview.chromium.org/2393303002 Cr-Commit-Position: refs/heads/master@{#40133}
-
- 06 Oct, 2016 1 commit
-
-
adamk authored
d8 now elides './' when constructing absolute paths. '../' is still not normalized. R=neis@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2393243002 Cr-Commit-Position: refs/heads/master@{#40057}
-
- 28 Sep, 2016 1 commit
-
-
zhengxing.li authored
[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Platform Class. The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc compilation fail for v8 debug mode. The error message was: In file included from .././include/libplatform/v8-tracing.h:13:0, from .././src/libplatform/default-platform.h:14, from ../src/libplatform/default-platform.cc:5: .././include/v8-platform.h:169:20: error: ‘virtual uint64_t v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, unsigned int)’ was hidden [-Werror=overloaded-virtual] virtual uint64_t AddTraceEvent( ^ In file included from ../src/libplatform/default-platform.cc:5:0: .././src/libplatform/default-platform.h:55:12: error: by ‘virtual uint64_t v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’ [-Werror=overloaded-virtual] uint64_t AddTraceEvent( ^ This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all declarations of AddTraceEvent functions in Classes derived from Platform Class. BUG= Review-Url: https://codereview.chromium.org/2380583002 Cr-Commit-Position: refs/heads/master@{#39810}
-