- 11 Jan, 2017 40 commits
-
-
jshin authored
Move the language code checking for 4 languages requiring special case mapping to C++ from JavaScript. This is a speculative fix for crashes reported from Windows and Mac Chrome canary builds when icu-case-mapping is enabled by default. (see crbug.com/676643) In addition, tighten up comparision operators in a couple of places in i18n.js (=== and !== instead of == and !=). BUG=v8:4477, v8:4476, chromium:676643 TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Review-Url: https://codereview.chromium.org/2621393002 Cr-Commit-Position: refs/heads/master@{#42246}
-
petermarshall authored
Review-Url: https://codereview.chromium.org/2623023003 Cr-Commit-Position: refs/heads/master@{#42245}
-
bradnelson authored
This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244}
-
scottmg authored
This is part of removing the dependency of the Chromium browser DLL on Windows on V8. R=jochen@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2621983002 Cr-Commit-Position: refs/heads/master@{#42243}
-
clemensh authored
Also, add a runtime function to call the interpreter, passing a stack-allocated buffer holding the arguments. The WASM_INTERPRETER_ENTRY stub allocates the stack slot for the arguments, fills it, and calls to the wasm interpreter. It's abi is compatible with WASM functions, such that we can just replace a call to a WASM_FUNCTION with a call to WASM_INTERPRETER_ENTRY. See tracking bug to get the overall picture. BUG=v8:5822 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2619803004 Cr-Commit-Position: refs/heads/master@{#42242}
-
bradnelson authored
These interfere with layout tests. BUG=v8:4203 R=titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2628703003 Cr-Commit-Position: refs/heads/master@{#42241}
-
ahaas authored
R=titzer@chromium.org BUG=chromium:679352 TEST=cctest/test-run-wasm-interpreter/GrowMemory Review-Url: https://codereview.chromium.org/2627943002 Cr-Commit-Position: refs/heads/master@{#42240}
-
clemensh authored
This will be used to pass parameters of wasm functions to the wasm interpreter. All of them need to be packed into one buffer, which is then passed to the interpreter. R=ahaas@chromium.org, titzer@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2624183002 Cr-Commit-Position: refs/heads/master@{#42239}
-
ahaas authored
According to the latest spec changes the WasmToJS wrapper and the JSToWasm wrapper through a TypeError if the signature of the wrapper contains a I64 parameter or return value. Originally the TypeError was thrown when the parameter or return value was converted to or from JS. In addition I removed all special handling of I64 parameters and return values in the wrappers which was already dead code. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2626853003 Cr-Commit-Position: refs/heads/master@{#42238}
-
ahaas authored
Original commit message: [wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2627003002 Cr-Commit-Position: refs/heads/master@{#42237}
-
leszeks authored
Since type feedback is stored as Smis, we can avoid a few shift instructions per bytecode handler by performing type feedback updates on Smis directly, rather than converting between Smi and Word32. Review-Url: https://codereview.chromium.org/2624753002 Cr-Commit-Position: refs/heads/master@{#42236}
-
jkummerow authored
using newly introduced ThinStrings, which store a pointer to the actual, internalized string they represent. BUG=v8:4520 (Previously landed as #42168 / af51befe) (Previously landed as #42193 / 4c699e34) Review-Url: https://codereview.chromium.org/2549773002 Cr-Commit-Position: refs/heads/master@{#42235}
-
rdevlin.cronin authored
The Local<Value> in the MessageCallback typedef is named "error", but should be "data" - it's referred to as "data" everywhere else, and that seems to be the canonical name for a curried-in value. BUG=None Review-Url: https://codereview.chromium.org/2621163003 Cr-Commit-Position: refs/heads/master@{#42234}
-
titzer authored
R=rossberg@chromium.org BUG=v8:5814,chromium:575167 Review-Url: https://codereview.chromium.org/2623183002 Cr-Commit-Position: refs/heads/master@{#42233}
-
machenbach authored
BUG=chromium:680110 TBR=clemensh@chromium.org, titzer@chromium.org, ahaas@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2626073002 Cr-Commit-Position: refs/heads/master@{#42232}
-
titzer authored
R=rossberg@chromium.org BUG=v8:5813,chromium:575167 Review-Url: https://codereview.chromium.org/2620203005 Cr-Commit-Position: refs/heads/master@{#42231}
-
ahaas authored
Original commit message: [wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2628433004 Cr-Commit-Position: refs/heads/master@{#42230}
-
jarin authored
Review-Url: https://codereview.chromium.org/2626013002 Cr-Commit-Position: refs/heads/master@{#42229}
-
ulan authored
for debugging. This function is needed to pass increased heap limit from the main DevTools isolate to the worker isolates it spawns. BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2624973003 Cr-Commit-Position: refs/heads/master@{#42228}
-
hpayer authored
BUG=chromium:676635 Review-Url: https://codereview.chromium.org/2628853002 Cr-Commit-Position: refs/heads/master@{#42227}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2621303002 Cr-Commit-Position: refs/heads/master@{#42226}
-
ulan authored
This API will allow DevTools to intercept out-of-memory condition, increase the heap limit and schedule heap snapshot. BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2621873003 Cr-Commit-Position: refs/heads/master@{#42225}
-
mstarzinger authored
This changes the BytecodeGraphBuilder interface to make the fact that graph construction is independent of a closure explicit. A valid graph can be constructed by providing only the pair of statically known values for SharedFunctionInfo and TypeFeedbackVector. This is in preparation of inlining based on the SharedFunctionInfo. R=jarin@chromium.org BUG=v8:2206 Review-Url: https://codereview.chromium.org/2626623002 Cr-Commit-Position: refs/heads/master@{#42224}
-
jarin authored
This is mainly to catch a crash that we see in Canary with escape analysis on. Review-Url: https://codereview.chromium.org/2625893003 Cr-Commit-Position: refs/heads/master@{#42223}
-
machenbach authored
Revert of [wasm] Enable WASM by default (--expose-wasm=true). (patchset #3 id:40001 of https://codereview.chromium.org/2623743003/ ) Reason for revert: layout test breakages: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12574 revert first to unblock rolling. otherwise please rebaseline. Original issue's description: > [wasm] Enable WASM by default (--expose-wasm=true). > > BUG=chromium:575167 > R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@chromium.org > > Review-Url: https://codereview.chromium.org/2623743003 > Cr-Original-Commit-Position: refs/heads/master@{#42197} > Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f > Review-Url: https://codereview.chromium.org/2623743003 > Cr-Commit-Position: refs/heads/master@{#42214} > Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346a8a84 TBR=clemensh@chromium.org,ahaas@chromium.org,bradnelson@chromium.org,rossberg@chromium.org,bradnelson@google.com,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2621323002 Cr-Commit-Position: refs/heads/master@{#42222}
-
rmcilroy authored
This CL modifies the ast-numbering phase to collect function literals which should be compiled eagerly. This is then used to eagerly compile the inner functions before compiling the outer function. This will be used to queue compilation jobs on the CompilerDispatcher in a later CL. This CL moves the compilation of eager inner functions out of the GetSharedFunctionInfo function and instead compiles them explicitly. This simplifies GetSharedFunctionInfo and also means there is no need to pass a LazyCompilationMode to the function, so this concept has been removed. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2618553004 Cr-Commit-Position: refs/heads/master@{#42221}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589203002 Cr-Original-Commit-Position: refs/heads/master@{#41911} Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 Review-Url: https://codereview.chromium.org/2589203002 Cr-Commit-Position: refs/heads/master@{#42220}
-
jkummerow authored
This has been broken since forever. BUG=v8:5669 Review-Url: https://codereview.chromium.org/2610343002 Cr-Commit-Position: refs/heads/master@{#42219}
-
jgruber authored
Most notably, the interpreter now calls this stub instead of the runtime. BUG= Review-Url: https://codereview.chromium.org/2619163004 Cr-Commit-Position: refs/heads/master@{#42218}
-
machenbach authored
BUG=chromium:680064 TBR=clemensh@chromium.org, titzer@chromium.org, ahaas@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2620333002 Cr-Commit-Position: refs/heads/master@{#42217}
-
mstarzinger authored
R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2624113002 Cr-Commit-Position: refs/heads/master@{#42216}
-
machenbach authored
Also suppress a testcase using f.arguments. BUG=chromium:662424 TBR=jarin@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2625983002 Cr-Commit-Position: refs/heads/master@{#42215}
-
titzer authored
BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42214}
-
clemensh authored
and rename WasmFrame to WasmCompiledFrame. The WasmToInterpreterFrames are not used yet; this will follow in a follow-up CL (see tracking bug for the overall picture). Those frames will represent frames for WASM_TO_INTERPRETER stubs, which call from wasm code to the wasm interpreter, implemented in C++. They will support the Summarize method to inspect the stack frames in the wasm interpreter. R=yangguo@chromium.org, titzer@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2623773004 Cr-Commit-Position: refs/heads/master@{#42213}
-
jkummerow authored
Revert of Internalize strings in-place (patchset #17 id:320001 of https://codereview.chromium.org/2549773002/ ) Reason for revert: blocks roll, see: https://codereview.chromium.org/2628733002/ Debug mode runs into an Abort("External string expected, but not found"). Original issue's description: > Internalize strings in-place (reland) > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > BUG=v8:4520 > > (Previously landed as #42168 / af51befe. > > Review-Url: https://codereview.chromium.org/2549773002 > Cr-Commit-Position: refs/heads/master@{#42193} > Committed: https://chromium.googlesource.com/v8/v8/+/4c699e349a4986b28574b3a51e8780e3a3d067b1 TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4520 Review-Url: https://codereview.chromium.org/2625073002 Cr-Commit-Position: refs/heads/master@{#42212}
-
machenbach authored
BUG=chromium:679957 NOTRY=true TBR=jarin@chromium.org,bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2628813002 Cr-Commit-Position: refs/heads/master@{#42211}
-
franzih authored
Lower StoreDataPropertyInLiteral() when storing computed property names in object literals. Add a new AccessMode, kStoreInLiteral. It is similar to AccessMode::kStore but does not look up properties on the prototype chain. 99% of all literal definitions with computed property names end up with generic access_info because of how we count properties. Once we fix https://bugs.chromium.org/p/v8/issues/detail?id=5625, they'll get lowered as well. BUG=v8:5624 Review-Url: https://codereview.chromium.org/2619773002 Cr-Commit-Position: refs/heads/master@{#42210}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/da5025b..91344e6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/886ff59..8b10e78 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2622133002 Cr-Commit-Position: refs/heads/master@{#42209}
-
zhengxing.li authored
port 0c4b8ff4 (r42192) original commit message: - Refactor Dispatch tables to have separate function, signature tables - New Relocation type for WasmFunctionTableReference, assembler, compiler support. - RelocInfo helper functions for Wasm references BUG= Review-Url: https://codereview.chromium.org/2623133002 Cr-Commit-Position: refs/heads/master@{#42208}
-
aseemgarg authored
R=bradnelson@chromium.org BUG=v8:5809 Review-Url: https://codereview.chromium.org/2625853003 Cr-Commit-Position: refs/heads/master@{#42207}
-