- 30 Aug, 2021 7 commits
-
-
Georg Neis authored
These methods are called only during the inlining phase, so even in the default configuration we follow the same branch as concurrent inlining and ignore the serialized data. We can thus tighten their return types and cut down JSBoundFunctionData. Bug: v8:7790 Change-Id: Ic48f8f2651d684440dc5f6a9934de2ae3a5b5132 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123410Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76561}
-
Jakob Gruber authored
As per the release plan in crbug.com/v8/12142. Bug: v8:7790,v8:12142 Change-Id: I80e2a3c571681a968ea245d52adfa539e0e7ab7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3127711 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76560}
-
Jakob Gruber authored
.. to consistently support more than a single argument. Each argument is now a tagged union that may contain an AST string, a C string, or a JS string handle. Change-Id: Iac8e40b717dea95a2bc2903449dab56c181702d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122086 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76559}
-
Fergus Dall authored
This reverts commit adb6276f. Reason for revert: Broke several blink unit tests, see https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25255/overview for an example Original change's description: > Reland "cppgc: Enable checks for assignments in prefinalizers" > > This is a reland of edcc8ff5 > > Cause for previous revert was addressed by crbug.com/1241773. > > Original change's description: > > cppgc: Enable checks for assignments in prefinalizers > > > > Bug: v8:11749 > > Change-Id: Ic027f732030fb6a2befeffeca9db2eacfd0830a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099953 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#76370} > > Bug: v8:11749 > Change-Id: I57fc138ace002d41e54f7f70250e4d19bc9262b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122153 > Auto-Submit: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76553} Bug: v8:11749 Change-Id: Icc6a3e56d54c22de943b498c2fd6d57f3ef33f96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3128562 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76558}
-
Yu Yin authored
Change-Id: I49276c44d4b457d65be0e5e922c7c473bb64071e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124216 Auto-Submit: Yu Yin <xwafish@gmail.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Achenbach authored
The runtime-function blocking is implemented in V8 behind the --fuzzing flag since a while now. The legacy blocklist on the fuzzer side can be removed since some time now - it already diverted. No-Try: true Bug: chromium:1044942 Change-Id: I55f92419beb4d4462cbe03918dbf84d9c979862d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124810 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bb0b1e9..609fda6 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia33684dc160a1d490d2ebefceec59175486bfdfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3128307Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76555}
-
- 29 Aug, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bf6f9ce..bb0b1e9 Rolling v8/third_party/aemu-linux-x64: oGv3yTl6dFNfI8UFd1J4dLV7QgFxe8HeuXPcvvBqsygC..ddSGEd1PA5UG-ur2YFNiaY2SuddaJRHJB8HprZVuD68C Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/a38aef9..ece15d0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3c6e9c019d82f2574a1e4c324625d30ac57564f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3127580Reviewed-by:
-
- 28 Aug, 2021 5 commits
-
-
Omer Katz authored
This is a reland of edcc8ff5 Cause for previous revert was addressed by crbug.com/1241773. Original change's description: > cppgc: Enable checks for assignments in prefinalizers > > Bug: v8:11749 > Change-Id: Ic027f732030fb6a2befeffeca9db2eacfd0830a5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099953 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76370} Bug: v8:11749 Change-Id: I57fc138ace002d41e54f7f70250e4d19bc9262b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122153 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76553}
-
Michael Achenbach authored
The CL https://crrev.com/c/2928505 changed tests without changing the fuzzer with the result that tests fail now. It's not helpful to switch to using new API methods in generated fuzz tests, as they'd then not bisect well backwards to older V8 versions. No-Try: true Change-Id: Ia307e88b4532bd792091b23374889f2b0e490fce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124809 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76552}
-
Frank Tang authored
Land some of the tests for Temporal.PlainDate All marked as FAIL at this stage. Bug: v8:11544 Change-Id: I004b7cb34effe1de1735b61c7ac749ae3c8e9bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085624 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#76551}
-
Frank Tang authored
Land some of the tests for Temporal.Instant All marked as FAIL at this stage. Bug: v8:11544 Change-Id: I79d14df47248c708e5d73a0e00e3f7973c521d16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086903 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/37c02f2..bf6f9ce Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/295492f..2bbb839 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/094e3dd..bd0674c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5ab37cd..403247e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3a36585169b9ace304af1aadd040b3d03f14c194 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3126035Reviewed-by:
-
- 27 Aug, 2021 27 commits
-
-
Milad Fa authored
Change-Id: Ic2289faa55788554b4f300d8548f33b1cbcafcb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123022Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76548}
-
Ng Zhi An authored
These are either unused or have been defined in the shared-macro-assembler. Bug: v8:11589 Change-Id: I161c60c33641db7d68ce25ff7da8366a19db1a20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123637Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76547}
-
Ng Zhi An authored
These are unused Pmaddubsw, Pblendvb, Blendvps, Blendvpd. Bug: v8:11879 Change-Id: Idff00ee031bc76698f2ddd92b6495450add0242d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123636Reviewed-by:
-
Bruce Dawson authored
For historical reasons MinGW used to define a higher value for _WIN32_WINNT. Over years of refactoring this turned into a _lower_ value, which has then started breaking compilation on MinGW. This change gets ride of the MinGW specific value. R: mlippautz@chromium.org Bug: V8:12099 Change-Id: Ic24b71c6767cd4d1b53a6cb6487517dec614cd1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123639Reviewed-by:
-
Junliang Yan authored
Change-Id: Ifc75747a179486b6fe173c2d34f72f66c1918d88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124813Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76544}
-
Junliang Yan authored
Change-Id: I8891da57d90d0a88e55d869f334215b2d3d05b02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125174Reviewed-by:
-
Junliang Yan authored
Change-Id: If4fb93b5c1f0775b6caaff2a5842fe07dfadb286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124812Reviewed-by:
-
Junliang Yan authored
Change-Id: If7a6bd6a39f24d016d8596bd107a912bdf9bd751 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124811Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:11826 Change-Id: Id1e236376cda3514554cdad7229094fabee280d6 Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124803 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76540}
-
Ng Zhi An authored
Handle all 4 selects that wasm-compiler generates. Also modify unittest to allow optional operations (select operations are not supported on all archs). Bug: v8:12136 Change-Id: Ia54d7a71cffaa1c5cc8203520a1f3d812997bbb1 Fixed: v8:12136 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3119991Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Victor Gomes authored
Minor improvements for on heap reference vectors: - Use emplace_back instead of push_back. - Reserve initial capacity. Bug: v8:11993 Change-Id: Ie2f9ad9cc48d1b48a76419459a9ac721f4079175 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124802 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 732f394c Original Commit Message: StaGlobal didn't write the accumulator, but the baseline implementation assumed that it could preserve the accumulator by taking the return value of the StoreGlobalIC. This almost always worked, except for setters on the global object. Fix this by marking StaGlobal as clobbering the accumulator, same as StaNamedProperty (StaNamedProperty needs to do this anyway to avoid inlined setters from needing to create accumulator-preserving frames; StaGlobal would have needed the same thing if we'd ever inlined setters for it). Also, add a new debug scope, EnsureAccumulatorPreservedScope, to the baseline compiler, which checks if the accumulator value is preserved across non-accumulator-writing bytecodes. This found a (benign) bug with ForInPrepare, so fix that too. R=leszeks@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Id8ada05abeb1a9c7e8a16936c35be9d652c4e8b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124529Reviewed-by:
-
Leszek Swirski authored
Add a CodePageCollectionMemoryModificationScope to CompileAllWithBaseline so that we still get W^X batching under --always-sparkplug Change-Id: Ic522ef26a9fce1e10d409015ee0dfb3917ffa7c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124796 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#76536}
-
Manos Koukoutos authored
Change-Id: I8ac9f04ce8410f8ca81b1436850cd96ce79a3b6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122161 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:11826 Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng Change-Id: I1e77562cd86aa5b3a3a8c51e7bb4d37079b450d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3118947 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Given ref.func, we might need to wrap any function in the program, as opposed to imported functions only. Change-Id: I79942ef2dabf3b6da2d26b49167db6caff53745e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122160 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
WriteInitializerExpressions did not emit the final 'end' opcode, and expected call sites to do so, which they did not do consistently. We move this functionality to WriteInitializerExpression. Change-Id: Idf42272a3dbdfd0d7f22675731e193584f75c41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122159 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Rakhim Khismet authored
We add br.on_null, ref.as_non_null and ref.eq to the fuzzed module. They are called when liftoff is used. ref.is_null has been changed, according to comments from the last CL. GetRefType has been removed. Bug: v8:11954 Change-Id: If93f6e9911cbcd3001ab45da02ebc037af8bdc54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122171 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76531}
-
Al Muthanna Athamina authored
Bug: v8:11826 Change-Id: I95a41939dbaca7a14f40a7823a8fa90f45fd9310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059681 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Mythri A authored
--stress-concurrent-inlining disables lazy feedback allocation. These tests require lazy feedback allocation to compile baseline code. Listing them in INCOMPATIBLE_FLAGS_PER_VARIANT isn't sufficient for NumFuzzer. Bug: v8:12088 Change-Id: I4fe091d27e104f4d9acda447fcf43f9a52bf60dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123420 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This is a reland of 80f10346 Original change's description: > Reland "heap: Use generic flags for main-thread only flags" > > This is a reland of 2a8e2a9b > > Original change's description: > > heap: Use generic flags for main-thread only flags > > > > BasicMemoryChunk flags should only be mutated from the main thread > > when no concurrent task can access them. For that purpose it is enough > > to use regular non-atomic flags as they are immutable while the GC is > > running. > > > > Change-Id: I0a9f8ecb2eb2aafaf17e77626ae27604abd1b618 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3107230 > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#76471} > > Change-Id: Iaf495546f82291ab674537f5d39e10d0495ac612 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3117486 > Auto-Submit: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76506} Change-Id: I662bccdf94fc53efcdd209f85d6b044786dee250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123412 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#76528}
-
Mythri A authored
Bug: v8:12088 Change-Id: Ibc4db95125d44eca110829f1c043e769de5bd349 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123416 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Optimisation affects both reachability and tier-up, so disable it for the flushing tests. This should de-flake the Numfuzz bots. Change-Id: I87c479f216eae2d801e7a0dc665e7325bd1b6bd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123415 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
StaGlobal didn't write the accumulator, but the baseline implementation assumed that it could preserve the accumulator by taking the return value of the StoreGlobalIC. This almost always worked, except for setters on the global object. Fix this by marking StaGlobal as clobbering the accumulator, same as StaNamedProperty (StaNamedProperty needs to do this anyway to avoid inlined setters from needing to create accumulator-preserving frames; StaGlobal would have needed the same thing if we'd ever inlined setters for it). Also, add a new debug scope, EnsureAccumulatorPreservedScope, to the baseline compiler, which checks if the accumulator value is preserved across non-accumulator-writing bytecodes. This found a (benign) bug with ForInPrepare, so fix that too. Fixed: chromium:1242306 Change-Id: I220b5b1c41010c16ac9f944cbd55d2705c299434 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122325 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76525}
-
Frank Tang authored
Land some of the tests for Temporal.Duration All marked as FAIL at this stage. Bug: v8:11544 Change-Id: I4696edee7a2345133ed13c25aa720febe1f8fc69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087363 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Lu Yahan authored
This is causing a warning on newer build configs (crrev.com/c/3117087) Change-Id: I8cf7644861c27b9959283510163ecf8acdb6bdc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124174 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76523}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6916c05..37c02f2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4241fca..295492f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fc66578..094e3dd Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/ff21b36..955c7f8 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idfcb99ea06fe22c031d512c443ed9d3e4dd93eed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123072Reviewed-by:
-
