• Milad Fa's avatar
    PPC/s390: [sparkplug] skip test on unsupported platforms · aed61ff4
    Milad Fa authored
    Port 732f394c
    
    Original Commit Message:
    
        StaGlobal didn't write the accumulator, but the baseline implementation
        assumed that it could preserve the accumulator by taking the return
        value of the StoreGlobalIC. This almost always worked, except for
        setters on the global object.
    
        Fix this by marking StaGlobal as clobbering the accumulator, same as
        StaNamedProperty (StaNamedProperty needs to do this anyway to avoid
        inlined setters from needing to create accumulator-preserving frames;
        StaGlobal would have needed the same thing if we'd ever inlined setters
        for it).
    
        Also, add a new debug scope, EnsureAccumulatorPreservedScope, to the
        baseline compiler, which checks if the accumulator value is preserved
        across non-accumulator-writing bytecodes. This found a (benign) bug with
        ForInPrepare, so fix that too.
    
    R=leszeks@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
    BUG=
    LOG=N
    
    Change-Id: Id8ada05abeb1a9c7e8a16936c35be9d652c4e8b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124529Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#76537}
    aed61ff4
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...