- 02 Jul, 2018 13 commits
-
-
Gergely Nagy authored
When parsing a numeric literal in a line like "a=0x0e+b|0;", currently the scanner consumes the "e+" part (as it thinks it's the start of an exponent). In the ECMAScript lexical grammar HexIntegerLiteral cannot contain exponents, which means the '+' character should be parsed as a binary operator. R=bradnelson@chromium.org BUG=v8:7893 Change-Id: I97a0d4ea2ee1d38a3462efbfaef5eb87b8ea704b Reviewed-on: https://chromium-review.googlesource.com/1116551Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54132}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I5e12f49038f569187b751cc07a3bfad5eb904949 Reviewed-on: https://chromium-review.googlesource.com/1121460 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54131}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I44d0bde25283ac8c00155344f879eb1143b43bc9 Reviewed-on: https://chromium-review.googlesource.com/1119688Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54130}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I422277d565173273e632db07e0e762ee7ae01e87 Reviewed-on: https://chromium-review.googlesource.com/1122116Reviewed-by:
-
Leszek Swirski authored
Adds a instance types for each HashTable subtype, rather than reusing HASH_TABLE_TYPE. This allows us to check for these types by checking the instance type directly, rather than by comparing against the map in the root set. Also, as a drive-by, do the same for SCRIPT_CONTEXT_TABLE_TYPE, and use instance type checks rather than map checks for Context types. This is a good general clean-up, but in particular is intended for GetIsolate removal. TBR=jarin@chromium.org Bug: v8:7786 Change-Id: I420abdd12906dfa20c922e486ecdc657eb3c6ef0 Reviewed-on: https://chromium-review.googlesource.com/1114958Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Peter Marshall authored
Currently we don't check the result of AllocateUninitialized and just continue execution, failing at the following memcpy. Instead, check for a nullptr result from the embedder-provided allocator and crash with OOM. Bug: chromium:853706 Change-Id: I7a9b4e5d0ce3ef2b2cbb5fd3dc949ec2705bdfaa Reviewed-on: https://chromium-review.googlesource.com/1113454Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54127}
-
Stephan Herhut authored
This change helps mostly to reduce register pressure. By default, we compile LoadStackPointer into a move from the stack register into some general purpose register and then later use that register. This might trigger a spill to free up space, which is particularly costly in loops. Change-Id: I886233f890b7833f873fc24773f621add7cf0588 Reviewed-on: https://chromium-review.googlesource.com/1104351 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54126}
-
Rodrigo Bruno authored
Change-Id: Ic32383b9a4116b8f05568d7e8e0ca70a18813cea Reviewed-on: https://chromium-review.googlesource.com/1121458Reviewed-by:
-
Michael Starzinger authored
This makes sure the reverse tag translation of direct call targets to respective call tags is properly performed. Otherwise all direct call end up being deserialized to call the function with index '0'. Ooops! R=clemensh@chromium.org TEST=mjsunit/wasm/compiled-module-serialization BUG=chromium:857049 Change-Id: I37c1ee72b000daec87efdeed08d60a067b1a1b0c Reviewed-on: https://chromium-review.googlesource.com/1120256Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54124}
-
Michael Achenbach authored
This reverts commit 8d4572a2. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21312 Original change's description: > [builtins] Add %IsTraceCategoryEnabled and %Trace builtins > > Adds the builtin Trace and IsTraceCategoryEnabled functions > exposed via extra bindings. These are intended to use by > embedders to allow basic trace event support from JavaScript. > > ```js > isTraceCategoryEnabled('v8.some-category') > > trace('e'.charCodeAt(0), 'v8.some-category', > 'Foo', 0, { abc: 'xyz'}) > ``` > > Bug: v8:7851 > Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 > Reviewed-on: https://chromium-review.googlesource.com/1103294 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54121} TBR=fmeawad@chromium.org,yangguo@chromium.org,cbruni@chromium.org,bmeurer@chromium.org,jasnell@gmail.com Change-Id: I352e2413aa771ba9eb069bcc26c04414abfc500f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7851 Reviewed-on: https://chromium-review.googlesource.com/1122036Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54123}
-
Anna Henningsen authored
Provide a more complete BigInt API. Bug: v8:7712 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic8562d616f3125deabdf8b52c7019b191bef0e07 Reviewed-on: https://chromium-review.googlesource.com/1101198 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
James M Snell authored
Adds the builtin Trace and IsTraceCategoryEnabled functions exposed via extra bindings. These are intended to use by embedders to allow basic trace event support from JavaScript. ```js isTraceCategoryEnabled('v8.some-category') trace('e'.charCodeAt(0), 'v8.some-category', 'Foo', 0, { abc: 'xyz'}) ``` Bug: v8:7851 Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 Reviewed-on: https://chromium-review.googlesource.com/1103294 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54121}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/23d647e..213a0e3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id0d7a996abe5b5bc7e92cfcc7b125d40dee12659 Reviewed-on: https://chromium-review.googlesource.com/1121959Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54120}
-
- 01 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b79f5b5..23d647e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iedbe6547eac1badd18f35ee32aae1319ea220c25 Reviewed-on: https://chromium-review.googlesource.com/1121821Reviewed-by:
-
- 30 Jun, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f76f0b4..34f0d7e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a19649b..024a331 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I847abf895aa5182d1dbab83746223d34635954c6 Reviewed-on: https://chromium-review.googlesource.com/1121625 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 29 Jun, 2018 20 commits
-
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8e3406c..b79f5b5 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/9c9fd97..0dd5c6f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e2d6bbc..f76f0b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ae1f033..a19649b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/de629a4..dec27d7 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5721136b50509762c2b22a0782b9fbfd370fbde5 Reviewed-on: https://chromium-review.googlesource.com/1121079Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Aseem Garg authored
This CL adds simd select, addHoriz, shuffle, anyTrue and all true to the interpreter. It also gets rid of SIMD_COMPILED_AND_LOWERED_TEST and SIMD_COMPILED_TEST macros. R=gdeepti@chromium.org BUG=v8:6020 Change-Id: I44abbcaddc3223a95c79ccc65ae9c6bf1a911c5d Reviewed-on: https://chromium-review.googlesource.com/1119258 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54116}
-
Rodrigo Bruno authored
This is a reland of 6b810dad Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} Bug: chromium:845409 Change-Id: I71576bd397ca70d9ce76de279c2d9d1fa5a70596 Reviewed-on: https://chromium-review.googlesource.com/1120365Reviewed-by:
-
Rodrigo Bruno authored
This reverts commit 5863c0b6. Reason for revert: Breaks GPU bots (https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/1648) Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I77787df6aef2efec95c79714d1baf43feeb8a27e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1120265Reviewed-by:
-
Clemens Hammacher authored
Liftoff needs to emit the same code, thus move it to a place where it can be reused. Also, switch the _MSC_VER switch to V8_OS_WIN. It is unclear if _MSC_VER would also be set in clang. V8_OS_WIN seems to fit better. Drive-by: Reorder the code to save one jmp in the loop (loop inversion). R=mstarzinger@chromium.org Bug: v8:7908, v8:6600 Change-Id: Ia76aa4dad3f96e179a9daad8c1551b1aab499878 Reviewed-on: https://chromium-review.googlesource.com/1120174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I0e3f81b14d971d077afba2f4065e229b99948808 Reviewed-on: https://chromium-review.googlesource.com/1119687Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ia5f1d52df1b2ebbe4ea4d38464fc59b0d128426d Reviewed-on: https://chromium-review.googlesource.com/1119924Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 Reviewed-on: https://chromium-review.googlesource.com/1118164 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Simon Zünd authored
This CL fixes the NumberDictionary fast-path in Array.p.sort, when storing to a read-only property that was never read from. R=jgruber@chromium.org Bug: v8:7907 Change-Id: I2b772fb5b1619a94a7d239ba4417ecb7902a167c Reviewed-on: https://chromium-review.googlesource.com/1119910 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54109}
-
Rodrigo Bruno authored
This is a reland of 9072bef0 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} Bug: chromium:845409 Change-Id: Icff4e2a2b974942f73f5e6bb0bfd6ee8655e8ce7 Reviewed-on: https://chromium-review.googlesource.com/1119985Reviewed-by:
-
Clemens Hammacher authored
Since the wire bytes are now stored on the C++ heap, referenced directly from the {NativeModule}, there is no need any more for the additional copy in the {CompilationState}. R=mstarzinger@chromium.org Bug: v8:7868 Change-Id: I3ca25981b37bc14037a83a199354b70b4e52f8c7 Reviewed-on: https://chromium-review.googlesource.com/1118886 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I0cbd3e82a865aa2e52019057cea796cd6a8b17e2 Reviewed-on: https://chromium-review.googlesource.com/1118560 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Just a refactoring to make clear that we are talking about function names. Note that there are also names for locals inside functions, which we currently don't use. Drive-by: Remove style-guide violation by {WasmModule::names_} field. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I9c47ea01893f128e1716be01032adfaf006ae28a Reviewed-on: https://chromium-review.googlesource.com/1118271Reviewed-by: -
jgruber authored
This change somehow got lost when relanding an earlier CL in https://crrev.com/c/1118139 Bug: v8:7891 Change-Id: I31244be136322cccfb465c24356f1d0fd5e0c6d6 Reviewed-on: https://chromium-review.googlesource.com/1119786Reviewed-by:
-
Sreten Kovacevic authored
Commit edec05ea Usage of Print function was not consistent with it's signature, which caused failures in compilation. Original commit message: `All Object::Print functions now take an Isolate* parameter. Various XX::XXPrint functions now take an Isolate if it's needed rather than calling GetIsolate(). Such method use DECL_PRINTER_WITH_ISOLATE rather than DECL_PRINTER. The _v8_internal_Print_ function (intended for use in gdb) now uses Isolate::Current() to get hold of an Isolate. Reduces the GetIsolate and GetHeap count by 9 and 5 respectively. Also removes unneeded gdb/lldb macros (along with their support functions), jfv, jfm, jda and jta, since job does the same thing.` Cr-Original-Commit-Position: refs/heads/master@{#54029} Change-Id: I5d4eb974340159ae91a50c1c2272ab195fc514ea Reviewed-on: https://chromium-review.googlesource.com/1116965Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#54103}
-
Clemens Hammacher authored
No need to go via the {ModuleEnv} in the {CompilationState}. R=mstarzinger@chromium.org Change-Id: I11ff647824ad107131ce329453b365d6ecaec7fb Reviewed-on: https://chromium-review.googlesource.com/1118561Reviewed-by: -
Clemens Hammacher authored
This reverts commit d8281a29. Reason for revert: breaks win32: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/14559 Original change's description: > Reland^2 "[wasm] Enable Liftoff by default on ia32 and x64" > > This is a reland of 20f33823. > The flakes that lead to the revert are hopefully fixed with > https://crrev.com/c/1118171. > > Original change's description: > > [wasm] Enable Liftoff by default on ia32 and x64 > > > > R=titzer@chromium.org, hablich@chromium.org > > > > Bug: v8:6600, chromium:787421 > > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > > Reviewed-on: https://chromium-review.googlesource.com/1109899 > > Reviewed-by: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Michael Hablich <hablich@chromium.org> > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53965} > > TBR=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Icfc6f5c7701f18891ede34edb2bc22a7c01c8d6d > Reviewed-on: https://chromium-review.googlesource.com/1118485 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54099} TBR=titzer@chromium.org,hablich@chromium.org,clemensh@chromium.org Change-Id: I0caa20c70ab18a8da4665b565d35801c3cf03fed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:787421 Reviewed-on: https://chromium-review.googlesource.com/1119885Reviewed-by:
-
Michael Hablich authored
This reverts commit 9072bef0. Reason for revert: Speculative revert because of https://chromium-review.googlesource.com/c/chromium/src/+/1118280 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:845409 Change-Id: I818e24d236d93a4645d1532b666056f89156eb86 Reviewed-on: https://chromium-review.googlesource.com/1119825Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#54100}
-
Clemens Hammacher authored
This is a reland of 20f33823. The flakes that lead to the revert are hopefully fixed with https://crrev.com/c/1118171. Original change's description: > [wasm] Enable Liftoff by default on ia32 and x64 > > R=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > Reviewed-on: https://chromium-review.googlesource.com/1109899 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53965} TBR=titzer@chromium.org, hablich@chromium.org Bug: v8:6600, chromium:787421 Change-Id: Icfc6f5c7701f18891ede34edb2bc22a7c01c8d6d Reviewed-on: https://chromium-review.googlesource.com/1118485Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5fc0186..8e3406c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d96c633..e2d6bbc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b3853af..ae1f033 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I27e7412d84723d40d045e94ba87e9a36e9fd6373 Reviewed-on: https://chromium-review.googlesource.com/1119647 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 28 Jun, 2018 5 commits
-
-
Bill Budge authored
- Adds some unit tests for InstructionSelector::TryMatch* methods. - Adds a TryMatchIdentity method. We should detect identity shuffles and emit no code in that case. Bug: v8:6020 Change-Id: I5dea84738bf87db7112eb7d19f91b1e6b20811c7 Reviewed-on: https://chromium-review.googlesource.com/1116058 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54097}
-
Caitlin Potter authored
When storing an indexed property in a typed array, it's necessary to convert the value to a Number (or to a Bigint) before performing the bounds check, per https://tc39.github.io/ecma262/#sec-integerindexedelementset. This CL adds appropriate type conversions in Object::SetPropertyInternal (which technically is reached after the bounds check has already occurred, but this isn't observable yet --- In the future, once OOB accesses on TypedArrays actually throw, this will need to be refactored again), and in StoreFastElementStub, and ElementsTransitionAndStoreStub (via CSA::EmitElementStore). The change was not necessary in TurboFan, as JSNativeContextSpecialization already performs the value conversion before the boundscheck. The result is some fixed test262 tests, and some new test coverage for this behaviour in mjsunit. BUG=v8:7896, v8:5327 R=neis@chromium.org, jkummerow@chromium.org, gsathya@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibe6bec24c72ef6a4fd3e77d5bcafa03737f4c5e3 Reviewed-on: https://chromium-review.googlesource.com/1117372 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:857179 Change-Id: I6bbaa2601d62d303391d082a2ae1dff8d3c6e2b8 Reviewed-on: https://chromium-review.googlesource.com/1118562 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The flake is hopefully fixed with https://crrev.com/c/1118171. R=titzer@chromium.org Bug: v8:7879 Change-Id: I67ac9a447cbf8a99dfc612e84b3e381cc86fa643 Reviewed-on: https://chromium-review.googlesource.com/1118381Reviewed-by:
-
Ben Smith authored
Supporting postMessage from WebAssembly.Module requires implementing some logic in the ValueSerializer and ValueDeserializer delegates. This change implements some simple logic for d8. This change also fixes a DCHECK that occurs when sending a shared WebAssembly.Memory object to two Workers. Bug: chromium:857049 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idddb23a48175c7175967af3fbc03d8572452a069 Reviewed-on: https://chromium-review.googlesource.com/1117871Reviewed-by:
-
