- 28 Oct, 2020 4 commits
-
-
Zhi An Ng authored
This is a reland of df34fb95 Original change's description: > [wasm-simd] Add more test cases for load lane > > Test load lane using memarg offset immediate, and also test all > supported alignments. > > Bug: v8:10975 > Change-Id: Iac7e9f7e335bd86528a8723b04df97a17d7a7f66 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500928 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70816} TBR=bbudge@chromium.org Bug: v8:10975 Change-Id: I286776b351ecd3c78d56bec20c02a3ba283213df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504851Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70820}
-
Zhi An Ng authored
Prototype i8x16, i16x8, i32x4, i64x2 sign select on x64 and interpreter. Bug: v8:10983 Change-Id: I7d6f39a2cb4c2aefe31daac782978fe8b363dd1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2486235 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70818}
-
Zhi An Ng authored
This reverts commit df34fb95. Reason for revert: Broke msvc compile https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/15566 Original change's description: > [wasm-simd] Add more test cases for load lane > > Test load lane using memarg offset immediate, and also test all > supported alignments. > > Bug: v8:10975 > Change-Id: Iac7e9f7e335bd86528a8723b04df97a17d7a7f66 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500928 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70816} TBR=bbudge@chromium.org,zhin@chromium.org Change-Id: Ia80d167846dac99070e6e9d280dd4ea53455af30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504850Reviewed-by:
-
Zhi An Ng authored
Test load lane using memarg offset immediate, and also test all supported alignments. Bug: v8:10975 Change-Id: Iac7e9f7e335bd86528a8723b04df97a17d7a7f66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500928 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 27 Oct, 2020 5 commits
-
-
Ng Zhi An authored
And remove all ifdefs guarding the tests. Bug: v8:11038 Change-Id: I91487a4bd60b6f2e327d1c2348289e446d6e93d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501967Reviewed-by:
-
Zhi An Ng authored
This is a reland of dde93768 Original change's description: > Add int64_t min and max to value helpers for test > > And also fix up a truncate float to int test that was using > int list as input instead of a float list. > > Change-Id: I544e38b2d212f8d11dfb5758db4fe6b283acae0d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419654 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70774} Change-Id: Id196ea40eaf616d784d644346b912f1561fd97a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500926Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70810}
-
Zhi An Ng authored
Implement these two instructions on arm. Bug: v8:11038 Change-Id: I23d9c7291f60e29415cfbebced1bff323fd2465a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485250 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Zhi An Ng authored
This reverts commit dde93768. Reason for revert: ubsan failures https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/13518 Original change's description: > Add int64_t min and max to value helpers for test > > And also fix up a truncate float to int test that was using > int list as input instead of a float list. > > Change-Id: I544e38b2d212f8d11dfb5758db4fe6b283acae0d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419654 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70774} TBR=clemensb@chromium.org,zhin@chromium.org Change-Id: If0faa8be8c55715a529dfe777c0ad9819105fc5b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500925Reviewed-by:
-
Ng Zhi An authored
And also fix up a truncate float to int test that was using int list as input instead of a float list. Change-Id: I544e38b2d212f8d11dfb5758db4fe6b283acae0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419654Reviewed-by:
-
- 26 Oct, 2020 1 commit
-
-
Zhi An Ng authored
This relands commit 61b56d16 The fix is to capture variables used in the lambda. Original change's description: > [wasm-simd] Add more tests for v128 load zero > > Add tests for all valid alignments, and using memarg immediate offset > instead of i32 index. > > Also randomize the memory to help catch cases where we are loading more > than we should, and accidentally get correct values with zero-ed memory. > > Bug: v8:10713 > Change-Id: I443c2799ba0d539bf23c63760c08e18c4d36607f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487880 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70693} Bug: v8:10713 Change-Id: Ib8fa58c6600d85a37fc0b6647ddbdb991f3b1c04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497382Reviewed-by:
-
- 22 Oct, 2020 2 commits
-
-
Bill Budge authored
This reverts commit 61b56d16. Reason for revert: Breaks tests on MSVC bot: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/15485 Original change's description: > [wasm-simd] Add more tests for v128 load zero > > Add tests for all valid alignments, and using memarg immediate offset > instead of i32 index. > > Also randomize the memory to help catch cases where we are loading more > than we should, and accidentally get correct values with zero-ed memory. > > Bug: v8:10713 > Change-Id: I443c2799ba0d539bf23c63760c08e18c4d36607f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487880 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70693} TBR=bbudge@chromium.org,zhin@chromium.org Change-Id: I9391c5e948c528f00dc966bbf33f709da30d1b17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10713 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2490479Reviewed-by:
-
Ng Zhi An authored
Add tests for all valid alignments, and using memarg immediate offset instead of i32 index. Also randomize the memory to help catch cases where we are loading more than we should, and accidentally get correct values with zero-ed memory. Bug: v8:10713 Change-Id: I443c2799ba0d539bf23c63760c08e18c4d36607f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487880Reviewed-by:
-
- 20 Oct, 2020 3 commits
-
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for v8. R=jkummerow@chromium.org, ochang@chromium.org, yangguo@chromium.org Bug: chromium:1113033 Change-Id: I82cbb62e438d82dbbc408e87120af39fa9da0afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476680Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#70669}
-
Ng Zhi An authored
Bug: v8:10713 Change-Id: I7b123347e00f31d071d45e3b807354610b71ed2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2486238Reviewed-by:
-
Ng Zhi An authored
This is similar to https://crrev.com/c/2466377, for all other checks for numeric_limits found in the same file. The check for float/double to uint32/uint64 doesn't seem to be replaceable, due to this check: https://source.chromium.org/chromium/chromium/src/+/master:v8/src/base/safe_conversions_impl.h;l=361;drc=c10c83c31ba0b774c3c05c73bb4894ba2495394b We probably need something specific for converting to float/doubles. I'll leave those as they are first. Bug: v8:10933 Change-Id: I5ea95fd04caa7b5963bb3cb8e5870cd8e790fb19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477039 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 19 Oct, 2020 5 commits
-
-
Ng Zhi An authored
Prototype these two instructions on ia32. They are movss and movsd respectively, so the implementation is pretty simple, as we support these instructions already. Bug: v8:11038 Change-Id: Iebf4afab2bf1edfb4b14a4855d5036677f999ca9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2486232Reviewed-by:
-
Milad Fa authored
First CL with initial changes: https://crrev.com/c/2468618 This CL adds the same set to the wasm interpreter. We also need to make sure "negation" as well as "std::abs" are excluded from this fix as they can reverse the sign bit intentionally. Change-Id: I115649f55b5290d2529dda3d5592feaff3363b76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485246Reviewed-by:
-
Ng Zhi An authored
Not sure why I originally chose to name it LoadMem32Zero instead of Load32Zero like the proposal. This fixes it. Bug: v8:10713 Change-Id: If05603f743213bc6b7aea0ce22c80ae4b3023ccf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2481824Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70630}
-
Etienne Pierre-doray authored
IsRunning is the v8 equivalent of operator bool, but is confusing with IsCompleted. IsValid (to match base:: operator bool) should be more clear. Change-Id: I2529bea21c7cb7613bd5057c66715fb5ea450396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461840Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#70625}
-
Ng Zhi An authored
Also known as multiply long, this multiplies the top or bottom half of the input operands, the result is twice as wide as the input. This implements arm64 and interpreter. Bug: v8:11008 Change-Id: Iad693007066dd1a9bc529b282e88812a081c3a01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2469156Reviewed-by:
-
- 16 Oct, 2020 2 commits
-
-
Ng Zhi An authored
Bug: v8:10993 Change-Id: I9b3cd1499cc9ebb93690e4940e9d94c5f445e315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477432Reviewed-by:
-
Ng Zhi An authored
Store lane loads a value from memory and replaces a single lane of a simd value. This implements store lane for x64 and interpreter. Bug: v8:10975 Change-Id: Ida79a03e0fd2bc18f2c06687311936b3cb550ed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2473383Reviewed-by:
-
- 15 Oct, 2020 4 commits
-
-
Ng Zhi An authored
This is merged into the proposal, move it out of post-mvp flags, and remove any ifdefs guarding it. Bug: v8:10993 Change-Id: I4c82e3fc17c97735d5417fa4a5d85d7f091fbb8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2453457Reviewed-by:
-
Ng Zhi An authored
Rename AddSaturate and SubSaturate to the shorter version, AddSat and SubSat, following the spec. Bug: v8:10946,v8:10933 Change-Id: Idf74b3a1eb2e2f6d4e37d2b8e5fa6d96ea090db4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436615Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10933 Change-Id: I3a0526e4744b7a36d03d2bfd182616969b9db12b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2466377 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Some of the tests were incorrectly using DCHECK for assertions, we want these checks to run in all configurations, not only in DEBUG. Change-Id: I41ab7c7f1aa9fe3947255fc107437fa48f304e5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2473579Reviewed-by:
-
- 14 Oct, 2020 2 commits
-
-
Milad Fa authored
Due to a bug on AIX, some of the glibc FP functions do not preserve the sign bit when a negative input is passed by value and the output is rounded to 0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97086 This CL forces the use of "-0.0" in such cases. Change-Id: If9935596e32e97720f3cb22f27975267ac1124d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2468618Reviewed-by:
-
Vicky Kontoura authored
This CL adds a basic tiering strategy for the js-to-wasm wrappers. When applicable, calls to exported WebAssembly functions are initially handled through the generic js-to-wasm wrapper. If these calls through the generic wrapper reach a constant threshold, the specific (per-signature) wrapper is compiled synchronously for the function and the generic wrapper is replaced. Bug: v8:10982 Change-Id: I65e706daffb5cb6e723ce2f7b785f7ecb7b2fa7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461243 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70503}
-
- 12 Oct, 2020 6 commits
-
-
Ng Zhi An authored
These are still not in proposal, so they should be behind the post-mvp flag. Bug: v8:10972 Change-Id: I1b53307f334ddd8e21a095c13d7f7abb8ce05203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465654 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This implements i8x16.popcnt on arm64 and interpreter. Bug: v8:11002 Change-Id: Ia94a053d7e0a0c800057ac80865ba6f86ac7caf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461058Reviewed-by:
-
Ng Zhi An authored
Implement on interpreter and x64. Bug: v8:10997 Change-Id: I3537ce54e1b56cc3b04d91cb07c430c35b88c3aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2459109 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Load lane loads a value from memory and replaces a single lane of a simd value. This implements the load (no stores yet) for x64 and interpreter. Bug: v8:10975 Change-Id: I95d1b5e781ee9adaec23dda749e514f2485eda10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444578 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
These instructions are not in the proposal, and will be unlikely to be requested (poor performance, insufficient use cases). As we get more instruction suggestions, these are sitting around on useful opcodes and we have to play musical chairs every time we prototype a new instruction. Bug: v8:10933 Change-Id: Ic7ce4e514c343d821f76b8c071e41f9bddfbd1ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2457669Reviewed-by:
-
Pierre Langlois authored
This test allocates a large mapping and splits into kThunkBufferSize areas that it needs to be able to change permissions on. So kThunkBufferSize needs to be set to the largest page size possible, which is 64k at the moment. It doesn't matter if kThunkBufferSize is larger than the actual page size. Bug: v8:10808 Change-Id: I3a8947f04a7ec25be49a54015cd128e901065ea6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463404Reviewed-by:
-
- 09 Oct, 2020 3 commits
-
-
Ng Zhi An authored
These tests were disabled because scalar lowering wasn't fully implemented yet. Now we are at a stage when we can enable them. The only remaining tests with lowering test disabled are prototype instructions, once they are merged into the proposal proper, scalar lowering should be implemented for them, and relevant tests enabled. Bug: v8:10507 Change-Id: I4b7c8778f70e226ebda3bf5a2a7dd5efa343bc0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460841Reviewed-by:
-
Ng Zhi An authored
Lowering for f32x4 and f64x2 pmin and pmax. Bug: v8:10501,v8:10507 Change-Id: I2d92d337835a62e6adb979ed573b616cc2b86c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461453Reviewed-by:
-
Ng Zhi An authored
Some of these functions don't need to be defined, we can directly call the same helpers defined elsewhere. Bug: v8:10933 Change-Id: I31464195b11ed14f0725d9ed9711fa72ddbb4e92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461478Reviewed-by:
-
- 08 Oct, 2020 3 commits
-
-
Ng Zhi An authored
Missed this earlier when it was merged into the proposal. f32x4 and f64x2 ceil, floor, trunc, nearestint. Also enable cctests. Bug: v8:10507,v8:10906 Change-Id: I2de00e615cd63d81303649774db2a2ab800f6f72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461451Reviewed-by:
-
Ulan Degenbaev authored
Currently MockPlatform has shorter lifetime than the isolate that uses it. This leads to use-after-free races in concurrent tasks that fetch the mock platform just before it is freed. This CL ensures that MockPlatform is valid throughout the whole lifetime of the isolate Change-Id: Ib94dc7674b9f94833be3372de68209ec38577ca1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461726 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#70407}
-
Ng Zhi An authored
Prototype these 4 instructions: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u Bug: v8:10972 Change-Id: I3cc3bfdd6dfd0f0bab1dfef63399ed9fa68bd2d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2441369Reviewed-by:
-
