- 10 May, 2022 2 commits
-
-
Michael Lippautz authored
Deprecate the existing parameter to treat global objects as roots as this is implied by exposing internals. Bug: chromium:1321620 Change-Id: I73a8124d63f87599dee7080980844c418eb3b5e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637797 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#80456}
-
Clemens Backes authored
Deprecate the OOMErrorCallback such that we can add a new parameter for OOM details. R=mlippautz@chromium.org Bug: chromium:1323177 Change-Id: I72c931ad0d1b75cda46e8815387098acbe091c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632106Reviewed-by: Lutz Vahl <vahl@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80453}
-
- 09 May, 2022 3 commits
-
-
henrika authored
Bug: v8:11043 Change-Id: I8cbdd8a5f68bdadbe7fc44414c6d46cdd57e6802 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627512Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/main@{#80429}
-
Clemens Backes authored
This adds a typedef for LegacyOOMErrorCallback, which is identical to OOMErrorCallback. Embedders will need to switch to LegacyOOMErrorCallback so that we can change the definition of OOMErrorCallback (see https://crbug.com/1323177). R=mlippautz@chromium.org Bug: chromium:1323177 Change-Id: I92312a577ca49e0174f2bb6b914cc11c3a0b0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632305Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80424}
-
Anton Bikineev authored
Allocation granularity (8 bytes on 64bit platforms) is already subsumed by whatever range size we choose. Bug: chromium:1029379 Change-Id: Iab95e6f36955c9ffbbe9ea0c98cb9d1f8dd0337b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629869Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80415}
-
- 06 May, 2022 1 commit
-
-
Michael Lippautz authored
- Repurpose flag `treat_global_objects_as_roots` when taking a heap snapshot for toggling whether internals should be exposed (to `hide_internals`). - Use the toggle in creating heap snapshots for exposing class names as object names for C++ objects that have not explicitly been given a name. Change-Id: I77d71babfdfe53269964fe81ed985037a431c28b Bug: chromium:1321620 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623740Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80391}
-
- 04 May, 2022 1 commit
-
-
Michael Lippautz authored
Bug: chromium:1322318 Change-Id: Id3899a493eb1519e2f7498dcad1e607cc2b6a5db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627509Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80353}
-
- 03 May, 2022 6 commits
-
-
Danil Somsikov authored
Distinguish untrusted clients in v8 inspector and disable Profiler, HeapProfiler and Schema CDP domains for them. Bug: chromium:1313437 Change-Id: I7544c64acb4bc368392ba5f6a87ed62176828304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616517Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#80340}
-
Michael Lippautz authored
Before this CL, the heap object name of unnamed objects(those not inheriting from NameProvider) would be solely determined by whether the build-time configuration cppgc_enable_object_names is enabled. This patch adds a way to override that value at runtime. This is useful for preserving default behavior with custom builds but at the same time allow them to still enable the feature. Bug: chromium:1321620 Change-Id: I3aa06db15e58d9ba9773be6797572f17f007e9ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620279Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80338}
-
Camillo Bruni authored
Previously marked V8_DEPRECATED_SOON that are now V8_DEPRECATED: File Version Date Commit include/v8-initialization.h:208 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:226 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:236 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:250 v9.9 2021-12-15 277fdd1d include/v8-locker.h:130 v10.0 2022-01-20 116ca00f include/v8-message.h:90 v9.8 2021-11-09 2b3df06b Previously marked V8_DEPRECATED that are now removed: File Version Date Commit include/v8-fast-api-calls.h:886 v9.8 2021-11-11 b295d0b0 include/v8-fast-api-calls.h:893 v9.8 2021-11-11 b295d0b0 include/v8-fast-api-calls.h:902 v9.8 2021-11-11 b295d0b0 include/v8-initialization.h:186 v10.0 2022-01-26 36707481 include/v8-isolate.h:639 v10.0 2022-01-26 36707481 include/v8-locker.h:132 v9.8 2021-11-11 b295d0b0 include/v8-object.h:597 v9.9 2022-01-18 0a61fa51 include/v8-object.h:609 v9.8 2021-11-11 b295d0b0 include/v8-script.h:50 v10.0 2022-01-26 36707481 include/v8-script.h:653 v10.0 2022-01-18 9cf4f131 Output generated by ./tools/release/list_deprecated.py Bug: v8:11165, chromium:1166077 Change-Id: Ie0d435f7a10f362ed714bdc30ad899ee9c485cb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571804 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80337}
-
jameslahm authored
This CL changes MaybeLocal::ToLocal documentation to assign |out| with nullptr when the MaybeLocal is empty to be consistent with the behavior. Bug: v8:12845 Change-Id: I8145d6604c51b79f137b686b3e9b4f328534e0a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616432 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80329}
-
Camillo Bruni authored
Due to the consistent overhead of snapshot checksum verification we ideally want to avoid it all-together. However there are still enough devices out there that suffer from corrupted snapshots that might cause hard to debug heap corruptions. This CL exposes the calculated (dummy value for now) and the expected snapshot checksum as a crash key, so it can be easily consulted during investigation. Note: The calculated crash key contains 0x0 for now as a dummy value. We will come up with a strategy later-on to limit the overhead of calculating the checksum. Bug: v8:12195 Change-Id: I6da6d74c035cb6f9b0edae212a36e6c41c048a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605813Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80325}
-
Rob Paveza authored
This change adds support for computing SHA-256 hashes in the stack output of errors by adding a function to the prototype of the `CallSite` object, passed to `Error.prepareStackTrace`. Additionally, it updates the `hash` property from `Debugger.scriptParsed` and `Debugger.scriptFailedToParse` to be SHA-256 instead of the proprietary hash it is today. It is intended to be an advancement in indexing source maps to support improved tooling, especially for post-hoc or in-production diagnostics scenarios. The explainer can be found here: https://docs.google.com/document/d/13hNeeLC2Ve_FVieNndZUUUP15x2O4ltvjnGWwOsMlrU/edit?usp=sharing Change-Id: Ifbbed4b22c8256e74e6d79974d2dd1e444143eda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229957Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80320}
-
- 02 May, 2022 2 commits
-
-
Anton Bikineev authored
The CL prepares the sources and the tests for enabling cppgc_enable_young_generation by default. The static initializer in YoungGenerationEnabler (due to v8::base::Mutex) changed to be lazy. The tests are now checking the runtime flag. Bug: chromium:1029379 Change-Id: I1497a3dd2b8d62c1acd48496821f07324b7944d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616726Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80304}
-
https://crrev.com/c/3472077Maksim Sadym authored
1. Use `StringBuffer` instead of `StringView` in `WebDriverValue`. 2. Add some `DCHECK`s. 3. Reserve vector size. 4. Respect properties with `undefined` values. 5. Minor clean-ups. Change-Id: Ic109acb1e3adf2d950767173c17a9203e3c816dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596173Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/main@{#80296}
-
- 30 Apr, 2022 1 commit
-
-
Anton Bikineev authored
Change-Id: I29bcdf3302f37568e8c8925e70a01ba342c17925 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3606229Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80288}
-
- 29 Apr, 2022 1 commit
-
-
Anton Bikineev authored
The CL introduces a new option --cppgc-young-generation. This option can't be enabled statically, because V8 options are parsed after heap initialization. The CL changes minor GC so that it can be enabled dynamically. The way it works is as follows: - the user calls YoungGenerationEnabler::Enable(); - a heap checks in the next atomic pause whether the flag was enabled; - if so, the heap enables young generation for itself. To avoid barrier regressions without young-generation enabled, the CL changes the meaning of the global flag is-any-incremental-or-concurrent-marking to is-barrier-enabled. The runtime option would enable us to test young generation on try- and performance-bots. Bug: chromium:1029379 Change-Id: I664cccdcd208225ffcbf9901f1284b56d088c5c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3607993 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80274}
-
- 28 Apr, 2022 2 commits
-
-
Camillo Bruni authored
* Prefix all isolate variables with i_ for i::Isolate and v8_ for v8::Isolate * Change _DO_NOT_USE macro suffix to _INTERNAL Change-Id: I005efbe0192cf202741448c63a4263e6a4b1fa1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610429 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#80252}
-
Samuel Groß authored
It is expected that changing page permissions can fail due to the system running out of memory. However, any other failure is unexpected and likely indicates a bug in the caller, such as changing the permissions of an invalid memory region. To allow distinguishing between these unexpected failures and expected OOM failures, this CL adds CHECKs into the low-level memory management routines to abort when an unexpected failure occurs. Similar logic could later be added to other low-level memory management routines that can legitimately fail due to OOM as well. Bug: chromium:1320126 Change-Id: I3de6f4b2aed8962c91770b81382df34384584501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610445 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80245}
-
- 27 Apr, 2022 1 commit
-
-
Anton Bikineev authored
If the following conditions hold: 1) value is kSentinel, 2) slot is on stack, 3) stack is allocated below 4GB, then the generational barrier would be erroneously triggered for the stack object object. This CL fixes it. At the same time, it aims to simplify the code and potentially optimizes it (by having 'and' instead of 'sub'). Bug: chromium:1029379 Change-Id: Iafd91d50b0a1c3d97647f7bf3643dfcc7e9fb48f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3608629Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80202}
-
- 26 Apr, 2022 2 commits
-
-
Igor Sheludko authored
It's necessary to support fast W^X permission switching on MacOS on ARM64 ("Apple M1"/Apple Silicon) where permission modification of RWX pages to anything else is prohibited. On all the other architectures/platforms RecommitPages() is equivalent to SetPermissions(). The new API will be used in a follow-up CLs. Bug: v8:12797 Change-Id: Id0d8b8c42c81b80cd8fa6b47c227680d7d1f9b10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3606231Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Samuel Groß <saelo@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80190}
-
Anton Bikineev authored
When setting a range for a newly allocated lab, consider adjacent cards. If either is young, don't mark it as kMixed. Bug: chromium:1029379 Change-Id: If7d1d920dd5769679de68800eae61f3a8dc1eb17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3584116Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80175}
-
- 22 Apr, 2022 2 commits
-
-
Seth Brenith authored
One of the biggest categories in heap snapshots is named “(system)”, which gives developers no indication of why all that memory is used or what they might do to reduce it. In this change, I propose that we create a new category for Maps, DescriptorArrays, and related objects, and call this new category “(object shape)” in the devtools. I think that this category name would be more meaningful, while still grouping those objects together so that they mostly stay out of the way. Bug: v8:12769 Doc: https://docs.google.com/document/d/1a-6V_2LIJuRcsppwh6E18g8OSnC9j6gN4ao2gq--BiU Change-Id: I282a7b87c34ca6ed371ff32f3c7332d794ae42ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3587974Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80123}
-
Michael Lippautz authored
Remove PENDING state as handles were always immediately transitioned into FREE or NEAR_DEATH state. Bug: v8:12672 Change-Id: I9a9d40b573e862282d41d7a4a3f9c8c8ed21b9e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599473Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80119}
-
- 21 Apr, 2022 2 commits
-
-
Michael Lippautz authored
When moving forward and optimizing internals, these APIs cannot be trusted anymore as their semantics are tangled to the current implementation. Bug: v8:12819 Change-Id: I0e3370724307a420ee42fed8070b55542be9400d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599475 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80082}
-
Michael Lippautz authored
Removes support for specifying weak handles with finalizers that allow for object resurrection. This CL removes the public facing APIs. Internal support will be removed in a follow up. Bug: v8:12672 Change-Id: Ia6ea269093aaa128caadb7508aca2e5a1254923c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596174 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80070}
-
- 20 Apr, 2022 1 commit
-
-
Simon Zünd authored
Doc: https://bit.ly/revive-restart-frame Context: https://crrev.com/c/3582395 (whole feature) This CL adds a new optional flag `canBeRestarted` to every call frame in Debugger.paused events. As the name suggests, the flag indicates whether we can restart a particular frame through Debugger.restartFrame once implemented. We are not able to safely restart all frames: * We don't support WASM frames * We don't support frames where resumable functions (async fns, generators) and embedder C++ frames are between the top-most frame and the to-be-restarted frame. Note that from a CDP perspective the flag doesn't actually guarantee a successful restart. CDP clients can issue CDP commands between the Debugger.paused event and before a user decides to restart a frame, which can potentially mess with the stack. The `canBeRestarted` flag tests are folded into the Debugger.restartFrame tests. As the feature is not yet fully implemented we short-circuit most of the tests for now and only run them up until the first Debugger.restartFrame call fails (except "fails-for-resumables.js"). This means the tests exercise the `canBeRestarted` flag, but not the restarting functionality itself. R=bmeurer@chromium.org, kimanh@chromium.org Bug: chromium:1303521 Change-Id: I01ab46dc3557ab8383960969fbe03e00604cc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596160Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#80046}
-
- 14 Apr, 2022 1 commit
-
-
V8 Autoroll authored
Change-Id: Idb40d6a544cebbdd127eb3c8d71f11adf6ac6a97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3586227Reviewed-by: Lutz Vahl <vahl@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79986}
-
- 13 Apr, 2022 1 commit
-
-
Anton Bikineev authored
This reduces card granularity from 4096 to 512 bytes with the goal to improve write barrier filtering. Bug: chromium:1029379 Change-Id: I22e2a9c61ef4c36c3db65404370213d0a8048e08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582393Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#79960}
-
- 11 Apr, 2022 1 commit
-
-
Maksim Sadym authored
1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`. 2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set. 3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491). 4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`. 5. Hardcode `max_depth=1`. 6. Added tests. Not implemented yet: 1. `objectId`. 2. Test of embedder-implemented serialization. Tested automatically by: ``` python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value ``` Naming to be discussed. Suggestions are very welcome. Design doc: http://go/bidi-serialization Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/main@{#79922}
-
- 08 Apr, 2022 1 commit
-
-
Michael Lippautz authored
Trivial changes from https://crrev.com/c/3571887. Bug: v8:12600 Change-Id: I0a6f36d32f72a6c3817a4390645ccf5a690c5580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579161Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79885}
-
- 06 Apr, 2022 5 commits
-
-
Corentin Pescheloche authored
This CL adds support for interacting with CpuProfile with their integer id. A String ID is problematic because it forces an allocation when stopping or cancelling a Profiler which can happen during a GC when this is not allowed. Change-Id: I9a8e754bd67214be0bbc5ca051bcadf52bf71a68 Bug: chromium:1297283 Co-Authored-By: Nicolas Dubus <nicodubus@fb.com> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522896Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com> Commit-Queue: Corentin Pescheloche <cpescheloche@fb.com> Cr-Commit-Position: refs/heads/main@{#79835}
-
Kevin Babbitt authored
Embedders can currently specify a callback for OOM errors during Isolate initialization. However, there are cases where an OOM error can be thrown in a context where we don't have access to an Isolate, for example on a task posted to a worker thread. This CL introduces an initialization API to allow the embedder to specify a process-wide OOM callback. Bug: chromium:614440 Change-Id: I326753d80767679f677e85104d9edeef92e19086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561916Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79832}
-
Leszek Swirski authored
Change the unittest runner to no longer uncondtionally set up a default platform in the "environment", but to instead make platform set-up part of the "mixin" framework for test fixtures. Requires modifying some tests that expect the platform to be available, and all flag implications resolved, before the mixin constructors run. We still keep the environment for setting up the process for cppgc. This process setup can only be done once per process, so it can no longer use the platform -- that's ok though, the page allocator used by cppgc's process initialisation doesn't have to be the same as the platform's so we can just pass in a separate new one. Change-Id: Ic8ccf39722e8212962c5bba87350c4b304388a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571886Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79820}
-
Clemens Backes authored
Remove the pre-C++17 implementation of void_t, just use std::void_t now. R=omerkatz@chromium.org Bug: v8:12425 Change-Id: Iabf72f1540ddb4db666e5a74f169f73546241c1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571888Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79812}
-
Stephen Roettger authored
Change from V8_DEPRECATE_SOON to V8_DEPRECATED. It turned out that we don't have to make changes in chrome code, so we can go to deprecated right away. Bug: chromium:1310790 Change-Id: I1bd529536d3a0098f11f13b3e44fe3dbc80eed04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571897Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#79811}
-
- 04 Apr, 2022 2 commits
-
-
Anton Bikineev authored
The CL makes sure to extract and copy Oilpan young GC metrics to v8::metrics::GarbageCollectionYoungCycle. In addition, it makes sure that metrics are not reported twice by bailing out from GCTracer::NotifyCppGCCompleted() for young GC cycles (the metrics are reported later in Heap::CollectGarbage() by calling GCTracer::StopCycle()). Bug: chromium:1029379 Change-Id: I07bf51e85a76a7cdbeeb8d87c9072edf2634158b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545168Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#79766}
-
Jakob Gruber authored
.. since they are the same as eager deopts (% an unused counter). Fixed: v8:12765 Change-Id: I2be6210e476ead4ac6629a49259f28321e965867 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565717Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79729}
-
- 31 Mar, 2022 1 commit
-
-
Stephen Roettger authored
Deprecate signature checks in * Template::SetNativeDataProperty * ObjectTemplate::SetAccessor These are not used in Chrome and require some complicated check in the IC code, which we want to remove. Change-Id: I413fafc8658e922fd590e7fe200600a624f019a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557253Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#79689}
-
- 30 Mar, 2022 1 commit
-
-
Benedikt Meurer authored
This introduces a `V8InspectorClient::dispatchError()` callback that embedders can use to dispatch errors from scripts injected by DevTools (via debug evaluate). The idea here being that while these errors are technically caught by the inspector logic, the DevTools UX presents them just like other uncaught errors, with the exception that they don't trigger error handlers installed by the page. The latter can be quite confusing to developers, and surprising when for example testing these error handlers from DevTools. So this adds the foundations on the V8 side to enable triggering error handlers for these technically caught, but morally uncaught, exceptions. On the Chromium side https://crrev.com/c/3560458 will implement and use the hook. And that CL also adds a web tests to check the behavior. Bug: chromium:1295750 Change-Id: I945c8a9e9b4ec5705fc7f1891dcda185b04c8310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557234 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79673}
-