1. 10 May, 2022 2 commits
  2. 09 May, 2022 3 commits
  3. 06 May, 2022 1 commit
  4. 04 May, 2022 1 commit
  5. 03 May, 2022 6 commits
  6. 02 May, 2022 2 commits
  7. 30 Apr, 2022 1 commit
  8. 29 Apr, 2022 1 commit
    • Anton Bikineev's avatar
      cppgc: young-gen: Add runtime option for young generation · c7dfa3fa
      Anton Bikineev authored
      The CL introduces a new option --cppgc-young-generation. This option
      can't be enabled statically, because V8 options are parsed after heap
      initialization. The CL changes minor GC so that it can be enabled
      dynamically. The way it works is as follows:
      - the user calls YoungGenerationEnabler::Enable();
      - a heap checks in the next atomic pause whether the flag was enabled;
      - if so, the heap enables young generation for itself.
      
      To avoid barrier regressions without young-generation enabled, the CL changes the meaning of the global flag is-any-incremental-or-concurrent-marking to is-barrier-enabled.
      
      The runtime option would enable us to test young generation on try-
      and performance-bots.
      
      Bug: chromium:1029379
      Change-Id: I664cccdcd208225ffcbf9901f1284b56d088c5c3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3607993
      Commit-Queue: Anton Bikineev <bikineev@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80274}
      c7dfa3fa
  9. 28 Apr, 2022 2 commits
  10. 27 Apr, 2022 1 commit
  11. 26 Apr, 2022 2 commits
  12. 22 Apr, 2022 2 commits
  13. 21 Apr, 2022 2 commits
  14. 20 Apr, 2022 1 commit
    • Simon Zünd's avatar
      [inspector] Add 'canBeRestarted' flag to CallFrames when debugger pauses · ec41a70e
      Simon Zünd authored
      Doc: https://bit.ly/revive-restart-frame
      Context: https://crrev.com/c/3582395 (whole feature)
      
      This CL adds a new optional flag `canBeRestarted` to every call frame
      in Debugger.paused events. As the name suggests, the flag indicates
      whether we can restart a particular frame through Debugger.restartFrame
      once implemented.
      
      We are not able to safely restart all frames:
        * We don't support WASM frames
        * We don't support frames where resumable functions (async fns,
          generators) and embedder C++ frames are between the top-most
          frame and the to-be-restarted frame.
      
      Note that from a CDP perspective the flag doesn't actually guarantee
      a successful restart. CDP clients can issue
      CDP commands between the Debugger.paused event and before a user
      decides to restart a frame, which can potentially mess
      with the stack.
      
      The `canBeRestarted` flag tests are folded into the
      Debugger.restartFrame tests. As the feature is not yet fully
      implemented we short-circuit most of the tests for now and only
      run them up until the first Debugger.restartFrame call fails
      (except "fails-for-resumables.js").
      This means the tests exercise the `canBeRestarted` flag, but not
      the restarting functionality itself.
      
      R=bmeurer@chromium.org, kimanh@chromium.org
      
      Bug: chromium:1303521
      Change-Id: I01ab46dc3557ab8383960969fbe03e00604cc5e2
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596160Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80046}
      ec41a70e
  15. 14 Apr, 2022 1 commit
  16. 13 Apr, 2022 1 commit
  17. 11 Apr, 2022 1 commit
    • Maksim Sadym's avatar
      Add `WebDriverBiDi` serialization to CDP · a913a75b
      Maksim Sadym authored
      1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`.
      2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set.
      3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491).
      4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`.
      5. Hardcode `max_depth=1`.
      6. Added tests.
      
      Not implemented yet:
      1. `objectId`.
      2. Test of embedder-implemented serialization.
      
      Tested automatically by:
      ```
      python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value
      ```
      
      Naming to be discussed. Suggestions are very welcome.
      
      Design doc: http://go/bidi-serialization
      
      Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Maksim Sadym <sadym@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79922}
      a913a75b
  18. 08 Apr, 2022 1 commit
  19. 06 Apr, 2022 5 commits
  20. 04 Apr, 2022 2 commits
  21. 31 Mar, 2022 1 commit
  22. 30 Mar, 2022 1 commit
    • Benedikt Meurer's avatar
      [inspector] Add custom error dispatch machinery for debug evaluate. · 56cfdd68
      Benedikt Meurer authored
      This introduces a `V8InspectorClient::dispatchError()` callback that
      embedders can use to dispatch errors from scripts injected by DevTools
      (via debug evaluate). The idea here being that while these errors are
      technically caught by the inspector logic, the DevTools UX presents them
      just like other uncaught errors, with the exception that they don't
      trigger error handlers installed by the page. The latter can be quite
      confusing to developers, and surprising when for example testing these
      error handlers from DevTools. So this adds the foundations on the V8
      side to enable triggering error handlers for these technically caught,
      but morally uncaught, exceptions.
      
      On the Chromium side https://crrev.com/c/3560458 will implement and
      use the hook. And that CL also adds a web tests to check the behavior.
      
      Bug: chromium:1295750
      Change-Id: I945c8a9e9b4ec5705fc7f1891dcda185b04c8310
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557234
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79673}
      56cfdd68