• Maksim Sadym's avatar
    Add `WebDriverBiDi` serialization to CDP · a913a75b
    Maksim Sadym authored
    1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`.
    2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set.
    3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491).
    4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`.
    5. Hardcode `max_depth=1`.
    6. Added tests.
    
    Not implemented yet:
    1. `objectId`.
    2. Test of embedder-implemented serialization.
    
    Tested automatically by:
    ```
    python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value
    ```
    
    Naming to be discussed. Suggestions are very welcome.
    
    Design doc: http://go/bidi-serialization
    
    Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Maksim Sadym <sadym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79922}
    a913a75b
Name
Last commit
Last update
..
cppgc Loading commit data...
libplatform Loading commit data...
APIDesign.md Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol-1.3.json Loading commit data...
js_protocol.pdl Loading commit data...
v8-array-buffer.h Loading commit data...
v8-callbacks.h Loading commit data...
v8-container.h Loading commit data...
v8-context.h Loading commit data...
v8-cppgc.h Loading commit data...
v8-data.h Loading commit data...
v8-date.h Loading commit data...
v8-debug.h Loading commit data...
v8-embedder-heap.h Loading commit data...
v8-embedder-state-scope.h Loading commit data...
v8-exception.h Loading commit data...
v8-extension.h Loading commit data...
v8-external.h Loading commit data...
v8-fast-api-calls.h Loading commit data...
v8-forward.h Loading commit data...
v8-function-callback.h Loading commit data...
v8-function.h Loading commit data...
v8-initialization.h Loading commit data...
v8-inspector-protocol.h Loading commit data...
v8-inspector.h Loading commit data...
v8-internal.h Loading commit data...
v8-isolate.h Loading commit data...
v8-json.h Loading commit data...
v8-local-handle.h Loading commit data...
v8-locker.h Loading commit data...
v8-maybe.h Loading commit data...
v8-memory-span.h Loading commit data...
v8-message.h Loading commit data...
v8-metrics.h Loading commit data...
v8-microtask-queue.h Loading commit data...
v8-microtask.h Loading commit data...
v8-object.h Loading commit data...
v8-persistent-handle.h Loading commit data...
v8-platform.h Loading commit data...
v8-primitive-object.h Loading commit data...
v8-primitive.h Loading commit data...
v8-profiler.h Loading commit data...
v8-promise.h Loading commit data...
v8-proxy.h Loading commit data...
v8-regexp.h Loading commit data...
v8-script.h Loading commit data...
v8-snapshot.h Loading commit data...
v8-statistics.h Loading commit data...
v8-template.h Loading commit data...
v8-traced-handle.h Loading commit data...
v8-typed-array.h Loading commit data...
v8-unwinder-state.h Loading commit data...
v8-unwinder.h Loading commit data...
v8-util.h Loading commit data...
v8-value-serializer-version.h Loading commit data...
v8-value-serializer.h Loading commit data...
v8-value.h Loading commit data...
v8-version-string.h Loading commit data...
v8-version.h Loading commit data...
v8-wasm-trap-handler-posix.h Loading commit data...
v8-wasm-trap-handler-win.h Loading commit data...
v8-wasm.h Loading commit data...
v8-weak-callback-info.h Loading commit data...
v8.h Loading commit data...
v8config.h Loading commit data...