Commit e9244f37 authored by Michael Lippautz's avatar Michael Lippautz Committed by V8 LUCI CQ

cppgc: Fix official build

Bug: chromium:1322318
Change-Id: Id3899a493eb1519e2f7498dcad1e607cc2b6a5db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627509Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80353}
parent c4f14db8
......@@ -56,7 +56,7 @@ struct HeapStatistics final {
/** Amount of memory actually used on the page. */
size_t used_size_bytes = 0;
/** Statistics for object allocated on the page. Filled only when
* NameProvider::HideInternalNames() is false. */
* NameProvider::SupportsCppClassNamesAsObjectNames() is true. */
std::vector<ObjectStatsEntry> object_statistics;
};
......
......@@ -45,7 +45,7 @@ TEST(NameTraitTest, InternalNamesHiddenInOfficialBuild) {
// (b) avoid exposing internal types until it has been clarified whether
// exposing internals in DevTools is fine.
#if defined(OFFICIAL_BUILD)
EXPECT_TRUE(NameProvider::HideInternalNames());
EXPECT_FALSE(NameProvider::SupportsCppClassNamesAsObjectNames());
#endif
}
......@@ -64,8 +64,8 @@ TEST(NameTraitTest, DefaultName) {
NameTrait<OtherNoName>::GetName(
nullptr, HeapObjectNameForUnnamedObject::kUseClassNameIfSupported)
.value);
// The following ignores `NameProvider::HideInternalNames()` and just always
// returns the hidden name, independent of the build support.
// The following ignores `NameProvider::SupportsCppClassNamesAsObjectNames()`
// and just always returns the hidden name, independent of the build support.
EXPECT_STREQ("InternalNode",
NameTrait<NoName>::GetName(
nullptr, HeapObjectNameForUnnamedObject::kUseHiddenName)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment