- 29 Nov, 2018 30 commits
-
-
Ben L. Titzer authored
This CL moves a number of memory-related methods out of utils into its own header, since utils.h is included in many places that do not need these methods. R=clemensh@chromium.org,mstarzinger@chromium.org Change-Id: I5155baf329844784286413408c05c7108b789020 Reviewed-on: https://chromium-review.googlesource.com/c/1354889 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57948}
-
Andreas Haas authored
The problem were missing V8_EXPORT_PRIVATE and V8_EXPORT. The unittests test if the trap handler only handles those traps it is supposed to handle: * Only handle traps when the thread-in-wasm flag is set. * Only handle traps of the right type, i.e. memory access violations. * Only handle traps at recorded instructions. The tests also test the consistency of the thread-in-wasm flag. I made one change in the trap handler where that consistency could be violated. All tests are executed with the default trap handler provided by V8, and with the trap handler callback installed in a test signal/exception handler. Patchset 1 is the original CL. R=mstarzinger@chromium.org Change-Id: I172d94f24cdba4c3a1f7f344825b059dbb59da79 Reviewed-on: https://chromium-review.googlesource.com/c/1351024Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Fix two bugs: - Initial configuration of limit allowed to go below the size of already allocated objects. - Context disposal without dependend context reset the heap state to not configured without actually increasing the limit again. Bug: chromium:843903 Change-Id: Ibdcf69b0b92b800f8919d5cc98186334945d811f Reviewed-on: https://chromium-review.googlesource.com/c/1355143Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8091 Change-Id: Ib0e0b50d1fe24b0e528a3dd9849829799b33f1bc Reviewed-on: https://chromium-review.googlesource.com/c/1355139Reviewed-by:
-
Clemens Hammacher authored
This adds error functions that receive offsets instead of pc, since the streaming compiler stores different sections in different buffers, so computing pointer differences between different sections does not work. We keep the pc-based methods for now to reduce code-churn and complexity at the different call sites. R=ahaas@chromium.org CC=binji@chromium.org Bug: v8:8238 Change-Id: I1aa68740bdda93c3341431aa7a81ac01ecfb71bb Reviewed-on: https://chromium-review.googlesource.com/c/1354463Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57944}
-
Michael Starzinger authored
This introduces a dedicated instance type for exception tags. The main motivation is to reduce their footprint and getting rid of a temporary workaround that used the {JSObject} type for this purpose. R=clemensh@chromium.org BUG=v8:8091 Change-Id: Id5678bce513f2ac086c7380bd803011b11d5050e Reviewed-on: https://chromium-review.googlesource.com/c/1354464Reviewed-by: -
Vasili Skurydzin authored
Change-Id: If22939274db5db07a4f947ef5ef209d96078da36 Reviewed-on: https://chromium-review.googlesource.com/c/1351766Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57942}
-
Sigurd Schneider authored
This adds a new target :generated_cc_files which generates all generated .cc files and is quick to build (~5sec on my machine). TBR=yangguo@chromium.org Change-Id: I51485635671b55302b06f1ea300e86ef1745931e Bug: v8:8526 Reviewed-on: https://chromium-review.googlesource.com/c/1354881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57941}
-
Toon Verwaest authored
Changes [ x **= 2 ] = [] from [ x **= 2 ] = [] ^^^ SyntaxError: Unexpected token **= to: [ x **= 2 ] = [] ^^^^^^^ SyntaxError: Invalid destructuring assignment target Change-Id: I07170d12c151a94a7f99d37dce17197a3aa6f503 Reviewed-on: https://chromium-review.googlesource.com/c/1355140Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57940}
-
George Wort authored
This reverts commit 291a6029. Reason for revert: Unnecessary following f32 support for Liftoff on arm32. Original change's description: > [liftoff][arm] Fix overlapping of F32 and F64 registers in Liftoff > > Add a check to bailout in the case when F32 parameters are used for Arm. > > Bug: v8:6600, chromium:904026, chromium:904606 > Change-Id: I7f70c0806994a89dca31ef7e0b68f91d68484936 > Reviewed-on: https://chromium-review.googlesource.com/c/1346492 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57741} TBR=titzer@chromium.org,clemensh@chromium.org,george.wort@arm.com Change-Id: I98ba43017f521c83b96bbb15e9dc803954dc1eec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:904026, chromium:904606 Reviewed-on: https://chromium-review.googlesource.com/c/1354467Reviewed-by:
-
Toon Verwaest authored
|scope_snapshot_| might not have been cleared if there was a parser error between setting the snapshot and consuming it. Explicitly clear it at the end of parsing for that case. Otherwise Scope::Snapshot's destructor will possibly write into the already freed zone. Bug: chromium:909976 Change-Id: I8469d11f04e7f71528be5cba5663c652cd7eacb2 Reviewed-on: https://chromium-review.googlesource.com/c/1354880 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57938}
-
Michael Hablich authored
TBR=machenbach@chromium.org Change-Id: Id131f9624b6cd8e72f45e0506644d9e9765fa6f2 Reviewed-on: https://chromium-review.googlesource.com/c/1354888Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#57937}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I869ee5d6b705da0dab3c78dfd01eff9aca469d01 Reviewed-on: https://chromium-review.googlesource.com/c/1354886 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Peter Marshall authored
This is a reland of d5f4a33e Landing with test disabled for now. Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} TBR=v8-mips-ports@googlegroups.com TBR=jgruber@chromium.org Bug: v8:8464, v8:7202 Change-Id: I260d5ab3bc12c9c4529fb52a297a1040dcaa8ebf Reviewed-on: https://chromium-review.googlesource.com/c/1354466 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57935}
-
Ulan Degenbaev authored
This refactors Map operations to update the instance descriptors and the number of own descriptors via the SetInstanceDescriptors bottleneck. This will allow us to add a special marking barrier for these updates. Bug: v8:8486 Change-Id: Ie9c746d4bcdd6166d38402622734693fa59faf21 Reviewed-on: https://chromium-review.googlesource.com/c/1354883Reviewed-by:
-
Igor Sheludko authored
This CL unifies performance-critical slot processing code that was manually specifaized for ObjectSlot. Now one templated implementation can be used for processing both ObjectSlot and MaybeObjectSlot. Bug: v8:8518 Change-Id: Ia4346a817911f8042459ce579741fe2308ef5e4d Reviewed-on: https://chromium-review.googlesource.com/c/1354459 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57933}
-
George Wort authored
This supports the use of f32 values for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: I1fa2782f5a8bc6687a17d2df6e4ec8036b23452c Reviewed-on: https://chromium-review.googlesource.com/c/1354040 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Marja Hölttä authored
NOTRY=true Change-Id: I076e2f6c39674a98827e5939c9527678a5f81368 Reviewed-on: https://chromium-review.googlesource.com/c/1354882 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57931}
-
Tobias Tebbi authored
Disable CSA re-scheduling for the branch point, to address performance regressions. Bug: chromium:907011 Change-Id: I608ae23c20d8e1dd9a233dcb2d3f4ab4d8a5241e Reviewed-on: https://chromium-review.googlesource.com/c/1351009Reviewed-by:
-
Ross McIlroy authored
Swaps around the checks in CompileLazy to ensure we always enter the runtime to lazy compile if a function's SFI is uncompiled. This is necessary with bytecode flushing since the function may have an optimized code marker in the feedback vector, even if the bytecode has been flushed, and we don't want to try to optimize this flushed function. BUG=v8:8395 Change-Id: I7a348c40146673ba4a8f5e14d06995bbcc141695 Reviewed-on: https://chromium-review.googlesource.com/c/1352277 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#57929}
-
Jakob Kummerow authored
Explicitly disallow implicit casting of ObjectPtr to bool to match clang's and MSVC's behavior. Introduce a few function overloads using ObjectPtr instead of Object*. Fix printing of ObjectPtr for objects-printer.cc and GTest. Bug: v8:3770 Change-Id: I3c3580d363ae6d9fe8f743c6151abc11a915f05c Reviewed-on: https://chromium-review.googlesource.com/c/1351245 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
tzik authored
This CL marks v8::Isolate::GetEnteredContext as deprecated in favor of replacing it with GetEnteredOrMicrotaskContext. Blink no longer uses it, and Node.js does not use this too. GetEnteredOrMicrotaskContext() is relevant for all known cases over GetEnteredContext(), and it costs 2% of a benchmark score to maintain the entered contexts under the nestable microtask context. https://crrev.com/c/1322290 is a context for the bencmark and nestable microtask contexts. Bug: v8:8124 Change-Id: I260e32daadf34dc587926a1e20ab950ff2e31699 Reviewed-on: https://chromium-review.googlesource.com/c/1353025 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57927}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Change-Id: I74a1f7a66ee31ea4e6b02286de2f99c75f596027 Reviewed-on: https://chromium-review.googlesource.com/c/1354879Reviewed-by:
-
Michael Achenbach authored
This reverts commit ddaa1f0a. Reason for revert: Still flaky on windows. Maybe reland and keep skipped on windows? https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20nosnap%20-%20shared/31002 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/27826 Original change's description: > Reland "[cpu-profiler] Fix stack iterability for fast C calls with no exit frame" > > This is a reland of d5f4a33e > > Original change's description: > > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > > > Before fast C calls, store the current FP and PC on the isolate. When > > iterating frames in SafeStackFrameIterator, check if these fields are > > set and start iterating at the calling frame's FP instead of the current > > FP, which will be in C++ code. We need to do this because c_entry_fp is > > not set on the Isolate for Fast-C-Calls because we don't build an exit > > frame. > > > > This change makes stack samples that occur within 'Fast-C-Calls' > > iterable, meaning we can properly attribute ticks within the JS caller. > > > > Fast-C-Calls can't call back into JS code, so we can only ever have one > > such call on the stack at a time, allowing us to store the FP on the > > isolate rather than the stack. > > > > TBR=v8-mips-ports@googlegroups.com > > > > Bug: v8:8464, v8:7202 > > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > > Reviewed-by: Alexei Filippov <alph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#57896} > > TBR=v8-mips-ports@googlegroups.com > TBR=jgruber@chromium.org > > Bug: v8:8464, v8:7202 > Change-Id: I5f37ded4ea572e8e9890ba186aa3d74a0dfc1274 > Reviewed-on: https://chromium-review.googlesource.com/c/1354042 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57912} TBR=alph@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,martyn.capewell@arm.com,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,ibogosavljevic@wavecomp.com Change-Id: If810648dbf60df2ff70455b6e8ef466136c90145 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8464, v8:7202 Reviewed-on: https://chromium-review.googlesource.com/c/1354461Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bbd67a3..b7e2add Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6028a96..2e948dd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/17079a5..eee0f6a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib83450725f0228b99e29c05be42dd66d627917b8 Reviewed-on: https://chromium-review.googlesource.com/c/1351305 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57924}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If41076a377d12922cc3df859c678e1f20b99b00d Reviewed-on: https://chromium-review.googlesource.com/c/1351242 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Ia36e1b478c285752f2dafaaed509fc698acb2ccc Reviewed-on: https://chromium-review.googlesource.com/c/1354246 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#57922}
-
Jakob Kummerow authored
TransitionArray, NormalizedMapCache, DependentCode to the new design. Bug: v8:3770 Change-Id: I8bd56f231fb62b146e0fb05989418aedb62a628b Reviewed-on: https://chromium-review.googlesource.com/c/1350287 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57921}
-
Aleksei Koziatinskii authored
This method was experimental and deprecated for a while. R=dgozman@chromium.org Bug: none Change-Id: I7d5a13a83f36ecc7a92300f690dff5c8bb26f8de Reviewed-on: https://chromium-review.googlesource.com/c/1354182Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57920}
-
Aseem Garg authored
This reverts commit 9436e8a8. Reason for revert: Breaks TSAN. Original change's description: > [wasm] Add I64AtomicWait implementation > > Bug=v8:8075 > R=adamk@chromium.org,binji@chromium.org > > Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd > Reviewed-on: https://chromium-review.googlesource.com/c/1342948 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57917} TBR=binji@chromium.org,adamk@chromium.org,aseemgarg@chromium.org Change-Id: Ic82ce8794410a0d4d19de07abd9bb8a7aaff1c1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1351303Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57919}
-
- 28 Nov, 2018 10 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If405611d359d29ae1958beebd9202e068434a621 Reviewed-on: https://chromium-review.googlesource.com/c/1350286 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org,binji@chromium.org Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd Reviewed-on: https://chromium-review.googlesource.com/c/1342948Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8238 Change-Id: Ice11af2becb3b88a884c9231ed9610210efcc4d6 Reviewed-on: https://chromium-review.googlesource.com/c/1352292Reviewed-by:
-
Tom Tan authored
Two Fixes included to make V8 build work for Windows ARM64. 1. Don't emit ".def" and related macros to define function beginning, because they are invalid for Windows ARM64. 2. Set alignment of data section to 8 which is required for instruction which loads element from v8_Default_embedded_blob_. Version 7.2.479 Performance and stability improvements on all platforms. TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0bfea5dd8ed6c1340d11c13dcc2e492e7b22aa8c Reviewed-on: https://chromium-review.googlesource.com/c/1352210Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I1015edc7a4522ae161dfd408db2ddcfae5dbbc69 Reviewed-on: https://chromium-review.googlesource.com/c/1352218Reviewed-by:
-
Vasili Skurydzin authored
Bug: v8:8043 Change-Id: Iff786eccd2dcb63e46e331b096d91a6ddb13f851 Reviewed-on: https://chromium-review.googlesource.com/c/1351129Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Peter Marshall authored
This is a reland of d5f4a33e Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} TBR=v8-mips-ports@googlegroups.com TBR=jgruber@chromium.org Bug: v8:8464, v8:7202 Change-Id: I5f37ded4ea572e8e9890ba186aa3d74a0dfc1274 Reviewed-on: https://chromium-review.googlesource.com/c/1354042Reviewed-by:
-
Peter Marshall authored
These two tests fail if the memory used by builtins increases too much. They aren't intended to monitor the memory used by builtins, so these failures are spurious. Bug: v8:8521 Change-Id: I67e61abe30aaf69aeb3e6a2c885795061a318851 Reviewed-on: https://chromium-review.googlesource.com/c/1354041 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
George Wort authored
This implements arithmetic operations on i64, as well as eqz and conditional set for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: I21dc0f820e1429392599a5813c44b938c38093a2 Reviewed-on: https://chromium-review.googlesource.com/c/1348082 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
George Wort authored
This allows f32 floor, ceil, trunc, and nearest_int to use a C fallback in Liftoff in the same way that f64 rounding can. Bug: v8:6600 Change-Id: I8b88d806633bcfe2d2dfac9defaf60e551bf21b1 Reviewed-on: https://chromium-review.googlesource.com/c/1353898 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
