- 24 Jun, 2022 21 commits
-
-
Camillo authored
- Rename TryBuildCompareOperationBranch to TryBuildCompareOperation - Add CheckedInternalizedString conversion Node that checks for string inputs and extracts internalised Strings from ThinStrings - Add BranchIfReferenceCompare Node - Add runtime functions to create internalised and thin Strings - Add deopt check to test/mjsunit/maglev/int32-branch.js Bug: v8:7700 Change-Id: I0073c24fad9e3231c985153cd27b0b8fe6ee56f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664498Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81361}
-
Shu-yu Guo authored
Replace MutexGuards with ParkedMutexGuards where GC might happen. Change-Id: Ie782ca01962bd522870d3f82327aefd89095b165 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3720729 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81360}
-
Mohit Saini authored
v8 have not rolled latest perfetto's since January 2021. At the moment, this roll is blocked on b/236945541 Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Change-Id: Ife1a56a3b1ded47d806394738943805b7989964e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721615Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Mohit Saini <mohitms@google.com> Cr-Commit-Position: refs/heads/main@{#81359}
-
Camillo authored
Unaglined allocations are not fully supported in V8. - Set USE_ALLOCATION_ALIGNMENT_BOOL to false for documentation - Verify HeapObject address alignment requirements with --verify-heap - Move address alignment to right after allocation in the deserializer - Use object_size in the CheckAlignment helper to get a chance to figure out which allocation path we took Bug: chromium:1330861, v8:8875 Change-Id: Iffd02d869923ccec133618250dfefb0480b02741 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717995Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81358}
-
Manos Koukoutos authored
The optimization of a trap inside a branch is being removed. Since it does not speed-up non-trapping programs, and it is quite narrow, it is not worth the maintenance cost. Bug: chromium:1338947, chromium:1338950, chromium:1339153 Change-Id: I5b3f52e2b11d4c5113dd44fe23c14d74124a15f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721617 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81357}
-
Mohit Saini authored
|exclude_imports| flag is set in some of the perfetto's proto_library targets to indicate that we don't need to generate the proto-descriptor for the protos included in those `x.proto` files. In this CL we use that flag to conditionally pass `--include_imports` argument to protoc. This is similar to the CL (https://crrev.com/c/2632759) Bug: b:236945541 Change-Id: I0689003978096798d1e966ec8485cd6af7237804 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721616Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Mohit Saini <mohitms@google.com> Cr-Commit-Position: refs/heads/main@{#81356}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id886fa4c734bbd826770239ea145630570915749 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723505Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81355}
-
Nikolaos Papaspyrou authored
This is a reland of commit 543acf34 Original change's description: > cppgc: Minor fix in cppgc efficiency calculation > > Efficiency calculation (freed bytes over GC duration) assumes that the > duration of the GC is non zero. However, if the clock resolution is > not small enough and the entire GC is very short, the timed value > appears to be zero. This leads to NaN values showing in metrics and > CHECKs failing. This CL fixes the issue. > > Bug: chromium:1338256 > Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81329} Bug: chromium:1338256 Bug: chromium:1339180 Change-Id: Ib2b2a6973a6d290adf01568f35a205b606dd99f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723499Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#81354}
-
Michael Lippautz authored
There's no need to use the regular Scavenge visitor that would possibly populate the worklists again as we already know that we merely want to update the references at this point. Bug: chromium:1336158 Change-Id: I137d0bc990473cd6bc23f3a8849d83314807f6a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723500Reviewed-by:
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: Ie14c5055a4d24d064def7435fee2cde480844e8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717985Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81352}
-
JianxiaoLuIntel authored
Bug: v8:12833 Change-Id: I91e4dd6afb4c5b53a43067912a2d0cf0f4c9170a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719685Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Danylo Boiko authored
Bug: v8:12783 Change-Id: I33f2809b60c894a82c3f00c59e9b848cc9f5036d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723501 Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Reviewed-by:
-
Manos Koukoutos authored
There were multiple bugs and no test coverage for br_on_cast and br_on_cast_fail, specifically for the paths in the decoder where those checks get optimized away. Bug: v8:7748 Change-Id: I6e5d6449152df0456b43938174f57055a4c63fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723503Reviewed-by:
-
Samuel Groß authored
When a detached JSDataView is deserialized, it's backing ArrayBuffer backing store is empty (i.e. the EmptyBackingStoreBuffer() pointer). Previously, the JSDataView's data_pointer would then be set to EmptyBackingStoreBuffer() + byte_offset(), which is not a valid backing store pointer as it points outside of the sandbox. Instead, which this CL the data_pointer is now simply set to EmptyBackingStoreBuffer(). Bug: v8:10391 Change-Id: Ic7d144f2f20d5ec99438d2b3bf33735fbf8d5fc6 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717987 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Liu Yu authored
Port commit e35039e7 Bug: v8:12191 Change-Id: I1e6c49c22b3b94306d5b46e2672594cb842232d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723159Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#81347}
-
Hao Xu authored
Defer the branch to load receiver's map from a Smi because it is less likely to be used as a receiver, especially when the path to handle Smi receiver is already deferred. Change-Id: I2b55c146e36e548129a6c5460b55fef32df2c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719959Reviewed-by:
-
Lu Yahan authored
Port commit e35039e7 Change-Id: I19c3fddcf8b89dee74bd207909b2df4820c80f2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723540 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81345}
-
JianxiaoLuIntel authored
Change-Id: I4f3d03ebad41f32eff5d6570ad4d011586f1bac7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3722486 Commit-Queue: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5753f4e..ae20ef2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifa7c75592ca2e1400b082314136ccd827c3568b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723063 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81343}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/linux64: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/92ef8d4..b5f3d3b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c083518..3236751 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/28190a2..d9a9c40 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220622.0.1..version:8.20220623.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic27392879f4f3a067f67634866129586d69dbc48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723062 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81342}
-
Fanchen Kong authored
For small positive integer exponents, calculate the result with an inlined loop. This change may improve the average runtime of JetStream2/raytrace for ~8%. Change-Id: I0e3939dc9c21b0c392c04d61fd197bf618004ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3708024 Commit-Queue: Fanchen Kong <fanchen.kong@intel.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#81341}
-
- 23 Jun, 2022 19 commits
-
-
Shu-yu Guo authored
It is an invariant that objects in the shared heap never point into per-Isolate heaps. This is currently broken by DependentCode. At the same time, shared maps and other holders of DependentCode are designed to never invalidate optimized code. E.g., shared maps are effectively immutable. This CL does two things: 1. Prevent shared objects from being depended upon 2. DCHECK that shared objects never cause deoptimization Bug: v8:12547, v8:12761 Change-Id: I0fedae9134a8f786a9200e70f99dba7b38cd2d80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704809Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:12939 Change-Id: I853a718dec39485ae1ab1263e2be8f04567447f1 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3722455Reviewed-by:
-
Michael Lippautz authored
LocalHeap only uses LABs for allocation with size below kMaxLabObjectSize. Larger allocations used a path that was unaware of alignment restrictions. Bring implementations of LocalHeap and regular PagedSpace closer together by assuming the caller of their free list allocations takes care of size and alignment adjustments. Drive-by: Use unaligned allocations when possible which avoids a call into PreceedWithFiller(size) which would only bail out late for 0-sized fillers. Bug: chromium:1338687 Change-Id: I0f52c54359326a249b2ebe95bb73184ad95194f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721817Reviewed-by:
Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by:
-
Andy Wingo authored
Following change in https://github.com/WebAssembly/stringref/pull/22. This adds two new parsing modes: a strict UTF-8 parsing mode, and a sloppy mode that should replace invalid subsequences with U+FFFD. Bug: v8:12868 Change-Id: I03bd8d2a3408c399ce68f7b150d7650908804113 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719919Reviewed-by:
-
Ilya Rezvov authored
Bug: v8:12946 Change-Id: I3d9037a6dd940fe25f737efca49835b098d55081 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691129Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Ilya Rezvov <irezvov@chromium.org> Cr-Commit-Position: refs/heads/main@{#81336}
-
Shu-yu Guo authored
In the case of bugs creating shared->local edges, this lets us catch dangling pointers via CHECKs before they happen. Also removed some redundant checks in the shared struct verifier. Existing heap verification already checks that all of a Heap's pointers are contained within it. Bug: v8:12547 Change-Id: Ic7a007b3b6559e3dfd0286fbf869586023c6f801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704911Reviewed-by:
-
Shu-yu Guo authored
SeqStrings have their padding bytes serialized as 0s for deterministic snapshot contents. Currently this is done by mutating the SeqStrings and memsetting their padding bytes to 0 when serializing. This mutation is not threadsafe in the presence of shared strings. This CL removes the mutation by serializing the data and padding payloads separately for SeqStrings. Bug: v8:12939 Change-Id: I58c3ada767ce41e0a874a2d6e6392a86142fa1e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3715715Reviewed-by:
-
Andy Wingo authored
This will allow us to more easily add a strict UTF-8 decoder, for use in stringrefs. Bug: v8:12868 Change-Id: I6835dca619417f4d2994d8283728cf8ebe599bd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714660Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Jakob Kummerow authored
Follow-up to 032dfb82. No-Try: true Change-Id: Ia12343a7ce9e1b865da4fbf562bdd9169892932c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721816 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 543acf34. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/10365/overview Original change's description: > cppgc: Minor fix in cppgc efficiency calculation > > Efficiency calculation (freed bytes over GC duration) assumes that the > duration of the GC is non zero. However, if the clock resolution is > not small enough and the entire GC is very short, the timed value > appears to be zero. This leads to NaN values showing in metrics and > CHECKs failing. This CL fixes the issue. > > Bug: chromium:1338256 > Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81329} Bug: chromium:1338256 Change-Id: Ie9a23651494fc28a11bb59485a9812ee1a7cff48 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721697 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81331}
-
snek authored
Code for map methods was added a really long time ago but no one ever brought that to set. Adds new common lowering for both collections and updates the SetPrototypeHas builtin. My initial testing shows this to be as much as 50x faster in some cases. Change-Id: Ifea5be01c9e51013d57ac00bd817759ceace6669 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3709246Reviewed-by:
-
Nikolaos Papaspyrou authored
Efficiency calculation (freed bytes over GC duration) assumes that the duration of the GC is non zero. However, if the clock resolution is not small enough and the entire GC is very short, the timed value appears to be zero. This leads to NaN values showing in metrics and CHECKs failing. This CL fixes the issue. Bug: chromium:1338256 Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356Reviewed-by:
-
Milad Fa authored
Port e35039e7 Original Commit Message: If the returned promise rejects, we switch to the suspender's stack and throw the value. Re-purpose the WasmOnFulfilled data to also represent the rejecting case and rename it to WasmResumeData. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic9e5b959df90f1041353662dc054a849fea9874e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721416Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81328}
-
Sunny Sachanandani authored
This reverts commit 83f60359. Reason for revert: RB-Dev crash - crbug.com/1338687 Original change's description: > [snapshot] Turn alignment DCHECKS into CHECKS > > This is a temporary change to get more detailed crash reports for > further investigations. > > Bug: chromium:1330861 > Change-Id: Ifdd8d61692577dffd54d07fadb65575a5c30dcd3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707592 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81262} Bug: chromium:1330861, chromium:1338687 Change-Id: I845aee5cfe02dee399851484d1a72f73dc56f1f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718943 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Throw a wasm trap when trying to re-enter a suspender that is active or suspended. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Ic448a15db29de14fb8d6bb8408af8fbaae82a2b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716481Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81326}
-
Thibaud Michaud authored
If the returned promise rejects, we switch to the suspender's stack and throw the value. Re-purpose the WasmOnFulfilled data to also represent the rejecting case and rename it to WasmResumeData. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I91a301c3c6d9d243efbfabe7263555e11f0d9277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706606Reviewed-by:
-
Patrick Thier authored
To be able to share external strings, we need to share the external pointer table in sandbox builds. To avoid branches at runtime all pointers for external strings are stored in the shared external pointer table. Bug: v8:12957 Change-Id: Iaa6be7839a2f5e50f80fd58c5b33fb9c6af61057 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695263Reviewed-by:
Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#81324}
-
Leon Bettscheider authored
MinorMC events were incorrectly grouped under the V8.GCScavenger trace event name. This CL introduces the trace event name V8.GCMinorMC and uses it when MinorMC is used instead of Scavenger. Change-Id: Ide22526adfa9cc6dec91d3c34186b1c2ea6eb862 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717989 Commit-Queue: Leon Bettscheider <bettscheider@google.com> Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I2984b3ed6ac6b769f9b4ce758fdf4bfc3b6f6d49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714661Reviewed-by:
-
