• Nico Hartmann's avatar
    Revert "cppgc: Minor fix in cppgc efficiency calculation" · da12b9ac
    Nico Hartmann authored
    This reverts commit 543acf34.
    
    Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/10365/overview
    
    Original change's description:
    > cppgc: Minor fix in cppgc efficiency calculation
    >
    > Efficiency calculation (freed bytes over GC duration) assumes that the
    > duration of the GC is non zero. However, if the clock resolution is
    > not small enough and the entire GC is very short, the timed value
    > appears to be zero. This leads to NaN values showing in metrics and
    > CHECKs failing. This CL fixes the issue.
    >
    > Bug: chromium:1338256
    > Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#81329}
    
    Bug: chromium:1338256
    Change-Id: Ie9a23651494fc28a11bb59485a9812ee1a7cff48
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721697
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Owners-Override: Nico Hartmann <nicohartmann@chromium.org>
    Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81331}
    da12b9ac
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...