- 09 May, 2017 21 commits
-
-
bjaideep authored
Revert of PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector (patchset #1 id:1 of https://codereview.chromium.org/2861863003/ ) Reason for revert: Original CL reverted. Crashing on Canary BUG=chromium:718891 Original issue's description: > PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector > > Port 662aa425 > > Original Commit Message: > > Since the feedback vector is itself a native context structure, why > not store optimized code for a function in there rather than in > a map from native context to code? This allows us to get rid of > the optimized code map in the SharedFunctionInfo, saving a pointer, > and making lookup of any optimized code quicker. > > Original patch by Michael Stanton <mvstanton@chromium.org> > > R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG=v8:6246 > LOG=N > > Review-Url: https://codereview.chromium.org/2861863003 > Cr-Commit-Position: refs/heads/master@{#45111} > Committed: https://chromium.googlesource.com/v8/v8/+/d587812258c232f7b9a1f1a9a017ba3f9cea12ea TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,rmcilroy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:6246 Review-Url: https://codereview.chromium.org/2870703003 Cr-Commit-Position: refs/heads/master@{#45195}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iddbf8f2053318d90eaa3f469a36e67afca06b529 Reviewed-on: https://chromium-review.googlesource.com/500347Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45194}
-
Michael Achenbach authored
This reverts commit dd9dbf4d. Reason for revert: Fixed Bug: v8:6375 Change-Id: Ied3fb991ba6f5774f5a2e6f13947b53f61196650 Reviewed-on: https://chromium-review.googlesource.com/500133Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45193}
-
Franziska Hinkelmann authored
There's no point in using our own implemention of List for this. Bug:v8:6333 Change-Id: Ic239c9348bb17d61e41130a18e1c9f16cab9d8ee Reviewed-on: https://chromium-review.googlesource.com/489503Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#45192}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:6127 Change-Id: I4f20eae61f47eaa300ba54269c68eefa910b68da Reviewed-on: https://chromium-review.googlesource.com/500068Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45191}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ifa9f0f510bc5b864ebba199603919adb6a35d3a1 Reviewed-on: https://chromium-review.googlesource.com/500267Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45190}
-
Michael Starzinger authored
This tests and fixes validation failures caused by assignments to variables holding functions references (which are all considered immutable). Such references can come from "stdlib" or "foreign". R=clemensh@chromium.org TEST=mjsunit/asm/global-imports BUG=chromium:719382 Change-Id: Ic02be765e0773a6cc74a54e11a09d42ffb683cb8 Reviewed-on: https://chromium-review.googlesource.com/500188Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45189}
-
Michael Achenbach authored
Before this fix, all existing suites would get wastefully initialized in each subprocess. Bug: v8:6375 Change-Id: I68d961cde143754724735aecbac605852f89c7d9 Reviewed-on: https://chromium-review.googlesource.com/500187Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45188}
-
Loo Rong Jie authored
Before this, --print-bytecode flag was available in all Release builds but did not actually print the bytecodes because OBJECT_PRINT is not set. The output was pretty confusing: [generating bytecode for function: ] 000002115442ABE9 <BytecodeArray[27]>[generating bytecode for function: main] 000002115442B069 <BytecodeArray[114]>[generating bytecode for function: Primes] 000002115442B729 <BytecodeArray[63]>[generating bytecode for function: Int32Array] 000002115442BB51 <BytecodeArray[175]>[generating bytecode for function: Primes.getPrimeCount] 000002115442BE81 <BytecodeArray[7]>[generating bytecode for function: Primes.isPrimeDivisible] 000002115442BFC9 <BytecodeArray[71]>[generating bytecode for function: Primes.addPrime] 000002115442C1C1 <BytecodeArray[31]>[generating bytecode for function: Primes.getPrime] 000002115442D7B1 <BytecodeArray[14]> With this CL, --print-bytecode flag will always output bytecode, but detailed info about constant pool and handler table are still guarded. Bug:NO Change-Id: Ie03be74520f45659303d1658da5b2acc02cf1b36 Reviewed-on: https://chromium-review.googlesource.com/497808Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Loo Rong Jie <loorongjie@gmail.com> Cr-Commit-Position: refs/heads/master@{#45187}
-
jshin authored
Temporarily disable check for Etc/GMT and take it as well as Etc/UTC until the root cause of crbug.com/719609 is found. BUG=chromium:719609,v8:6252 TBR=adamk@chromium.org Review-Url: https://codereview.chromium.org/2872873002 Cr-Commit-Position: refs/heads/master@{#45186}
-
bmeurer authored
Due to speculative optimizations, the compiler can run into situations where it's asked perform impossible operations, like loading a tagged element as a float64 instead. All of this is guaranteed to be in dead code (unless there's a bug), but leads to confusion and violates assumptions in the compiler (that make perfect sense for code that is not dead). So teach LoadElimination not to mix up element accesses with incompatible representations. BUG=chromium:719479 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2866233002 Cr-Commit-Position: refs/heads/master@{#45185}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2870683003 Cr-Commit-Position: refs/heads/master@{#45184}
-
Mythri authored
This is the next in the series of simplifying the logic to collect feedback in compare bytecode handlers. An earlier cl ( https://chromium-review.googlesource.com/c/483399/) modified StrictEquals bytecode handler. This cl inlines the type feedback collection for the Equalbytecode handler. Bug: v8:4280 Change-Id: I36210a2412bb84a3fdb982aabccf8cdefe87e30e Reviewed-on: https://chromium-review.googlesource.com/498447 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45183}
-
Michael Achenbach authored
This reverts commit 9a90717d. Reason for revert: Erroneous submit... Original change's description: > Reland "[test] Don't flatten testcfg globals" > > This reverts commit 4fdf7cdf. > > Reason for revert: Fixed > > Original change's description: > > Revert "[test] Don't flatten testcfg globals" > > > > This reverts commit 4fa473cb. > > > > Reason for revert: Problems when v8 isn't located in a folder called "v8". > > > > Original change's description: > > > [test] Don't flatten testcfg globals > > > > > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > > > > > Bug: v8:6375 > > > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > > > Reviewed-on: https://chromium-review.googlesource.com/498807 > > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45178} > > > > TBR=jkummerow@chromium.org,machenbach@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: v8:6375 > > > > Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 > > Reviewed-on: https://chromium-review.googlesource.com/500130 > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45180} > > TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: v8:6375 > > Change-Id: I8198b74ff8e1c3aa179769bef24f204dc705da67 > Reviewed-on: https://chromium-review.googlesource.com/500131 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45181} TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: Id8ab1c3482806b613a024d4fff5c84a7ab0d2b0b Reviewed-on: https://chromium-review.googlesource.com/500132Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45182}
-
Michael Achenbach authored
This reverts commit 4fdf7cdf. Reason for revert: Fixed Original change's description: > Revert "[test] Don't flatten testcfg globals" > > This reverts commit 4fa473cb. > > Reason for revert: Problems when v8 isn't located in a folder called "v8". > > Original change's description: > > [test] Don't flatten testcfg globals > > > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > > > Bug: v8:6375 > > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > > Reviewed-on: https://chromium-review.googlesource.com/498807 > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45178} > > TBR=jkummerow@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: v8:6375 > > Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 > Reviewed-on: https://chromium-review.googlesource.com/500130 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45180} TBR=jkummerow@chromium.org,machenbach@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: I8198b74ff8e1c3aa179769bef24f204dc705da67 Reviewed-on: https://chromium-review.googlesource.com/500131Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45181}
-
Michael Achenbach authored
This reverts commit 4fa473cb. Reason for revert: Problems when v8 isn't located in a folder called "v8". Original change's description: > [test] Don't flatten testcfg globals > > This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. > > Bug: v8:6375 > Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 > Reviewed-on: https://chromium-review.googlesource.com/498807 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45178} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: v8:6375 Change-Id: I3600b54279c0d98a39475432c5b2163f510153f0 Reviewed-on: https://chromium-review.googlesource.com/500130Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45180}
-
ulan authored
This patch also makes concurrent marking visitor loads atomic. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2872443003 Cr-Commit-Position: refs/heads/master@{#45179}
-
Michael Achenbach authored
This loads each test's testcfg.py as a unique module rather than flattening all into testcfg. Other than accessing LoadTestSuite there should be no references into testcfg files. Bug: v8:6375 Change-Id: If863c1b35096b2589111e8091bb7d68f135da674 Reviewed-on: https://chromium-review.googlesource.com/498807Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45178}
-
Michael Achenbach authored
This reverts commit 7dcc8eff. Reason for revert: Some flakes still (see comments) and breaks predictable testing: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20predictable/builds/11452 Original change's description: > Revert "Revert "Introducing an event loop mechanism for d8."" > > This reverts commit f7c25da6. > > Reason for revert: Fixed > > Original change's description: > > Revert "Introducing an event loop mechanism for d8." > > > > This reverts commit de964dbe. > > > > Reason for revert: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 > > > > Original change's description: > > > Introducing an event loop mechanism for d8. > > > > > > This mechanism ensures APIs like wasm async complete their work, > > > without requiring use of natives (%APIs). > > > > > > The mechanism is similar to the one used in content_shell, > > > which should allow us to easily port tests in that environment. > > > > > > Review-Url: https://codereview.chromium.org/2842843005 > > > Cr-Original-Commit-Position: refs/heads/master@{#44908} > > > Bug: > > > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > > > Reviewed-on: https://chromium-review.googlesource.com/494968 > > > Commit-Queue: Mircea Trofin <mtrofin@google.com> > > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45165} > > > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f > > Reviewed-on: https://chromium-review.googlesource.com/498630 > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45166} > > TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Ic3c782e918326e291a6cb9bb349c609e9a340b09 > Reviewed-on: https://chromium-review.googlesource.com/498430 > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > Commit-Queue: Mircea Trofin <mtrofin@google.com> > Cr-Commit-Position: refs/heads/master@{#45172} TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I21ffba7141db0bfb4a3275b6e1bf4fb399800ed2 Reviewed-on: https://chromium-review.googlesource.com/500128Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45177}
-
Ilija.Pavlovic authored
This CL prevents problems with library libicui18n.so during execution inspector tests when component is defined as shared library. TEST=inspector/* BUG= Review-Url: https://codereview.chromium.org/2863383003 Cr-Commit-Position: refs/heads/master@{#45176}
-
v8-autoroll authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/06294c8..39a3450 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ab75dcc..db1fe5b Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/ada8f7c..a263e55 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I89e1bbff7464eafdd8a34787e0d66adc5316467c Reviewed-on: https://chromium-review.googlesource.com/499927Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45175}
-
- 08 May, 2017 19 commits
-
-
Ross McIlroy authored
This reverts commit 662aa425. Reason for revert: Crashing on Canary BUG=chromium:718891 Original change's description: > Reland: [TypeFeedbackVector] Store optimized code in the vector > > Since the feedback vector is itself a native context structure, why > not store optimized code for a function in there rather than in > a map from native context to code? This allows us to get rid of > the optimized code map in the SharedFunctionInfo, saving a pointer, > and making lookup of any optimized code quicker. > > Original patch by Michael Stanton <mvstanton@chromium.org> > > BUG=v8:6246 > TBR=yangguo@chromium.org,ulan@chromium.org > > Change-Id: Ic83e4011148164ef080c63215a0c77f1dfb7f327 > Reviewed-on: https://chromium-review.googlesource.com/494487 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45084} TBR=ulan@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org,jarin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=v8:6246 Change-Id: Idab648d6fe260862c2a0e35366df19dcecf13a82 Reviewed-on: https://chromium-review.googlesource.com/498633Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45174}
-
hpayer authored
TBR=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2867863002 Cr-Commit-Position: refs/heads/master@{#45173}
-
Mircea Trofin authored
This reverts commit f7c25da6. Reason for revert: Fixed Original change's description: > Revert "Introducing an event loop mechanism for d8." > > This reverts commit de964dbe. > > Reason for revert: > https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 > > Original change's description: > > Introducing an event loop mechanism for d8. > > > > This mechanism ensures APIs like wasm async complete their work, > > without requiring use of natives (%APIs). > > > > The mechanism is similar to the one used in content_shell, > > which should allow us to easily port tests in that environment. > > > > Review-Url: https://codereview.chromium.org/2842843005 > > Cr-Original-Commit-Position: refs/heads/master@{#44908} > > Bug: > > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > > Reviewed-on: https://chromium-review.googlesource.com/494968 > > Commit-Queue: Mircea Trofin <mtrofin@google.com> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45165} > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f > Reviewed-on: https://chromium-review.googlesource.com/498630 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45166} TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic3c782e918326e291a6cb9bb349c609e9a340b09 Reviewed-on: https://chromium-review.googlesource.com/498430Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@google.com> Cr-Commit-Position: refs/heads/master@{#45172}
-
mvstanton authored
Intrinsic and generic lowering for generator object creation. In a follow-on, create lowering will be addressed. BUG=v8:6352 Review-Url: https://codereview.chromium.org/2862213002 Cr-Commit-Position: refs/heads/master@{#45171}
-
Adam Klein authored
This patch expands scope analysis to skip hole initialization when it can be determined statically that no hole checks will be generated at runtime. Two conditions must be met to safely eliminate hole initialization: - There must not exist a VariableProxy referencing this Variable whose HoleCheckMode is kRequired - The Variable must be stack allocated; any other allocation implies that it may be accessed from not-yet-analyzed scopes (other modules, inner functions, or eval code) and that code may require hole checks. The new logic required removing debug code in full-codegen which is now incorrect in some cases. Also fixed Variable's bitfield helpers to take no more space than needed. Bug: chromium:651637 Change-Id: Ie5ac326af4e05b7a5c3c37cd4d0afba6a51a504d Reviewed-on: https://chromium-review.googlesource.com/494006 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45170}
-
Ross McIlroy authored
This reverts commit ec619cbd. Reason for revert: Crashing on Canary BUG=chromium:718891 Original change's description: > [Interpreter] Transition JSFunctions to call optimized code when possible. > > Now that the optimized code hangs off the feedback vector, it is possible > to check whether a function has optimized code available every time it's > called in the interpreter entry trampoline. If optimized code exists, the > interpreter entry trampoline 'self-heals' the closure to point to the > optimized code and links the closure into the optimized code list. > > BUG=v8:6246 > > Change-Id: If1bd7c555bb0551bfe04b36baa6bcf949604717e > Reviewed-on: https://chromium-review.googlesource.com/488026 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45103} TBR=rmcilroy@chromium.org,mvstanton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=v8:6246 Change-Id: Ibda719be90fddf1d116c03a2a0c3018bcbe76018 Reviewed-on: https://chromium-review.googlesource.com/498632Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45169}
-
kschimpf authored
The code for UMA stats (in counters.h) is not thread safe, and can lead to using pointers with uninitialized values. Therefore, this CL turns them off when compiling asynchronously. It also turns back on several UMA stats that were previously turned off, but no longer need to because the code now knows if it is running synchronously. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2864583004 Cr-Commit-Position: refs/heads/master@{#45168}
-
hpayer authored
BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2867073002 Cr-Commit-Position: refs/heads/master@{#45167}
-
Michael Achenbach authored
This reverts commit de964dbe. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 Original change's description: > Introducing an event loop mechanism for d8. > > This mechanism ensures APIs like wasm async complete their work, > without requiring use of natives (%APIs). > > The mechanism is similar to the one used in content_shell, > which should allow us to easily port tests in that environment. > > Review-Url: https://codereview.chromium.org/2842843005 > Cr-Original-Commit-Position: refs/heads/master@{#44908} > Bug: > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > Reviewed-on: https://chromium-review.googlesource.com/494968 > Commit-Queue: Mircea Trofin <mtrofin@google.com> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45165} TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f Reviewed-on: https://chromium-review.googlesource.com/498630Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45166}
-
Mircea Trofin authored
This mechanism ensures APIs like wasm async complete their work, without requiring use of natives (%APIs). The mechanism is similar to the one used in content_shell, which should allow us to easily port tests in that environment. Review-Url: https://codereview.chromium.org/2842843005 Cr-Original-Commit-Position: refs/heads/master@{#44908} Bug: Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 Reviewed-on: https://chromium-review.googlesource.com/494968 Commit-Queue: Mircea Trofin <mtrofin@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#45165}
-
Clemens Hammacher authored
Another fix for more explicit management of ownership. The CompilationHelper now always owns the WasmModule, and transfers ownership to the generated WasmModuleWrapper (a Managed<WasmModule>) once that object is created. Since the stored uniqe_ptr cannot be accessed any more after this transfer, the creation of the WasmModuleWrapper is delayed until it is really needed (step 5 in async compilation). R=ahaas@chromium.org Change-Id: I22dea2e14a364ddf76751d97bd0d736a4c0ceff4 Reviewed-on: https://chromium-review.googlesource.com/498507Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45164}
-
machenbach authored
Revert of [test] add --no-harness option to debugger tests. (patchset #1 id:1 of https://codereview.chromium.org/2831083003/ ) Reason for revert: Should define its own NO_HARNESS_PATTERN. See comments. Original issue's description: > [test] add --no-harness option to debugger tests. > > Review-Url: https://codereview.chromium.org/2831083003 > Cr-Commit-Position: refs/heads/master@{#44774} > Committed: https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bba8eff TBR=caitp@igalia.com,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2871593002 Cr-Commit-Position: refs/heads/master@{#45163}
-
Wiktor Garbacz authored
BUG=v8:6093 Change-Id: I612ad27bf0bcdc30a5d2f1f86a0c31b40ab4494d Reviewed-on: https://chromium-review.googlesource.com/493348 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45162}
-
Clemens Hammacher authored
Since the wasm module is verified before starting execution with lazy compilation, the compilation of individual functions should not fail later. This CL changes the implementation to check this condition earlier and removes unused error paths. R=ahaas@chromium.org, mstarzinger@chromium.org BUG=chromium:719286 Change-Id: If4bab457a47f214b457b2e2bc8570cba8c8bbcfd Reviewed-on: https://chromium-review.googlesource.com/497755Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45161}
-
Clemens Hammacher authored
Make ModuleResult and FunctionResult return Result<std::unique_ptr<X>>. This makes memory ownership and transfer of ownership more clear and avoids a lot of manual releases of the referenced native heap object. R=ahaas@chromium.org Change-Id: I7a3f5bd7761b6ae1ebdc7d17ff1b96a8df599871 Reviewed-on: https://chromium-review.googlesource.com/498352Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45160}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2871543002 Cr-Commit-Position: refs/heads/master@{#45159}
-
Clemens Hammacher authored
We don't currently depend on this, but it might improve performance by avoiding intermediate copies. The functions are already set up for perfect forwarding, but without declaring the parameters as forwarding references, this does not work as expected. R=ahaas@chromium.org Change-Id: I2c4d96ea1108b3f884d3e581e74c20aafd232934 Reviewed-on: https://chromium-review.googlesource.com/497409Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45158}
-
Clemens Hammacher authored
Inside the CompilationHelper, we were creating another compilation helper to execute sequential or parallel compilation. I don't see the reason to do so. R=ahaas@chromium.org Change-Id: Ib2c4486296a8f923e7e38620879c02963fff7d60 Reviewed-on: https://chromium-review.googlesource.com/497754Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45157}
-
Andreas Haas authored
With this CL we share code among the wasm fuzzers which construct a module and run it in the interpreter and as compiled code.The fuzzers themselves only contain the code now which creates the module and the parameters. BUG=v8:6325 R=eholk@chromium.org Change-Id: I1c2d8b013531c86cb27837f1b8ec89d2688c536b Reviewed-on: https://chromium-review.googlesource.com/490048 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#45156}
-