• Clemens Hammacher's avatar
    [wasm] Make CompilationHelper own the WasmModule · 4d81f7f0
    Clemens Hammacher authored
    Another fix for more explicit management of ownership. The
    CompilationHelper now always owns the WasmModule, and transfers
    ownership to the generated WasmModuleWrapper (a Managed<WasmModule>)
    once that object is created. Since the stored uniqe_ptr cannot be
    accessed any more after this transfer, the creation of the
    WasmModuleWrapper is delayed until it is really needed (step 5 in async
    compilation).
    
    R=ahaas@chromium.org
    
    Change-Id: I22dea2e14a364ddf76751d97bd0d736a4c0ceff4
    Reviewed-on: https://chromium-review.googlesource.com/498507Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45164}
    4d81f7f0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...