• Loo Rong Jie's avatar
    Fix print-bytecode in release build without setting OBJECT_PRINT · e77ae927
    Loo Rong Jie authored
    Before this, --print-bytecode flag was available in all Release builds
    but did not actually print the bytecodes because OBJECT_PRINT is not set.
    
    The output was pretty confusing:
    
    [generating bytecode for function: ]
    000002115442ABE9 <BytecodeArray[27]>[generating bytecode for function: main]
    000002115442B069 <BytecodeArray[114]>[generating bytecode for function: Primes]
    000002115442B729 <BytecodeArray[63]>[generating bytecode for function: Int32Array]
    000002115442BB51 <BytecodeArray[175]>[generating bytecode for function: Primes.getPrimeCount]
    000002115442BE81 <BytecodeArray[7]>[generating bytecode for function: Primes.isPrimeDivisible]
    000002115442BFC9 <BytecodeArray[71]>[generating bytecode for function: Primes.addPrime]
    000002115442C1C1 <BytecodeArray[31]>[generating bytecode for function: Primes.getPrime]
    000002115442D7B1 <BytecodeArray[14]>
    
    With this CL, --print-bytecode flag will always output bytecode, but
    detailed info about constant pool and handler table are still guarded.
    
    Bug:NO
    
    Change-Id: Ie03be74520f45659303d1658da5b2acc02cf1b36
    Reviewed-on: https://chromium-review.googlesource.com/497808Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Loo Rong Jie <loorongjie@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#45187}
    e77ae927
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...