1. 19 Apr, 2022 1 commit
  2. 24 Aug, 2021 1 commit
    • Dan Elphick's avatar
      Reland "[include] Split out v8.h" · ec06bb6c
      Dan Elphick authored
      This is a reland of d1b27019
      
      Fixes include:
      Adding missing file to bazel build
      Forward-declaring classing before friend-classing them to fix win/gcc
      Add missing v8-isolate.h include for vtune builds
      
      Original change's description:
      > [include] Split out v8.h
      >
      > This moves every single class/function out of include/v8.h into a
      > separate header in include/, which v8.h then includes so that
      > externally nothing appears to have changed.
      >
      > Every include of v8.h from inside v8 has been changed to a more
      > fine-grained include.
      >
      > Previously inline functions defined at the bottom of v8.h would call
      > private non-inline functions in the V8 class. Since that class is now
      > in v8-initialization.h and is rarely included (as that would create
      > dependency cycles), this is not possible and so those methods have been
      > moved out of the V8 class into the namespace v8::api_internal.
      >
      > None of the previous files in include/ now #include v8.h, which means
      > if embedders were relying on this transitive dependency then it will
      > give compile failures.
      >
      > v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      > that Chrome continue to compile but that change will be reverted once
      > those transitive #includes in chrome are changed to include it directly.
      >
      > Full design:
      > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      >
      > Bug: v8:11965
      > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#76424}
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
      Bug: v8:11965
      Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76460}
      ec06bb6c
  3. 23 Aug, 2021 2 commits
    • Dan Elphick's avatar
      Revert "[include] Split out v8.h" · 44fe02ce
      Dan Elphick authored
      This reverts commit d1b27019.
      
      Reason for revert: Broke vtune build, tsan build and possibly others
      
      Original change's description:
      > [include] Split out v8.h
      >
      > This moves every single class/function out of include/v8.h into a
      > separate header in include/, which v8.h then includes so that
      > externally nothing appears to have changed.
      >
      > Every include of v8.h from inside v8 has been changed to a more
      > fine-grained include.
      >
      > Previously inline functions defined at the bottom of v8.h would call
      > private non-inline functions in the V8 class. Since that class is now
      > in v8-initialization.h and is rarely included (as that would create
      > dependency cycles), this is not possible and so those methods have been
      > moved out of the V8 class into the namespace v8::api_internal.
      >
      > None of the previous files in include/ now #include v8.h, which means
      > if embedders were relying on this transitive dependency then it will
      > give compile failures.
      >
      > v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      > that Chrome continue to compile but that change will be reverted once
      > those transitive #includes in chrome are changed to include it directly.
      >
      > Full design:
      > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      >
      > Bug: v8:11965
      > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#76424}
      
      Bug: v8:11965
      Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Owners-Override: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76428}
      44fe02ce
    • Dan Elphick's avatar
      [include] Split out v8.h · d1b27019
      Dan Elphick authored
      This moves every single class/function out of include/v8.h into a
      separate header in include/, which v8.h then includes so that
      externally nothing appears to have changed.
      
      Every include of v8.h from inside v8 has been changed to a more
      fine-grained include.
      
      Previously inline functions defined at the bottom of v8.h would call
      private non-inline functions in the V8 class. Since that class is now
      in v8-initialization.h and is rarely included (as that would create
      dependency cycles), this is not possible and so those methods have been
      moved out of the V8 class into the namespace v8::api_internal.
      
      None of the previous files in include/ now #include v8.h, which means
      if embedders were relying on this transitive dependency then it will
      give compile failures.
      
      v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      that Chrome continue to compile but that change will be reverted once
      those transitive #includes in chrome are changed to include it directly.
      
      Full design:
      https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      
      Bug: v8:11965
      Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76424}
      d1b27019
  4. 29 Apr, 2021 1 commit
  5. 25 Feb, 2021 1 commit
  6. 01 Dec, 2020 1 commit
  7. 28 Nov, 2020 1 commit
  8. 13 Jul, 2020 1 commit
  9. 23 Dec, 2019 1 commit
  10. 19 Dec, 2019 1 commit
  11. 17 Dec, 2019 1 commit
    • Zhang, Shiyu's avatar
      Reland "Support Intel VTune ITT API" · 0b812b72
      Zhang, Shiyu authored
      This is a reland of 5f5b4b04
      
      Original change's description:
      > Support Intel VTune ITT API
      > 
      > Add VTune domain support extension to use VTune Domain/Task API and
      > tagging trace data for particular JS code block.
      > 
      > How to use:
      > 1. Set `"checkout_ittapi" = True` in the custom_vars section of .gclient
      > file to download intel/ittapi by 'gclient sync'
      > 2. Build d8 with gn build flag 'v8_enable_vtunetracemark = true'
      > 3. Run d8 with flag '--enable-vtune-domain-support'
      > 
      > The Vtune Domain/Task API can be invoked from JS to mark JS code block.
      > You can mark the start of a JS task by
      >     vtunedomainmark(domain_name, task_name, "start")
      > and the end of a task by
      >     vtunedomainmark(domain_name, task_name, "end")
      > Tasks can nest.
      > 
      > The VTune API (ittapi) is integrated as an external third party library
      > while the v8_vtune_jit also relies on the VTune ittapi. We have another
      > patch almost ready which refactors the v8_vtune_jit related code to
      > depend on the third_party/ittapi. We will submit the refactored v8_vtune_jit
      > code after this patch stabilized and landed.
      > 
      > 
      > Contributed by fanchen.kong@intel.com
      > 
      > Change-Id: I0ecc9dd4e1ea52545f1b6932fcdadfa7c1a6d2b2
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938490
      > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65409}
      
      Change-Id: I563aa70fa2b8abe34c981af47aa7220cfc2a7edb
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1963511
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65478}
      0b812b72
  12. 11 Dec, 2019 2 commits
    • Maya Lekova's avatar
      Revert "Support Intel VTune ITT API" · d8053c9a
      Maya Lekova authored
      This reverts commit 5f5b4b04.
      
      Reason for revert: Breaks vtunejit bot - see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/32958
      
      Original change's description:
      > Support Intel VTune ITT API
      > 
      > Add VTune domain support extension to use VTune Domain/Task API and
      > tagging trace data for particular JS code block.
      > 
      > How to use:
      > 1. Set `"checkout_ittapi" = True` in the custom_vars section of .gclient
      > file to download intel/ittapi by 'gclient sync'
      > 2. Build d8 with gn build flag 'v8_enable_vtunetracemark = true'
      > 3. Run d8 with flag '--enable-vtune-domain-support'
      > 
      > The Vtune Domain/Task API can be invoked from JS to mark JS code block.
      > You can mark the start of a JS task by
      >     vtunedomainmark(domain_name, task_name, "start")
      > and the end of a task by
      >     vtunedomainmark(domain_name, task_name, "end")
      > Tasks can nest.
      > 
      > The VTune API (ittapi) is integrated as an external third party library
      > while the v8_vtune_jit also relies on the VTune ittapi. We have another
      > patch almost ready which refactors the v8_vtune_jit related code to
      > depend on the third_party/ittapi. We will submit the refactored v8_vtune_jit
      > code after this patch stabilized and landed.
      > 
      > 
      > Contributed by fanchen.kong@intel.com
      > 
      > Change-Id: I0ecc9dd4e1ea52545f1b6932fcdadfa7c1a6d2b2
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938490
      > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65409}
      
      TBR=machenbach@chromium.org,hpayer@chromium.org,verwaest@chromium.org,shiyu.zhang@intel.com
      
      Change-Id: I44a6e5b1aa32e753ae41966ed321ed787cc752f8
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960291Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65410}
      d8053c9a
    • Zhang, Shiyu's avatar
      Support Intel VTune ITT API · 5f5b4b04
      Zhang, Shiyu authored
      Add VTune domain support extension to use VTune Domain/Task API and
      tagging trace data for particular JS code block.
      
      How to use:
      1. Set `"checkout_ittapi" = True` in the custom_vars section of .gclient
      file to download intel/ittapi by 'gclient sync'
      2. Build d8 with gn build flag 'v8_enable_vtunetracemark = true'
      3. Run d8 with flag '--enable-vtune-domain-support'
      
      The Vtune Domain/Task API can be invoked from JS to mark JS code block.
      You can mark the start of a JS task by
          vtunedomainmark(domain_name, task_name, "start")
      and the end of a task by
          vtunedomainmark(domain_name, task_name, "end")
      Tasks can nest.
      
      The VTune API (ittapi) is integrated as an external third party library
      while the v8_vtune_jit also relies on the VTune ittapi. We have another
      patch almost ready which refactors the v8_vtune_jit related code to
      depend on the third_party/ittapi. We will submit the refactored v8_vtune_jit
      code after this patch stabilized and landed.
      
      
      Contributed by fanchen.kong@intel.com
      
      Change-Id: I0ecc9dd4e1ea52545f1b6932fcdadfa7c1a6d2b2
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938490
      Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
      Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65409}
      5f5b4b04
  13. 31 Oct, 2019 1 commit
  14. 17 Oct, 2019 1 commit
    • Zhou, Zhiguo's avatar
      Log debug info of WASM for Intel VTune Amplifier · ec580709
      Zhou, Zhiguo authored
      This CL logs debug information of WASM in Intel VTune Amplifer via
      VTune's JIT Profiling API. With this CL, the profiling information
      of JITted code and its corresponding C/C++ source code is displayed
      optionally. To use this feature, a runtime flag "vtune_prof_annotat
      e_wasm" should be passed to the VTune-enabled V8 engine. Currently,
      the inline function in C/C++ is not well supported due to the
      limitation of source map.
      
      As a drive-by fix, the dynamically allocated event-specific data
      of JavaScript (src/third_party/vtune/vtune-jit.cc) is managed with
      C++ containers for safety.
      
      Change-Id: Ic27420fcdcd775bc5c7778abf5cff6edf0fb38b6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782126Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com>
      Cr-Commit-Position: refs/heads/master@{#64351}
      ec580709
  15. 12 Aug, 2019 1 commit
  16. 31 May, 2019 1 commit
  17. 30 May, 2019 1 commit
  18. 27 May, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Replace simple typedefs by using · a335f2ae
      Clemens Hammacher authored
      This replaces all typedefs that define types and not functions by the
      equivalent "using" declaration.
      
      This was done mostly automatically using this command:
      ag -l '\btypedef\b' src test | xargs -L1 \
           perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg'
      
      Patchset 2 then adds some manual changes for typedefs for pointer types,
      where the regular expression did not match.
      
      R=mstarzinger@chromium.org
      TBR=yangguo@chromium.org, jarin@chromium.org
      
      Bug: v8:9183
      Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61849}
      a335f2ae
  19. 24 Apr, 2019 1 commit
  20. 04 Apr, 2019 1 commit
  21. 09 Jan, 2019 1 commit
  22. 08 Aug, 2018 1 commit
  23. 23 Jul, 2018 1 commit
  24. 16 Jul, 2018 1 commit
  25. 28 Mar, 2018 1 commit
  26. 23 Jan, 2018 1 commit
  27. 11 Dec, 2017 1 commit
    • Justin Ridgewell's avatar
      Implement DFA Unicode Decoder · cedec225
      Justin Ridgewell authored
      This is a separation of the DFA Unicode Decoder from
      https://chromium-review.googlesource.com/c/v8/v8/+/789560
      
      I attempted to make the DFA's table a bit more explicit in this CL. Still, the
      linter prevents me from letting me present the array as a "table" in source
      code. For a better representation, please refer to
      https://docs.google.com/spreadsheets/d/1L9STtkmWs-A7HdK5ZmZ-wPZ_VBjQ3-Jj_xN9c6_hLKA
      
      - - - - -
      
      Now for a big copy-paste from 789560:
      
      Essentially, reworks a standard FSM (imagine an
      array of structs) and flattens it out into a single-dimension array.
      Using Table 3-7 of the Unicode 10.0.0 standard (page 126 of
      http://www.unicode.org/versions/Unicode10.0.0/ch03.pdf), we can nicely
      map all bytes into one of 12 character classes:
      
      00. 0x00-0x7F
      01. 0x80-0x8F (split from general continuation because this range is not
          valid after a 0xF0 leading byte)
      02. 0x90-0x9F (split from general continuation because this range is not
          valid after a 0xE0 nor a 0xF4 leading byte)
      03. 0xA0-0xBF (the rest of the continuation range)
      04. 0xC0-0xC1, 0xF5-0xFF (the joined range of invalid bytes, notice this
          includes 255 which we use as a known bad byte during hex-to-int
              decoding)
      05. 0xC2-0xDF (leading bytes which require any continuation byte
          afterwards)
      06. 0xE0 (leading byte which requires a 0xA0-0xBF afterwards then any
          continuation byte after that)
      07. 0xE1-0xEC, 0xEE-0xEF (leading bytes which requires any continuation
          afterwards then any continuation byte after that)
      08. 0xED (leading byte which requires a 0x80-0x9F afterwards then any
          continuation byte after that)
      09. 0xF1-F3 (leading bytes which requires any continuation byte
          afterwards then any continuation byte then any continuation byte)
      10. 0xF0 (leading bytes which requires a 0x90-0xBF afterwards then any
          continuation byte then any continuation byte)
      11. 0xF4 (leading bytes which requires a 0x80-0x8F afterwards then any
          continuation byte then any continuation byte)
      
      Note that 0xF0 and 0xF1-0xF3 were swapped so that fewer bytes were
      needed to represent the transition state ("9, 10, 10, 10" vs.
      "10, 9, 9, 9").
      
      Using these 12 classes as "transitions", we can map from one state to
      the next. Each state is defined as some multiple of 12, so that we're
      always starting at the 0th column of each row of the FSM. From each
      state, we add the transition and get a index of the new row the FSM is
      entering.
      
      If at any point we encounter a bad byte, the state + bad-byte-transition
      is guaranteed to map us into the first row of the FSM (which contains no
      valid exiting transitions).
      
      The key differences from Björn's original (or his self-modified) DFA is
      the "bad" state is now mapped to 0 (or the first row of the FSM) instead
      of 12 (the second row). This saves ~50 bytes when gzipping, and also
      speeds up determining if a string is properly encoded (see his sample
      code at http://bjoern.hoehrmann.de/utf-8/decoder/dfa/#performance).
      
      Finally, I've replace his ternary check with an array access, to make
      the algorithm branchless. This places a requirement on the caller to 0
      out the code point between successful decodings, which it could always
      have done because it's already branching.
      
      R=marja@google.com
      
      Bug: 
      Change-Id: I574f208a84dc5d06caba17127b0d41f7ce1a3395
      Reviewed-on: https://chromium-review.googlesource.com/805357
      Commit-Queue: Justin Ridgewell <jridgewell@google.com>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50012}
      cedec225
  28. 02 Aug, 2017 1 commit
  29. 13 Feb, 2017 1 commit
  30. 05 Jul, 2016 1 commit
  31. 30 Jun, 2016 1 commit
  32. 20 Jun, 2016 1 commit
    • bmeurer's avatar
      [builtins] Introduce proper Float64Tan operator. · c87168bc
      bmeurer authored
      Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan
      operator based on that, similar to what we do for Float64Cos and Float64Sin.
      Rewrite Math.tan() as TurboFan builtin and use those operators to also
      inline Math.tan() into optimized TurboFan functions.
      
      Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only
      the %ConstructDouble runtime entry for writing tests.
      
      BUG=v8:5086,v8:5126
      R=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2083453002
      Cr-Commit-Position: refs/heads/master@{#37087}
      c87168bc
  33. 17 Jun, 2016 3 commits
  34. 16 Jun, 2016 3 commits