- 27 Jul, 2018 10 commits
-
-
Peter Marshall authored
Previously we used the start address of the AbstractCode object. This doesn't make sense for off-heap builtins, where the code isn't contained in the object itself. It also hides other potential problems - sometimes the sample.pc is inside the AbstractCode object header - this is never valid. There were a few changes necessary to make this happen: - Change the interface of CodeMoveEvent. Now 'to' and 'from' are both AbstractCode objects, which is nice because many users were taking 'to' and adding the header offset to it to try and find the instruction start address. This isn't valid for off-heap builtins. - Fix a bug in CodeMap::MoveCode where we didn't update the CodeEntry object to reflect the new instruction_start. - Rename the 'start' field in all of the CodeEventRecord sub-classes to make it clear that this is the address of the first instruction. - Fix the confusion in RecordTickSample between 'tos' and 'pc' which caused pc_offset to be calculated incorrectly. Bug: v8:7983 Change-Id: I3e9dddf74e4b2e96a5f031d216ef7008d6f184d1 Reviewed-on: https://chromium-review.googlesource.com/1148457 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54749}
-
Peter Marshall authored
Fixes: src/objects/intl-objects-inl.h src/objects/js-collection.h src/objects/js-collection-inl.h src/objects/js-regexp-string-iterator-inl.h src/objects/microtask-inl.h src/objects/module-inl.h src/objects/ordered-hash-table-inl.h src/objects/promise-inl.h Bug: v8:7754,v8:7490 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a5017713fa9920add2b38dbc56ab74abd4addd Reviewed-on: https://chromium-review.googlesource.com/1152732Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54748}
-
Michael Achenbach authored
This reverts commit 51ad234f. Reason for revert: Speculative revert. Suspect for layout test change: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25165 See also: https://github.com/v8/v8/wiki/Blink-layout-tests The bots currently have another problem with webkit_unit_tests and don't run the layout tests on every revision. Hence the speculative revert. Original change's description: > [Intl] move localeCompare to C++ > > > Bug: v8:7958 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa > Reviewed-on: https://chromium-review.googlesource.com/1144644 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54740} TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org Change-Id: Iceab3316bd1eacfe449c8182cbb3027acb56047e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7958 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1152767Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54747}
-
Michael Achenbach authored
This reverts commit a895f01a. Reason for revert: Needed for other revert: https://chromium-review.googlesource.com/c/v8/v8/+/1152767 Original change's description: > [Intl] Move Number.toLocaleString from js to c++ > > > Bug: v8:7960 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I21a524b620e210cce625a1a00e68c0b687187087 > Reviewed-on: https://chromium-review.googlesource.com/1144659 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54741} TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org Change-Id: I060fa2834dde5e1b4cc71923cc066d97bce2a33b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7960 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1152787Reviewed-by:
-
Creddy authored
The CSA fast path returned null for Proxy.prototype whereas runtime GetProperty returned undefined. The CL fixes this discrepancy by returning undefined for both cases and this makes it complaint with the spec. Change-Id: I35b75c09dc99e8fd629671e30eacd2cabea8c1d4 Reviewed-on: https://chromium-review.googlesource.com/1145438Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Florian Sattler authored
This places the hot part of SkipWhiteSpace in the header, allowing it to be inlined, and leaves a slow path to handle the rest. This improves comment scanning overall by ~10%. Bug: v8:7926 Change-Id: I2e2ebbbae0d1af619b161397712fdf667d078884 Reviewed-on: https://chromium-review.googlesource.com/1150230 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54744}
-
Théotime Grohens authored
This CL removes the last bit of Float64 math that was left, by adding a TypeGuard node to help the typer figure out that stuff actually fits in Int32 operations. This should improve the inline performance a little bit more. Change-Id: I35bf3445e6c73c9433d5ff5e177d6bb3c8b82071 Reviewed-on: https://chromium-review.googlesource.com/1151635Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54743}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ad6fe7d..adaab11 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/691bfec..0dd5c6f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c829a63..933672b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ad463c9..079812c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifefb5530249db31449b9b35127afb54cc1bc5ec0 Reviewed-on: https://chromium-review.googlesource.com/1152558 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54742}
-
Frank Tang authored
Bug: v8:7960 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I21a524b620e210cce625a1a00e68c0b687187087 Reviewed-on: https://chromium-review.googlesource.com/1144659 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54741}
-
Frank Tang authored
Bug: v8:7958 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa Reviewed-on: https://chromium-review.googlesource.com/1144644 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 26 Jul, 2018 30 commits
-
-
Deepti Gandluri authored
Change-Id: I9cab4e35c356a1fdd9942bd54832e7a375cd0800 Reviewed-on: https://chromium-review.googlesource.com/1152162Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54739}
-
Brian Stell authored
Bug: v8:7978 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I98f33de90be2ecc7fca3fd21652a9cf3c283dc8f Reviewed-on: https://chromium-review.googlesource.com/1150875Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Frank Tang authored
This also move the function body of Runtime_StringLocaleConvertCase into IntlFunc::StringLocaleConvertCase Bug: v8:7958 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibc081150babdd7d50043383b0f7375d46cfcf4a5 Reviewed-on: https://chromium-review.googlesource.com/1144525 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Peter Marshall authored
Fixes: src/objects/arguments.h src/objects/arguments-inl.h src/objects/compilation-cache-inl.h src/objects/data-handler-inl.h src/objects/hash-table-inl.h Bug: v8:7754,v8:7490 Change-Id: Ic17d4c3477c7d2003b325497cb9082899a0bf3fc Reviewed-on: https://chromium-review.googlesource.com/1151312Reviewed-by:
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib02a634dd82b6cef647e23464401af4acccc21f1 Reviewed-on: https://chromium-review.googlesource.com/1151049 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Ie950a24612949f2f5ab96d2fd5d681f817fdde46 Reviewed-on: https://chromium-review.googlesource.com/1151867 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
John Barboza <jbarboza@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54734}
-
Michael Starzinger authored
R=titzer@chromium.org TEST=cctest/test-wasm-shared-engine/SharedEngineRunThreadedExecution Change-Id: I01fbb13408020145c9d6bd6bbb66ca5136922bd2 Reviewed-on: https://chromium-review.googlesource.com/1151629Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54733}
-
Ivica Bogosavljevic authored
MIPS team has moved to new @wavecomp.com e-mail addresses. This CL is not actually changing owners, it only renames the owners to the new email addresses. No-Presubmit: true Change-Id: Ic334defa06a36d974de87e99ed6c30bdf021958f Reviewed-on: https://chromium-review.googlesource.com/1151349 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#54732}
-
Michael Starzinger authored
This reverts commit 53fe5c44. Reason for revert: Test can be re-enabled, a fix for the flake landed by now. Original change's description: > [wasm] Temporarily disable --wasm-shared-engine test. > > R=leszeks@chromium.org > > Change-Id: Ib037c43571cda0e2da3c6da3d763cfe27c797413 > Reviewed-on: https://chromium-review.googlesource.com/1150033 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54692} TBR=mstarzinger@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I406740898d896a18eef365cdd20581d5de84023a Reviewed-on: https://chromium-review.googlesource.com/1151407Reviewed-by:
-
Sigurd Schneider authored
This is a reland of f5a8352b Original change's description: > [embedded-builtins] Enable on all arches except x86 for benchmarks > > This CL enables embedded builtins to get benchmark feedback. We need > this feedback to identify and address remaining performance problems. > > Bug: v8:6666 > Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233 > Reviewed-on: https://chromium-review.googlesource.com/1105834 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53836} Bug: v8:6666 Change-Id: Idd736f3ec06a7ea57e53a666fd5434e32ca316ad Reviewed-on: https://chromium-review.googlesource.com/1148100 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
This is a refactoring-only CL that packs builtin offsets and lengths into a metadata struct. The struct should make future modifications to metadata simpler. Bug: v8:6666 Change-Id: Iae8070c2aa24d7e803cd75da3dea09e437ef275e Reviewed-on: https://chromium-review.googlesource.com/1145069 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54729}
-
Stephan Herhut authored
This is a first step to make basic block profiling work in wasm. More is needed, including eventually making the profiler thread safe. Change-Id: Ic216c881a4ab5a633e147e5538bb405c32e687cd Reviewed-on: https://chromium-review.googlesource.com/1150234 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: I32510f33fb88c2f1a79864e6033d3aa53ad9fe48 Reviewed-on: https://chromium-review.googlesource.com/1150149 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54727}
-
Clemens Hammacher authored
This ensures that tests actually abort on unimplemented opcodes instead of just printing them as "Unimplemented Instruction". If used to disassemble a code region though, we want to ignore unimplemented opcodes to keep printing remaining valid instructions. The tests were previously fixed by Deepti in 8fa509d3, but this got partly reverted on the "Address" refactoring in 2459046c. R=titzer@chromium.org Change-Id: I802dda2b0f45ee77c4f9b244ed984b1c4679bac3 Reviewed-on: https://chromium-review.googlesource.com/1146649 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
All we care about w.r.t FieldType is object identity. Moreover, FieldType does not have its own instance type. Hence it makes no sense to have the broker know about FieldType at all. Bug: v8:7790 Change-Id: I585e7e06826fae95890c1889ae2f4613479cbb32 Reviewed-on: https://chromium-review.googlesource.com/1151300 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL uses segfaulting instructions in embedded builtins, instead of a trap handler which require relocation and can hence not be used in embedded builtins. Bug: v8:7985, v8:6666 Change-Id: I87776785602f13d15f565d49b2332eb2adc62bd4 Reviewed-on: https://chromium-review.googlesource.com/1151192 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883 Reviewed-on: https://chromium-review.googlesource.com/1151295 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 TBR=mlippautz@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic310ebcf0af2f3985cee9872f6e57a05652c4484 Reviewed-on: https://chromium-review.googlesource.com/1151197Reviewed-by:
-
Théotime Grohens authored
This CL tries to reduce as much as possible the emission of Float64 operations in the inlining of DataView methods. It adds CheckSmi calls guarding the main variables that the methods use, and deopts back to the baseline when outside of Smi range. This should happen extremely rarely anyway, since we don't allow ArrayBuffers to be larger than that by default. Change-Id: I26fdd7b6884507a3a555dea114cf30da487dd34c Reviewed-on: https://chromium-review.googlesource.com/1151194Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54721}
-
Toon Verwaest authored
Change-Id: I388f6a6c937b6897efe9e88b06ba4b56670fea4f Reviewed-on: https://chromium-review.googlesource.com/1151191 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This test uses assertOptimized and is not suitable for GC stress. Change-Id: If746c7980f93da2834deac879751d66c151e5aed Reviewed-on: https://chromium-review.googlesource.com/1151122 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
MIPS64 doesn't support 32-bit compare operations, instead it relies that values in registers are properly sign extended to 64-bit. Sign extending and then comparing is a costly operation that we want to avoid. We use costly compare only in those cases when one operand is signed and other is unsigned. This CL adds marks PoisonedLoad and ProtectedLoad of unsigned values as needing full compare instead of optimized one. TEST=mjsunit/empirical_max_arraybuffer Change-Id: I7e6599d7c6e6969b74301cf88f1e5f32ee7b18ce Reviewed-on: https://chromium-review.googlesource.com/1150536 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
-
Michael Lippautz authored
Instead of actually allocating an objects just test the corner cases around the page boundary by casting addresses. Bug: v8:7984 Change-Id: I27615cc193d6f85abc91cfe898719a4a9b761f23 Reviewed-on: https://chromium-review.googlesource.com/1151114Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54717}
-
Andreas Haas authored
Stack parameters on arm64 require padding. Since the stack areas for parameters and returns should not overlap, we have to pad the parameters already during the construction of the CallDescriptor so that we can set the correct stack offset for returns. R=mstarzinger@chromium.org Bug: chromium:838098 Change-Id: I23389dc35037054b750e61ea6b1bfdfc4c5bc868 Reviewed-on: https://chromium-review.googlesource.com/1150178Reviewed-by:
-
Dan Elphick authored
Add v8_deprecation_warnings and v8_imminent_deprecation_warnings to external_config so they can also control how embedders see deprecation warnings. Also defaults v8_deprecation_warnings to true. Change-Id: I267607d7b3e1ff6ee34a5555722118f9f22e0791 Reviewed-on: https://chromium-review.googlesource.com/1151110Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54715}
-
Andreas Haas authored
R=herhut@chromium.org Change-Id: I9c67227da8d304a805f7f25fa64862ee400530d7 Reviewed-on: https://chromium-review.googlesource.com/1149820Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54714}
-
Michael Lippautz authored
The test creates a new spaces without hooking it up into Heap, which makes allocations crash. Tbr: leszeks@chromium.org No-try: true Bug: v8:7984 Change-Id: I58c43eedd4fbbedfacfdee3a3bae99c4107404ec Reviewed-on: https://chromium-review.googlesource.com/1151112Reviewed-by:
-
Rodrigo Bruno authored
This CL depends on Reland^2 "Avoiding re-externalization of strings" (Idb1b6d1b29499f66bf8cd704977c40b027f99dbd).. Previously landed as Ied341ec6268000343d2a577b22f2a483460b01f5 and I3fe2b294f6e038d77787cf0870d244ba7cc20550 Previously reviewed at https://chromium-review.googlesource.com/1121736 and https://chromium-review.googlesource.com/1118164 Bug: chromium:845409 Change-Id: Ied50bbcaa22a90ecaf15dca19dbc9aaec1737223 Reviewed-on: https://chromium-review.googlesource.com/1147227Reviewed-by:
-
Georgia Kouveli authored
The tests were not flushing the i-cache before calling the generated code. Use Factory::NewCode to make sure that the i-cache is flushed instead. Bug: v8:7977 Change-Id: I9c7c6f0d0e31700634e50279e75858a5d74603d8 Reviewed-on: https://chromium-review.googlesource.com/1150165Reviewed-by:
-
Michael Lippautz authored
Move write barrier essentials into heap/heap-write-barrier-inl.h. Avoid including further heap inline headers by relying on constant to load flags from. Bug: v8:7490 Change-Id: I2891299f1b1ca2c3e2031cb9c63b583b1665e3f9 Reviewed-on: https://chromium-review.googlesource.com/1148448 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54710}
-
