Commit 079eee43 authored by Georgia Kouveli's avatar Georgia Kouveli Committed by Commit Bot

[arm][arm64] Fix TurboAssembler tests for hard aborts

The tests were not flushing the i-cache before calling the generated
code. Use Factory::NewCode to make sure that the i-cache is flushed
instead.

Bug: v8:7977
Change-Id: I9c7c6f0d0e31700634e50279e75858a5d74603d8
Reviewed-on: https://chromium-review.googlesource.com/1150165Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
Cr-Commit-Position: refs/heads/master@{#54711}
parent 9e3d6cbe
......@@ -27,6 +27,9 @@ static inline void MakeAssemblerBufferExecutable(uint8_t* buffer,
bool result = v8::internal::SetPermissions(buffer, allocated,
v8::PageAllocator::kReadExecute);
CHECK(result);
// Flush the instruction cache as part of making the buffer executable.
Assembler::FlushICache(buffer, allocated);
}
static inline void MakeAssemblerBufferWritable(uint8_t* buffer,
......
......@@ -15,10 +15,4 @@
'RandomNumberGenerator.NextSampleSlowInvalidParam1': [SKIP],
'RandomNumberGenerator.NextSampleSlowInvalidParam2': [SKIP],
}], # 'system == macos and asan'
['arch == arm and not simulator_run', {
# Crashes flakily: https://crbug.com/v8/7977
'TurboAssemblerTest.TestCheck': [SKIP],
}], # arch == arm and not simulator_run
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment